Jump to content

OpenCore General Discussion

dgsga

By dgsga,
in OpenCore

 Share
8,826 posts in this topic

Recommended Posts

Guest 5T33Z0
Guest 5T33Z0
Posted
Posted (edited)

Saw this new Dictionary in the latest build. "Read and set serial PCD values from config". But I have no idea what that is or does:

 

1717292710_Bildschirmfoto2022-04-01um06_15_13.thumb.png.4af3a73e0f54bf8363afd70ac2be3263.png

Seems to be related to network settings. Firefox on my IvyBridge Notebook seens to load pages faster now that I added this dict. Nice.

Edited by 5T33Z0
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted (edited)
3 hours ago, 5T33Z0 said:

Saw this new Dictionary in the latest build. "Read and set serial PCD values from config". But I have no idea what that is or does:

 

 

Seems to be related to network settings. Firefox on my IvyBridge Notebook seens to load pages faster now that I added this dict. Nice.

 

Hi @5T33Z0 I don't  find this new dictionary in sample.plist and samplecustom.plist at OC Github repository. Nothing inside Configuration.pdf 
Where do you find the explanations for setting. Please.

Edited by Matgen84
Link to comment
Share on other sites
miliuco
miliuco
Posted
Posted (edited)

@ghost8282

Thanks for the link to the issue. Yes, it has to do with serial port initialisation prior to debug logging.

It is accompanied by the removal of the Misc >> Debug >> SerialInit key which it replaces by providing more options and fixing some things.

 

Edited by miliuco
  • Like 1
Link to comment
Share on other sites
Guest 5T33Z0
Guest 5T33Z0
Posted
Posted (edited)

Okay. Anyways: do not use OCAT for updating to this built yet. Do it manually for now. Because since the dict is not incorporated in the GUI as a tab yet, it will be deleted once you save the config which in return will result in errors reported by OCValidate.

Edited by 5T33Z0
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
3 hours ago, 5T33Z0 said:

@Matgen84 https://github.com/acidanthera/OpenCorePkg/actions

 

>> OcMainLib: Read and set serial PCD values from config

@5T33Z0 Thanks. This commit is not yet implemented in Master Branch, only pcd-test. After building latest commit 3f930d0 (3 days ago) from Master, OCValidate detect, of course, no error without the new Serial key from config.plist. So, for the moment, wait and see 🙂

  • Like 1
  • Thanks 1
Link to comment
Share on other sites
eSaF
eSaF
Posted
Posted (edited)
2 hours ago, Stefanalmare said:

With the last build c953fa0, I always get "OCS: Couldn't parse serialized file!", but I have no problem booting.

No such problem here with latest 'master' commit.

Spoiler

135614296_Screenshot2022-04-08at5_15_55pm.png.825714425d10d657ef55ae75df695d4d.png

 

Edited by eSaF
  • Like 2
Link to comment
Share on other sites
eSaF
eSaF
Posted
Posted
1 hour ago, Stefanalmare said:

You "ocvalidate" the config.plist?

Yes I did, if anything was out of sync the Tick symbol would be a red exclamation symbol.

Here is the proof all is well with latest commit on my system.

Spoiler

1316524013_Screenshot2022-04-08at7_32_05pm.png.9637aa41aafb260786226053db5597fc.png

 

  • Like 4
Link to comment
Share on other sites
Stefanalmare
Stefanalmare
Posted
Posted (edited)
9 minutes ago, eSaF said:

Yes I did, if anything was out of sync the Tick symbol would be a red exclamation symbol.

Here is the proof all is well with latest commit on my system.

  Reveal hidden contents

1316524013_Screenshot2022-04-08at7_32_05pm.png.9637aa41aafb260786226053db5597fc.png

 

 

Spoiler

1.thumb.png.0d8ff8b016b57570b14ba71521d29fac.png

Edited by Stefanalmare
  • Thanks 1
Link to comment
Share on other sites
eSaF
eSaF
Posted
Posted

Aha!!! I see what you mean, using OCAT's builtin OCvalidate returns no errors or comments but using OC's latest commit ocvalidate returns the comment mentioned. There is possibly a Bug with this commit.

Spoiler

1892607958_Screenshot2022-04-08at7_46_11pm.png.6d24e4a13f452226ae16de9e380e0ac6.png

 

  • Like 4
Link to comment
Share on other sites
Guest 5T33Z0
Guest 5T33Z0
Posted
Posted (edited)

Sane here. I guess OCAT uses OCValidate from the previous built where it was fixed and doesn't produce errors.

 

 

Edited by 5T33Z0
Link to comment
Share on other sites
eSaF
eSaF
Posted
Posted
10 hours ago, 5T33Z0 said:

Sane here. I guess OCAT uses OCValidate from the previous built where it was fixed and doesn't produce errors.

I concur - We'll see what the next 'Master' release brings.

  • Like 1
Link to comment
Share on other sites
eSaF
eSaF
Posted
Posted
3 hours ago, Stefanalmare said:

Fix it in 292b7c9.

:lol: Now OCAT is complaining unable to 'parse serialized file' but ocvalidate within the latest commit returns all is well. I guess what @5T33Z0 reported about that file in OCAT needs updating to fix that output.

Spoiler

1124699317_Screenshot2022-04-09at6_42_19pm.png.a38157bafb935e848c9e5d19b2e03145.png574864728_Screenshot2022-04-09at6_42_55pm.png.d385e98c76006ffd6be70baeac2ab261.png

 

  • Haha 1
Link to comment
Share on other sites
Guest 5T33Z0
Guest 5T33Z0
Posted
Posted (edited)

@eSaF OCAT uses whatever is in the opemncore package when updating. And since the issue occurs in the ocvalidate of the latest built, the error occurs.

 

To fix iit, you can replace the OCValidate file with the working one or wait til the next OC package with the fixed OC Vaidate.

  • in OCAT, go to EDIT >  Open Database Directory,
  • A Finder window opens containing the OpenCore Files
  • DevDatabase cntains the files for the nightly builds
  • In DevDatabase > mac is OCValidate

 

BTW: I get no errors when using the lastest build: 292b7c9

 

Edited by 5T33Z0
Link to comment
Share on other sites
ghost8282
ghost8282
Posted
Posted
14 hours ago, Stefanalmare said:

I can't compile anymore Lilu and all the Lilu's suite with Xcode 13.3. What I do wrong?

I confirm this, something changed in xcode 13.3

The issue seems to be in kern_qsort file: 

loop:	SWAPINIT(a, es);

-> Performing pointer subtraction with a null pointer may have undefined behavior

 

a is in fact defined as void pointer: 

qsort(void *a, size_t n, size_t es, int (*cmp)(const void *, const void *))

 

  • Like 1
Link to comment
Share on other sites
Stefanalmare
Stefanalmare
Posted
Posted
14 minutes ago, ghost8282 said:

I confirm this, something changed in xcode 13.3

The issue seems to be in kern_qsort file: 

loop:	SWAPINIT(a, es);

-> Performing pointer subtraction with a null pointer may have undefined behavior

 

a is in fact defined as void pointer: 

qsort(void *a, size_t n, size_t es, int (*cmp)(const void *, const void *))

 

Same.

  • Like 1
Link to comment
Share on other sites
  • 2 weeks later...
 Share
Go to topic listing
×
×
  • Create New...