Clover.app testing

[Sherlocks]

Sorry for the inconvenience, but you just give me a good new as mount finally works for you. This is the code:

if (disk != nil) {       // get the mount point or mount it       var mounted : Bool = false       if let mp = getMountPoint(from: disk!) {         mounted = true         saveNVRAM(nvram: nvram, volume: mp)         return       }       if !mounted {         log("mount begin for \(disk!)..")         var mountattempts : Int = 0         repeat {           mount(disk: disk!, at: nil) { (result) in             mountattempts+=1             sleep(1)             if result == true {               var attempts = 0               repeat {                 sleep(1)                 attempts+=1                 if let mp = getMountPoint(from: disk!) {                   mounted = true                   mountattempts = 5                   saveNVRAM(nvram: nvram, volume: mp)                   sleep(1)                   umount(disk: disk!, force: true)                   break                 }               } while (getMountPoint(from: disk!) == nil || attempts > 10)             }           }         } while mountattempts 

There are two loops, one for mount and one to wait for the mount point to appear. This is easy to fix by force to break the first loop as soon the volume is mounted. Now I have no time but I will within 4 hours.
P.S. as far I can see mount succeded at first attempt, and maybe there's no need for a loop.

okay i will wait your new version. thank you

나의 SM-N960N 의 Tapatalk에서 보냄

[vector sigma]

@Sherlocks : {removed} no loop with only one attempt and I hope it is full working now. Otherwise a loop will be still needed, but now the code is so robust and all services are still enabled at the time is doing its job. Give me a good result  

Edited November 21, 2019 by vector sigma

[Sherlocks]

3 hours ago, vector sigma said:

@Sherlocks Clover.app_v1.06.zip:  no loop with only one attempt and I hope it is full working now. Otherwise a loop will be still needed, but now the code is so robust and all services are still enabled at the time is doing its job. Give me a good result  

 

still happen loop

here is log

Spoiler

Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19---------------------------------------------------
CloverDaemon start at 2019-11-19 07:36:57
---------------------------------------------------
/Library/LaunchDaemons/com.projectosx.clover.daemon.plist: Operation now in progress

 

[vector sigma]

On 11/18/2019 at 11:38 PM, Sherlocks said:

 

still happen loop

here is log

  Reveal hidden contents

Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19
Detected ESP disk0s1 as boot device.
disk0s1 was already mounted.
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut v1.0.1: logout begin at 2019-11-19 07:36:19---------------------------------------------------
CloverDaemon start at 2019-11-19 07:36:57
---------------------------------------------------
/Library/LaunchDaemons/com.projectosx.clover.daemon.plist: Operation now in progress

 

There's no loop in the code, so the problem, as I'm now sure, is that old rc scripts are interferring all the time:

/Library/LaunchDaemons/com.projectosx.clover.daemon.plist: Operation now in progress

Also old code was working well, and probably the older as well. Is too much If I ask you to remove them completely?

 

using {removed} and reboot?. It will never work otherwise. Thanks

Edited November 21, 2019 by vector sigma

[Sherlocks]

10 hours ago, vector sigma said:

There's no loop in the code, so the problem, as I'm now sure, is that old rc scripts are interferring all the time:

/Library/LaunchDaemons/com.projectosx.clover.daemon.plist: Operation now in progress

Also old code was working well, and probably the older as well. Is too much If I ask you to remove them completely?

 

using uninstall_rc_scripts.zip and reboot?. It will never work otherwise. Thanks

 

no working now. it's same like before.

also i tested all cleared clover files.

/Volumes/EFI/EFI/CLOVER/drivers64UEFI/EmuVariableUefi-64.efi
/etc/rc.clover.lib
/etc/rc.boot.d/10.save_and_rotate_boot_log.local
/etc/rc.boot.d/20.mount_ESP.local
/etc/rc.boot.d/70.disable_sleep_proxy_client.local.disabled
/etc/rc.shutdown.d/80.save_nvram_plist.local

/etc/rc.boot.d 
/etc/rc.shutdown.d 

 

and

install cloverdaemonew from clover app 1.0.6beta. but i can't logout. 

force reboot with power button. then i checked log. but it is empty.

 

after remove cloverdaemonnew from clover app 1.0.6beta, i can logout. i think cloverdaemon has problem.

[vector sigma]

1 hour ago, Sherlocks said:

 

no working now. it's same like before.

also i tested all cleared clover files.

/Volumes/EFI/EFI/CLOVER/drivers64UEFI/EmuVariableUefi-64.efi
/etc/rc.clover.lib
/etc/rc.boot.d/10.save_and_rotate_boot_log.local
/etc/rc.boot.d/20.mount_ESP.local
/etc/rc.boot.d/70.disable_sleep_proxy_client.local.disabled
/etc/rc.shutdown.d/80.save_nvram_plist.local

/etc/rc.boot.d 
/etc/rc.shutdown.d 

 

and

install cloverdaemonew from clover app 1.0.6beta. but i can't logout. 

force reboot with power button. then i checked log. but it is empty.

 

after remove cloverdaemonnew from clover app 1.0.6beta, i can logout. i think cloverdaemon has problem.

@Sherlocks what is the result of

ls -a /Library/Application\ Support/Clover/

and 

sudo defaults read /var/root/Library/Preferences/com.apple.loginwindow.plist

and 

defaults read com.apple.loginwindow LogoutHook

? Please let me know

 

EDIT

(just read, do nothing)

Edited November 19, 2019 by vector sigma

[Sherlocks]

16 minutes ago, vector sigma said:

@Sherlocks what is the result of

ls -a /Library/Application\ Support/Clover/

and 

sudo defaults read /var/root/Library/Preferences/com.apple.loginwindow.plist

and 

defaults read com.apple.loginwindow LogoutHook

? Please let me know

 

EDIT

(just read, do nothing)

 

 

sherlocks@SherloccBookPro ~ % ls -a /Library/Application\ Support/Clover/

. CloverLogOut

.. CloverUpdater.app

CloverDaemon CloverUpdaterUtility

CloverDaemon-stopservice CloverWrapper.sh

CloverDaemonNew

sherlocks@SherloccBookPro ~ % 

 

 

sherlocks@SherloccBookPro ~ % sudo defaults read /var/root/Library/Preferences/com.apple.loginwindow.plist

Password:

{

    LogoutHook = "/Library/Application Support/Clover/CloverWrapper.sh";

}

sherlocks@SherloccBookPro ~ % 

 

sherlocks@SherloccBookPro ~ % defaults read com.apple.loginwindow LogoutHook

2019-11-19 21:02:06.645 defaults[598:6474] 

The domain/default pair of (com.apple.loginwindow, LogoutHook) does not exist

sherlocks@SherloccBookPro ~ % 

 

here is log

thanks in advance

[vector sigma]

3 minutes ago, Sherlocks said:

thanks in advance

Thanks to you. Ok, can you remove the following?

/Library/LaunchDaemons/com.projectosx.clover.daemon.plist
/Library/Application Support/Clover/CloverDaemon
/Library/Application Support/Clover/CloverDaemon-stopservice
/Library/Application Support/Clover/CloverWrapper.sh

and 

/etc/rc.boot.d/10.save_and_rotate_boot_log.local
/etc/rc.boot.d/20.mount_ESP.local
/etc/rc.boot.d/70.disable_sleep_proxy_client.local.disabled
/etc/rc.boot.d/70.disable_sleep_proxy_client.local
/etc/rc.clover.lib
/etc/rc.shutdown.d/80.save_nvram_plist.local

 

and reboot twice? Thanks in advance

[Sherlocks]

5 minutes ago, vector sigma said:

Thanks to you. Ok, can you remove the following?

/Library/LaunchDaemons/com.projectosx.clover.daemon.plist
/Library/Application Support/Clover/CloverDaemon
/Library/Application Support/Clover/CloverDaemon-stopservice
/Library/Application Support/Clover/CloverWrapper.sh

and 

/etc/rc.boot.d/10.save_and_rotate_boot_log.local
/etc/rc.boot.d/20.mount_ESP.local
/etc/rc.boot.d/70.disable_sleep_proxy_client.local.disabled
/etc/rc.boot.d/70.disable_sleep_proxy_client.local
/etc/rc.clover.lib
/etc/rc.shutdown.d/80.save_nvram_plist.local

 

and reboot twice? Thanks in advance

 

/Library/LaunchDaemons/com.projectosx.clover.daemon.plist.   <---- no file
/Library/Application Support/Clover/CloverDaemon             <---- deleted
/Library/Application Support/Clover/CloverDaemon-stopservice <---- deleted
/Library/Application Support/Clover/CloverWrapper.sh         <---- deleted

 

/etc/rc.boot.d/10.save_and_rotate_boot_log.local             <---- no file
/etc/rc.boot.d/20.mount_ESP.local                            <---- no file
/etc/rc.boot.d/70.disable_sleep_proxy_client.local.disabled  <---- no file
/etc/rc.boot.d/70.disable_sleep_proxy_client.local           <---- no file
/etc/rc.clover.lib                                           <---- no file
/etc/rc.shutdown.d/80.save_nvram_plist.local                 <---- no file

 

reboot twice. i can reboot! thank you.

and here is log

- CloverLogOut v1.0.1: logout begin at 2019-11-19 09:14:42
Detected ESP disk0s1 as boot device.
mounting disk0s1..
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut: end at 2019-11-19 09:14:45

--------------------------------------------
- CloverDaemonNew v1.0.3
- macOS Version 10.15.2 (Build 19C39d)
- System start at 2019-11-19 09:13:30
------
Registering for Power notifications..
root mount point is '/Volumes/Macintosh HD'
Started with Clover r5098.
making '/' writable as Clover.RootRW=true.
Clover.DisableSleepProxyClient=true
Sleep Proxy Client disabled as requested.
Logout hook is: /Library/Application Support/Clover/CloverLogOut

SIGTERM received at 2019-11-19 09:14:45
Clover.DisableSleepProxyClient=true
Sleep Proxy Client disabled as requested.
 

[vector sigma]

Finally  it works! I rewrote it just 20 times for nothing Lol. What I have to do is do erase any trace of the old rc scripts...

Edited November 19, 2019 by vector sigma

[Sherlocks]

4 minutes ago, vector sigma said:

Finally  it works! Just rewrite it 20 times for nothing Lol. What I have to do is do erase any trace of the old rc scripts...

 

thank you for hard work.

this file is also good.

Clover.app_v1.05Beta-5098.zip

 

--------------------------------------------
- CloverDaemonNew v1.0.3
- macOS Version 10.15.2 (Build 19C39d)
- System start at 2019-11-19 09:21:40
------
Registering for Power notifications..
root mount point is '/Volumes/Macintosh HD'
Started with Clover r5098.
making '/' writable as Clover.RootRW=true.
Clover.DisableSleepProxyClient=true
Sleep Proxy Client disabled as requested.
Logout hook is: /Library/Application Support/Clover/CloverLogOut

SIGTERM received at 2019-11-19 09:22:12
Clover.DisableSleepProxyClient=true
Sleep Proxy Client disabled as requested.

[vector sigma]

2 minutes ago, Sherlocks said:

thank you for hard work.

Thanks for your tests and for putting up with me. Next will remove any trace of old rc scripts (is ready).

@SherlocksWhat's next then? What about sound at boot?

[Sherlocks]

13 minutes ago, vector sigma said:

Thanks for your tests and for putting up with me. Next will remove any trace of old rc scripts (is ready).

@SherlocksWhat's next then? What about sound at boot?

 

good. i think this needs improvement

 

1.

root mount point is '/Volumes/Macintosh HD'
Started with Clover r5098.
Clover.DisableSleepProxyClient=true
Sleep Proxy Client disabled as requested.
old '/Volumes/EFI/nvram.plist' removed.
old '/nvram.plist' removed.
old '/Volumes/Mac Data/nvram.plist' removed.

 

i think this is not good when wakeup nvram.plist file will be remove on all partition. of course, now your new daemon consider logout, shutdown and wakeup

we need to update nvram.plist better only logout or shutdown than wakeup on ESP. other nvram.plist of other partition will be remove except MBR user

 

2.

nvram.plist compared function. between saved nvram.plist on ESP or will be saved nvram.plist from memory. already old rc script consider this case.

if contents is same saved nvram.plist from memory, skip saved nvram.plist, if it is different, update new nvram.plist from memory.

 

3. cosmetic issue

--------------------------------------------
- CloverDaemonNew v1.0.3
- macOS Version 10.15.2 (Build 19C39d)
- System start at 2019-11-19 09:30:18
------
Registering for Power notifications..
root mount point is '/Volumes/Macintosh HD'
Started with Clover r5098.
Clover.DisableSleepProxyClient=true
Sleep Proxy Client disabled as requested.
old '/Volumes/EFI/nvram.plist' removed.
old '/nvram.plist' removed.
old '/Volumes/Mac Data/nvram.plist' removed.
Logout hook is: /Library/Application Support/Clover/CloverLogOut
System awaken at 2019-11월-19 21:30:20

SIGTERM received at 2019-11-19 09:31:04
Clover.DisableSleepProxyClient=true
Sleep Proxy Client disabled as requested.

Edited November 19, 2019 by Sherlocks

[vector sigma]

22 minutes ago, Sherlocks said:

i think this is not good when wakeup nvram.plist file will be remove on all partition. of course, now your new daemon consider logout, shutdown and wakeup

but it does not get removed.

1. when the system start all nvram.plist are removed from all mounted volumes (so not from the ESPs)
2. only after wake the daemon remove the following keys from /nvram.plist  (efi-backup-boot-device, efi-backup-boot-device-data, install-product-url, previous-system-uuid). the file will be hidden from the Finder, but is present.
3. At shut down/restart it delete again, if found, efi-backup-boot-device, efi-backup-boot-device-data, install-product-url, previous-system-uuid and save the nvram.

22 minutes ago, Sherlocks said:

2.

nvram.plist compared function. between saved nvram.plist on ESP or will be saved nvram.plist from memory.

if contents is same saved nvram.plist from memory, skipped save nvram.plist, if it is different, save new nvram.plist.

Really not needed. After mounting the ESP this is a tiny task compared to mount operation. But ok, I can do something.

22 minutes ago, Sherlocks said:

System awaken at 2019-11월-19 21:30:20

Does it mean anything?

Edited November 19, 2019 by vector sigma

[vector sigma]

 

NOTE: i've edited my last post

Edited November 19, 2019 by vector sigma

[Sherlocks]

13 minutes ago, vector sigma said:

 

NOTE: i've edited my last post

 

1. when the system start all nvram.plist is removed from all volumes (but not from the ESP)
after type password on login windows?, i'm not sure that but problems may arise if hibernationfixup case.

 

2. only after wake the daemon remove the following keys from /nvram.plist  (efi-backup-boot-device, efi-backup-boot-device-data, install-product-url, previous-system-uuid)

i tested this cases.
i just copy nvram.plist on root of every partition. and mounted ESP. then go sleep, and wakeup, every nvram.plist were removed. if unmount ESP, nvram.plist alive on ESP.
i think better these "efi-backup-boot-device, efi-backup-boot-device-data, install-product-url, previous-system-uuid" key be remove when logout or shutdown. normally, update macos from setting, and when logout and system go installation windows(apple logo with black background), systeme makes these nvram.plist keys

3. At shut down/restart it deleted again, if found, efi-backup-boot-device, efi-backup-boot-device-data, install-product-url, previous-system-uuid and save the nvram.

actually, we don't consider specific nvram.plist keys, just consider point

 

 

i think

basically
1. cloverdaemon consider update nvram.plist or not on ESP with remove nvram.plist of other partition except MBR, if MBR, update nvram.plist on root of own mac partition when only logout.

2. no need extra work for nvram.plist when wakeup and boot.

 

Does it mean anything?

- System awaken at 2019-11"월"-19 21:30:20 added korean word"월". it means month. there is no other korean word for year and day.

 

 

Edited November 19, 2019 by Sherlocks

[vector sigma]

7 minutes ago, Sherlocks said:

1. when the system start all nvram.plist is removed from all volumes (but not from the ESP)
after type password on login windows?, i'm not sure that but problems may arise if hibernationfixup case.

Only at start up when Clover has already restored the nvram. 

 

8 minutes ago, Sherlocks said:

i just copy nvram.plist on root of every partition. and mounted ESP. then go sleep, and wakeup, every nvram.plist were removed. if unmount ESP, nvram.plist alive on ESP.

That should not happen. Does probably get hidden??? 

try again but use

ls -a /

 

9 minutes ago, Sherlocks said:

3. At shut down/restart it deleted again, if found, efi-backup-boot-device, efi-backup-boot-device-data, install-product-url, previous-system-uuid and save the nvram.

actually, we don't consider specific nvram.plist keys, just consider point

Please reprhase ... Is good or not to remove those keys for CloverEFI? And when?

12 minutes ago, Sherlocks said:

1. cloverdaemon consider update nvram.plist or not on ESP with remove nvram.plist of other partition except MBR, if MBR, update nvram.plist on root of own mac partition when only logout.

Ok this is easy

12 minutes ago, Sherlocks said:

2. no need extra work for nvram.plist when wakeup and boot.

Ok, more easy..

13 minutes ago, Sherlocks said:

- System awaken at 2019-11"월"-19 21:30:20 added korean word"월". it means month. there is no other korean word for year and day.

Written by the macOS API as recognize your language. But I'll make it in english for all

[Sherlocks]

12 minutes ago, vector sigma said:

Only at start up when Clover has already restored the nvram. 

 

That should not happen. Does probably get hidden??? 

try again but use

ls -a /

 

Please reprhase ... Is good or not to remove those keys for CloverEFI? And when?

 

Q.Only at start up when Clover has already restored the nvram. 
A.
aha yes, clover will read nvram.plist made by hibernationfixup and put nvram values in memory. when booting, no mounted ESP, nvram.plist alive on ESP. on root of mac parititon, nvram.plist that hibernationfixup will be remove.
process is good.

 

Q. That should not happen. Does probably get hidden??? try again but use
A. i tried it. but no success. everytime all nvram.plist will be remove on all partition.
i copied nvram.plist from ESP, and paste it on other all mac partition.

 

Q. Please reprhase ... Is good or not to remove those keys for CloverEFI? And when?
A. these keys were made when update macos. i think that no need these keys or special key be removed by cloverdaemon.

 

I think the clover daemon does not need bother(mount/unmount) the disk when it boots up or sleeps and wakes up.

Edited November 19, 2019 by Sherlocks

[vector sigma]

9 minutes ago, Sherlocks said:

Q. Please reprhase ... Is good or not to remove those keys for CloverEFI? And when?
A. these keys were made when update macos. i think that no need these keys or special key be removed by cloverdaemon.

 

I think the clover daemon shouldn't bother the disk when it boots up or sleeps and wakes up.

That's why i told you that it should not remove anything after wake.

There are two programs: 

 

CloverDaemonNew

run when system starts (and only at this time delete old nvram.plist) but not after wake. But after wake clean and hide nvram.plist. Otherwise this have no sense to me as it run only at start up and not multiple times.

 

CloverLogOut

run at logout/shut down/restart: it doesn't delete any file. Only save the nvram to ESP or to / if no ESP is found.

 

Edited November 19, 2019 by vector sigma

[vector sigma]

14 minutes ago, Sherlocks said:

I think the clover daemon does not need bother(mount/unmount) the disk when it boots up or sleeps and wakes up.

CloverDaemonNew doesn't do that, root volumes are already mounted by the System.

Edited November 19, 2019 by vector sigma

[vector sigma]

Ok please test this: Clover.app_Sherlocks.zip EDIT

 

In the meantime I'm working to not saving the nvram each logout if nvram is the same.

Edited November 19, 2019 by vector sigma

[Sherlocks]

14 minutes ago, vector sigma said:

That's why i told you that it should not remove anything after wake.

There are two programs: 

 

CloverDaemonNew

run when system starts (and only at this time delete old nvram.plist) but not after wake. But after wake clean and hide nvram.plist. Otherwise this have no sense to me as it run only at start up and not multiple times.

 

CloverLogOut

run at logout/shut down/restart: it doesn't delete any file. Only save the nvram to ESP or to / if no ESP is found.

 

 

confirmed.

this way is different compared old rc script.

 

8 minutes ago, vector sigma said:

CloverDaemonNew doesn't do that, root volumes are already mounted by the System.

 

okay. checked too.

 

report one.

after checked DisableSleepProxyClient in clover app, and clover app makes Clover.DisableSleepProxyClient true in nvram.

 

then reboot and i checked

 

it is fine, but, i uncheck DisableSleepProxyClient in clover app, and nvram -p, i checked DisableSleepProxyClient key was removed.

then reboot, and checked com.apple.mDNSResponder.plist file

but still there is -DisableSleepProxyClient in ProgramArguments. i have to remove -DisableSleepProxyClient manually

[vector sigma]

1 minute ago, Sherlocks said:

report one.

after checked DisableSleepProxyClient in clover app, and clover app makes Clover.DisableSleepProxyClient true in nvram.

 

then reboot and i checked

 

it is fine, but, i uncheck DisableSleepProxyClient in clover app, and nvram -p, i checked DisableSleepProxyClient key was removed.

then reboot, and checked com.apple.mDNSResponder.plist file

but still there is -DisableSleepProxyClient in ProgramArguments. i have to remove -DisableSleepProxyClient manually

Please, we will check it later. We have to focus to nvram saving :-)

2 minutes ago, Sherlocks said:

confirmed.

this way is different compared old rc script.

late, I removed all the code. Now we have to redone it?? 

[Sherlocks]

9 minutes ago, vector sigma said:

late, I removed all the code. Now we have to redone it?? 

 

aha i just checked it and report it for you.

i think only old script way. haha. no need it. if you want, redone again

 

Please, we will check it later. We have to focus to nvram saving :-)

- okay.

 

EDIT

I will check

Clover.app_Sherlocks.zip 

Edited November 19, 2019 by Sherlocks

[Sherlocks]

@vector sigma

Clover.app_Sherlocks.zip is perfect working now like old rc script.

thanks you so much.

also there is no that old clover app(1.0.5 and older) has mount issue.

 

EDIT1

--------------------------------------------
- CloverDaemonNew v1.0.3
- macOS Version 10.15.2 (Build 19C39d)
- System start at 2019-11-19 11:19:56
------
root mount point is '/Volumes/Macintosh HD'
Started with Clover r5098.
making '/' writable as Clover.RootRW=true.
Logout hook is: /Library/Application Support/Clover/CloverLogOut

SIGTERM received at 2019-11-19 11:21:15

- CloverLogOut v1.0.1: logout begin at 2019-11-19 11:31:42
Detected ESP disk0s1 as boot device.
mounting disk0s1..
nvram correctly saved to /Volumes/EFI with UUID: 0E239BC6-F960-3107-89CF-1C97F78BB46B.
- CloverLogOut: end at 2019-11-19 11:31:44

--------------------------------------------

Edited November 19, 2019 by Sherlocks