Slice Posted October 28, 2018 Author Share Posted October 28, 2018 Icon sizes must be defined by additional rect with name "BoundingRect_XXX" and opacity=0.0 Bur I am not agree that color is good. I checked these pictures with Photoshop. With QuickLook I see (120,130,0) while with Clover I see (179,140,28) which is much lighter and more red. I think we should avoid semitransparency when possible. Sample theme which not good because of opacities Theme.svg 1 Link to comment Share on other sites More sharing options...
blackosx Posted October 28, 2018 Share Posted October 28, 2018 I'll test more with colours when I get time. But yes, results show that current drawing is good when on top of a solid base colour, but not when base is transparent. Thanks for theme file. I'll test soon. For ref, that Theme.svg has error on line #762 with closing /> <rect id="BoundingRect" y="0" class="st0" width="1200" height="768"/ visibility="hidden"> Should be <rect id="BoundingRect" y="0" class="st0" width="1200" height="768" visibility="hidden"/> Link to comment Share on other sites More sharing options...
HmO Posted October 28, 2018 Share Posted October 28, 2018 1 Link to comment Share on other sites More sharing options...
joevt Posted October 28, 2018 Share Posted October 28, 2018 13 hours ago, blackosx said: This is what I see in Photoshop when viewing the SVG on dark background and white background. Left side is original SVG, right side is screenshot from clover gui. Centre square when the 50% green is overlaid on the red is good and any visual differences is due to optical illusion. 50% green is different in Clover due to the way it's being blended with the background. What method does Clover use to average color? Here's one method: https://graphicdesign.stackexchange.com/questions/113884/calculating-average-of-two-rgb-values Here's an explanation video: 1 Link to comment Share on other sites More sharing options...
Slice Posted October 29, 2018 Author Share Posted October 29, 2018 Clover uses plain RGB and yes it can explain color difference https://sourceforge.net/p/cloverefiboot/code/HEAD/tree/rEFIt_UEFI/libeg/nanosvgrast.c#l1185 nsvg__scanlineSolid 3 Link to comment Share on other sites More sharing options...
Badruzeus Posted November 4, 2018 Share Posted November 4, 2018 (edited) This is Clovy vector theme screenshot using r4731, no idea why it looks different with yours Edited November 4, 2018 by Badruzeus 1 Link to comment Share on other sites More sharing options...
Matgen84 Posted November 4, 2018 Share Posted November 4, 2018 (edited) Hi This is Clovy theme screenshot (r4731): it seems not detect apfs volume, and some big issue on my system (Grey bar on left side, fonts...) Edited November 4, 2018 by Matgen84 Link to comment Share on other sites More sharing options...
blackosx Posted November 4, 2018 Share Posted November 4, 2018 Same here. Volume icons are low-res also. 1 Link to comment Share on other sites More sharing options...
Slice Posted November 4, 2018 Author Share Posted November 4, 2018 The issue may be related to switching theme. Try to see the theme if it set initially in config.plist. Link to comment Share on other sites More sharing options...
blackosx Posted November 4, 2018 Share Posted November 4, 2018 That was from config.plist. I didn’t try switching theme. I’m out now but will test later. 1 Link to comment Share on other sites More sharing options...
Badruzeus Posted November 4, 2018 Share Posted November 4, 2018 Oh, I got this issue with Clovy vector Theme.svg since r4733. Link to comment Share on other sites More sharing options...
Slice Posted November 5, 2018 Author Share Posted November 5, 2018 8 hours ago, Badruzeus said: Oh, I got this issue with Clovy vector Theme.svg since r4733. Thanks, no problem to fix. 1 1 Link to comment Share on other sites More sharing options...
blackosx Posted November 5, 2018 Share Posted November 5, 2018 Good job with the continued changes and improvements with SVG support. And I see the Clovy theme is becoming more polished and including more icons. I'll play and learn with this theme while it's being developed. @Slice Is there anyway yet to instruct SVG theme to use <key>Theme</key> <dict> <key>Badges</key> <dict> <key>Swap</key> <true/> </dict> </dict> 2 Link to comment Share on other sites More sharing options...
Slice Posted November 5, 2018 Author Share Posted November 5, 2018 2 hours ago, blackosx said: Good job with the continued changes and improvements with SVG support. And I see the Clovy theme is becoming more polished and including more icons. I'll play and learn with this theme while it's being developed. @Slice Is there anyway yet to instruct SVG theme to use <key>Theme</key> <dict> <key>Badges</key> <dict> <key>Swap</key> <true/> </dict> </dict> <clover:theme SelectionOnTop="0" BadgeOffsetX="0xFFFF" BadgeOffsetY="0xFFFF" NonSelectedGrey="0" CharWidth="16" BackgroundDark="1" BackgroundSharp="0x80" Badges="none" BackgroundScale="scale" SelectionColor="0x80808080" /> Possible values are Badges="swap inline none" in any combination. 1 1 Link to comment Share on other sites More sharing options...
Slice Posted November 5, 2018 Author Share Posted November 5, 2018 It is the first theme that can be used on screen like 640x480 1 Link to comment Share on other sites More sharing options...
blackosx Posted November 5, 2018 Share Posted November 5, 2018 Clover r4739 is looking a lot better Link to comment Share on other sites More sharing options...
Badruzeus Posted November 5, 2018 Share Posted November 5, 2018 (edited) With r4739, font character spacing and space between lines bcome tight on Bitmap themes, so it cropped on some parts. And function icons seem have centering posision issue. But on Vector theme, font spacing is wide. Thanks anyway yaa. Spoiler Edited November 6, 2018 by Badruzeus 2 Link to comment Share on other sites More sharing options...
Slice Posted November 6, 2018 Author Share Posted November 6, 2018 TODO 1. Correct bugs, exclude panics and tune layout. 2. Vector text drawing 3. Depending on 2. make multifont support. 4. Depending on 3. make international characters. For now we have english and russian, somehow korean. Now we can make even chinese. 5. Make animation like in raster themes. 6. Make vector animation (?). 7. Dynamic background like in Mojave: morning, dawn, midday, twilight, midnight, ... Sun and Moon. Functions 4-7 require designers work. 3 Link to comment Share on other sites More sharing options...
Slice Posted November 6, 2018 Author Share Posted November 6, 2018 Rev 4741 looking on 1920x1080 as It means yes, it is Scalable Graphics! 3 Link to comment Share on other sites More sharing options...
Badruzeus Posted November 6, 2018 Share Posted November 6, 2018 (edited) 1 hour ago, Slice said: Rev 4741 looking on 1920x1080 as It means yes, it is Scalable Graphics! Sorry for reporting this @Slice, with r4741: 1. Switching between Vector - Bitmap themes will broke font appearance, also banner animation random issue 2. Font character spacing issue, OK.. I could increase 1px for my Bitmap themes. But Line spacing is too tight on both Bitmap and Vector theme, so some characters are cropped (ie. j, g, p, q, y, etc..) 3. Function icons centering issue (Bitmap themes only). Anyway, thanks for your hard works with Vector theme. Edited November 6, 2018 by Badruzeus 1 Link to comment Share on other sites More sharing options...
Slice Posted November 6, 2018 Author Share Posted November 6, 2018 Thanks for the report! I will think about. @all About slow boot. 4:125 0:000 === [ InitTheme ] ======== ... 4:374 0:000 Chosen theme Clovy This is 250 milliseconds. Not so dangerous! 3 Link to comment Share on other sites More sharing options...
Hackmac101 Posted November 7, 2018 Share Posted November 7, 2018 11 hours ago, Slice said: Rev 4741 looking on 1920x1080 as It means yes, it is Scalable Graphics! Where can I get this theme? Will it scale 4K to 200%? 1 Link to comment Share on other sites More sharing options...
Badruzeus Posted November 7, 2018 Share Posted November 7, 2018 (edited) 20 minutes ago, Hackmac101 said: Where can I get this theme? Will it scale 4K to 200%? I guess, YES. This is screenshot from 4K display (3840x2160 px): #EDIT: Not sure how many percents it was increased #LoL Edited November 7, 2018 by Badruzeus 3 Link to comment Share on other sites More sharing options...
Hackmac101 Posted November 7, 2018 Share Posted November 7, 2018 (edited) 1 hour ago, Badruzeus said: I guess, YES. This is screenshot from 4K display (3840x2160 px): #EDIT: Not sure how many percents it was increased #LoL Looks like 300% PS: I've been using my own script to extract & replace Clover.efi to update Clover, not running the installer, so I didn't know there are new included themes. My bad. Edit: bdmesg tells us that the scaling is 2.812500 Edited November 7, 2018 by Hackmac101 1 Link to comment Share on other sites More sharing options...
blackosx Posted November 7, 2018 Share Posted November 7, 2018 (edited) Badges=swap is not working. I tried a quick debug this morning but log didn't show anything. I'll need to take a deeper look when I get time. EDIT: Would this be issue with theme or Clover? Edited November 7, 2018 by blackosx 1 1 Link to comment Share on other sites More sharing options...
Recommended Posts