Sherlocks Posted August 18, 2018 Share Posted August 18, 2018 (edited) 6 minutes ago, Badruzeus said: r4651; It's OK with another Themes, but now "Embedded" DarkMode has gone. what is your type? "embedded" or "Embedded"? i tested "embedded". it was no problem. EDIT1. i followed default embedded folder name 0:120 0:000 === [ GetListOfThemes ] =================================== 0:120 0:000 - [00]: newyear 0:121 0:001 - [01]: christmas 0:122 0:000 - [02]: random 0:122 0:000 - [02]: bootcamp 0:123 0:000 - [03]: embedded 나의 LG-F800S 의 Tapatalk에서 보냄 Edited August 18, 2018 by Sherlocks 1 Link to comment Share on other sites More sharing options...
Badruzeus Posted August 18, 2018 Share Posted August 18, 2018 8 minutes ago, Sherlocks said: what is your type? "embedded" or "Embedded"? i tested "embedded". it was no problem. With this, now "embedded" DarkMode is fine. But another theme's font issue is still there: Spoiler <key>GUI</key> <dict> ... <key>Theme</key> <string>embedded</string> <key>embeddedThemeType</key> <string>Dark</string> </dict> Link to comment Share on other sites More sharing options...
Sherlocks Posted August 18, 2018 Share Posted August 18, 2018 (edited) 9 minutes ago, Badruzeus said: With this, now "embedded" DarkMode is fine. But another theme's font issue is still there: Hide contents <key>GUI</key> <dict> ... <key>Theme</key> <string>embedded</string> <key>embeddedThemeType</key> <string>Dark</string> </dict> can you explain it in detail? i don't know theme issue. because i always use bootcamp. also can you upload theme that has issue? EDIT1. is it you mentioned like this? this case is no problem. <key>GUI</key> <dict> ... <key>Theme</key> <string>bootcamp</string> <key>embeddedThemeType</key> <string>Dark</string> </dict> EDIT2. you mistook it. it's correct like this <key>GUI</key> <dict> ... <key>Theme</key> <string>embedded</string> <key>EmbeddedThemeType</key> <string>Dark</string> </dict> Edited August 18, 2018 by Sherlocks 1 Link to comment Share on other sites More sharing options...
Badruzeus Posted August 18, 2018 Share Posted August 18, 2018 2 minutes ago, Sherlocks said: can you explain it in detail? i don't know theme issue. because i always use bootcamp. also can you upload theme that has issue? If this key is exist on config.plist: <key>embeddedThemeType</key> <string>Dark</string> .. but we're using other themes (not "embedded"), then another one has font rendering issue, as seen on prev. screenshots above. Link to comment Share on other sites More sharing options...
Sherlocks Posted August 18, 2018 Share Posted August 18, 2018 (edited) 1 minute ago, Badruzeus said: If this key is exist on config.plist: <key>embeddedThemeType</key> <string>Dark</string> .. but we're using other themes (not "embedded"), then another one has font rendering issue, as seen on prev. screenshots above. try EmbeddedThemeType correctly. upload your issue theme. i want to check it by myself Edited August 18, 2018 by Sherlocks Link to comment Share on other sites More sharing options...
Trung_Nguyen Posted August 18, 2018 Share Posted August 18, 2018 On 8/14/2018 at 2:32 PM, Slice said: @ type in terminal nvram -p https://www.insanelymac.com/forum/topic/304530-clover-change-explanations/?do=findComment&comment=2629641 On 8/15/2018 at 4:40 PM, Trung_Nguyen said: fakesmc-key-BBIN-ui8 %01 fakesmc-key-MSWr-ui8 %00 fakesmc-key-RPlt-ch8* j30%00%00%00%00%00 fakesmc-key-RBr -ch8* branch%00%00 EFILoginHiDPI %00%00%00%00 efi-boot-device <array><dict><key>IOMatch</key><dict><key>IOProviderClass</key><string>IOMedia</string><key>IOPropertyMatch</key><dict><key>UUID</key><string>D1D17580-8D7B-44EB-9587-9744768E0ADE</string></dict></dict></dict></array> fakesmc-key-#KEY-ui32 %00%00%00%11 SystemAudioVolumeDB %00 prev-lang:kbd en:0 fakesmc-key-BATP-flag %00 fakesmc-key-MSTc-ui8 %00 LocationServicesEnabled %01 security-mode none fakesmc-key-BNum-ui8 %01 csr-active-config g%00%00%00 fakesmc-key-$Num-ui8 %01 fakesmc-key-MSFW-ui8 %01%00 fakesmc-key-REV -ch8* %02%02%0f%00%00D fakesmc-key-MSPS-ui16 %00%03 fmm-computer-name Trung%e2%80%99s MacBook Pro backlight-level %0a%07 fakesmc-key-$Adr-ui32 %00%00%03%00 fakesmc-key-EPCI-ui32 %06`%07%00 bluetoothActiveControllerInfo %97%81<A%00%00%00%00%14%1a$%fdR2%b8} fakesmc-key-MSAc-ui16 %00%00 SystemAudioVolume %1f specialbootdevice %02%01%0c%00%d0A%03%0a%00%00%00%00%01%01%06%00%02%1f%03%12%0a%00%00%00%ff%ff%00%00%04%01*%00%02%00%00%00%80`%1f%00%00%00%00%00%08%d2%af%1d%00%00%00%00%80u%d1%d1{%8d%ebD%95%87%97Dv%8e%0a%de%02%02%04%03$%00%f7%fct%be|%0b%f3I%91G%01%f4%04.hBX`%efZ%8f@%97M%b5d%02%b2.C%f9%a4%7f%ff%04%00 fakesmc-key-RMde-char A flagstate %00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00%00 efi-boot-device-data %02%01%0c%00%d0A%03%0a%00%00%00%00%01%01%06%00%02%1f%03%12%0a%00%00%00%ff%ff%00%00%04%01*%00%02%00%00%00%80`%1f%00%00%00%00%00%08%d2%af%1d%00%00%00%00%80u%d1%d1{%8d%ebD%95%87%97Dv%8e%0a%de%02%02%04%03$%00%f7%fct%be|%0b%f3I%91G%01%f4%04.hBX`%efZ%8f@%97M%b5d%02%b2.C%f9%a4%7f%ff%04%00 fakesmc-key-BEMB-flag %01 Here you go On 8/13/2018 at 9:11 PM, Trung_Nguyen said: [PROBLEM REPORT] Hello, I'm using FileVault 2 of macOS Mojave beta 6. Clover version 4644 The EFI login screen took too long(as long as booting the kernel). When I use the -v, there are spamming of message "smcProtocol->SmcReadValue failed for key "blah"" after the LoginWindow loaded Not sure if it is related to SMCHelper or not? Thanks Is there a solution for this? Still exists in beta 7 Link to comment Share on other sites More sharing options...
Badruzeus Posted August 18, 2018 Share Posted August 18, 2018 7 minutes ago, Sherlocks said: try EmbeddedThemeType correctly Yes, I can confirm was using "EmbeddedThemeType" correctly. Spoiler Link to comment Share on other sites More sharing options...
Sherlocks Posted August 18, 2018 Share Posted August 18, 2018 (edited) 14 minutes ago, Badruzeus said: Yes, I can confirm was using "EmbeddedThemeType" correctly. Hide contents i don't understand. i'm sure that i checked it in UEFI. what is your step? just change theme in GUI? EDIT1 you changed theme in GUI! yes there is font issue in GUI if change theme EDIT2. my partition is apfs. but icon shown hfs+. is it issue for long time? i used FlatCamp EDIT3. in korea, too late. i will check it tomoroow. Edited August 18, 2018 by Sherlocks 1 Link to comment Share on other sites More sharing options...
Badruzeus Posted August 18, 2018 Share Posted August 18, 2018 (edited) 10 minutes ago, Sherlocks said: i don't understand. i'm sure that i checked it in UEFI. what is your step? just change theme in GUI? There's no issue with "embedded" theme "DarkMode" after your r4651 commit, thanks. But the problem is.. if we use different themes, as defined on config.plist GUI Theme or NVRAM's Clover.Theme="ThemeName" << this another "ThemeName" get issue with font rendering (glitchy), except removing "EmbeddedThemeType" key from config.plist. Edited August 18, 2018 by Badruzeus Link to comment Share on other sites More sharing options...
Sherlocks Posted August 18, 2018 Share Posted August 18, 2018 (edited) 21 minutes ago, Badruzeus said: There's no issue with "embedded" theme "DarkMode" after your r4651 commit, thanks. But the problem is.. if we use different themes, as defined on config.plist GUI Theme or NVRAM's Clover.Theme="ThemeName" ThemeName" get issue with font rendering (glitchy), except removing "EmbeddedThemeType" key from config.plist. strange. Flatcamp and DarkMode is are no font problem. now, after use darkmode with embedded in config.plist, reboot system, get GUI, go theme part, change theme and press esc and esc. shown font issue. EDIT1. also i will check apfs and hfs icon issue(clover will detect hfs and apfs icon properly). i found some point. 나의 LG-F800S 의 Tapatalk에서 보냄 Edited August 18, 2018 by Sherlocks 3 Link to comment Share on other sites More sharing options...
Badruzeus Posted August 18, 2018 Share Posted August 18, 2018 (edited) 36 minutes ago, Sherlocks said: my partition is apfs. but icon shown hfs+. is it issue for long time? i used FlatCamp Yes, known issue with APFS if using Badges "Swap=false" on theme.plist. There's "vol_internal_apfs.icns" on /icons dir, but.. it's still useless for sure. Edited August 18, 2018 by Badruzeus 1 Link to comment Share on other sites More sharing options...
blackosx Posted August 18, 2018 Share Posted August 18, 2018 I looked in to it before, see https://www.insanelymac.com/forum/topic/288685-clover-themes/?page=34&tab=comments#comment-2486012 2 Link to comment Share on other sites More sharing options...
Sherlocks Posted August 19, 2018 Share Posted August 19, 2018 (edited) 20 hours ago, Badruzeus said: Yes, known issue with APFS if using Badges "Swap=false" on theme.plist. There's "vol_internal_apfs.icns" on /icons dir, but.. it's still useless for sure. 19 hours ago, blackosx said: I looked in to it before, see https://www.insanelymac.com/forum/topic/288685-clover-themes/?page=34&tab=comments#comment-2486012 done @Badruzeus can you test hfs+ and apfs partition? here is test file i tested flatcamp. i just added it in theme folder, and reboot, get screenshot above test1.zip Edited August 19, 2018 by Sherlocks 1 Link to comment Share on other sites More sharing options...
Badruzeus Posted August 19, 2018 Share Posted August 19, 2018 11 minutes ago, Sherlocks said: done @Badruzeus can you test hfs+ and apfs partition? here is test file i tested flatcamp. i just added it in theme folder, and reboot, get screenshot above test.zip Many thanks. But My 10.14 was no longer using APFS, so I can only test it with HFS+ when I'm back home. Link to comment Share on other sites More sharing options...
Sherlocks Posted August 19, 2018 Share Posted August 19, 2018 8 minutes ago, Badruzeus said: Many thanks. But My 10.14 was no longer using APFS, so I can only test it with HFS+ when I'm back home. okay. @chris1111 chris can you test test file for apfs and hfs icon in theme? Link to comment Share on other sites More sharing options...
chris1111 Posted August 19, 2018 Share Posted August 19, 2018 37 minutes ago, Sherlocks said: okay. @chris1111 chris can you test test file for apfs and hfs icon in theme? I will update clover now I let you know Link to comment Share on other sites More sharing options...
chris1111 Posted August 19, 2018 Share Posted August 19, 2018 I not see any problem here 1 Link to comment Share on other sites More sharing options...
Sherlocks Posted August 19, 2018 Share Posted August 19, 2018 (edited) 3 minutes ago, chris1111 said: I not see any problem here can you test flatcamp theme? you have old mac(hfs) and mojave(apfs) because i want to know that clover correctly detect apfs or hfs parition icon. please test this file with flatcamp theme test1.zip Edited August 19, 2018 by Sherlocks 1 Link to comment Share on other sites More sharing options...
chris1111 Posted August 19, 2018 Share Posted August 19, 2018 this is from latest clover this is from your file I notice no difference looks ok for me 1 Link to comment Share on other sites More sharing options...
Sherlocks Posted August 19, 2018 Share Posted August 19, 2018 this is from latest clover this is from your file I notice no difference looks ok for me you can see APFS letter on icon and HFS.what is your sierra partition type? HFS+? your partition shown APFS icon. 나의 LG-F800S 의 Tapatalk에서 보냄 1 Link to comment Share on other sites More sharing options...
chris1111 Posted August 19, 2018 Share Posted August 19, 2018 (edited) 5 minutes ago, Sherlocks said: you can see APFS letter on icon and HFS. what is your sierra partition type? HFS+? your partition shown APFS icon. 나의 LG-F800S 의 Tapatalk에서 보냄 Sierra is HFS+J with another partition APFS Mojave=HD but I am boot from High Sierra and is on APFS Volume Edited August 19, 2018 by chris1111 1 Link to comment Share on other sites More sharing options...
Sherlocks Posted August 19, 2018 Share Posted August 19, 2018 38 minutes ago, chris1111 said: Sierra is HFS+J with another partition APFS Mojave=HD but I am boot from High Sierra and is on APFS Volume thanks. i checked it by myself. yes. still there is problem. need to think more cases. i will debug it. Link to comment Share on other sites More sharing options...
Badruzeus Posted August 19, 2018 Share Posted August 19, 2018 With r4652 test, FlatCamp theme uses vol_internal_ext3 instead of vol_recovery for my HFS+ RecoveryHD volumes (10.11.6, 10.13.5, 10.14 b7) Link to comment Share on other sites More sharing options...
Sherlocks Posted August 19, 2018 Share Posted August 19, 2018 With r4652 test, FlatCamp theme uses vol_internal_ext3 instead of vol_recovery for my HFS+ RecoveryHD volumes (10.11.6, 10.13.5, 10.14 b7)test.zip or test1.zip?나의 LG-F800S 의 Tapatalk에서 보냄 1 Link to comment Share on other sites More sharing options...
Badruzeus Posted August 19, 2018 Share Posted August 19, 2018 (edited) 35 minutes ago, Sherlocks said: test.zip or test1.zip? Was test.zip, now it shown properly with "test1.zip" for "Recovery HD". Thanks. Spoiler Edited August 19, 2018 by Badruzeus 1 Link to comment Share on other sites More sharing options...
Recommended Posts