cendana Posted September 2, 2019 Share Posted September 2, 2019 (edited) Thanks, full worked on mojave, install on S/L/E device is 10ec:5289 Edited September 2, 2019 by cendana Link to comment Share on other sites More sharing options...
girardpallet Posted September 8, 2019 Share Posted September 8, 2019 @ egore24 : did you fix 0x10EC-0x525A ? Link to comment Share on other sites More sharing options...
windowless31 Posted September 10, 2019 Share Posted September 10, 2019 (edited) Hi everybody, My Laptop is a Dell XPS 15-9560 with Realtek PCIE-Card-Reader 10EC:525A Not working with 10.14.6 Sinetek-rtsx.kext is in /L/E, but is not loaded. EDIT: I have added 0x525A10EC to the Info.plist. Now the driver is loaded. An SDHC or SDXC card is still not recognized. Edited September 11, 2019 by windowless31 Link to comment Share on other sites More sharing options...
rlp Posted September 23, 2019 Share Posted September 23, 2019 Laptop HP Probook 450G4 with internal reader , driver works well for me. Don't have anything to compare, but I found no problems. Link to comment Share on other sites More sharing options...
carlinyos Posted October 30, 2019 Share Posted October 30, 2019 @sysclare you still developing this code? Found that error 60 on reads was caused by idle function on read_task_impl... Link to comment Share on other sites More sharing options...
egore24 Posted November 3, 2019 Share Posted November 3, 2019 (edited) On 9/8/2019 at 6:47 AM, girardpallet said: @ egore24 : did you fix 0x10EC-0x525A ? I have not had any success with our card, sadly. Anyone else? Edited November 4, 2019 by egore24 Link to comment Share on other sites More sharing options...
Krennn Posted November 26, 2019 Share Posted November 26, 2019 (edited) Works great on Catalina 15.1 Speed small 5MB / s Edited November 26, 2019 by Krennn Link to comment Share on other sites More sharing options...
jman985 Posted December 21, 2019 Share Posted December 21, 2019 (edited) @egore24 @girardpallet @Sinetek any updates on 0x10EC-0x525A? I have the same card reader in my XPS 9570 in Catalina 10.15.3 Edited February 18, 2020 by jman985 Link to comment Share on other sites More sharing options...
juniorairton Posted February 17, 2020 Share Posted February 17, 2020 (edited) Acer Nitro 5 (AN515-50U2) internal Card Reader (0x528710EC) working on Catalina with your kext. Thank you! Edited February 17, 2020 by juniorairton Link to comment Share on other sites More sharing options...
cholonam Posted March 23, 2020 Share Posted March 23, 2020 For those with a 0x525A, I am trying to make this kext work. As of now, the kext loads and can read the card once it's inserted (writing is disabled for now). It will stop working if you extract and insert the card again. I will be working on this kext at least for a few weeks, so you can expect improvements and if you can help troubleshooting that would be very welcome. Source code (modified from @Sinetek and @syscl's) is here. Sinetek-rtsx-1.0.zip 2 Link to comment Share on other sites More sharing options...
Pickupman Posted March 29, 2020 Share Posted March 29, 2020 On 3/23/2020 at 11:59 PM, cholonam said: For those with a 0x525A, I am trying to make this kext work. As of now, the kext loads and can read the card once it's inserted (writing is disabled for now). It will stop working if you extract and insert the card again. I will be working on this kext at least for a few weeks, so you can expect improvements and if you can help troubleshooting that would be very welcome. Source code (modified from @Sinetek and @syscl's) is here. Sinetek-rtsx-1.0.zip YES! This one worked for me... However, it takes quite a while to recognise the SD card and the device doesn't appear anywhere in the "system report". Weird. My SD card reader is a 0x5287. Thanks Cholonam! Link to comment Share on other sites More sharing options...
carlinyos Posted April 1, 2020 Share Posted April 1, 2020 @cholonam thank you for maintaining (and improving) a working source. That is supervaluable! I might try to help your improve your version, but I still have a lot of questions regarding the kext. Let me know if I can PM you. Link to comment Share on other sites More sharing options...
cholonam Posted April 7, 2020 Share Posted April 7, 2020 On 4/2/2020 at 5:05 AM, carlinyos said: @cholonam thank you for maintaining (and improving) a working source. That is supervaluable! I might try to help your improve your version, but I still have a lot of questions regarding the kext. Let me know if I can PM you. Sure you can I am still learning about the kext too, but I think I could make it work properly. I just need time, which I don't have a lot.. What I've learned so far: The kext is basically the OpenBSD driver with a layer on top (Sinetek_rtsx.cpp/SDDisk.cpp) to make it work using the macOS' IOKit framework. Looks like syscl added the PM-management part on top of Sinetek's work, but does not look like working, so I just disabled it for now (rstx_activate() just returns 0). I'm afraid that even if we make the OpenBSD driver fully working, even this driver seems buggy and not 100% working.. the ideal way to go would be to port the Linux driver. I have compared both and they set registers differently, even some register numbers are different... Seems like the BSD driver was designed for just one particular card and just "happens to kind of work" with other cards too. That means the only hope to continue with this driver is that: 1) the OpenBSD team does some more work on it, and 2) that we can port those changes back again. I definitely don't have time to port the linux driver, even though it doesn't look too difficult. Maybe someone with Linux kernel and Darwin kernel experience (or eager to learn) wants to take the challenge... What I am doing in the develop branch is to implement a "BSD compatibility layer" so that we can use the OpenBSD code almost untouched and integration is easier if/when the BSD driver is improved. My goal is to just change the headers included by the BSD files to a single "openbsd_compat.h" which takes care off all the differences between BSD and mac functions. After I am done with this low-level part, I'll start looking into everything else that needs to be done (PM, multiblock read, stability...). Anyone willing to collaborate is welcome Cheers! 1 Link to comment Share on other sites More sharing options...
Sniki Posted April 7, 2020 Share Posted April 7, 2020 6 hours ago, cholonam said: Sure you can I am still learning about the kext too, but I think I could make it work properly. I just need time, which I don't have a lot.. What I've learned so far: The kext is basically the OpenBSD driver with a layer on top (Sinetek_rtsx.cpp/SDDisk.cpp) to make it work using the macOS' IOKit framework. Looks like syscl added the PM-management part on top of Sinetek's work, but does not look like working, so I just disabled it for now (rstx_activate() just returns 0). I'm afraid that even if we make the OpenBSD driver fully working, even this driver seems buggy and not 100% working.. the ideal way to go would be to port the Linux driver. I have compared both and they set registers differently, even some register numbers are different... Seems like the BSD driver was designed for just one particular card and just "happens to kind of work" with other cards too. That means the only hope to continue with this driver is that: 1) the OpenBSD team does some more work on it, and 2) that we can port those changes back again. I definitely don't have time to port the linux driver, even though it doesn't look too difficult. Maybe someone with Linux kernel and Darwin kernel experience (or eager to learn) wants to take the challenge... What I am doing in the develop branch is to implement a "BSD compatibility layer" so that we can use the OpenBSD code almost untouched and integration is easier if/when the BSD driver is improved. My goal is to just change the headers included by the BSD files to a single "openbsd_compat.h" which takes care off all the differences between BSD and mac functions. After I am done with this low-level part, I'll start looking into everything else that needs to be done (PM, multiblock read, stability...). Anyone willing to collaborate is welcome Cheers! Thanks for the amazing work that you did. As long as the kext works after wake from sleep, can eject and mount + read and write, it's absolutely amazing and just all we need for the currently supported card readers. Lenovo Thinkpads with Haswell and Broadwell generations have the 5227 model The last version from sinetek was working with read and write, eject and mount but after you let the laptop sleep then wake, it broke. I haven't tested using a fast SD card but even at current supported speeds we would be more than happy to have a working kext released. Thanks in advance ! Link to comment Share on other sites More sharing options...
polyzargone Posted April 7, 2020 Share Posted April 7, 2020 Thanks too @cholonam I observed the same behavior as Hervé using RTS5209 on my Acer Aspire 772G V3: Link to comment Share on other sites More sharing options...
jakepowell28 Posted April 9, 2020 Share Posted April 9, 2020 Can anyone help me troubleshoot this on my laptop? t440p laptop - realtek 5227 PCI card reader. i used https://github.com/jloisel/t440p guide and am running Catalina 10.15.3 everything else works amazingly well and stable - except wake from sleep (which I'm working on fixing and is a separate issue). I have the kext installed in L/E. I have it in clover EFI also and I've tried it in S/L/E , all to no avail . I tried editing the plist of apple storage drivers kext trick also. but i admit I'm not 100% i got it all correct . Here is my IOreg : Here is what Hackintool sees : and here is my edited kext for AppleStorageDrivers. AppleStorageDrivers.kext.zip Where have I gone wrong? Thanks to all the amazing community here ! Link to comment Share on other sites More sharing options...
cholonam Posted April 13, 2020 Share Posted April 13, 2020 For those interested, I am preparing a new release of the kext, in which I totally refactored the integration with the code from OpenBSD and added some code from the Linux driver that should help with the initialization (stability) of the 525A chip. I also added multiblock-reads (PR by Charlyo), which in my case has made the read speed double. The OpenBSD driver also uses ADMA, which should be even a bit faster, but that's not enabled yet since it needs some more changes in the compatibility layer. There are quite many changes this time, so I would like to test it thoroughly before issuing a new release. The code is on my github's develop branch (https://github.com/cholonam/Sinetek-rtsx/tree/develop) and I'm attaching a pre-release compiled version here. Writing can be enabled by using the "-rtsx_rw" boot parameter. Also, the LOCK switch on the card is now honored. Please take some time to test and let me know of any mayor problems. * The driver may still be unstable and crash your computer corrupting your APFS partition and valuable data (didn't happen to me recently, but I did before and it could happen to you)... be careful and always make backups. ** For those with other chips different from 525A but similar, I suspect that those chips are not being correctly initialized. The Linux driver looks much more complete than OpenBSD's. I recommend to take a look at the Linux driver and see what's missing (the driver is in drivers/misc/cardreader). It's not too hard, but takes time. I can't support all the chips because it would take too much time, but I'll accept pull requests if you have any. Sinetek-rtsx_PRERELEASE.zip 1 Link to comment Share on other sites More sharing options...
carlinyos Posted April 13, 2020 Share Posted April 13, 2020 Perfect cholonam! I'll try it and update it once I can Best regards, Charlyo (from github) Link to comment Share on other sites More sharing options...
Sniki Posted April 13, 2020 Share Posted April 13, 2020 (edited) @cholonam i just tested the attached prerelease kext and it seems that it is not attaching / loading. Here is mine on IOREG: It was working with last sinetek-rtsx from Sinetek attached on this thread. Im using OpenCore 0.5.7, injecting it with Bootloader. Let me know if you need additional logs, it seems that you have issues disabled on Github. Thanks for your great work. Edited April 13, 2020 by Sniki Link to comment Share on other sites More sharing options...
cholonam Posted April 13, 2020 Share Posted April 13, 2020 Sorry, but there was a bug in the prerelease I sent before which prevented card formatting from Disk Utility. I am sending a new prerelease and the fix is also on github. @Sniki I took care not to affect the original Syscl code for other chips, but I may have miss something. Like I said, there are many changes in this release and I will not be able to support chips other than mine (525A). Finding where both codes differ now for your particular chip will take a few days at lease, a time I don't have.. in any case, if you find the problem and let me know I'll be happy to merge your changes. Cheers, cholonam Sinetek-rtsx_PRERELEASE2.zip Link to comment Share on other sites More sharing options...
polyzargone Posted April 13, 2020 Share Posted April 13, 2020 RTS5209 not working too with latest release. Media does not attached to Sinetek_rtsx: Link to comment Share on other sites More sharing options...
Sniki Posted April 13, 2020 Share Posted April 13, 2020 1 hour ago, Hervé said: No good with my RTS525a (unlike your initial version). This is what I systematically get on inserting an SDHC card: Did you add the boot-arg: -rtsx_rw As @cholonam explained. Link to comment Share on other sites More sharing options...
cholonam Posted April 13, 2020 Share Posted April 13, 2020 2 hours ago, Hervé said: No good with my RTS525a (unlike your initial version). This is what I systematically get on inserting an SDHC card: Are you sure the card didn't get corrupted before? Can you try formatting it? Link to comment Share on other sites More sharing options...
lucatek Posted April 13, 2020 Share Posted April 13, 2020 (edited) IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/RP04@1C/IOPP/PXSX@0 PciRoot(0x0)/Pci(0x1C,0x0)/Pci(0x0,0x0) Hi Guys My Sinetek Card Reader Work Fine but after Sleep don't Work... Somebody can help me please? Card Reader Realtek RTS522A [10ec:522a] Lenovo s540-15IWL macOS Catalina Edited April 13, 2020 by lucatek Link to comment Share on other sites More sharing options...
carlinyos Posted April 13, 2020 Share Posted April 13, 2020 (edited) @cholonam built last develop branch for RTS522A. Read / write working well before sleep. After sleep (leaving card attached) error code 60 is present in all r/w commands. Edited April 13, 2020 by carlinyos specification Link to comment Share on other sites More sharing options...
Recommended Posts