[GUIDE] Lenovo T460/T470 macOS with Clover and OpenCore

[tluck]

i just found this out on my T420 - that WhateverGreen kext may conflict with the AppleBacklightInjector kext. and if Whatevergreen wins then you may not have a display brightness slider. i will merge BackLight Injector stuff into WhateverGreen so it will not be a conflict. 

[Miieanab]

Hi, I read your post and also https://octoperf.com/blog/2018/10/22/thinkpad-t460-how-to-install-macos/.
I'm using T460s (i7 6600u/16g/512g SSD/HD 520).
In others case, their screenshot of clover home screen, the first option is "boot macos install from install macos xxxxxxx", but my case is "start ueft shell 64", seems that clover does not recognize my macos disk partition.
Then I try to use "start ueft shell 64", but it only shows black screen without any response.
I already config the correct BIOS CONFIG, MACOS USB INSTALLER.The picture below is my macos USB installer, the first partition is EFI, the second is macos.

So can you help me with this?
Thanks a lot.

[nijhawank]

On 5/18/2018 at 3:06 AM, tluck said:

yes. worth a shot.  you can easily change in SSDT-PS2K-T460.dsl and recompile it.

 

On 5/22/2018 at 2:33 PM, verleihnix said:

Edit VoodooPS2Controller.kext/Contents/PlugIns/VoodooPS2Trackpad.kext/Contents/Info.plist

                <key>LENOVO</key>
                <dict>
                    <key>T420</key>
                    <string>Thinkpad_TrackPad</string>
                    <key>T460</key>
                    <string>Thinkpad_ClickPad</string>
                    <key>T560</key>
                    <string>Thinkpad_ClickPad</string>
                    <key>Thinkpad_ClickPad</key>
                    <dict>
                        <key>BogusDeltaThreshX</key>
                        <integer>800</integer>
                        <key>BogusDeltaThreshY</key>
                        <integer>800</integer>

Reinstall the kext to /L/E or to /EFI/Clover/kext folder

 

Hi tluck, verleihnix,

 

I'm also facing the same problems with trackpad. If I do quick swipes, the pointer doesn't move in proportion to the swipe but rather is very jerky (feels sticky). If I do slow swipes, then its ok.

I tried using the latest rehabman's version but exactly the same problems. I confirmed that Rehabman's version has all the corresponding T460 related changes (three buttons, clickpad etc.) so I'm continuing to use it but with your SSDT-PS2K-T460.

I'm using the latest v2018.10.12 release with T460 and the SSDT-PS2K-T460.aml has the BogusDeltaThreshX/Y=800. 

 

I resolved the jerky mouse pointer movement by

1. Commenting everything under "Synaptics TouchPad", Package() except "Thinkpad", ">y", in the SSDT-PS2K-T460.dsl, recompiling into .aml, replacing the previous one in EFI

2. Modify the Info.plist inside the kext by changing BogusDeltaThreshX/Y=800 (default values were 100)

3. Rebuilt kextcache

4. Mouse movement problem is gone, I can do quick swipes now

 

However, the scrolling with two fingers swipes is still jerky / sticky. Is there any documentation on the different attributes (like BogusDeltaThreshX/Y, ScrollResolution etc.) so that we can play with?

 

On a different note, why the kext did not account for the values in SSDT? Because the SSDT already had a Bogusxxx value of 800 and the mouse behavior was exactly the same in your latest voodoops2 kext as well as rehabman's version. The problem got only fixed by modifying the Info.plist inside the kext.

 

Secondly, is there a way unload / reload voodoops2controller kext or just the trackpad plugin inside it, so that I won't have to restart for testing different values?

I tried doing a "kextunload -b org.rehabman.voodoo.driver.PS2Trackpad" and my macos got reset. 

 

Thanks in advance for any help.

 

[yangjohn]

I using VoodooPS2Controller.kext from relase Lenovo-T460-Clover-2018.04.04 working fine with Mojave 10.14.2 .but any of rehubman's relase Voodoo version work well without use SSDT-PS2K-T460.dsl to make three buttons working.If use .dsl clickpad will lag with finger touch although three buttons are effecting.I tried many versions of SSDT-PS2K-T460.dsl but seems doesn't matter what contents inside all failed to improve this issue.My model is T460p with this problem when using rehubman's publish.Dose other three buttons user working fine?

Edited December 29, 2018 by yangjohn

[kolodzieski]

Just a simplification note on configuration of my T470 (i5-6500U). 

 

Latest WhateverGreen (1.2.5) + Rehabman's base SSDT-PNLF enable backlight injection fine. slider and brightness keys work fine. 

 

Directions:

 

remove AppleBacklightInjector.kext from /Library/Extensions, add new WhateverGreen.kext, rebuild cache. 

 

build SSDT-PNLF.dsl and add to ACPI/patched (remove SSDT-PNLF-T460)

 

Modify config.plist per:

 

Scotts-MacBook-Pro:DSDT.T470 sjk$ diff -wu config.plist /Volumes/ESP/EFI/CLOVER/config.plist
--- config.plist    2018-12-20 11:41:21.000000000 -0500
+++ /Volumes/ESP/EFI/CLOVER/config.plist    2018-12-27 10:12:54.000000000 -0500
@@ -176,7 +176,7 @@
       <key>Boot</key>
       <dict>
          <key>Arguments</key>
-         <string>kext-dev-mode=1</string>
+         <string>kext-dev-mode=1 igfxcflbklt=1</string>
          <key>DefaultVolume</key>
          <string>osX</string>
          <key>IgnoreNVRAMBoot</key>
@@ -243,6 +243,8 @@
                <data>
                   AAAAgA==
                </data>
+           <key>enable-cfl-backlight-fix</key>
+           <true/>
             </dict>
          </dict>
          <key>USB</key>

[Blaggah]

On 12/12/2018 at 2:53 AM, verleihnix said:

Do you have the USB Restartfix in place?

Whatever do you mean? Did I miss something? Please elaborate. I haven't been using my t460 because of this issue. 

[Blaggah]

On 5/1/2018 at 1:54 PM, tluck said:

@verleihnix - well everything should be there

- execpt 1 thing: i had forgotten about the USB Fix. that is not in the most recent pack. but I just added to SSDT-HACK-T460.dsl for the next push.

$ cat SSDT-HACK-T460.dsl 

DefinitionBlock ("", "SSDT", 2, "T460", "HACK", 0x00000000)
{
    External (\_SB.PCI0, DeviceObj)    // (from opcode)
    External (\_SB.PCI0.LPC, DeviceObj)    // (from opcode)
    External (\_SB.PCI0.XHC.PMEE, FieldUnitObj)
    External (\_SI._SST, MethodObj)    // 1 Arguments (from opcode)
    External (ZPTS, MethodObj)    // 1 Arguments (from opcode)
    External (ZWAK, MethodObj)    // 1 Arguments (from opcode)

    Method (_PTS, 1, NotSerialized)  // _PTS: Prepare To Sleep
    {
        If (0x05 == Arg0)
        {
// fix "auto start after shutdown"
            \_SB.PCI0.XHC.PMEE = 0
            Return (Zero)
        }

        ZPTS (Arg0)
    }

    Method (_WAK, 1, NotSerialized)  // _WAK: Wake
    {
        If ((Arg0 < One) || (Arg0 > 0x05))
        {
            Arg0 = 0x03
        }

        Local0 = ZWAK (Arg0)
        \_SI._SST (One)
        Return (Local0)
    }
}

 

Could it be why my T460 isn't shutting down properly? I'll check later to see if I have that ssdt and report back. If not, where do I find it?

[verleihnix]

2 hours ago, Blaggah said:

Could it be why my T460 isn't shutting down properly? I'll check later to see if I have that ssdt and report back. If not, where do I find it?

 

Yes, it could be. I had this as well.

It is included in the most recent pack.

Edited December 29, 2018 by verleihnix

[Blaggah]

On 11/22/2018 at 2:40 AM, verleihnix said:

Yes, you have to build your own AppleBacklightInjector.

The tool is located in Tluck's pack, Utilities/Create_AppleBacklightInjector_kext

Nice, i managed to do it.  Thanks.  How would i go about doing the same on my x1 carbon 4th generation?

 

I think i fixed my problem. I already had the latest pack for some odd reason, i think i was running the default dsdt which wasn't suited for my 1366x768 screen.  I reran the command to create my dsdt and all is well now.  Thanks for the feedback..

[Blaggah]

On 9/26/2016 at 12:17 PM, tluck said:

@azerty076 - just posted a reply on another site. but i will update the GUIDE with my latest files etc. 

 

So quickly what works:

1) ethernet - IntelMausi kext
2) WiFi/BT - with BCM4352Z NGFF M.2 (aka Dell DW1560) - BrcmPatchRAM2 modified for to slow down firmware for USB wake.
3) Audio - ALC293 AppleHDA.kext
4) PS2 - Clickpad/Trackpad + TrackPoint + all 3 buttons - VoodooPS2Controller modified - F key maps
5) USB - custom SSDT + USBInjectAll kext mods. so all external USB3/USB2 ports and internal ports - Camera, BT work.
6) sleep/wake
 

have not messed with SD Card.

What's the likelihood of you implementing my x1 Carbon 4th gen into your package?  I had to do a fresh install on my carbon today and I need to get my sound and the rest of the stuff sorted out.   What do I need to provide in order to achieve this?

[kolodzieski]

VoodooPS2Controller KP on sleep? 

 

Anyone have any ideas on this. With VoodooPS2Controller 1.8.3 system is perfect, sleep/wake no issues. 

 

Bumping the kext to 1.9.x causes a KP on sleep. Apparently in unloading the driver. 

 

Any ideas?

 

Mon Dec 31 11:47:06 2018

*** Panic Report ***
panic(cpu 0 caller 0xffffff80062da1ed): Kernel trap at 0xffffff7f86ce0663, type 13=general protection, registers:
CR0: 0x000000008001003b, CR2: 0x00007fffaf51a450, CR3: 0x00000003247b1112, CR4: 0x00000000003626e0
RAX: 0x3f001138c1bbbb60, RBX: 0xffffff8029ea3800, RCX: 0xffffff8006a9deb8, RDX: 0x0000000000000000
RSP: 0xffffff920f573a90, RBP: 0xffffff920f573aa0, RSI: 0x0000000009000000, RDI: 0xffffff802a153a80
R8:  0xffffff8006a9de50, R9:  0xffffff8006a9de80, R10: 0xffffff8006a9deb0, R11: 0x0000000000000001
R12: 0x0000000100000326, R13: 0xffffff80068292b0, R14: 0xffffff8029ee01e0, R15: 0x0000000100000323
RFL: 0x0000000000010282, RIP: 0xffffff7f86ce0663, CS:  0x0000000000000008, SS:  0x0000000000000010
Fault CR2: 0x00007fffaf51a450, Error code: 0x0000000000000000, Fault CPU: 0x0, PL: 0, VF: 0

Backtrace (CPU 0), Frame : Return Address
0xffffff8005f4c290 : 0xffffff80061aeafd
0xffffff8005f4c2e0 : 0xffffff80062e85a3
0xffffff8005f4c320 : 0xffffff80062d9fca
0xffffff8005f4c390 : 0xffffff800615bca0
0xffffff8005f4c3b0 : 0xffffff80061ae517
0xffffff8005f4c4d0 : 0xffffff80061ae363
0xffffff8005f4c540 : 0xffffff80062da1ed
0xffffff8005f4c6b0 : 0xffffff800615bca0
0xffffff8005f4c6d0 : 0xffffff7f86ce0663
0xffffff920f573aa0 : 0xffffff7f86cdc8bf
0xffffff920f573ad0 : 0xffffff80068293bd
0xffffff920f573b10 : 0xffffff800685546e
0xffffff920f573b50 : 0xffffff8006828479
0xffffff920f573bd0 : 0xffffff8006827577
Kernel_2018-12-31-114706_Scotts-MacBook-Pro.panic...skipping...
Anonymous UUID:       EC038489-3092-0406-30E4-8B3B5720E3DD

Mon Dec 31 11:47:06 2018

*** Panic Report ***
panic(cpu 0 caller 0xffffff80062da1ed): Kernel trap at 0xffffff7f86ce0663, type 13=general protection, registers:
CR0: 0x000000008001003b, CR2: 0x00007fffaf51a450, CR3: 0x00000003247b1112, CR4: 0x00000000003626e0
RAX: 0x3f001138c1bbbb60, RBX: 0xffffff8029ea3800, RCX: 0xffffff8006a9deb8, RDX: 0x0000000000000000
RSP: 0xffffff920f573a90, RBP: 0xffffff920f573aa0, RSI: 0x0000000009000000, RDI: 0xffffff802a153a80
R8:  0xffffff8006a9de50, R9:  0xffffff8006a9de80, R10: 0xffffff8006a9deb0, R11: 0x0000000000000001
R12: 0x0000000100000326, R13: 0xffffff80068292b0, R14: 0xffffff8029ee01e0, R15: 0x0000000100000323
RFL: 0x0000000000010282, RIP: 0xffffff7f86ce0663, CS:  0x0000000000000008, SS:  0x0000000000000010
Fault CR2: 0x00007fffaf51a450, Error code: 0x0000000000000000, Fault CPU: 0x0, PL: 0, VF: 0

Backtrace (CPU 0), Frame : Return Address
0xffffff8005f4c290 : 0xffffff80061aeafd
0xffffff8005f4c2e0 : 0xffffff80062e85a3
0xffffff8005f4c320 : 0xffffff80062d9fca
0xffffff8005f4c390 : 0xffffff800615bca0
0xffffff8005f4c3b0 : 0xffffff80061ae517
0xffffff8005f4c4d0 : 0xffffff80061ae363
0xffffff8005f4c540 : 0xffffff80062da1ed
0xffffff8005f4c6b0 : 0xffffff800615bca0
0xffffff8005f4c6d0 : 0xffffff7f86ce0663
0xffffff920f573aa0 : 0xffffff7f86cdc8bf
0xffffff920f573ad0 : 0xffffff80068293bd
0xffffff920f573b10 : 0xffffff800685546e
0xffffff920f573b50 : 0xffffff8006828479
0xffffff920f573bd0 : 0xffffff8006827577
0xffffff920f573c30 : 0xffffff800682b15d
:...skipping...
Anonymous UUID:       EC038489-3092-0406-30E4-8B3B5720E3DD

Mon Dec 31 11:47:06 2018

*** Panic Report ***
panic(cpu 0 caller 0xffffff80062da1ed): Kernel trap at 0xffffff7f86ce0663, type 13=general protection, registers:
CR0: 0x000000008001003b, CR2: 0x00007fffaf51a450, CR3: 0x00000003247b1112, CR4: 0x00000000003626e0
RAX: 0x3f001138c1bbbb60, RBX: 0xffffff8029ea3800, RCX: 0xffffff8006a9deb8, RDX: 0x0000000000000000
RSP: 0xffffff920f573a90, RBP: 0xffffff920f573aa0, RSI: 0x0000000009000000, RDI: 0xffffff802a153a80
R8:  0xffffff8006a9de50, R9:  0xffffff8006a9de80, R10: 0xffffff8006a9deb0, R11: 0x0000000000000001
R12: 0x0000000100000326, R13: 0xffffff80068292b0, R14: 0xffffff8029ee01e0, R15: 0x0000000100000323
RFL: 0x0000000000010282, RIP: 0xffffff7f86ce0663, CS:  0x0000000000000008, SS:  0x0000000000000010
Fault CR2: 0x00007fffaf51a450, Error code: 0x0000000000000000, Fault CPU: 0x0, PL: 0, VF: 0

Backtrace (CPU 0), Frame : Return Address
0xffffff8005f4c290 : 0xffffff80061aeafd
0xffffff8005f4c2e0 : 0xffffff80062e85a3
0xffffff8005f4c320 : 0xffffff80062d9fca
0xffffff8005f4c390 : 0xffffff800615bca0
0xffffff8005f4c3b0 : 0xffffff80061ae517
0xffffff8005f4c4d0 : 0xffffff80061ae363
0xffffff8005f4c540 : 0xffffff80062da1ed
0xffffff8005f4c6b0 : 0xffffff800615bca0
0xffffff8005f4c6d0 : 0xffffff7f86ce0663
0xffffff920f573aa0 : 0xffffff7f86cdc8bf
0xffffff920f573ad0 : 0xffffff80068293bd
0xffffff920f573b10 : 0xffffff800685546e
0xffffff920f573b50 : 0xffffff8006828479
0xffffff920f573bd0 : 0xffffff8006827577
0xffffff920f573c30 : 0xffffff800682b15d
0xffffff920f573cb0 : 0xffffff800684e351
0xffffff920f573ce0 : 0xffffff800684e545
0xffffff920f573d20 : 0xffffff800688fc24
0xffffff920f573d50 : 0xffffff8006291eb0
0xffffff920f573d80 : 0xffffff80061b42bd
0xffffff920f573dd0 : 0xffffff800618ebe5
0xffffff920f573e50 : 0xffffff80061a359e
0xffffff920f573ef0 : 0xffffff80062c170b
0xffffff920f573fa0 : 0xffffff800615c486
      Kernel Extensions in backtrace:
         org.rehabman.voodoo.driver.PS2Trackpad(1.9.2)[172C5C14-5D31-3BE0-A947-59A4F3938B90]@0xffffff7f86cd9000->0xffffff7f86ce4fff
            dependency: com.apple.iokit.IOHIDFamily(2.0.0)[2AEFB432-C333-3CFC-955E-24BBDDDE0F5E]@0xffffff7f86c22000
            dependency: com.apple.iokit.IOReportFamily(47)[75A625B5-0DEB-343A-A723-9D72533F098C]@0xffffff7f86cca000
            dependency: org.rehabman.voodoo.driver.PS2Controller(1.9.2)[E11711CB-AFEA-384E-97B8-B8EECB515995]@0xffffff7f86cb6000

BSD process name corresponding to current thread: kextunload
Boot args: kext-dev-mode=1

Mac OS version:
18C54

Kernel version:
Darwin Kernel Version 18.2.0: Mon Nov 12 20:24:46 PST 2018; root:xnu-4903.231.4~2/RELEASE_X86_64
Kernel UUID: 56B30885-F9BA-30E8-AD1C-5D59EC243BA9
Kernel slide:     0x0000000005e00000
Kernel text base: 0xffffff8006000000
__HIB  text base: 0xffffff8005f00000
System model name: MacBookPro13,1 (Mac-473D31EABEB93F9B)

System uptime in nanoseconds: 70719129145
last loaded kext at 30073858799: com.apple.driver.AppleBluetoothMultitouch      96 (addr 0xffffff7f8944a000, size 61440)
loaded kexts:
(none)

[Blaggah]

Hi, I read your post and also https://octoperf.com/blog/2018/10/22/thinkpad-t460-how-to-install-macos/.
I'm using T460s (i7 6600u/16g/512g SSD/HD 520).
In others case, their screenshot of clover home screen, the first option is "boot macos install from install macos xxxxxxx", but my case is "start ueft shell 64", seems that clover does not recognize my macos disk partition.
Then I try to use "start ueft shell 64", but it only shows black screen without any response.
I already config the correct BIOS CONFIG, MACOS USB INSTALLER.The picture below is my macos USB installer, the first partition is EFI, the second is macos.

So can you help me with this?
Thanks a lot.

You have to make sure apfs.efi or the other apfs driver is included inside your ego clover/drivers64 folder.


Sent from my iPhone using Tapatalk

[nijhawank]

Hi tluck,

 

I'm using your T460 pack for my T460. However I had to add the following in config.plist as the clover kextstopatch do not work in Mojave for framebuffer patching. Without this the macos panics at framebuffer initialization.

         <key>Properties</key>
         <dict>
            <key>PciRoot(0x0)/Pci(0x2,0x0)</key>
            <dict>
               <key>AAPL,ig-platform-id</key>     <data>AAAWGQ==</data>
               <key>device-id</key>               <data>FhkAAA==</data>
               <key>enable-hdmi20</key>           <data>AQAAAA==</data>
               <key>framebuffer-fbmem</key>       <data>AACQAA==</data>
               <key>framebuffer-patch-enable</key><data>AQAAAA==</data>
               <key>framebuffer-stolenmem</key>   <data>AAAwAQ==</data>
               <key>framebuffer-unifiedmem</key>  <data>AAAAgA==</data>
            </dict>
         </dict>

However, I notice that I do not have all the brightness levels before the sleep. After sleep cycle its fine.

I did create the backlightinjector per your guide but it doesn't work. Is it because I do not have the following kextstopatch per the new whatevergreen style? But I don't know the equivalent in whatevergreen config?

<dict>
	<key>Comment</key>
	<string>Framebuffer - brightness</string>
	<key>Disabled</key>
	<false/>
	<key>Find</key>
	<data>
	bAUAAGwFAAA=
	</data>
	<key>Name</key>
	<string>com.apple.driver.AppleIntelSKLGraphicsFramebuffer</string>
	<key>Replace</key>
	<data>
	6AMAAOgDAAA=
	</data>
</dict>

I also tried removingapplebacklightinjector and replaced with AppleBacklightFixup and replaced SSDT-PNLF-T460.aml with the one from Rehabman's AppleBacklightFixup package. But same results.

 

Recently, I have also tried using the latest WhateverGreen (that already has the Rehabman's AppleBacklightFixup code merged) but same results.

I am rebuilding kextcache between any changes.

 

What I am doing wrong?

[tluck]

@nijhawank 

 

yeah you should move towards Whatevergreen.kext - and the recent 1.2.5 version adds support for backlight and which may conflict with AppleBacklightInjector.kext. 

 

the kext patch above sets the max brightness from value 1388 (0x56C) to 1000 (0x3E8) - not sure why i did that?!

so

you can remove that patch.

change UID from 10 to 16 in SSDT-PNLF - there is the F16Txxxx profile in WEG.kext to do backlight.

remove the AppleBacklightInjector kext

 

Edited January 3, 2019 by tluck

[nijhawank]

16 minutes ago, tluck said:

@nijhawank 

 

yeah you should move towards Whatevergreen.kext - and the recent 1.2.5 version adds support for backlight and which may conflict with AppleBacklightInjector.kext. 

 

the kext patch above sets the max brightness from value 1388 (0x56C) to 1000 (0x3E8) - not sure why i did that?!

so

you can remove that patch.

change UID from 10 to 16 in SSDT-PNLF - there is the F16Txxxx profile in WEG.kext to do backlight.

remove the AppleBacklightInjector kext

 

 

Thanks @tluck for your very prompt reply. Yes, I have removed AppleBacklightInjector and now using the latest WhateverGreen.

I also had replaced the SSDT-PNLF-T460.aml from your pack to the precompiled one available from Rehabman's AppleBacklightFixup. I believe it is compiled from https://github.com/RehabMan/AppleBacklightFixup/blob/master/SSDT-PNLF.dsl that dynamically calculates _UID depending on PWMMax. An extract...

// _UID is set depending on PWMMax
// 14: Sandy/Ivy 0x710
// 15: Haswell/Broadwell 0xad9
// 16: Skylake/KabyLake 0x56c (and some Haswell, example 0xa2e0008)
// 17: custom LMAX=0x7a1
// 18: custom LMAX=0x1499
// 19: CoffeeLake 0xff7b
// 99: Other (requires custom AppleBacklightInjector.kext)

So shouldn't it already be deriving _UID to 16? What could be the reason that my PWMMax is not right, if that's the reason? Anyways I'll try changing _UID to 16 in your version of SSDT-PNLF-T460.dsc at https://github.com/tluck/Lenovo-T460-Clover/blob/master/DSDT.T460/SSDT-PNLF-T460.dsl and see if that makes any difference.

 

[nijhawank]

Nope that didn't work. This is the SSDT-PNLF I'm using with latest whatevergreen. Should I be saying 0x16?

 

DefinitionBlock ("", "SSDT", 2, "T460", "PNLF", 0)

{

    // For backlight control

    Device(_SB.PNLF)

    {

        Name(_ADR, Zero)

        Name(_HID, EisaId ("APP0002"))

        Name(_CID, "backlight")

        Name(_UID, 16) //changed from 10 to 16

        Name(_STA, 0x0B)

    }

}

[verleihnix]

1 hour ago, nijhawank said:

Nope that didn't work. This is the SSDT-PNLF I'm using with latest whatevergreen. Should I be saying 0x16?

 

If you edit SSDT-PNLF-T460.dsl you have to change it to 16 and with .aml you have to change it to 0x10.

Edited January 3, 2019 by verleihnix

[nijhawank]

So I made _UID to 16 in SSDT-PNLF-T460.dsl and recompiled but to no avail.

 

Do you think I'd need to adjust something in SSDT-IGPU-T460.dsl as Rehabman says you need to remove any backlight patches from DSDT/clover to use the new AppleBacklightFixup (assuming the new whatevergreen would have the same requirements)?

Edited January 3, 2019 by nijhawank

[verleihnix]

1 hour ago, nijhawank said:

So I made _UID to 16 in SSDT-PNLF-T460.dsl and recompiled but to no avail.

 

Do you think I'd need to adjust something in SSDT-IGPU-T460.dsl as Rehabman says you need to remove any backlight patches from DSDT/clover to use the new AppleBacklightFixup (assuming the new whatevergreen would have the same requirements)?

 

I have only WEG 1.2.5 and the new ID in SSDT-PNLF-T460.

Backlight adjust is working.

[xeu]

1 hour ago, nijhawank said:

So I made _UID to 16 in SSDT-PNLF-T460.dsl and recompiled but to no avail.

 

Do you think I'd need to adjust something in SSDT-IGPU-T460.dsl as Rehabman says you need to remove any backlight patches from DSDT/clover to use the new AppleBacklightFixup (assuming the new whatevergreen would have the same requirements)?

 

To get whatevergreen backlight working

 

clover config.plist

Boot / Arguments:  add    igfxcflbklt=1

Devices / Properties / PciRoot ; same place as framebuffer entries, within dict

<key>enable-cfl-backlight-fix</key>

<true/>

 

With those and a simple PLNF DSDT entry I got backlight buttons working but only after a sleep/wake cycle.

 

[nijhawank]

8 minutes ago, xeu said:

 

To get whatevergreen backlight working

 

clover config.plist

Boot / Arguments:  add    igfxcflbklt=1

Devices / Properties / PciRoot ; same place as framebuffer entries, within dict

<key>enable-cfl-backlight-fix</key>

<true/>

 

With those and a simple PLNF DSDT entry I got backlight buttons working but only after a sleep/wake cycle.

 

 

My backlight adjustment is working but not all brightness levels are present before the sleep (just between 70 - 100%). After the sleep cycle, all brightness levels are present.

 

From the WEG documentation...

• igfxcflbklt=1 boot argument (and enable-cfl-backlight-fix property) to enable CFL backlight patch
• applbkl=0 boot argument to disable AppleBacklight.kext patches for IGPU

Isn't the boot flag (igfxcflbklt and related property in config.plist) only for Coffylake? T460 is Skylake and I assume that applbkl=0 boot entry controls for everything other than coffylake and I assume that by default WEG applies the backlight patches and applblk=0 is only needed to disable backlight patches?

 

Is the understanding correct?

[tluck]

sorry. i just don't have a box to test and verify the configs anymore.

 

but yeah - there are about 18 patches in config.list related to SKL/Gfx and AppleHDA that are now obsolete since they are handled by the new AppleALC and Whatevergreen kexts.

moving from 10 to 16 for PNLF UID - is good to be consistent with RehabMan (and other's) tools. 

 

- or using generalized RehabMan's SSDT-PNLF.dsl/aml - may be the best thing...

 

the BackLight Injector function is now handled by WEG as are the memory patches etc.

 

@kolodzieski

 

try removing the kextunload/kextload lines from your /etc/rc.sleep and /etc/rc.wake scripts - or remove these as they may not be needed anymore.

should not need to unload VoodooPS for sleep!?

 

 

Edited January 3, 2019 by tluck

[kolodzieski]

1 hour ago, tluck said:

sorry. i just don't have a box to test and verify the configs anymore.

 

but yeah - there are about 18 patches in config.list related to SKL/Gfx and AppleHDA that are now obsolete since they are handled by the new AppleALC and Whatevergreen kexts.

moving from 10 to 16 for PNLF UID - is good to be consistent with RehabMan (and other's) tools. 

 

- or using generalized RehabMan's SSDT-PNLF.dsl/aml - may be the best thing...

 

the BackLight Injector function is now handled by WEG as are the memory patches etc.

 

@kolodzieski

 

try removing the kextunload/kextload lines from your /etc/rc.sleep and /etc/rc.wake scripts - or remove these as they may not be needed anymore.

should not need to unload VoodooPS for sleep!?

 

 

 

Thanks @tluck, that is the obvious solution. I commented out the unload/reload from the rs.cleep and rc.wake scripts, and can use the latest voodoo kext from rehabman. 

 

I am down to only using kext's from the authors (except your bcrm bluetooth kext's). The backlight from WEG works great for me. I will be pushing my latest config soon and will send you a pull request. 

 

My latest set of kext's are:

 

 

[kolodzieski]

I was able to simplify my kext set and config a bit more.  I am able to use the most up to date set of kext's from the original authors. Everything on my T470 works great. 

 

Here are my latest set of notes from my github project. 

 

Begin Simplification/Consolidation of KEXT's / Config

Bumped WhateverGreen to 1.2.6 -- Use built in Backlight Injector --

       remove AppleBacklightInjector.kext from /Library/Extensions

       build SSDT-PNLF.dsl (from rehabman repo) and add to ACPI/patched (remove SSDT-PNLF-T460)

       Modify config.plist per:

sjk$ diff -wu config.plist /Volumes/ESP/EFI/CLOVER/config.plist
--- config.plist    2018-12-20 11:41:21.000000000 -0500
@@ -176,7 +176,7 @@
       <key>Boot</key>
       <dict>
          <key>Arguments</key>
-         <string>kext-dev-mode=1</string>
+         <string>kext-dev-mode=1 bpr_probedelay=100 bpr_initialdelay=300 bpr_postresetdelay=300</string>
          <key>DefaultVolume</key>
          <string>osX</string>
          <key>IgnoreNVRAMBoot</key>
@@ -243,6 +243,8 @@
                <data>
                   AAAAgA==
                </data>
+           <key>enable-cfl-backlight-fix</key>
+           <true/>
             </dict>
          </dict>
          <key>USB</key>

 

 

I did need to edit my /etc/rc.wake and /etc/rc.sleep and comment out the unload/load of the voodoo trackpack drivers. Does not seem like that matters at all to functionality. Sleep/Wake works fine. 

 

NOTE the bpr_ boot flags that makes the bluetooth drivers correctly functions after
waking from sleep.

 

Consolidate and Updated kext's in /Library/Extensions:

All kext are from the kext's author, and not taken from TLUCK's repository.

 

Edited January 4, 2019 by kolodzieski
forgot line on rc.sleep/rc.wake

[nijhawank]

On 11/18/2017 at 8:20 PM, ka209 said:

no you need drivers. but is already in the kext folder in the EFI.

 

but I'll do it for you as an attachment

 

Do it in your kext folder and it's good

BrcmFirmwareRepo.kext.zip

AirportBrcmFixup.kext.zip

BrcmPatchRAM2.kext.zip

 

hi ka209, i see that you use dw1830 for your hackintosh and you said its working flawless. It's working perfectly for me as well except bluetooth. It works fine after a boot but after a sleep cycle bluetooth becomes unavailable. I have exactly the same issue as described in this thread https://www.tonymacx86.com/threads/dw1830-bluetooth-not-available-power-saving-issue.246350/ 

Unfortunately, the issue is unresolved in that thread. I have tried various bpr_probedelay/initial/postresetdelays options in the boot to no avail.