Jump to content

Clover Problems and Solutions

ErmaC

By ErmaC,
in Clover Development

 Share
3,206 posts in this topic

Recommended Posts

LockDown
LockDown
Posted
Posted

about the NvidiaWeb in SystemParameters

It appears to work only in Sierra.

For other systems use

 

<key>Boot</key>	<dict>		<key>Arguments</key>		<string>nvda_drv=1</string>
But I don't think it should be set statically in config.plist.

Let macOS set this argument by using pref panel.

wouldnt be nice if it can work with lower builds too?
Link to comment
Share on other sites
Sherlocks
Sherlocks
Posted
Posted

i research to fix korean font. i used metal theme's korean font file.

 

 

 

this screenshot is best in clover GUI

post-980913-0-10114300-1474808917_thumb.png

 

Original code

 

 

 

        //korean

        Shift = 18;
        c -= 0xAC00;
        c1 = c / 28;
        Jong = c % 28;
        Cho = c1 / 21;
        Joong = c1 % 21;
        Cho += 28 * 7;
        Joong += 28 * 8;
        Jong += 28 * 9;
      }
//        DBG("Cho=%d Joong=%d Jong=%d\n", Cho, Joong, Jong);
      if (Shift == 18) {
        egRawCompose(BufferPtr, FontPixelData + Cho * FontWidth + 4 + FontLineOffset,
                     GlobalConfig.CharWidth, FontHeight,
                     BufferLineOffset, FontLineOffset);
      } else {
        egRawCompose(BufferPtr + BufferLineOffset * 3, FontPixelData + Cho * FontWidth + 2,
                     GlobalConfig.CharWidth, FontHeight,
                     BufferLineOffset, FontLineOffset);
      }
      if (i == Cursor) {
        c = 99;
        egRawCompose(BufferPtr, FontPixelData + c * FontWidth + 2,
                     GlobalConfig.CharWidth, FontHeight,
                     BufferLineOffset, FontLineOffset);
      }
      if (Shift == 18) {
        egRawCompose(BufferPtr + 9, FontPixelData + Joong * FontWidth + 6, //9 , 4 are tunable
                     GlobalConfig.CharWidth - 8, FontHeight,
                     BufferLineOffset, FontLineOffset);
        egRawCompose(BufferPtr + BufferLineOffset * 9, FontPixelData + Jong * FontWidth + 5,
                     GlobalConfig.CharWidth, FontHeight - 10,
                     BufferLineOffset, FontLineOffset);
 
      }

 

 

 

Edit code

 

 

 

               //korean

                Shift = 18;
                c -= 0xAC00;
                c1 = c / 28;
                Jong = c % 28;
                Cho = c1 / 21;
                Joong = c1 % 21;
                Cho += 28 * 7;
                Joong += 28 * 8;
                Jong += 28 * 9;
            }
            //        DBG("Cho=%d Joong=%d Jong=%d\n", Cho, Joong, Jong);
            if (Shift == 18) {
                egRawCompose(BufferPtr, FontPixelData + Cho * FontWidth + 4 + FontLineOffset,
                             GlobalConfig.CharWidth, FontHeight,
                             BufferLineOffset, FontLineOffset);
            } else {
                egRawCompose(BufferPtr + BufferLineOffset * 3, FontPixelData + Cho * FontWidth + 2,
                             GlobalConfig.CharWidth, FontHeight,
                             BufferLineOffset, FontLineOffset);
            }
            if (i == Cursor) {
                c = 99;
                egRawCompose(BufferPtr, FontPixelData + c * FontWidth + 2,
                             GlobalConfig.CharWidth, FontHeight,
                             BufferLineOffset, FontLineOffset);
            }
            if (Shift == 18) {
                egRawCompose(BufferPtr + 9, FontPixelData + Joong * FontWidth + 6, //9 , 4 are tunable
                             GlobalConfig.CharWidth - 8, FontHeight,
                             BufferLineOffset, FontLineOffset);
                egRawCompose(BufferPtr + BufferLineOffset * 9, FontPixelData + Jong * FontWidth + 1,
                             GlobalConfig.CharWidth, FontHeight - 3,
                             BufferLineOffset, FontLineOffset);
                
            }

 

 

 

i tried to change other shift value but not good result.

 

also FontHeight - 3. -3 value is minimum, -2, -1, 0 are not effect font height.

 

here is screenshot.

post-980913-0-29946600-1474809968_thumb.png

 

red square show cutten words. this word have to show "저장합니다"

 

 

let's see this screenshot

 

post-980913-0-48077300-1474809346_thumb.png

 

first red circle letter is "위". but it's not shown like "위" in GUI.  if "위" seperated, ㅇ + ㅜ + ㅣ.  "위" is consist of 3 strokes.

 

Clover is not showing this letter exactly. 

 

korean language is more complex than others..

 

example

"우" is consist of ㅇ + ㅜ.  strokes is 2

 

"울" is consist of ㅇ + ㅜ + ㄹ. strokes is 3

 

"욹" is consist of ㅇ + ㅜ + ㄹ + ㄱ. strokes is 4.

 

korean letter almost consist of strokes maximum 4.

 

 

so need more height, more complex code to show korean font in GUI.

 

i don't have technic to solve this issue.

 

sorry my english

 

thanks in advance

  • Like 1
Link to comment
Share on other sites
Sherlocks
Sherlocks
Posted
Posted

I know that korean letters are more complex then others :wink_anim: and thanks that you find an improvement.

More improvement you can make if you will draw new korean font image.

Thanks.

 

I tried to fix red circle letter.

 

But no effect any value. I think need more code? Or something...

 

나의 LG-F410S 의 Tapatalk에서 보냄

Link to comment
Share on other sites
  • 3 weeks later...
PMheart
PMheart
Posted
Posted

Hi Slice,

It seems that something goes wrong in Clover r3816, cannot compile it now. I got the following error:

In file included from /Users/Vanilla/CloverGrowerPro/edk2/Clover/SMCHelper/SMCHelper.c:18:0:
/Users/Vanilla/CloverGrowerPro/edk2/Clover/Include/Protocol/AppleSMC.h:225:3: error: unknown type name 'SMC_ADDRESS'
   SMC_ADDRESS                   Address;             ///<
   ^
make: *** [/Users/Vanilla/CloverGrowerPro/edk2/Build/Clover/RELEASE_GCC49/X64/Clover/SMCHelper/SMCHelper/OUTPUT/SMCHelper.obj] Error 1


build.py...
 : error 7000: Failed to execute command
	make tbuild [/Users/Vanilla/CloverGrowerPro/edk2/Build/Clover/RELEASE_GCC49/X64/Clover/SMCHelper/SMCHelper]


build.py...
 : error 7000: Failed to execute command
	make tbuild [/Users/Vanilla/CloverGrowerPro/edk2/Build/Clover/RELEASE_GCC49/X64/Clover/DumpUefiCalls/DumpUefiCalls]


build.py...
 : error F002: Failed to build module
	/Users/Vanilla/CloverGrowerPro/edk2/Clover/SMCHelper/SMCHelper.inf [X64, GCC49, RELEASE]

- Failed -
Build end time: 08:15:48, Oct.16 2016
Build total time: 00:00:42

Cloverx64  ERROR!!


Ejecting RAM disk
"disk2" unmounted.
"disk2" ejected.

Any idea? Thanks.

 

PMheart

Link to comment
Share on other sites
mhaeuser
mhaeuser
Posted
Posted

Looks like r3816 added parts of the AppleSmcIo protocol header from CupertinoNet/ApplePkg (but not completely, hence why SMC_ADDRESS isn't defined).

lol, probably forgot IndustryStandard/AppleSmc.h

 

EDIT: Wth, why did you copy my header into tiamo's? o_O

Link to comment
Share on other sites
mhaeuser
mhaeuser
Posted
Posted

I managed to refactor DumpUefiCalls & SmcHelper to directly use the headers from ApplePkg: https://github.com/theracermaster/Clover/commit/a5932646088ad03e938285720fdd34b726f809b4

 

Cool, but tbh, I'm not sure if I might not change naming/dir structure in the future (hence branch: development)... I think I could push the current state into master and leave it there for a while?

Link to comment
Share on other sites
Slice
Slice
Posted
Posted

Hi Slice,

Clover r3832 compile fine if in FirmwareVolume.c at line 223 "EFI_STATUS Status;" is initialized.

Also this preinstall.zip ('Clover/CloverPackage/package/Scripts.templates/EFIFolder/preinstall') solve this bug:             #11413            

 

Cheers 

My file identical to your?!

Link to comment
Share on other sites
Slice
Slice
Posted
Posted

I will remind this topic is not for user questions and discussion.

Post here if you know what is wrong in sources.

 

I also don't need a report of compilation errors like this  #1249 . It will be corrected in next revision when I test by myself.

  • Like 1
Link to comment
Share on other sites
ErmaC
ErmaC
Posted
  • Author
Posted

 

  • Add ability to modify provided Devices->Audio LayoutID (clover.config) from Clover GUI subMenu 'Audio tuning->'
    - refit/menu.c

    - Platform/Platform.h

    - Platform/Settings.c

    --> GUILayoutID.zip

AudioTuning.png
Thx to Micky1979, Jolly and gengik84 for the test.
 

Cordially

ErmaC

  • Like 6
Link to comment
Share on other sites
Slice
Slice
Posted
Posted

@Slice Are you aware that your implementation of "AppleKeyState" is not going to work? It neither takes EFI_KEY, nor a unicode char...

It's a fish.

I am propose to test how it used and may be implement decoding.

Link to comment
Share on other sites
Slice
Slice
Posted
Posted

Errrr, it is known how it is used, check AppleHid.h and UsbKbDxe.

There are too many actions made for real mac. If we want to enter password in boot.efi then we need no most of these functions.

Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...