Jump to content

Clover Problems and Solutions

ErmaC

By ErmaC,
in Clover Development

 Share
3,206 posts in this topic

Recommended Posts

Zenith432
Zenith432
Posted
Posted
2 hours ago, Slice said:

And now even the checkout fails. 


 U   Clover/code
Checked out revision 5069.
svn: E125002: 'cloverefiboot-code' does not appear to be a URL

sf.net is dead. We have to move to github.

well, I successfully comitted 5070, so the problem is local.

This error message seems to be a syntax error.  the command to checkout is

svn checkout svn://svn.code.sf.net/p/cloverefiboot/code/ cloverefiboot-code

So it appears that the URL on the command line is missing...

Link to comment
Share on other sites
Slice
Slice
Posted
Posted
34 minutes ago, vector sigma said:

@Slice I can't find the XCODE8 toolchain anywhere in the repositories at github, is that intended or some patches arent applied?

I committed new files just now. Take them and try again.

 

21 hours ago, Slice said:

This command worked

nasm -Ox -f win64 -o d:\projects\clover\Build\Clover\RELEASE_VS2015x86\X64\MdePkg\Library\BaseLib\BaseLib\OUTPUT\X64\LongJump.obj d:\projects\clover\Build\Clover\RELEASE_VS2015x86\X64\MdePkg\Library\BaseLib\BaseLib\OUTPUT\X64\LongJump.iii

if I place Nasm.inc into Clover root folder.

There is a claim that include must be from build folder.

It appears that Nasm.inc must be in MdePkg/Library/BaseLib/X64/Nasm.inc. May be it is windows cbuild bug, may be windows nasm bug.

GenFds in Windows is not working.

Link to comment
Share on other sites
Zenith432
Zenith432
Posted
Posted

The makefile rule for nasm sources is generted from build_rule.txt 

        "$(NASM)" -I${s_path}(+) $(NASM_INC) $(NASM_FLAGS) -o $dst ${d_path}(+)${s_base}.iii

and I see this line in cbuild.bat 

  set NASM_INC=

which is not found in ebuild.sh.  Could have something to do with it.

You can look in the Build product folder (Build\Clover\RELEASE_VS2015x86\X64\MdePkg\Library\BaseLib\BaseLib) and compare the makefile generated for macOS (GNUmakefile) to the makefile generated for Windows see if produces a different rule.

Link to comment
Share on other sites
vector sigma
vector sigma
Posted
Posted (edited)
1 hour ago, Slice said:

I will recommend to use 


$ git config --global core.autocrlf false

manual line ending? bad idea in mac OS

 

Anyway can you check my status as I cannot commit? 

MacBook-Pro-di-Francy:Clover vectorsigma$ git push
Username for 'https://github.com': vectorsigma72
Password for 'https://vectorsigma72@github.com': 
remote: Permission to CloverHackyColor/CloverBootloader.git denied to vectorsigma72.
fatal: unable to access 'https://github.com/CloverHackyColor/CloverBootloader.git/': The requested URL returned error: 403
MacBook-Pro-di-Francy:Clover vectorsigma$

EDIT

may be https is read only..

Edited by vector sigma
Link to comment
Share on other sites
Slice
Slice
Posted
Posted

Yes, there was read-only by default. Now I give write permisions to all members.

Strange logic, non-member also has read permision.

3 minutes ago, Download-Fritz said:

edk2 stock builds with NASM on all OSes and with XCODE5 for any Xcode ver fine without any file copying or changes. If you have issues, most likely your patches are borked

I know that Nasm.inc has no problem in MacOS. I have the issue in Windows and I don't understand it.

Link to comment
Share on other sites
mhaeuser
mhaeuser
Posted
Posted
3 minutes ago, Slice said:

I know that Nasm.inc has no problem in MacOS. I have the issue in Windows and I don't understand it.

As I said, any OS, I build with Windows' VS2019 (VS2017 toolchain) almost daily. As I suggested before, make sure your Conf files (tools and rules) are up-to-date, because one of them has the include path

  • Like 1
Link to comment
Share on other sites
Slice
Slice
Posted
Posted
1 hour ago, vector sigma said:

manual line ending? bad idea in mac OS

 

Anyway can you check my status as I cannot commit? 


MacBook-Pro-di-Francy:Clover vectorsigma$ git push
Username for 'https://github.com': vectorsigma72
Password for 'https://vectorsigma72@github.com': 
remote: Permission to CloverHackyColor/CloverBootloader.git denied to vectorsigma72.
fatal: unable to access 'https://github.com/CloverHackyColor/CloverBootloader.git/': The requested URL returned error: 403
MacBook-Pro-di-Francy:Clover vectorsigma$

EDIT

may be https is read only..

Check commit again, now it should work.

line ending for Clover sources is LF while for EDK2 sources is CRLF and git cryes about this. I just calm down it.

For macOS it is not needed.

3 minutes ago, Download-Fritz said:

As I said, any OS, I build with Windows' VS2019 (VS2017 toolchain) almost daily. As I suggested before, make sure your Conf files (tools and rules) are up-to-date, because one of them has the include path

Can you show me one example of NASM_INC macro definition? I tested several version without success.

  • Like 1
Link to comment
Share on other sites
vector sigma
vector sigma
Posted
Posted
1 minute ago, Slice said:

Check commit again, now it should work.

line ending for Clover sources is LF while for EDK2 sources is CRLF and git cryes about this. I just calm down it.

For macOS it is not needed.

Worked now thanks. Clover is compilable but I have to solve (soon) a problem compiling the pkg.

To all, buildme, inside Clover on github is updated.

Link to comment
Share on other sites
Zenith432
Zenith432
Posted
Posted (edited)
1 hour ago, Slice said:

There is a question how we will maintain Clover revision? I can propose to write it in vers.txt manually.

You can get the 7-character short hash for a git object with

git describe --always <commit>

or

git describe --always  (acts on HEAD by default)

 

I suggest you tag each release that you publish binaries for, maybe use date as part of the tag to make it unique.  Then

git describe --tags

gives you the tag name attached to the 7-character hash which you can use to identify the published file.

 

Do man git-describe for other options.

 

Another issue:

The files

Conf/.cache

Conf/BuildEnv.sh

Conf/target.txt

 

should not be committed to the respository because they have local paths and build options and are generated by various tools.  In edk2 these files are not committed, they're .gitignore-d.

Edited by Zenith432
Link to comment
Share on other sites
mhaeuser
mhaeuser
Posted
Posted
1 hour ago, Slice said:

Can you show me one example of NASM_INC macro definition? I tested several version without success.

You do not define it, it is handled by GenMake, paths coming from .dec (iirc). If your Conf files are not the problem, just rebuild BaseTools. Or even better, remove the BaseTools folder, check it out again, build, and use fresh Conf files.

Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...