Jump to content

Clover Problems and Solutions

ErmaC

By ErmaC,
in Clover Development

 Share
3,206 posts in this topic

Recommended Posts

tluck
tluck
Posted
Posted

well for my theme, it was a matter of converting from the Apple Icon format to PNG format. i thought it would be easy to script on the command but ImageMagic doesnt seem to recognize the Apple Icon format. :(

 

So used Preview. open the .icns file (that shows a "data" file) then saved this as as .png file. then renamed all the .png files back .icns.  tedious. anyway. it gave me chance to clean out the icons folder and give a new banner look. 

 

it would be great to get this revised updated theme ThinkPad copied over from the theme repo to the Clover repo.

Link to comment
Share on other sites
tluck
tluck
Posted
Posted

good idea. i have updated and crushed my PNG 8-bit files (used pngcrush) and pushed to the theme repo. if you get chance please replace the thinkpad theme in the clover repo. thanks

 

Note: to rename all .png files to .icns files in a directory:

 

for f in *.png; do mv "$f" "${f%%.*}.icns"; done

  • Like 1
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted

Hello,

 

Sorry for my poor english, I'm french.

 

Since r3696 and with r3706, I have some issues with the theme that I created. Some PNG files are not loaded in GUI: background, function icons and font.

 

With r3694, all is OK

 

Please help me

Link to comment
Share on other sites
Slice
Slice
Posted
Posted

@Slice

 

With optimized theme: windows partition (4) on separeted Hard disk are seen as mac partition. No background.

More information to analyze?

rev 3694 and 3696 have no differences for this issue.

Link to comment
Share on other sites
Micky1979
Micky1979
Posted
Posted

Hi Slice I think that in menu.c miss the "#ifdef CHECK_FLAG" when you call "EncodeOptions()". rev 3709

    if (!GlobalConfig.FastBoot) {
      CHAR16 *TmpArgs = NULL;
      if (gThemeNeedInit) {
        InitTheme(TRUE, &Now);
        gThemeNeedInit = FALSE;
      } else if (gThemeChanged) {
//        DBG("change theme\n");
        InitTheme(FALSE, NULL);
        FreeMenu(&OptionMenu);
      }
      gThemeChanged = FALSE;
      DBG("Choosing theme %s\n", GlobalConfig.Theme);

      //now it is a time to set RtVariables
      SetVariablesFromNvram();
#ifdef CHECK_FLAGS
      TmpArgs = PoolPrint(L"%a", gSettings.BootArgs);
      gSettings.OptionsBits = EncodeOptions(TmpArgs);
#endif
      FillInputs(TRUE);
      if (TmpArgs) {
        FreePool(TmpArgs);
      }
      // scan for loaders and tools, add then to the menu
      if (GlobalConfig.LegacyFirst){
        AddCustomLegacy();
        if (!GlobalConfig.NoLegacy) {
          ScanLegacy();
        }
      }
    } 

Also initialiazed 'TmpArgs' to NULL.

..and please take a look here:            #50            

Link to comment
Share on other sites
Slice
Slice
Posted
Posted

Hi Slice I think that in menu.c miss the "#ifdef CHECK_FLAG" when you call "EncodeOptions()". rev 3709

    if (!GlobalConfig.FastBoot) {
      CHAR16 *TmpArgs = NULL;
      if (gThemeNeedInit) {
        InitTheme(TRUE, &Now);
        gThemeNeedInit = FALSE;
      } else if (gThemeChanged) {
//        DBG("change theme\n");
        InitTheme(FALSE, NULL);
        FreeMenu(&OptionMenu);
      }
      gThemeChanged = FALSE;
      DBG("Choosing theme %s\n", GlobalConfig.Theme);

      //now it is a time to set RtVariables
      SetVariablesFromNvram();
#ifdef CHECK_FLAGS
      TmpArgs = PoolPrint(L"%a", gSettings.BootArgs);
      gSettings.OptionsBits = EncodeOptions(TmpArgs);
#endif
      FillInputs(TRUE);
      if (TmpArgs) {
        FreePool(TmpArgs);
      }
      // scan for loaders and tools, add then to the menu
      if (GlobalConfig.LegacyFirst){
        AddCustomLegacy();
        if (!GlobalConfig.NoLegacy) {
          ScanLegacy();
        }
      }
    } 

Also initialiazed 'TmpArgs' to NULL.

..and please take a look here:            #50            

Accepted.

  • Like 1
Link to comment
Share on other sites
Sherlocks
Sherlocks
Posted
Posted

here is clover log

 

okay, find it now

 

if i use ko language in GUI, language is broken like screen above, its happen latest clover.

 

r3696 is no problem about this issue.

 

i change en now. i can get language correctly. but font size big and have space alpabat. not properly not shown like before.

 

post-980913-0-41199000-1471674283_thumb.png

 

post-980913-0-77374300-1471674286_thumb.png

 

also system get GUI more slower than r3696 in latest clover. 

 

 

thank you

Link to comment
Share on other sites
cecekpawon
cecekpawon
Posted
Posted (edited)

Slice: Errors mentioned by Sherlocks (randomly bad icons drawing, especially embedded theme) will appear if we compile Clover other than GCC. Updated my lodepng from developer (previously from coderush) with some fix about memory allocation, please compare / tweak more to synced with edk2. You can rollback to picopng with less trouble but loosing png encoding support for screenshot. Bin attached to test.

 

** remove attachment

Edited by cecekpawon
Link to comment
Share on other sites
Slice
Slice
Posted
Posted

Slice: Errors mentioned by Sherlocks (randomly bad icons drawing, especially embedded theme) will never appear if we compile Clover other than GCC. Updated my lodepng from developer (previously from coderush) with some fix about memory allocation, please compare / tweak more to synced with edk2. You can rollback to picopng with less trouble but loosing png encoding support for screenshot. Bin attached to test.

I compile Clover by clang so "will never appear if we compile Clover other than GCC".

I can no more accept changes that change good working codes by 90%. 

At the 3rd line is not Without Injected Kexts? normally!

 

 

If ☑︎then "with injected kexts"

else if ☐ then "without injected kexts"

Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...