vector sigma Posted June 7, 2019 Share Posted June 7, 2019 3 minutes ago, Sherlocks said: thanks. can you cleanup platformdata for future with maintenance? for example https://sourceforge.net/p/cloverefiboot/code/HEAD/tree/rEFIt_UEFI/Platform/platformdata.c#l223 { 0x02, 0x45, 0x0f, 0, 0, 0x00 }, "2018mbp", "j680", 0xf0a009 }, // there are no BIOS REV rBR EPCI to NULL, NULL, "j680", NULL }, if has smc3, don't add it blow https://sourceforge.net/p/cloverefiboot/code/HEAD/tree/rEFIt_UEFI/Platform/DataHubCpu.c#l458 https://sourceforge.net/p/cloverefiboot/code/HEAD/tree/rEFIt_UEFI/Platform/DataHubCpu.c#l467 Do you mean in Clover or somewhere in the IO registry? Link to comment Share on other sites More sharing options...
Sherlocks Posted June 7, 2019 Share Posted June 7, 2019 Do you mean in Clover or somewhere in the IO registry?probably both or not.mbp15,1 and 15,2 and etc of smc3 model in clover have dummy key now(rev, epci, pbr).we need to cleaup these values.if there is no key, dont add or override this key(anyway you already done but seems now clover always attempt to override key)나의 SM-N960N 의 Tapatalk에서 보냄 Link to comment Share on other sites More sharing options...
vector sigma Posted June 7, 2019 Share Posted June 7, 2019 @Sherlocks do you need to clear the nvram? Link to comment Share on other sites More sharing options...
Sherlocks Posted June 7, 2019 Share Posted June 7, 2019 [mention=980913]Sherlocks[/mention] do you need to clear the nvram?clover now support to clear nvram if press f11 in gui.i just mentioned platformdata.c and datahubcpu.c나의 SM-N960N 의 Tapatalk에서 보냄 Link to comment Share on other sites More sharing options...
vector sigma Posted June 7, 2019 Share Posted June 7, 2019 (edited) 11 minutes ago, Sherlocks said: i just mentioned platformdata.c and datahubcpu.c May be I don't understand. Do you need a code to know when Clover should not inject these keys? Because I have questions as well: Will older OSes run without these keys in involved models? If yes, why just don't remove them completely? If not, what's the problem? No OS version when DataHub runs? ? Edited June 7, 2019 by vector sigma 1 Link to comment Share on other sites More sharing options...
Sherlocks Posted June 7, 2019 Share Posted June 7, 2019 May be I don't understand. Do you need a code to know when Clover should not inject these keys? Because I have questions as well: Will older OSes run without these keys? If yes, why just don't remove them completely? If not, what's the problem? No OS version when DataHub runs? ?ofc old models(except smc3 models) need rev and pbr and epci.we just consider smc3 models.look herehttps://sourceforge.net/p/cloverefiboot/code/HEAD/tree/rEFIt_UEFI/Platform/platformdata.c#l279macbookair8,1 of clover platformdata has dummy rev from other old macbookair model. no need it on macbookair8,1.we change dummy key to NULL or Blank or etc that you want to cleanup source and data.then, rev has NULL and or Blank or etc, no need add or override rev values in Datahubcpu.c. in this cases, only smc3.나의 SM-N960N 의 Tapatalk에서 보냄 Link to comment Share on other sites More sharing options...
vector sigma Posted June 7, 2019 Share Posted June 7, 2019 (edited) 29 minutes ago, Sherlocks said: macbookair8,1 of clover platformdata has dummy rev from other old macbookair model. no need it on macbookair8,1. Real sorry, don't think I'm completely stupid , but, unless you are unable to reach the repository for unknown reasons to me, and just put nr 5 NULL in platformdata.c ...... are you asking me to change them and do a commit? ... I need to checkout Clover as I don't have it right now.... Edited June 7, 2019 by vector sigma 1 Link to comment Share on other sites More sharing options...
Sherlocks Posted June 7, 2019 Share Posted June 7, 2019 Real sorry, don't think I'm completely stupid , but, unless you are unable to reach the repository for unknown reasons to me, and just put nr 5 NULL in platformdata.c ...... are you asking me to change them and do a commit? ... I need to checkout Clover as I don't have it right now.... okay. i just asked you who completed smc3 patch in FakeSMC to cleanup source.나의 SM-N960N 의 Tapatalk에서 보냄 Link to comment Share on other sites More sharing options...
vector sigma Posted June 7, 2019 Share Posted June 7, 2019 1 hour ago, Sherlocks said: okay. i just asked you who completed smc3 patch in FakeSMC to cleanup source. Ok, I'll do that tomorrow! 1 Link to comment Share on other sites More sharing options...
Sherlocks Posted June 7, 2019 Share Posted June 7, 2019 Ok, I'll do that tomorrow!thanks vector. have a great day나의 SM-N960N 의 Tapatalk에서 보냄 1 Link to comment Share on other sites More sharing options...
vector sigma Posted June 7, 2019 Share Posted June 7, 2019 Just now, Sherlocks said: thanks vector. have a great day Good night (at least here... 00:50) Link to comment Share on other sites More sharing options...
Slice Posted June 8, 2019 Author Share Posted June 8, 2019 10 hours ago, vector sigma said: May be I don't understand. Do you need a code to know when Clover should not inject these keys? Because I have questions as well: Will older OSes run without these keys in involved models? If yes, why just don't remove them completely? If not, what's the problem? No OS version when DataHub runs? ? 1.2. Older OS with older models need these keys. 3. No problem at all. Cosmetic changes. 4 Link to comment Share on other sites More sharing options...
vector sigma Posted June 8, 2019 Share Posted June 8, 2019 FakeSMC and Clover updated. @Slice can you post a new package and a new dmg at sf? 1 Link to comment Share on other sites More sharing options...
Slice Posted June 8, 2019 Author Share Posted June 8, 2019 After weekend. 1 Link to comment Share on other sites More sharing options...
jinbingmao Posted June 8, 2019 Share Posted June 8, 2019 Link to comment Share on other sites More sharing options...
jinbingmao Posted June 8, 2019 Share Posted June 8, 2019 This is a very successful and great progress. Expect to be packaged and released! Thank Sigma for resolving the key problem skillfully and eliminating errors at the same time! 1 Link to comment Share on other sites More sharing options...
jinbingmao Posted June 9, 2019 Share Posted June 9, 2019 "target speed"= "目标速度" Link to comment Share on other sites More sharing options...
Slice Posted June 10, 2019 Author Share Posted June 10, 2019 On 6/8/2019 at 2:31 PM, vector sigma said: FakeSMC and Clover updated. @Slice can you post a new package and a new dmg at sf? Done! 2 Link to comment Share on other sites More sharing options...
vector sigma Posted June 10, 2019 Share Posted June 10, 2019 14 hours ago, jinbingmao said: "target speed"= "目标速度" Sorry, next time, yesterday my son wanted me with him almost all the day . 7 hours ago, Slice said: Done! Thanks! 1 Link to comment Share on other sites More sharing options...
jinbingmao Posted June 16, 2019 Share Posted June 16, 2019 (edited) On 2019/6/10 at PM7点10分, vector sigma said: 对不起，下一次，昨天我的儿子几乎整天都想和 他在一起。 谢谢！ Loss of key after awakening。 The computer restarted and returned to normal。 Edited June 17, 2019 by jinbingmao Link to comment Share on other sites More sharing options...
Slice Posted June 17, 2019 Author Share Posted June 17, 2019 Where is Ambient thermometer located? Link to comment Share on other sites More sharing options...
jinbingmao Posted June 17, 2019 Share Posted June 17, 2019 ITEIT87x.kext Link to comment Share on other sites More sharing options...
jinbingmao Posted June 17, 2019 Share Posted June 17, 2019 14 minutes ago, Slice said: Where is Ambient thermometer located? Link to comment Share on other sites More sharing options...
Slice Posted June 17, 2019 Author Share Posted June 17, 2019 Suppose you have this controller with an input pin where you expected to see an ambient temperature value. To do this you have to be sure there is an thermodiod which actually measures the temperature of environment and is connected to this input pin. I am not sure if the thermodiod exists. 1 Link to comment Share on other sites More sharing options...
jinbingmao Posted June 17, 2019 Share Posted June 17, 2019 (edited) 40 minutes ago, Slice said: Suppose you have this controller with an input pin where you expected to see an ambient temperature value. To do this you have to be sure there is an thermodiod which actually measures the temperature of environment and is connected to this input pin. I am not sure if the thermodiod exists. Existence before sleep, loss after awakening. There were no problems in earlier versions. Edited June 17, 2019 by jinbingmao Link to comment Share on other sites More sharing options...
Recommended Posts