Clover Themes

[Badruzeus]

1 hour ago, blackosx said:

Did you try reducing TileXSpace?

Well, seems I missed last explations from your prev. post. OK, it now looks better with TileSpaceX=0 or not using it at all, under theme's Layout (for themes with bigger than 128px for MainEntries)

 

#EDIT: I meant using your r4824 DEBUG 2.

Edited December 28, 2018 by Badruzeus

[blackosx]

Great. In that case we have a working solution which if used, would mean changing 75 x themes which use TileXSpace:

 

Aero, Aero256, alienware, Apocalypse, Beauty, BeautyDark, BeautyDark256, BeautyX, BGM256, blur, Buttons, Buttons256, Carbon, Chamelia, Circla, Circla256, Classic Mac OS, Classical, ClassicalDark, Clovernity, Crystal, DarkBoot, DarkBoot256, DarkBootX, Emerald, FlatCamp, Glassy, Glassy256, Gothic, Greenify, Greenify256, Hex256, HexaCore, HexaCore256, Hexagon, HexagonDark, HexagonDark256, HighSierra, InsanelyLook, Leather, Lightness, Lightness256, Luxury, Luxury2.0, Luxury256, mac, mac_s, Material, Material256, MaterialBox, MaterialDark, mimi black, Mojave4k, Neon, Neon256, Nightwish, Nightwish256, Oceanix, One, OSS, Outlines, Outlines256, QB, QBDark256, Ransom, Retina, Retina256, Retina4k, SilverLight, Smooth, SmoothDark256, Sphere, Sphere256, WorldCup, Xmas

 

Which would mean dealing with Theme git repo. That brings me on to your post in the CloverThemeManager thread regarding BFG Repo-Cleaner, (I did see it just not yet responded). Looks great and maybe worth a try. I saw apianti's post also about maybe clearing all themes from the repo and rebuilding it from server side? Either way it's worth a try, though I just don't want to find it f**ks it completely! 

 

12 hours ago, Sherlocks said:

chrismas theme is no problem now.
but need to update newyear theme.

나의 LG-F800S 의 Tapatalk에서 보냄
 

Okay. I'm on it. I'll see if I can create new icons for Slice's theme.

 

EDIT: Done.

 

Edited December 28, 2018 by blackosx

[apianti]

Unfortunately, the files are checked out on the server to be made publicly accessible through HTTP. There is no other way to clean the entire checked out repository except directly from the server since you are not actually trying to remove themes from existence in the repository (as that is what that tool does). Regardless, changing all those themes at once will still almost definitely timeout because of the server side checkout, and you will still end up having to commit the changes in small batches of themes.... The thing is you could easily use a find/replace to change the theme.plist's themselves, it's the pushing that will be the issue as it will checkout the themes on the server and most likely timeout.

[blackosx]

Thanks for your knowledge here apianti. Useful info on cleaner as I hadn't looked in to it yet. I'm happy to change all the themes locally here, as you say, using a find/replace, it was just the matter of pushing them to the repo. I'll probably just do it in stages.

 

When I get some time, I'll test my changes again and commit to Clover repo once happy. Then work on updating the themes. For ref, the changes I've made are:

 

menu.c line #4050

      //EntriesWidth = GlobalConfig.MainEntriesSize + (16 * row0TileSize) / 144;
      EntriesWidth = row0TileSize;

menu.c line #4056

      //row0PosX = (UGAWidth + (GlobalConfig.TypeSVG ? EntriesGap : 8) - (EntriesWidth + EntriesGap)
      //            * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;

      row0PosX = row0TileSize + EntriesGap;
      row0PosX = row0PosX * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count);
      row0PosX = row0PosX - EntriesGap;
      row0PosX = UGAWidth - row0PosX;
      row0PosX = row0PosX >> 1;

I'm sure the above can be simplified in to one line.

 

 

Edited December 28, 2018 by blackosx

[blackosx]

[mention=826765]Badruzeus[/mention]

Do you have any objections to me changing all the above themes' TileXSpace entries to zero and updating the theme repo?

 

EDIT:

All done. I went ahead and made all changes. Hope all is okay, though I’m sure some themes may need adjusting still.

 

Edited December 28, 2018 by blackosx

[Badruzeus]

10 hours ago, blackosx said:

[mention=826765]Badruzeus[/mention]

Do you have any objections to me changing all the above themes' TileXSpace entries to zero and updating the theme repo?

 

EDIT:

All done. I went ahead and made all changes. Hope all is okay, though I’m sure some themes may need adjusting still.

 

Sure, updates are ready to be pushed. Just about enough time doing it.

 

(Really sorry for too late reply, gotta outdoor job that forced me to not touching my pc at home).

[Bernardo415]

On 12/24/2018 at 12:20 PM, Ingwar77 said:

r4822 looks good

 

despite the unexpected loss of the night theme in Clovy 8 PM (GMT+3)

 

good, I'm looking for this theme, which is not in the repository, I wrote to the creator but still does not answer. Thank you

Edited December 29, 2018 by Bernardo415

[blackosx]

Hi Bernardo415

 

You will find Ingwar77's themes at the bottom of his post (see here).

 

I didn't add them to the Theme repo as I didn't think they were final themes, instead ideas?

Quote

 

Icons, Color and ...

Disks (I don't know how to fix it). So feel free to use my idea

 

 

The icons theme, for example, looks great but is missing many macOS icons.

[kylon]

no banner on clover 4727+

 

this my plist, it is a modified yosemitelogin

theme.plist

[Matgen84]

1 hour ago, kylon said:

no banner on clover 4727+

 

this my plist, it is a modified yosemitelogin

theme.plist

 

There is some explanations in Clover wiki theme: 

Banner

The banner is a centred image with limited dimensions depending on the monitor size. For instance, theme dawn has a banner with a dimension of 672x190px, which should be considered as a limit. If you do not use a background drawing, the banner should be opaque and its first pixel will determine the background colour. Otherwise you may use a trick and set transparency of the first pixel to 1%.

<key>Banner</key>
<string>logo-trans.png</string>
UPDATE: Since rev2524 (and with better placement with rev2534) the Banner can now optionally use new positional settings as used for the animations.

<key>Banner</key>
<array>
    <dict>
        <key>Path</key>
        <string>logo_trans.png</string>
        <key>ScreenEdgeX</key>
        <string>left</string>
        <key>DistanceFromScreenEdgeX%</key>
        <integer>nn</integer>
        <key>ScreenEdgeY</key>
        <string>top</string>
        <key>DistanceFromScreenEdgeY%</key>
        <integer>nn</integer>
        <key>NudgeX</key>
        <integer>nn</integer>
        <key>NudgeY</key>
        <integer>nn</integer>
    </dict>
</array>
See the Anime section for an explanation of these settings.

 

[Badruzeus]

19 hours ago, blackosx said:

EDIT:

All done. I went ahead and made all changes. Hope all is okay, though I’m sure some themes may need adjusting still.

 

Hmmb, I just got your EDIT'ed post. #OMG, can't believe that you did it for me after I opened Clover Activities on SF, so.. many thanks for your help. Well, I could cancel my changes #LoL ..

[apianti]

On 12/28/2018 at 6:44 AM, blackosx said:

Thanks for your knowledge here apianti. Useful info on cleaner as I hadn't looked in to it yet. I'm happy to change all the themes locally here, as you say, using a find/replace, it was just the matter of pushing them to the repo. I'll probably just do it in stages.

 

When I get some time, I'll test my changes again and commit to Clover repo once happy. Then work on updating the themes. For ref, the changes I've made are:

 

menu.c line #4050

      //EntriesWidth = GlobalConfig.MainEntriesSize + (16 * row0TileSize) / 144;
      EntriesWidth = row0TileSize;

menu.c line #4056

      //row0PosX = (UGAWidth + (GlobalConfig.TypeSVG ? EntriesGap : 8) - (EntriesWidth + EntriesGap)
      //            * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;

      row0PosX = row0TileSize + EntriesGap;
      row0PosX = row0PosX * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count);
      row0PosX = row0PosX - EntriesGap;
      row0PosX = UGAWidth - row0PosX;
      row0PosX = row0PosX >> 1;

I'm sure the above can be simplified in to one line.

 

 

 

No need to simplify into one line but you can simplify it using better operators:

      row0PosX = row0TileSize + EntriesGap;
      row0PosX *= ((MaxItemOnScreen < row0Count) ? MaxItemOnScreen : row0Count);
      row0PosX -= EntriesGap;
      row0PosX = UGAWidth - row0PosX;
      row0PosX >>= 1;

EDIT: I guess you could simplify it into one line:

      row0PosX = (UGAWidth - (((row0TileSize + EntriesGap) * ((MaxItemOnScreen < row0Count) ? MaxItemOnScreen : row0Count)) - EntriesGap)) >> 1;

 

Edited December 29, 2018 by apianti

[Ingwar77]

9 hours ago, blackosx said:

..., looks great but is missing many macOS icons.

Hi Bernardo415 

take a look at Mojave or Mojave 4K theme from Badruzeus - there are a lot of icons.

[blackosx]

no banner on clover 4727+

 

this my plist, it is a modified yosemitelogin

theme.plist

Hi kylon

 

4727 is a commit from a while back. Is it just your theme that’s affected or do other themes exhibit the same behaviour?

 

Sorry, I’ve not looked at your theme.plist.

 

Hmmb, I just got your EDIT'ed post. #OMG, can't believe that you did it for me after I opened Clover Activities on SF, so.. many thanks for your help. Well, I could cancel my changes #LoL ..

Yeah, sorry if you’d prepared changes your end but I went ahead as I knew I had a couple of hours last night which I could do it otherwise I’m busy now for a couple of days.

 

No need to simplify into one line but you can simplify it using better operators:

      row0PosX = row0TileSize + EntriesGap;      row0PosX *= ((MaxItemOnScreen  row0Count) ? MaxItemOnScreen : row0Count);      row0PosX -= EntriesGap;      row0PosX = UGAWidth - row0PosX;      row0PosX >>= 1;

EDIT: I guess you could simplify it into one line:

 

      row0PosX = (UGAWidth - (((row0TileSize + EntriesGap) * ((MaxItemOnScreen  row0Count) ? MaxItemOnScreen : row0Count)) - EntriesGap)) >> 1;

 

 

Thanks for taking a look apianti and passing on your optimisation

[kylon]

Hi kylon

 

4727 is a commit from a while back. Is it just your theme that’s affected or do other themes exhibit the same behaviour?

 

Sorry, I’ve not looked at your theme.plist

I don't know, this is the only one i have.

Christmas theme is fine

 

[chris1111]

2 hours ago, kylon said:

I don't know, this is the only one i have.

Christmas theme is fine

 

 

Christmas theme is fine

Edited December 31, 2018 by chris1111

[kylon]

I found the problem but not the fix.

 

There s an error with the background/screen size size calculation, my banner goes out of screen, even with static images.

My banner is working on other themes, so something has changed or is now broken? and my plist relies on it

 

 

EDIT:

If i set Banner NO in other themes, my animated logo goes out of screen

[Badruzeus]

1 hour ago, kylon said:

I found the problem but not the fix.

 

There s an error with the background/screen size size calculation, my banner goes out of screen, even with static images.

My banner is working on other themes, so something has changed or is now broken? and my plist relies on it

 

 

EDIT:

If i set Banner NO in other themes, my animated logo goes out of screen

At least tell us / attach which theme are you using.

[kylon]

yosemitelogin.zip

[Machinee]

Mac OS Classic - A Clover Theme by Machinee
(Work in progress)


 

 

Created a Classic Mac OS Theme for Clover Bootloader. Thought I'd share it for anyone interested.
It has the features of the Classic Mac OS with a modern look.

 

 

 

 

Features

Animated Banner
Scrollbar
Custom Icons
Custom Font

 

 

 

 

 

 

 

 

The non selected entries will turn to life with colors when selected.
Smaller monitors will also have a Classic Mac OS styled scrollbar when needed.

 

Notes:
I couldn't really get the scrollbar to work exactly as intended for now, seems to be a really buggy feature.
I might take requests for icons etc. if there's interest, we'll see.
Designed with 2.5K monitors in mind, let me know if something doesn't look right at other resolutions.

Enjoy!

 

 

 

 

 

Download here: https://github.com/fbongcam/Mac-OS-Classic-a-Clover-Bootloader-Theme

 

 

Edited January 5, 2019 by fbongcam

[LAbyOne]

3 Version theme I made recently for my machines...

which i'd like to share with you.

 

All 3 have also Animated logo

 

something like this one . 

 

sorry that gif came out terriblle   ....oh well its just to give an idea of what looks like

 

1_ is - Colbalt

 

2_ is - Lavender (white & Black)

 

3_ is - Cocoa also  (white & Black)

 

Since I still didn't install latest Clover so don't know if all settings into plist are to be modified om order to avoid glitches

sp i will post the files (if anyone interested) as soon i update clover and all settings are verified working.

 

Cheers

[blackosx]

Nice to see new themes @Machinee and nice work @LAbyOne 

[LAbyOne]

Here we go

ALL Tested under Clover_4842 and all seem work fine, 

 

PS: added a variation for Cocoa Black + small icons

 

 Lavender

 

Lavender White

 

Cobalt

 

Cobalt Black

 

Cocoa Black

 

Cocoa Black Small

 

Cocoa White

 

Enjoy

 

Edited May 11, 2019 by LAbyOne

[Needy]

@blackosx A bit late but, thank you for fixing the issue. I had alignment issues before committing those changes, there were random hardcoded numbers, like that 8, which you mentioned in one of your previous posts. Even though all that fixed the alignment issues for themes that use default sizes, it broke themes that are using custom sizes for icons, my bad I didn't check. Anyway, it's fixed now.

My apologies to everyone for breaking the custom themes, they differ in behaviour from default, which I didn't take into account.

[Needy]

@Badruzeus Fixed the TileYSpace issue with bootcampstyle. Used the attached theme to test it. 

It will break any theme that used hacks to adapt to the wrong logic. 

@@ -4068,7 +4068,7 @@ VOID MainMenuStyle(IN REFIT_MENU_SCREEN 
       row1PosX = (UGAWidth + 8 - (row1TileSize + (INTN)(8.0f * GlobalConfig.Scale)) * row1Count) >> 1;
 
       if (GlobalConfig.BootCampStyle && !(GlobalConfig.HideUIFlags & HIDEUI_FLAG_LABEL)) {
-        row1PosY = row0PosY + EntriesHeight + (BCSMargin * 2) + TextHeight +
+        row1PosY = row0PosY + row0TileSize + (BCSMargin * 2) + TextHeight +
             (INTN)(INDICATOR_SIZE * GlobalConfig.Scale) +
             (INTN)((LayoutButtonOffset + GlobalConfig.TileYSpace) * GlobalConfig.Scale);
       } else {

Also attached is the full diff file.

Aero256.zip

layoutYfix.diff

 

CLOVERX64.efi

Edited January 13, 2019 by Needy
Wrong binary