Jump to content

Clover General discussion

ErmaC

By ErmaC,
in Clover

 Share
30,171 posts in this topic

Recommended Posts

Jief_Machak
Jief_Machak
Posted
Posted
27 minutes ago, Slice said:

Very bad. Good program should never crash on bad user input.

No, no. It's bug if it does. I agree. So I read and search for all string access on TagPtr, for example, and many of where not guarded. Like in this : 

          if (Prop != NULL && Prop->string.notEmpty() ) {
            OSVersion = Prop->string;
          }

prop->string could be null if the property is the property is an int.

So I've added tests like : 

          if ( Prop != NULL ) {
            if ( !Prop->isString() ) {
              MsgLog("ATTENTION : property not string in ProductVersion\n");
            }else{
              if( Prop->stringValue().notEmpty() ) {
                OSVersion = Prop->stringValue();
              }
            }
          }

But I can have forgotten some.

 

 

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted (edited)
2 hours ago, Slice said:

The crash was happened reading nvram.plist which formed automatically by the command

nvram -x  -p> nvram.plist

Ok. Corrected.

2 hours ago, Slice said:

Debug.log loose line ending

What is the software you used to open the debug log?

 

 

Edited by Jief_Machak
Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted (edited)

Thanks for giving me the nvram.plist. It allows me to quickly find where the problem was.

 

My debug.log still have line endings. Strange. I did modified something about cr/lf are emitted to the console. I thought it would remove the cr/lf, leaving just the lf in debug.log. Which didn't seem to be a problem as it's standard mac. But no, my debug.log still has \r\n.

 

Could you open your debug.log in hex editor and tell what char do you have at the end of the line ?

Screenshot 2020-08-18 at 22.38.28.png

Edited by Jief_Machak
Link to comment
Share on other sites
Slice
Slice
Posted
Posted

New panic on new computer. 

if ( tagList == NULL ) panic("TagStruct::setDictValue() : tagList == NULL ");

All previous debug.log have 0D 0A line ending as EDK2 set as rule.

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted

Done : empty dict allowed.

 

I've also committed a guard in XTheme::ClearScreen() for when UGAWidth == 0 || UGAHeight == 0. I also notice that the graphic banner is displayed when in text mode (I didn't know that graphic and text mode can mix...).

UGAWidth == 0 or UGAHeight == 0 can happen is GOP and UGADraw are unavailable. Which, most likely almost never happen... But can happen on my virtual config.

Link to comment
Share on other sites
MICKHAEL
MICKHAEL
Posted
Posted
4 minutes ago, Jief_Machak said:

Here is my Clover efi. It's a debug version, might be slower than usual.

CloverX64.efi

unfortunately its the same message - cant load kext and failed to load kext. stuck on AppleIntelLpssController::_serviceMatchingTineSubr: fTimeServiceMatching timed out. fNotifications 0

  • Sad 1
Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
42 minutes ago, MICKHAEL said:

unfortunately its the same message - cant load kext and failed to load kext. stuck on AppleIntelLpssController::_serviceMatchingTineSubr: fTimeServiceMatching timed out. fNotifications 0

Are you trying Big Sur ?

I'm not yet working on that, because I can't download Big Sur. So any commit you see from me for now won't bring new fetures.

Link to comment
Share on other sites
MICKHAEL
MICKHAEL
Posted
Posted
6 minutes ago, Jief_Machak said:

Are you trying Big Sur ?

I'm not yet working on that, because I can't download Big Sur. So any commit you see from me for now won't bring new fetures.

yes) Big Sur Beta 4. you can't download? I could share with you over Mega. just let me know

Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted (edited)

 Hi @Jief_Machak

Latest commit 8b6f19f boot fine Catalina on Z390 Aorus Master.
 

Can't boot Big Sur: a lot of ACPI error despite MaLd0n's DSDT, stuck at apfs_module 2411 :cry:

 

 

IMPORTANT: crazybirdy's script for download BS attached

 

 

installScript_1016fullapp

Edited by Matgen84
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
2 minutes ago, Jief_Machak said:

No need to try Big Sur at the moment, I think. Clover's not ready. You'll know when it is from this forum...

 

In my previous post edited, there is crazybirdy's script attached for you, if you need 

Link to comment
Share on other sites
iCanaro
iCanaro
Posted
Posted (edited)
31 minutes ago, Jief_Machak said:

Are you trying Big Sur ?

I'm not yet working on that, because I can't download Big Sur. So any commit you see from me for now won't bring new fetures.

here fusion put direct beta4 download

https://www.insanelymac.com/forum/topic/344428-pre-release-macos-big-sur/?do=findComment&comment=2733286

 

Edited by iCanaro
Link to comment
Share on other sites
Slice
Slice
Posted
Posted
On 8/19/2020 at 10:30 PM, Jief_Machak said:

Wrong cast, I think. To test, I must enter GetBootFromOption(). It's only executed if (*(UINT32*)SelfLoadedImage->LoadOptions == CLOVER_SIGN). How do I do that ?

But you can test, should be ok. 

0:133  0:000  Clover started with option to boot bootmgfw from EFI

:thumbsup_anim:

  • Like 1
Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...