Jief_Machak Posted March 8, 2020 Share Posted March 8, 2020 1 hour ago, Slice said: Theme containing icns format must be rejected as not confirming Clover requirements. All icons MUST be PNG! I didn't know about requirement. No problem, can cancel my commit. Link to comment Share on other sites More sharing options...
vector sigma Posted March 8, 2020 Share Posted March 8, 2020 1 minute ago, Jief_Machak said: I didn't know about requirement. No problem, can cancel my commit. Actually the problems is in the theme repo that contains such icns when it shouldn't be. I think this caused a lot of problems in past 1 Link to comment Share on other sites More sharing options...
Jief_Machak Posted March 8, 2020 Share Posted March 8, 2020 Why do you want to restrict it to PNG, while it's already supporting ICNS ? Ok. Fine by me not to support them. 1 Link to comment Share on other sites More sharing options...
vector sigma Posted March 8, 2020 Share Posted March 8, 2020 (edited) 3 minutes ago, Jief_Machak said: Why do you want to restrict it to PNG, while it's already supporting ICNS ? I don't think Slice wanted to say that, but there are very old Clover revisions here and there.. Edited March 8, 2020 by vector sigma 1 Link to comment Share on other sites More sharing options...
vector sigma Posted March 8, 2020 Share Posted March 8, 2020 1 hour ago, Mork vom Ork said: i have just updated the de-language files for CLOVER and CloverApp. Attached you will find the files wich where changed de_language_files.zip Done! Link to comment Share on other sites More sharing options...
Jief_Machak Posted March 8, 2020 Share Posted March 8, 2020 @Slice I can see that you change "static XPointer mPointer;" back to what is was before (non-static). Was it just a trial ? Because having an instance of XPointer in each XImage seems no right : a big memory consumming. And there will only be one pointer at a time, right ? So for me, XPointer should only exist once. Either as a global, or as a static in a class. Same thing : only one instance exist. Am I right ? Link to comment Share on other sites More sharing options...
chris1111 Posted March 8, 2020 Share Posted March 8, 2020 (edited) The space (keyboard) option on clover GUI not working anymore Its Stock when I press Space EDIT **** This is what append in the left corner I have to push the power button to shutdown the PC Edited March 8, 2020 by chris1111 1 Link to comment Share on other sites More sharing options...
Matgen84 Posted March 9, 2020 Share Posted March 9, 2020 (edited) The space (keyboard) option on clover GUI not working always Its stock when I press Spacebar. Build r5104 1cb7b4e EDIT: This is what append in the left corner on CLOVER GUI Before scan entries, there is always "all tests message" in the left corner. Edited March 9, 2020 by Matgen84 Link to comment Share on other sites More sharing options...
Slice Posted March 9, 2020 Share Posted March 9, 2020 I can confirm that mouse pointer is very good now. Menu details is still not working 9:716 0:002 DefaultIndex=3 and MainMenu.Entries.size()=11 10:262 0:546 GUI ready 20:060 9:798 XArray<TYPE>::CheckSize(nNewSize=7130204406964771079, nGrowBy=0) : Xrealloc(4096, -734174180, 0) returned NULL. System halted 20:065 0:005 A fatal error happened. System halted 1 Link to comment Share on other sites More sharing options...
Jief_Machak Posted March 9, 2020 Share Posted March 9, 2020 Can you tell me what you do ? For me, when I press Space, it freezes. It freezes in "GraphicsOutput->Blt" in XImage. Very strange. But I saw that XPointer oldImage is 64x64 when pointer is 32x32. Don't know if it's connected. Link to comment Share on other sites More sharing options...
Jief_Machak Posted March 9, 2020 Share Posted March 9, 2020 I fixed the size problem of oldImage. There was also Alive not initialised in XPointer. I've got some menus, and you ? 1 Link to comment Share on other sites More sharing options...
Jief_Machak Posted March 9, 2020 Share Posted March 9, 2020 I've committed a Qemu folder, in which you can easily start under control of gdb to catch where the panic message come from. It'll considerably speed up the bug resolution. To use : - regenerate your basetools to recompile GenFW - install qemu with brew (super easy) - install gdb with brew (super easy too, but wait...) - codesign gdb. That's a bit annoying. Well there is plenty of guide over the internet and it doesn't take long. The thing is : if you got this error with a very good self explanatory message, you may have to create in your login keychain instead os System and move it after. I was able once to create in System, some time ago, but not anymore. This should work : https://gist.github.com/hlissner/898b7dfc0a3b63824a70e15cd0180154 If it doesn't work first time, it's not because of custom parameter of the certificate. No need to waste your time with that. The field you need to change are specify in the guide. It's really a problem of having your keychain unlock to create the certificate. If you got a panic message, compile with GCC53 toolchain, DEBUG version, then start Qemu/gdb_launch (not need in a the folder). When you got your panic agin, gdb should give you a prompt "(gdb) ". Just type bt, return and send us the backtrace. It looks like this and it's super helpful : (gdb) bt #0 panic () at /JiefLand/5.Devel/Clover/workspace_Clover-master/Clover--CloverHackyColor--master/rEFIt_UEFI/cpp_util/panic.cpp:18 #1 0x000000007ddb8448 in REFIT_MENU_SCREEN::RunGenericMenu (this=0x7deddfe0 <MainMenu>, StyleFunc=&virtual REFIT_MENU_SCREEN::MainMenuStyle(unsigned long long, wchar_t const*), DefaultEntryIndex=0x7fcef9b0, ChosenEntry=0x7fcef9c0) at /JiefLand/5.Devel/Clover/workspace_Clover-master/Clover--CloverHackyColor--master/rEFIt_UEFI/refit/menu.cpp:2770 #2 0x000000007ddc3426 in REFIT_MENU_SCREEN::RunMainMenu (this=0x7deddfe0 <MainMenu>, DefaultSelection=-1, ChosenEntry=0x7fcefac8) at /JiefLand/5.Devel/Clover/workspace_Clover-master/Clover--CloverHackyColor--master/rEFIt_UEFI/refit/menu.cpp:5682 #3 0x000000007dda8972 in RefitMain (ImageHandle=0x7ec38918, SystemTable=0x7f745f18) at /JiefLand/5.Devel/Clover/workspace_Clover-master/Clover--CloverHackyColor--master/rEFIt_UEFI/refit/main.cpp:2641 #4 0x000000007dda2360 in ProcessModuleEntryPointList (ImageHandle=0x7ec38918, SystemTable=0x7f745f18) at /JiefLand/5.Devel/Clover/workspace_Clover-master/Clover--CloverHackyColor--master/Build/Clover/DEBUG_GCC53/X64/rEFIt_UEFI/refit/DEBUG/AutoGen.c:497 #5 0x000000007dda2297 in _ModuleEntryPoint (ImageHandle=0x7ec38918, SystemTable=0x7f745f18) at /JiefLand/5.Devel/Clover/workspace_Clover-master/Clover--CloverHackyColor--master/MdePkg/Library/UefiApplicationEntryPoint/ApplicationEntryPoint.c:59 (gdb) Sometime, in the backtrace, you get a lot of line before (means below) RefitMain. No need for that. Hope you'll try. I'll assist. 1 Link to comment Share on other sites More sharing options...
Slice Posted March 9, 2020 Share Posted March 9, 2020 Thanks! Now detailed menu with space bar works both in QEMU and on real machine. The last stopping issue is crash after theme change. Last messages are 69:922 15:649 ReinitSelfLib after theme change 69:943 0:020 reinit: self device path=PciRoot(0x0)\Pci(0x1F,0x2)\Sata(0x0,0xFFFF,0x0)\HD(1,GPT,9BBF140E-C64F-4F36-B715-20B89E1A86A0,0x28,0x64000) 1 Link to comment Share on other sites More sharing options...
Jief_Machak Posted March 9, 2020 Share Posted March 9, 2020 Crash happens in QEMU ? From what theme to what theme ? Link to comment Share on other sites More sharing options...
Jief_Machak Posted March 9, 2020 Share Posted March 9, 2020 I confirm it's working here, so it must depend on the config. Send me your Qemu img, and what to do, I'll have a look. Link to comment Share on other sites More sharing options...
tluck Posted March 9, 2020 Share Posted March 9, 2020 FYI... I ran a quick test this morning, and space bar works for a Volume now, but Clover Boot Options gets hung and returning from shell upon exit goes to nowhere? 1 Link to comment Share on other sites More sharing options...
Jief_Machak Posted March 9, 2020 Share Posted March 9, 2020 Hi, thanks. Something was done 5 hours ago. Did you try after and updated ? Link to comment Share on other sites More sharing options...
Matgen84 Posted March 9, 2020 Share Posted March 9, 2020 (edited) 30 minutes ago, Jief_Machak said: Hi, thanks. Something was done 5 hours ago. Did you try after and updated ? I test. I try and let you know! EDIT1: All works fine with space bar, arrows keys, menu. There remains the message "all tests" in the top left corner. Can you remove it? EDIT2: Is it possible to go back in Clover GUI, after shell exit? Edited March 9, 2020 by Matgen84 Link to comment Share on other sites More sharing options...
exquirentibus Posted March 9, 2020 Share Posted March 9, 2020 (edited) After getting 10.15.3 installed, I'm seeing a very strange icon in 5104 CloverHacky for a USB connected SSD that is 10.15.3 bootable? Should I be concerned? UEFI drivers FSInject.efi FwRuntimeServices.efi OcQuirks.efi (from OcQuirks rev 17) OcQuirks.plist VBoxHfs.efi from 5104 CloverHacky UEFI\FileSystem\ApfsDriverLoader.efi Edited March 9, 2020 by exquirentibus Link to comment Share on other sites More sharing options...
Slice Posted March 9, 2020 Share Posted March 9, 2020 2 hours ago, Jief_Machak said: Crash happens in QEMU ? From what theme to what theme ? Switch from cesium to embedded in QEMU. Latest commit 5104-164-g579b28b4f Link to comment Share on other sites More sharing options...
Jief_Machak Posted March 9, 2020 Share Posted March 9, 2020 I can switch without problems between these 2 themes. So I can only help if you send me the img you use in Qemu and the exact procedure. 1 Link to comment Share on other sites More sharing options...
Slice Posted March 9, 2020 Share Posted March 9, 2020 On 3/8/2020 at 11:38 PM, Jief_Machak said: @Slice I can see that you change "static XPointer mPointer;" back to what is was before (non-static). Was it just a trial ? Because having an instance of XPointer in each XImage seems no right : a big memory consumming. And there will only be one pointer at a time, right ? So for me, XPointer should only exist once. Either as a global, or as a static in a class. Same thing : only one instance exist. Am I right ? I prefer Pointer arises at each screen and disappear after change screen. But I afraid static pointer will have images or position from previous screen which is incorrect. Link to comment Share on other sites More sharing options...
chris1111 Posted March 9, 2020 Share Posted March 9, 2020 Ok SPACE is back to normal , mousse pointer back to normal also Option working good here Thanks 1 Link to comment Share on other sites More sharing options...
LockDown Posted March 10, 2020 Share Posted March 10, 2020 On 3/9/2020 at 3:10 AM, vector sigma said: @Matgen84 try this: Clover.app.zip P.S. conversion of all images to png when optimizing... only if they are not. tried, but it was not converted to PNG extension Link to comment Share on other sites More sharing options...
vector sigma Posted March 10, 2020 Share Posted March 10, 2020 3 hours ago, ellaosx said: tried, but it was not converted to PNG extension No one said that the file extension will ever be changed. Where did you read this? 1 Link to comment Share on other sites More sharing options...
Recommended Posts