Clover General discussion

jinbingmao · June 9, 2019

Little omissions in the "clover" startup log: "Boot. efi" is wrongly written as "boot. efii"

Badruzeus · June 9, 2019

Thay's bit weird that since r4956 I got random AppleSMC kernel panic when mach halt (reboot / shutdown). Not sure why mine is affected bcoz I'm sure my SMBios (MBP10,1) is not on those updated platformdata.c list. A similar issue with 10.3.6 upto 10.15 Beta using FakeSMC (Rehabman), not trying VirtualSMC yet. (Sorry, can not upload full crash logs. I'm currently on mobile).

Sherlocks · June 9, 2019

1 hour ago, Badruzeus said:

Thay's bit weird that since r4956 I got random AppleSMC kernel panic when mach halt (reboot / shutdown). Not sure why mine is affected bcoz I'm sure my SMBios (MBP10,1) is not on those updated platformdata.c list. A similar issue with 10.3.6 upto 10.15 Beta using FakeSMC (Rehabman), not trying VirtualSMC yet. (Sorry, can not upload full crash logs. I'm currently on mobile).

strange. did you try to cleanup nvram?

Slice · June 9, 2019

2 hours ago, Badruzeus said:

Thay's bit weird that since r4956 I got random AppleSMC kernel panic when mach halt (reboot / shutdown). Not sure why mine is affected bcoz I'm sure my SMBios (MBP10,1) is not on those updated platformdata.c list. A similar issue with 10.3.6 upto 10.15 Beta using FakeSMC (Rehabman), not trying VirtualSMC yet. (Sorry, can not upload full crash logs. I'm currently on mobile).

Is it happen with FakeSMC-6 and never with FakeSMC-3?

PMheart · June 9, 2019

Hi,

I propose this new patch for kext injection of 10.15:

Index: rEFIt_UEFI/Platform/kext_inject.c
===================================================================
--- rEFIt_UEFI/Platform/kext_inject.c	(revision 4959)
+++ rEFIt_UEFI/Platform/kext_inject.c	(working copy)
@@ -681,8 +681,8 @@
 // Catalina (SIP)
 // PMheart: checked
 // Need to pair with KBEMojaCata*EXT
-UINT8   KBECataSearchSIP[]            = { 0x00, 0x85, 0xC0, 0x0F, 0x84, 0x87, 0x00, 0x00, 0x00, 0x49 };
-UINT8   KBECataReplaceSIP[]           = { 0x00, 0x85, 0xC0, 0x90, 0x90, 0x90, 0x90, 0x90, 0x90, 0x49 };
+UINT8   KBECataSearchSIP[]            = { 0xE8, 0xB0, 0xEE, 0x0C, 0x00, 0x85, 0xC0, 0x0F, 0x84 };
+UINT8   KBECataReplaceSIP[]           = { 0xE8, 0xB0, 0xEE, 0x0C, 0x00, 0x31, 0xC0, 0x0F, 0x84 };
 
 // Mojave 10.14 - 10.14.3
 // Avoid race condition in OSKext::removeKextBootstrap when using booter kexts without keepsyms=1.

Don't ask me if it works, of course it does - just read the asm code.

PMheart

Mison · June 9, 2019

18 hours ago, Pene said:

True, but I already fixed that with r4949. Try a later revision.

OK，thx

Badruzeus · June 9, 2019

1 hour ago, Slice said:

Is it happen with FakeSMC-6 and never with FakeSMC-3?

I think bcoz of Nvram, no longer having issue after Clover's F11 key for full clean, thanks @Sherlocks for suggestion. Oh ya, could be affected by VirtualSMC either.. I remember previously boot with it using OpenCore, then switch to Clover (FakeSMC). I will retry with your FakeSMC v3.5.1.

Sherlocks · June 9, 2019

8 minutes ago, Badruzeus said:

I think bcoz of Nvram, no longer having issue after Clover's F11 key for full clean, thanks @Sherlocks for suggestion. Oh ya, could be affected by VirtualSMC either.. I remember previously boot with it using OpenCore, then switch to Clover (FakeSMC). I will retry with your FakeSMC v3.5.1.

probably. recent commit for smc3 is no problem for rehabman and slice fakesmc version.

anyways f11 can clean opencore nvram keys.

now i keep rehabman fakesmc. his kext suppport all macos(10.6~10.15). its all in one. but his kext need to update for smc3 like vector's update of hwsensor3.

Edited June 9, 2019 by Sherlocks

Badruzeus · June 10, 2019

When building Clover r4961 with `./ebuild.sh --ext-co -fr` I got this errors (seem related to OcSupportPkg):

Building ... /Users/badruzeus/src/EXT_PACKAGES/OcSupportPkg/Library/OcStringLib/OcStringLib.inf [X64]
[CC] OcAsciiLib
[CC] BitOverflow
[CC] DataPatcher
[CC] FileProtocol
/Users/badruzeus/src/EXT_PACKAGES/OcSupportPkg/Library/OcStringLib/OcUnicodeLib.c:67:23: error: implicit declaration of function 'CharToUpper' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  UpperFirstString  = CharToUpper (*FirstString);
                      ^
/Users/badruzeus/src/EXT_PACKAGES/OcSupportPkg/Library/OcStringLib/OcUnicodeLib.c:143:23: error: implicit declaration of function 'CharToUpper' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  UpperFirstString  = CharToUpper (*FirstString);
                      ^
2 errors generated.
make: *** [/Users/badruzeus/src/UDK2018/Build/AptioFixPkg/RELEASE_XCODE8/X64/OcSupportPkg/Library/OcStringLib/OcStringLib/OUTPUT/OcUnicodeLib.obj] Error 1


build.py...
 : error 7000: Failed to execute command
	make tbuild [/Users/badruzeus/src/UDK2018/Build/AptioFixPkg/RELEASE_XCODE8/X64/OcSupportPkg/Library/OcStringLib/OcStringLib]


build.py...
 : error F002: Failed to build module
	/Users/badruzeus/src/EXT_PACKAGES/OcSupportPkg/Library/OcStringLib/OcStringLib.inf [X64, XCODE8, RELEASE]

- Failed -
Build end time: 09:07:33, Jun.10 2019
Build total time: 00:00:10

MacBookPro:Clover badruzeus$

Thanks.

Edited June 10, 2019 by Badruzeus

Slice · June 10, 2019

1 hour ago, Badruzeus said:

When building Clover r4961 with `./ebuild.sh --ext-co -fr` I got this errors (seem related to OcSupportPkg):


Building ... /Users/badruzeus/src/EXT_PACKAGES/OcSupportPkg/Library/OcStringLib/OcStringLib.inf [X64]
[CC] OcAsciiLib
[CC] BitOverflow
[CC] DataPatcher
[CC] FileProtocol
/Users/badruzeus/src/EXT_PACKAGES/OcSupportPkg/Library/OcStringLib/OcUnicodeLib.c:67:23: error: implicit declaration of function 'CharToUpper' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  UpperFirstString  = CharToUpper (*FirstString);
                      ^
/Users/badruzeus/src/EXT_PACKAGES/OcSupportPkg/Library/OcStringLib/OcUnicodeLib.c:143:23: error: implicit declaration of function 'CharToUpper' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  UpperFirstString  = CharToUpper (*FirstString);
                      ^
2 errors generated.
make: *** [/Users/badruzeus/src/UDK2018/Build/AptioFixPkg/RELEASE_XCODE8/X64/OcSupportPkg/Library/OcStringLib/OcStringLib/OUTPUT/OcUnicodeLib.obj] Error 1


build.py...
 : error 7000: Failed to execute command
	make tbuild [/Users/badruzeus/src/UDK2018/Build/AptioFixPkg/RELEASE_XCODE8/X64/OcSupportPkg/Library/OcStringLib/OcStringLib]


build.py...
 : error F002: Failed to build module
	/Users/badruzeus/src/EXT_PACKAGES/OcSupportPkg/Library/OcStringLib/OcStringLib.inf [X64, XCODE8, RELEASE]

- Failed -
Build end time: 09:07:33, Jun.10 2019
Build total time: 00:00:10

MacBookPro:Clover badruzeus$

Thanks.

It should be reported to Acidantera.

Slice · June 10, 2019

22 hours ago, PMheart said:

Hi,

I propose this new patch for kext injection of 10.15:


Index: rEFIt_UEFI/Platform/kext_inject.c
===================================================================
--- rEFIt_UEFI/Platform/kext_inject.c	(revision 4959)
+++ rEFIt_UEFI/Platform/kext_inject.c	(working copy)
@@ -681,8 +681,8 @@
 // Catalina (SIP)
 // PMheart: checked
 // Need to pair with KBEMojaCata*EXT
-UINT8   KBECataSearchSIP[]            = { 0x00, 0x85, 0xC0, 0x0F, 0x84, 0x87, 0x00, 0x00, 0x00, 0x49 };
-UINT8   KBECataReplaceSIP[]           = { 0x00, 0x85, 0xC0, 0x90, 0x90, 0x90, 0x90, 0x90, 0x90, 0x49 };
+UINT8   KBECataSearchSIP[]            = { 0xE8, 0xB0, 0xEE, 0x0C, 0x00, 0x85, 0xC0, 0x0F, 0x84 };
+UINT8   KBECataReplaceSIP[]           = { 0xE8, 0xB0, 0xEE, 0x0C, 0x00, 0x31, 0xC0, 0x0F, 0x84 };
 
 // Mojave 10.14 - 10.14.3
 // Avoid race condition in OSKext::removeKextBootstrap when using booter kexts without keepsyms=1.

Don't ask me if it works, of course it does - just read the asm code.

PMheart

Sorry for commiting too late.

SavageAUS · June 10, 2019

23 hours ago, Slice said:

Is it happen with FakeSMC-6 and never with FakeSMC-3?

FakeSMC jump from 3 to 6? Where is new version please?

Slice · June 10, 2019

10 minutes ago, SavageAUS said:

FakeSMC jump from 3 to 6? Where is new version please?

There are different branches. FakeSMC-3 is newer then FakeSMC-6.

artur_pt · June 10, 2019

hello Slice

last commit r4962 have problems

it boot Mojave but not Catalina

in Catalina give KP

thanks

telepati · June 10, 2019

7 hours ago, SavageAUS said:

FakeSMC jump from 3 to 6? Where is new version please?

Here it is;

cloverefiboot-code-r4961-CloverPackage-CloverV2-ThirdParty-kexts-Other.zip

I download a snapshot from here but I am not sure did I right.

https://sourceforge.net/p/cloverefiboot/code/4961/tree//CloverPackage/CloverV2/ThirdParty/kexts/Other/

Edited June 10, 2019 by telepati

arsradu · June 10, 2019

Looks like ext_packages have yet another issue when building Clover.

Just letting you guys know in case you come across the same thing.

OCSupportPkg should be for OpenCore only. Not sure why is it trying to compile it for Clover... But anyway. Maybe there's no condition put in place to detect what you're trying to compile and only add that support pkg where it's needed.

Anyway, I just thought you guys might wanna know about this.

[SLINK] BaseIoLibIntrinsic
Building ... /Users/jimmy/src/EXT_PACKAGES/OcSupportPkg/Library/OcDataHubLib/OcDataHubLib.inf [X64]
/Users/jimmy/src/EXT_PACKAGES/OcSupportPkg/Library/OcStringLib/OcUnicodeLib.c:67:23: error: implicit declaration of function 'CharToUpper' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  UpperFirstString  = CharToUpper (*FirstString);
                      ^
/Users/jimmy/src/EXT_PACKAGES/OcSupportPkg/Library/OcStringLib/OcUnicodeLib.c:143:23: error: implicit declaration of function 'CharToUpper' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  UpperFirstString  = CharToUpper (*FirstString);
                      ^
2 errors generated.
make: *** [/Users/jimmy/src/UDK2018/Build/AptioFixPkg/RELEASE_XCODE8/X64/OcSupportPkg/Library/OcStringLib/OcStringLib/OUTPUT/OcUnicodeLib.obj] Error 1


build.py...
 : error 7000: Failed to execute command
	make tbuild [/Users/jimmy/src/UDK2018/Build/AptioFixPkg/RELEASE_XCODE8/X64/OcSupportPkg/Library/OcStringLib/OcStringLib]


build.py...
 : error F002: Failed to build module
	/Users/jimmy/src/EXT_PACKAGES/OcSupportPkg/Library/OcStringLib/OcStringLib.inf [X64, XCODE8, RELEASE]

- Failed -
Build end time: 14:35:16, Jun.10 2019
Build total time: 00:00:04

Edited June 10, 2019 by arsradu

Badruzeus · June 10, 2019

8 minutes ago, arsradu said:

Looks like ext_packages have yet another issue when building Clover.

Just letting you guys know in case you come across the same thing.

OCSupportPkg should be for OpenCore only. Not sure why is it trying to compile it for Clover... But anyway. Maybe there's no condition put in place to detect what you're trying to compile and only add that support pkg where it's needed.

Anyway, I just thought you guys might wanna know about this.


[SLINK] BaseIoLibIntrinsic
Building ... /Users/jimmy/src/EXT_PACKAGES/OcSupportPkg/Library/OcDataHubLib/OcDataHubLib.inf [X64]
/Users/jimmy/src/EXT_PACKAGES/OcSupportPkg/Library/OcStringLib/OcUnicodeLib.c:67:23: error: implicit declaration of function 'CharToUpper' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  UpperFirstString  = CharToUpper (*FirstString);
                      ^
/Users/jimmy/src/EXT_PACKAGES/OcSupportPkg/Library/OcStringLib/OcUnicodeLib.c:143:23: error: implicit declaration of function 'CharToUpper' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  UpperFirstString  = CharToUpper (*FirstString);
                      ^
2 errors generated.
make: *** [/Users/jimmy/src/UDK2018/Build/AptioFixPkg/RELEASE_XCODE8/X64/OcSupportPkg/Library/OcStringLib/OcStringLib/OUTPUT/OcUnicodeLib.obj] Error 1


build.py...
 : error 7000: Failed to execute command
	make tbuild [/Users/jimmy/src/UDK2018/Build/AptioFixPkg/RELEASE_XCODE8/X64/OcSupportPkg/Library/OcStringLib/OcStringLib]


build.py...
 : error F002: Failed to build module
	/Users/jimmy/src/EXT_PACKAGES/OcSupportPkg/Library/OcStringLib/OcStringLib.inf [X64, XCODE8, RELEASE]

- Failed -
Build end time: 14:35:16, Jun.10 2019
Build total time: 00:00:04

vit9696 told me on OpenCore thread it needs AUDK (Acidenthera) instead of UDK.

arsradu · June 10, 2019

Just now, Badruzeus said:

vit9696 told me on OpenCore thread it needs AUDK (Acidenthera) instead of UDK.

Ok...but I'm not trying to build OpenCore. I'm trying to build Clover.

Badruzeus · June 10, 2019

40 minutes ago, arsradu said:

Ok...but I'm not trying to build OpenCore. I'm trying to build Clover.

I got similar error with OcSupportPkg when building Clover & OpenCore using UDK.

Matgen84 · June 10, 2019

Hi @Badruzeus, @arsradu

I think i's a AptiofixPg problem not Clover. There is some commits last 4hours 1hour in OCSupportPkg and OpenCore.

So wait and see

What flag to use for external package in ebuild.sh ( ---ext-co or --ext-pre)?

Sorry for my bad english

arsradu · June 10, 2019

8 minutes ago, Matgen84 said:

Hi @Badruzeus, @arsradu

I think i's a AptiofixPg problem not Clover. There is some commits last 4hours 1hour in OCSupportPkg and OpenCore.

So wait and see

What flag to use for external package in ebuild.sh ( ---ext-co or --ext-pre)?

Sorry for my bad english

At this point, all ebuild.sh parameters related to external packages will cause errors. Some will cause the error I mentioned before, others will cause other errors.

Anyway, these are the available options, and I've tried all of them with no success.

print_option_help "--ext-pre" "enable external driver download"
print_option_help "--ext-co" "checkout & build external drivers at ..src/EXT_PACKAGES"
print_option_help "--ext-build" "build existing external drivers located at ..src/EXT_PACKAGES"

The only way I could find to build Clover at this point is to build only Clover (no external drivers)

Edited June 10, 2019 by arsradu

Slice · June 10, 2019

Clover has enough drivers to be build without external one.

arsradu · June 10, 2019

6 minutes ago, Slice said:

Clover has enough drivers to be build without external one.

I think maybe the only one I need from those packages is ApfsDriverLoader. Do we have something similar for apfs, too? I mean, built with Clover? Cause apfs.efi itself is not open-source for as far as I know. And if you wanna use it and update it, you need to extract it yourself.

Edited June 10, 2019 by arsradu

Slice · June 10, 2019

Yes, apfs.efi is not open-source so I can't include it into distribution. Anyway I will recommend it for using.

Pene · June 10, 2019

On 6/9/2019 at 8:19 AM, PMheart said:

Hi,

I propose this new patch for kext injection of 10.15:


Index: rEFIt_UEFI/Platform/kext_inject.c
===================================================================
--- rEFIt_UEFI/Platform/kext_inject.c	(revision 4959)
+++ rEFIt_UEFI/Platform/kext_inject.c	(working copy)
@@ -681,8 +681,8 @@
 // Catalina (SIP)
 // PMheart: checked
 // Need to pair with KBEMojaCata*EXT
-UINT8   KBECataSearchSIP[]            = { 0x00, 0x85, 0xC0, 0x0F, 0x84, 0x87, 0x00, 0x00, 0x00, 0x49 };
-UINT8   KBECataReplaceSIP[]           = { 0x00, 0x85, 0xC0, 0x90, 0x90, 0x90, 0x90, 0x90, 0x90, 0x49 };
+UINT8   KBECataSearchSIP[]            = { 0xE8, 0xB0, 0xEE, 0x0C, 0x00, 0x85, 0xC0, 0x0F, 0x84 };
+UINT8   KBECataReplaceSIP[]           = { 0xE8, 0xB0, 0xEE, 0x0C, 0x00, 0x31, 0xC0, 0x0F, 0x84 };
 
 // Mojave 10.14 - 10.14.3
 // Avoid race condition in OSKext::removeKextBootstrap when using booter kexts without keepsyms=1.

Don't ask me if it works, of course it does - just read the asm code.

PMheart

@PMheart I have several reports injection does not work with the new patch in 10.15. Cannot test myself currently.

Edited June 10, 2019 by Pene

Clover General discussion

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites