chris1111 Posted March 30, 2018 Share Posted March 30, 2018 (edited) 2 minutes ago, ReddestDream said: L"\\System\\Library\\CoreServices\\boot.efi" "Library" and "CoreServices" are misspelled in yours. Sorry I am really tired This is good L "\\System\\Library\\CoreServices\\boot.efi" Edited March 30, 2018 by chris1111 Link to comment Share on other sites More sharing options...
ReddestDream Posted March 30, 2018 Share Posted March 30, 2018 (edited) Whether it will work or not is a different question. The Clover devs need to find another way to distinguish between installers and installed OSes since they are using hardcoded paths and not bless like a real mac . . . https://bombich.com/kb/ccc4/what-makes-volume-bootable Edited March 30, 2018 by ReddestDream Link to comment Share on other sites More sharing options...
chris1111 Posted March 30, 2018 Share Posted March 30, 2018 2 minutes ago, ReddestDream said: Whether it will work or not is a different question. The Clover devs need to find another way to distinguish between installers and installed OSes since they are using hardcoded paths and not bless like a real mac . . . I think is good, see loader.c Link to comment Share on other sites More sharing options...
ReddestDream Posted March 30, 2018 Share Posted March 30, 2018 1 minute ago, chris1111 said: I think is good, see loader.c But that's the same path an "installed" macOS uses: L"\\System\\Library\\CoreServices\\boot.efi" Now you can't tell if it's an installer or an OS that has already been installed . . . Link to comment Share on other sites More sharing options...
chris1111 Posted March 31, 2018 Share Posted March 31, 2018 (edited) 3 minutes ago, ReddestDream said: But that's the same path an "installed" macOS uses: L"\\System\\Library\\CoreServices\\boot.efi" Now you can't tell if it's an installer or an OS that has already been installed . . . Yes your right Edit ** @Sherlock will find a solution Edited March 31, 2018 by chris1111 Link to comment Share on other sites More sharing options...
ReddestDream Posted March 31, 2018 Share Posted March 31, 2018 Just now, chris1111 said: Yes your right Clover's probably going to have to start checking bless status to make this determination, which is how a real mac does it . . . In HFS+, this is done by checking the volume header for the inode of the Blessed System File and Folder. I'm not sure how it works on APFS . . . https://bombich.com/kb/ccc4/what-makes-volume-bootable 11 minutes ago, chris1111 said: Sorry I am really tired Should probably get sleep. This may end up being complex to fix . . . 4 minutes ago, chris1111 said: @Sherlock will find a solution Yay! 1 Link to comment Share on other sites More sharing options...
apianti Posted March 31, 2018 Share Posted March 31, 2018 The path is the same as an already installed macOS, updating method doesn't matter how - just run the same entry that has always been detected to update. If anything their change makes it even easier to upgrade since it won't be creating extra entries, boot.efi can deal with whatever it needs to start the correct action.... This is along the behavior of how windows updates. 1 Link to comment Share on other sites More sharing options...
ReddestDream Posted March 31, 2018 Share Posted March 31, 2018 (edited) 6 minutes ago, apianti said: The path is the same as an already installed macOS, updating method doesn't matter how - just run the same entry that has always been detected to update. If anything their change makes it even easier to upgrade since it won't be creating extra entries, boot.efi can deal with whatever it needs to start the correct action.... This is along the behavior of how windows updates. This isn't about updating an already installed system. It's about new USB-based macOS installers based on 10.13.4. Clover isn't detecting the macOS installer on the USB correctly. See here: https://www.insanelymac.com/forum/forums/topic/333560-macos-high-sierra-10134-is-out/?page=2&tab=comments#comment-2606462 Edited March 31, 2018 by ReddestDream 1 Link to comment Share on other sites More sharing options...
Slice Posted March 31, 2018 Share Posted March 31, 2018 5 hours ago, ReddestDream said: This isn't about updating an already installed system. It's about new USB-based macOS installers based on 10.13.4. Clover isn't detecting the macOS installer on the USB correctly. See here: https://www.insanelymac.com/forum/forums/topic/333560-macos-high-sierra-10134-is-out/?page=2&tab=comments#comment-2606462 What is happen at all? Clover detected the USB stick somehow? What is happen if click on it? I propose it works. Link to comment Share on other sites More sharing options...
chris1111 Posted March 31, 2018 Share Posted March 31, 2018 1 hour ago, Slice said: What is happen at all? Clover detected the USB stick somehow? What is happen if click on it? I propose it works. The entry is not visible on GUI Link to comment Share on other sites More sharing options...
Lucy183 Posted March 31, 2018 Share Posted March 31, 2018 (edited) Any success compiling r4419? Xcode 9.3 and Build_Clover.command Building ... /Users/LuCy/src/edk2/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf [X64] /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c:432:1: error: conflicting types for 'BmRepairAllControllers' BmRepairAllControllers ( ^ /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h:352:1: note: previous declaration is here BmRepairAllControllers ( ^ make: Nothing to be done for `tbuild'. Building ... /Users/LuCy/src/edk2/MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf [X64] make: Nothing to be done for `tbuild'. Building ... /Users/LuCy/src/edk2/ShellPkg/Library/UefiShellLib/UefiShellLib.inf [X64] /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c:580:32: error: use of undeclared identifier 'MAX_RECONNECT_REPAIR' if (ReconnectRepairCount < MAX_RECONNECT_REPAIR) { make: Nothing to be done for `tbuild'. ^ Building ... /Users/LuCy/src/edk2/MdePkg/Library/UefiMemoryLib/UefiMemoryLib.inf [X64] /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c:581:31: error: too many arguments to function call, expected 0, have 1 make: Nothing to be done for `tbuild'. BmRepairAllControllers (ReconnectRepairCount + 1); ~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~ /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h:351:1: note: 'BmRepairAllControllers' declared here VOID ^ /Users/LuCy/src/edk2/MdePkg/Include/Base.h:337:19: note: expanded from macro 'VOID' #define VOID void ^ Building ... /Users/LuCy/src/edk2/Clover/Library/OpensslLib/OpensslLibNull.inf [X64] 3 errors generated. make: *** [/Users/LuCy/src/edk2/Build/Clover/RELEASE_XCODE8/X64/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib/OUTPUT/BmDriverHealth.obj] Error 1 build.py... : error 7000: Failed to execute command make tbuild [/Users/LuCy/src/edk2/Build/Clover/RELEASE_XCODE8/X64/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib] build.py... : error F002: Failed to build module /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf [X64, XCODE8, RELEASE] - Failed - Build end time: 14:28:28, Mar.31 2018 Build total time: 00:00:16 o_Ops, ./ebuild.sh exited with error(s), aborting.. Edited March 31, 2018 by LuCyr04 1 Link to comment Share on other sites More sharing options...
Zenith432 Posted March 31, 2018 Share Posted March 31, 2018 (edited) @LuCyr04: update to latest edk2 and reapply Patches_for_edk2 Edited March 31, 2018 by Zenith432 1 1 Link to comment Share on other sites More sharing options...
Matgen84 Posted March 31, 2018 Share Posted March 31, 2018 (edited) 56 minutes ago, LuCyr04 said: Any success compiling r4419? Xcode 9.3 and Build_Clover.command Reveal hidden contents Building ... /Users/LuCy/src/edk2/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf [X64] /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c:432:1: error: conflicting types for 'BmRepairAllControllers' BmRepairAllControllers ( ^ /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h:352:1: note: previous declaration is here BmRepairAllControllers ( ^ make: Nothing to be done for `tbuild'. Building ... /Users/LuCy/src/edk2/MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf [X64] make: Nothing to be done for `tbuild'. Building ... /Users/LuCy/src/edk2/ShellPkg/Library/UefiShellLib/UefiShellLib.inf [X64] /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c:580:32: error: use of undeclared identifier 'MAX_RECONNECT_REPAIR' if (ReconnectRepairCount < MAX_RECONNECT_REPAIR) { make: Nothing to be done for `tbuild'. ^ Building ... /Users/LuCy/src/edk2/MdePkg/Library/UefiMemoryLib/UefiMemoryLib.inf [X64] /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c:581:31: error: too many arguments to function call, expected 0, have 1 make: Nothing to be done for `tbuild'. BmRepairAllControllers (ReconnectRepairCount + 1); ~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~ /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h:351:1: note: 'BmRepairAllControllers' declared here VOID ^ /Users/LuCy/src/edk2/MdePkg/Include/Base.h:337:19: note: expanded from macro 'VOID' #define VOID void ^ Building ... /Users/LuCy/src/edk2/Clover/Library/OpensslLib/OpensslLibNull.inf [X64] 3 errors generated. make: *** [/Users/LuCy/src/edk2/Build/Clover/RELEASE_XCODE8/X64/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib/OUTPUT/BmDriverHealth.obj] Error 1 build.py... : error 7000: Failed to execute command make tbuild [/Users/LuCy/src/edk2/Build/Clover/RELEASE_XCODE8/X64/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib] build.py... : error F002: Failed to build module /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf [X64, XCODE8, RELEASE] - Failed - Build end time: 14:28:28, Mar.31 2018 Build total time: 00:00:16 o_Ops, ./ebuild.sh exited with error(s), aborting.. All work fine here with Xcode 9.3: I just replace EDK2 26300--->26764 in Build_Clover.command. Of cause, select Update EDK2 in, the script. Edited March 31, 2018 by Matgen84 1 1 Link to comment Share on other sites More sharing options...
Zenith432 Posted March 31, 2018 Share Posted March 31, 2018 You can update to EDK2 svn r26767 or githib commit 9c7d0d4. I put 26764 in the commit msg because it's the last one that contained a change impacting the patches. 1 Link to comment Share on other sites More sharing options...
Lucy183 Posted March 31, 2018 Share Posted March 31, 2018 17 minutes ago, Zenith432 said: @LuCyr04: update to latest edk2 and reapply Patches_for_edk2 6 minutes ago, Matgen84 said: All work fine here with Xcode 9.3: I just replace EDK2 26300--->26764 in Build_Clover.command. Of cause, select Update EDK2 in, the script. 1 minute ago, Zenith432 said: You can update to EDK2 svn r26767 or githib commit 9c7d0d4. I put 26764 in the commit msg because it's the last one that contained a change impacting the patches. Thanks, compiled fine now. 3 Link to comment Share on other sites More sharing options...
apianti Posted March 31, 2018 Share Posted March 31, 2018 9 hours ago, ReddestDream said: This isn't about updating an already installed system. It's about new USB-based macOS installers based on 10.13.4. Clover isn't detecting the macOS installer on the USB correctly. See here: https://www.insanelymac.com/forum/forums/topic/333560-macos-high-sierra-10134-is-out/?page=2&tab=comments#comment-2606462 I still see no reason why it would not find the default path of every macOS install. It probably just says something different like Boot macOS from macOS or whatever. Also if someone gives a listing of the media, maybe there is new installer path...? Link to comment Share on other sites More sharing options...
chris1111 Posted March 31, 2018 Share Posted March 31, 2018 2 minutes ago, apianti said: I still see no reason why it would not find the default path of every macOS install. It probably just says something different like Boot macOS from macOS or whatever. Also if someone gives a listing of the media, maybe there is new installer path...? Install macOS High Sierra.app (10.13.4) Create Install Media This installer paths "\\.IABootFiles\\boot.efi" is change by Apple Link to comment Share on other sites More sharing options...
apianti Posted March 31, 2018 Share Posted March 31, 2018 Just now, chris1111 said: Install macOS High Sierra.app (10.13.4) Create Install Media This installer paths "\\.IABootFiles\\boot.efi" is change by Apple You proposed adding the default boot path as the installer path...? I can understand that the path changed, if you look in the other thread can you please provide me with that information? I imagine that the installer just moved the file to a new place and a new boot.efi path needs to be added. 1 Link to comment Share on other sites More sharing options...
chris1111 Posted March 31, 2018 Share Posted March 31, 2018 (edited) 36 minutes ago, apianti said: You proposed adding the default boot path as the installer path...? I can understand that the path changed, if you look in the other thread can you please provide me with that information? I imagine that the installer just moved the file to a new place and a new boot.efi path needs to be added. I don't have Installer create for now, Working to other thing sorry but last Night I verifying and the folder .IABootFiles not exist anymore the boot .efi is store now in "\\System\\Library\\CoreServices\\boot.efi" in the Create Install Media USB drive 10.13.4 Edited March 31, 2018 by chris1111 Link to comment Share on other sites More sharing options...
Sherlocks Posted March 31, 2018 Share Posted March 31, 2018 51 minutes ago, apianti said: You proposed adding the default boot path as the installer path...? I can understand that the path changed, if you look in the other thread can you please provide me with that information? I imagine that the installer just moved the file to a new place and a new boot.efi path needs to be added. i'm downloading 10.13.4. i will check 10.13.4's installer path 1 Link to comment Share on other sites More sharing options...
apianti Posted March 31, 2018 Share Posted March 31, 2018 (edited) 18 minutes ago, chris1111 said: I don't have Installer create for now, Working to other thing sorry but last Night I verifying and the folder .IABootFiles not exist anymore the boot .efi is store now in "\\System\\Library\\CoreServices\\boot.efi" in the Create Install Media USB drive 10.13.4 If this file is present then it is detected as a macOS installation, not an installer. That would be the only difference... It would just appear as a different type of entry. Edited March 31, 2018 by apianti 1 Link to comment Share on other sites More sharing options...
Sherlocks Posted March 31, 2018 Share Posted March 31, 2018 3 hours ago, apianti said: If this file is present then it is detected as a macOS installation, not an installer. That would be the only difference... It would just appear as a different type of entry. i finished 10.13.4 installer fix. i will commit for 10.13.4 3 Link to comment Share on other sites More sharing options...
chris1111 Posted March 31, 2018 Share Posted March 31, 2018 (edited) 36 minutes ago, Sherlocks said: i finished 10.13.4 installer fix. i will commit for 10.13.4 Thank you Sherlocks Edited March 31, 2018 by chris1111 Link to comment Share on other sites More sharing options...
apianti Posted March 31, 2018 Share Posted March 31, 2018 1 hour ago, Sherlocks said: i finished 10.13.4 installer fix. i will commit for 10.13.4 Dude - that code is a mess. You need to learn how to use arrays and why you shouldn't hard code indices.... First you could have used a bunch of arrays to hold those strings and iterated through them to set whatever variable. Second how you chose to check whether or not the default path is there, INSIDE the if you could have just returned either the installer type if the .IAPhysicalMedia is present or regular macOS if not. There was no need to expand the installer paths array. Also this shows me that it did indeed just create an entry that was a normal install instead of installer that apparently no one was selecting....? Then, you named the entry "OS X Installer" or something but it probably should be named "macOS Installer" like the previous versions. You can definitely do better... 1 Link to comment Share on other sites More sharing options...
Sherlocks Posted March 31, 2018 Share Posted March 31, 2018 3 minutes ago, apianti said: Dude - that code is a mess. You need to learn how to use arrays and why you shouldn't hard code indices.... First you could have used a bunch of arrays to hold those strings and iterated through them to set whatever variable. Second how you chose to check whether or not the default path is there, INSIDE the if you could have just returned either the installer type if the .IAPhysicalMedia is present or regular macOS if not. There was no need to expand the installer paths array. Also this shows me that it did indeed just create an entry that was a normal install instead of installer that apparently no one was selecting....? Then, you named the entry "OS X Installer" or something but it probably should be named "macOS Installer" like the previous versions. You can definitely do better... you are right. but.. i don't have time. soon i will get test for life i just checked work for 10.13.4 and old macos. now i don't have better code idea. can you improve code? sorry. Link to comment Share on other sites More sharing options...
Recommended Posts