Clover General discussion

[miliuco]

@matxpa

Tried your settings, no success. I can't boot Clover with BlockSkywalk.

Not clear why. I can say same words as @Slice in the above post.

 

[Slice]

Even latest Clover works with BlockSkywalk in QEMU. 

[MakAsus]

macOS 13.6.1 (22G313)
Xcode 14.3.1
Build version 14E300c
Apple clang version 14.0.3 (clang-1403.0.22.14.1)
Target: x86_64-apple-darwin22.6.0
Clover revision: 5156 (master, commit 0eac4088b)
2023-12-08 19:20:23 +0300
0eac4088b1c34cf84d2d7ad29d6cbd95a8d5755b
"Args: -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG -t GCC131 | --cmd-len=50000 -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG --conf=/Users/YitzhakB/src/CloverBootloader/Conf -D USE_LOW_EBDA -a X64 -b RELEASE -t GCC131 -n 21 | OS: 13.6.1"
build all and complete fine.

Bat on  macOS 14.1.2 (23B92)
xcodebuild -version
Xcode 15.0
Build version 15A240d
Clover r5156 (SHA: 0eac4088b)
TOOLCHAIN: GCC131
Python 3.9.6
build.py...
 : error 7000: Failed to execute command
    make tbuild [/Users/yitzhakbronstein/src/CloverBootloader/Build/Clover/RELEASE_GCC131/X64/rEFIt_UEFI/refit]

build.py...
 : error F002: Failed to build module
    /Users/yitzhakbronstein/src/CloverBootloader/rEFIt_UEFI/refit.inf [X64, GCC131, RELEASE]

- Failed -
Build end time: 13:00:58, Dec.09 2023
Build total time: 00:01:06

Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.
Deleting expired sessions...none found.

 

And not works with BlockSkywalk. Boot hang after BootKernelExtensions.kc.

Edited December 9, 2023 by MakAsus

[jsl2000]

On 12/9/2023 at 8:37 AM, jsl2000 said:

Thanks, but replaced with your BOOTX64.efi & CLOVERX64.efi as well as your settings my Z690 hackintosh still got the same hang in early boot of Clover 5157 as before.

One more question did your CPU in X75 have AVX2 instruction codes because ordinary Ivy Bridge's CPU need more to boot Ventura & Sonoma in my case ?

It's very strange that Clover 5156 specific version can boot Sonoma 14.2 in my B85M-G hackintosh with BlockSkywalk enabled and WiFiBCM4352 working too after applied OCLP 1.3.0n.

I'm very glad to confirm that this Clover 5156 version also worked in my Z97 hackintosh too !

Unfortunately it still got hang in early boot in my Z690, Z490, X299 & Z370 hackintoshs as well as Haswell laptop if BlockSkywalk was enabled.

In my FX-6300 hackintosh it got red screen panic if BlockSkywalk quirk was enabled.

Edited December 12, 2023 by jsl2000

[cankiulascmnfye]

4 hours ago, Slice said:

You are right and thank you for the investigation. There are two questions:

1. Why Clover before 16 November works for you and later not? While opencore always work. There is definitely mistake in 32fbf76 commit.

2. Why your working Clover is not working for me and some other users? Hardware dependency?

I see no how these two questions are connected.

 

To 1: I am a user, not a developer. I can't answer that. I can only tell you my experiences: my system boots with BootSkywalk enabled up to Clover r5156 commit bdb7a95d9. And this is the case for most uses who need BlockSkywalk: it works up to November 16th (for some) but definitely for nobody after November 16th.

To 2: The Clover folder I uploaded uses the build from your repo, as compiled by the workflow in its "ACTION" section. It didn't compile it. The only Hardware aspects where I see a possible difference is that  my machine uses an unlocked BIOS (1vyRain) which has CFG-Lock disabled and the Wifi whitelist removed so 3rd Part Wifi/BT cards by Broadcom e.g. can be used.

[Slice]

@jsl2000

Thanks for the confirmation. I also see that my proposition about toolset is wrong. This Clover compiled by gcc131 and OK.

[matxpa]

6 hours ago, Slice said:

@jsl2000

Thanks for the confirmation. I also see that my proposition about toolset is wrong. This Clover compiled by gcc131 and OK.

Hi

 

and with Xcode15 too, if I remember (glad to see that jsl2000 trust it now)

 

Slice could you add a DBG Msg in /.../CloverBootloader/rEFIt_UEFI/refit/main.cpp line 1258 like the lines below

 

    if (gSettings.KernelAndKextPatches.BlockSkywalk) {
        DBG("\t\t--> At Src code line (if) of /.../CloverBootloader/rEFIt_UEFI/refit/main.cpp boolean BlockSkywalk value below is\n"); // to be sur where DBG MSG comes from 
         DBG("\t\t----> KernelAndKextPatches.BlockSkywalk was set to %s\n", gSettings.KernelAndKextPatches.BlockSkywalk ? "TRUE" : "FALSE");

...

 

    }else{

        DBG("\t\t--> At Src code line (else) of /.../CloverBootloader/rEFIt_UEFI/refit/main.cpp boolean BlockSkywalk value below is\n"); // to be sur where DBG MSG comes from 
        DBG("\t\t---> KernelAndKextPatches.BlockSkywalk was set to %s\n", gSettings.KernelAndKextPatches.BlockSkywalk ? "TRUE" : "FALSE");
    }
 

 

 

with commit 0eac408 (last one) Boot Log extracted lines with BlockSkywalk set to FALSE and kexts/14 IOSkywalkFamily.kext Disabled otherwise boot hang immed.

 

0:157  0:044  === [ Starting Clover ] =========================
0:157  0:000  Now is 09.12.2023,  16:26:12 (GMT)
0:157  0:000  Starting Clover revision: 5157 (HEAD, commit 0eac4088b) on American Megatrends EFI
0:157  0:000  Build id: 20231208192023-0eac408-dirty
0:157  0:000  Build with: [Args: -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG -t XCODE15 | --cmd-len=50000 -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG --conf=/Users/meunier/CloverBootloader/Conf -D USE_LOW_EBDA -a X64 -b RELEASE -t XCODE15 -n 5 | OS: 14.1.2]
...

27:312  0:000  Bridge kext to OC : Path=AirPortBrcmNIC.kext
27:312  0:000  info plist path: Kexts\14\IO80211FamilyLegacy.kext\Contents\PlugIns\AirPortBrcmNIC.kext\Contents\Info.plist
27:312  0:000  InfoPlistPath=Kexts\14\IO80211FamilyLegacy.kext\Contents\PlugIns\AirPortBrcmNIC.kext\Contents\Info.plist
27:316  0:004  assign executable as 'Contents\MacOS\AirPortBrcmNIC'
27:316  0:000          --> At Src code line Num 1278 (else) of /.../CloverBootloader/rEFIt_UEFI/refit/main.cpp boolean BlockSkywalk value below is
27:316  0:000          ---> KernelAndKextPatches.BlockSkywalk was set to FALSE
27:321  0:005  Start 'OpenRuntime.efi' : Status Success
27:321  0:000  OC: OcMiscEarlyInit...
27:321  0:000  OC: OpenCore REL-102-2023-12-09 is loading in Optional mode (0/0)...
27:321  0:000  OC: OcMiscMiddleInit...
...

 

 

And then revert repo content to bdb7a95 commit

 

git checkout bdb7a95
git reset --hard bdb7a95

modify ~/CloverBootloader/rEFIt_UEFI/refit/main.cpp line at 1197 (r5157 (bdb7a95) November 12 20h.. commit)
 

Boot Log extracted lines with BlockSkywalk set to TRUE and kexts/14 IOSkywalkFamily.kext

 

0:157  0:044  === [ Starting Clover ] =========================
0:157  0:000  Now is 09.12.2023,  16:44:57 (GMT)
0:157  0:000  Starting Clover revision: 5157 (branch-2, commit bdb7a95d9) on American Megatrends EFI
0:157  0:000  Build id: 20231116221031-bdb7a95-dirty
0:157  0:000  Build with: [Args: -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG -t XCODE15 | --cmd-len=50000 -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG --conf=/Users/meunier/CloverBootloader/Conf -D USE_LOW_EBDA -a X64 -b RELEASE -t XCODE15 -n 5 | OS: 14.1.2]
...

9:391  0:000  AddKextsInArray from 14
9:391  0:000  ->Extra kext: 14\CryptexFixup.kext (v.1.0.3)
9:391  0:000  ->Extra kext: 14\AMFIPass.kext (v.1.4.0)
9:391  0:000  ->Extra kext: 14\IOSkywalkFamily.kext (v.1.0)
9:391  0:000  ->Extra kext: 14\RestrictEvents.kext (v.1.1.4)
9:391  0:000  ->Extra kext: 14\BlueToolFixup.kext (v.2.6.9)
9:391  0:000  ->Extra kext: 14\IO80211FamilyLegacy.kext (v.1200.12.2b1)
9:391  0:000      |-- PlugIn kext: 14\IO80211FamilyLegacy.kext\Contents\PlugIns\AirPortBrcmNIC.kext (v.1400.1.1)
...

9:400  0:000  Bridge kext to OC : Path=IOSkywalkFamily.kext
9:400  0:000  info plist path: Kexts\14\IOSkywalkFamily.kext\Contents\Info.plist
9:400  0:000  InfoPlistPath=Kexts\14\IOSkywalkFamily.kext\Contents\Info.plist
9:405  0:004  assign executable as 'Contents\MacOS\IOSkywalkFamily'
...

9:519  0:000  Bridge kext to OC : Path=AirPortBrcmNIC.kext
9:519  0:000  info plist path: Kexts\14\IO80211FamilyLegacy.kext\Contents\PlugIns\AirPortBrcmNIC.kext\Contents\Info.plist
9:519  0:000  InfoPlistPath=Kexts\14\IO80211FamilyLegacy.kext\Contents\PlugIns\AirPortBrcmNIC.kext\Contents\Info.plist
9:523  0:003  assign executable as 'Contents\MacOS\AirPortBrcmNIC'
9:523  0:000          --> At Src code line Num 1197 (if) of /.../CloverBootloader/rEFIt_UEFI/refit/main.cpp boolean BlockSkywalk value below is
9:523  0:000          ----> KernelAndKextPatches.BlockSkywalk was set to TRUE
9:528  0:005  Start 'OpenRuntime.efi' : Status Success
9:528  0:000  OC: OcMiscEarlyInit...
9:528  0:000  OC: OpenCore REL-102-2023-12-09 is loading in Optional mode (0/0)...
9:528  0:000  OC: OcMiscMiddleInit...
...

 

Regards

 

Edited December 9, 2023 by matxpa

[cankiulascmnfye]

@matxpa If you can provide a compiled build of your merged version, I could test it on my machine.

[datafeedexpert]

On 12/8/2023 at 11:35 PM, matxpa said:

@Slice

 

Hi

Here's what you want and what you need (BOOTX64.efi (and CLOVERX64.efi) after renaming the below efi components) of : 

 

 

r5157_a9b0654 (20231112-03h48) --> Wifi BCM 4360 works    CloverX64_r5157_20231112-03h48_a9b0654_XCODE15_RELEASE_master_local.efi

 

r5157_1914496 (20231116-19h14)   --> Wifi BCM 4360 works    CloverX64_r5157_20231116-19h14_1914496 _XCODE15_RELEASE_master_local..efi

 

r5157_bdb7a95 (20231116-22h10)  --> Wifi BCM 4360 works    CloverX64_r5157_20231116-22h10_bdb7a95_XCODE15_RELEASE_master_local.efi

 

What else ...

      ACPI/DSDT/Fixes           : FixAirport=TRUE

      Devices/FakeID             : WIFI=0x43a014e4

      KernelAndKextPatches : BlockSkywalk = TRUE 

      RtVariables                    : CsrActiveConfig=0x803 (just F.Y.I)

 

     kexts/14                          : AMFIPass.kext, IOSkywalkFamily.kext, IO80211FamilyLegacy.kext and RestrictEvents.kext) --> latest OC or OCLP releases

     kexts/Other                    : (Std kexts) ALC LILU WEG SMC(Virtual and specifics Asus X75VB kexts for RJ45, WebCam, KBD & PAD) --> latest OC or others Dev. releases

     

 

NB in KernelAndKextPatches/KextsToPatch

I don't need (Disabled=YES) the patch from www.applelife.ru (Broadcom 94360 activation AirPort.BrcmNIC)
 

Regards

@matxpa i followed these step but still i unable to boot sonoma , there is early KP , while sonoma boot if i moved IOS family kexts from 14 folder or False = Blockskywalk 

[matxpa]

Just now, cankiulascmnfye said:

@matxpa If you can provide a compiled build of your merged version, I could test it on my machine.

Hi

 

r5156_bdb7a95 with BlockSkywalk set to TRUE and kexts/14 IOSkywalkFamily.kext --> BCM4360 (0x43a014e4) work fine 

Clover X64 r5156_bdb7a95 (20231116-22h10) XCODE15 RELEASE  --> CloverX64_r5156_20231116-22h10_bdb7a95_XCODE15_RELEASE_master_local.efi

 

r5156_0eac408 with BlockSkywalk set to FALSE and kexts/14 IOSkywalkFamily.kext Disabled (in block kexts in Clover submenu before booting on Sonoma (SSD or HD) Device--> BCM4360 cant' work),

if BlockSkywalk stay TRUE and IOSkywalkFamily.kext stay Enabled --> boot hangs (after +/- 10 debug lines in verbose mode)

Clover X64 r5156_0eac408 (20231208-19h20) XCODE15 RELEASE --> CloverX64_r5156_20231208-19h20_0eac408_XCODE15_RELEASE_master_local.efi

 

You have to rename those '.efi' to BOOTX64.efi and CLOVERX64.efi (but you know that)

 

Regards

[matxpa]

33 minutes ago, datafeedexpert said:

@matxpa i followed these step but still i unable to boot sonoma , there is early KP , while sonoma boot if i moved IOS family kexts from 14 folder or False = Blockskywalk 

 

Hi

 

If you use a Clover build with a9b0654 commit to bdb7a95 commit, it could (fingers crossed) work with BlockSkywalk set to TRUE and kexts/(14 or Other) IOSkywalkFamily.kext (and IO80211FamilyLegacy.kext)

but it depends of (what Bios ? SMBios ? config content (DSDT/SSDT patches, KestToLoad patches, quirks, devices list and/or content ?), so it works on some Hardware, not on all (it's not necessary a Hard pbm) 

 

If you use a Clover build with commit 32fbf76 commit (you can't with this commit Clover build fails) to the last one bd45a8c with BlockSkywalk set to TRUE and kexts/(14 or Other) IOSkywalkFamily.kext (and IO80211FamilyLegacy.kext) boot hangs (after +/- 10 debug lines in verbose mode), and with BlockSkywalk set to FALSE and kexts/(14 or Other) IOSkywalkFamily.kext deactivated --> Sonoma boot (without BCM Wifi)

 

So since commit 32fbf76 apple.Skywalk kext blocking as OC does can't be no more done with Clover. (boot stuck with a page allocation pbm)

 

last lines of a PreBoot Log when Sonoma Clover boot hang

...

31:691  0:000  OCABC: Patching safe mode sur-2 at off ACF4
31:691  0:000  OCABC: AllocPages 2 0xC684C000 (512) - Success
31:692  0:000  OCABC: AllocPages 2 0xC684B000 (1) - Success
31:692  0:000  OC: Supported boot capabilities 4
31:693  0:001  OCABC: AllocPages 1 0xC67F4000 (1) - Success
31:694  0:001  OC: Opening file System\Library\Kernels\kernel with 1 mode gave - Not Found
31:694  0:000  OC: Opening file \1B929771-57FB-4FA4-8BC6-DE76BF06BAD1 with 1 mode gave - Success
31:694  0:000  OC: Opening file \1B929771-57FB-4FA4-8BC6-DE76BF06BAD1\System\Library\CoreServices\com.apple.Boot.plist with 1 mode gave - Not Found
31:697  0:002  OC: Opening file Library\Preferences\SystemConfiguration\com.apple.Boot.plist with 1 mode gave - Success
31:698  0:001  OCABC: AllocPages 2 0xFB00000 (71015) - Not Found
31:730  0:031  RestoreConfig called Param1=2
41:757  10:026  OCB: InternalEfiExit C78E2E18 - Aborted / Unsupported
41:757  0:000  StartImage failed : Aborted
 

 

Regards

Edited December 10, 2023 by matxpa

[cankiulascmnfye]

2 hours ago, matxpa said:

Hi

 

r5156_bdb7a95 with BlockSkywalk set to TRUE and kexts/14 IOSkywalkFamily.kext --> BCM4360 (0x43a014e4) work fine 

Clover X64 r5156_bdb7a95 (20231116-22h10) XCODE15 RELEASE  --> CloverX64_r5156_20231116-22h10_bdb7a95_XCODE15_RELEASE_master_local.efi

 

r5156_0eac408 with BlockSkywalk set to FALSE and kexts/14 IOSkywalkFamily.kext Disabled (in block kexts in Clover submenu before booting on Sonoma (SSD or HD) Device--> BCM4360 cant' work),

if BlockSkywalk stay TRUE and IOSkywalkFamily.kext stay Enabled --> boot hangs (after +/- 10 debug lines in verbose mode)

Clover X64 r5156_0eac408 (20231208-19h20) XCODE15 RELEASE --> CloverX64_r5156_20231208-19h20_0eac408_XCODE15_RELEASE_master_local.efi

 

You have to rename those '.efi' to BOOTX64.efi and CLOVERX64.efi (but you know that)

 

Regards

 

Thank you very much!

 

I tested Clover X64 r5156_bdb7a95 (it's detected a r5157, btw) and it boots! Wi-Fi and BT are workig (BCM4352). Awesome 😍

 

Edited December 10, 2023 by cankiulascmnfye

[miliuco]

@matxpa

To add debug info, is it in this way?

 

    if (gSettings.KernelAndKextPatches.BlockSkywalk) {
    
    	// to be sur where DBG MSG comes from 
        DBG("\t\t--> At Src code line (if) of /.../CloverBootloader/rEFIt_UEFI/refit/main.cpp boolean BlockSkywalk value below is\n");
        DBG("\t\t----> KernelAndKextPatches.BlockSkywalk was set to %s\n", gSettings.KernelAndKextPatches.BlockSkywalk ? "TRUE" : "FALSE");
        
        mOpenCoreConfiguration.Kernel.Block.Count = 1;
        mOpenCoreConfiguration.Kernel.Block.AllocCount = 1;
        mOpenCoreConfiguration.Kernel.Block.ValueSize = sizeof(__typeof_am__(**mOpenCoreConfiguration.Kernel.Block.Values));
        valuesSize = mOpenCoreConfiguration.Kernel.Block.AllocCount*sizeof(*mOpenCoreConfiguration.Kernel.Block.Values);
        mOpenCoreConfiguration.Kernel.Block.Values = (OC_KERNEL_BLOCK_ENTRY**)malloc(valuesSize);
        
        // to be sur where DBG MSG comes from 
    	DBG("\t\t--> At Src code line (else) of /.../CloverBootloader/rEFIt_UEFI/refit/main.cpp boolean BlockSkywalk value below is\n");
        DBG("\t\t---> KernelAndKextPatches.BlockSkywalk was set to %s\n", gSettings.KernelAndKextPatches.BlockSkywalk ? "TRUE" : "FALSE");   

 

[matxpa]

27 minutes ago, miliuco said:

@matxpa

To add debug info, is it in this way?

 

    if (gSettings.KernelAndKextPatches.BlockSkywalk) {
    
    	// to be sur where DBG MSG comes from 
        DBG("\t\t--> At Src code line (if) of /.../CloverBootloader/rEFIt_UEFI/refit/main.cpp boolean BlockSkywalk value below is\n");
        DBG("\t\t----> KernelAndKextPatches.BlockSkywalk was set to %s\n", gSettings.KernelAndKextPatches.BlockSkywalk ? "TRUE" : "FALSE");
        
        mOpenCoreConfiguration.Kernel.Block.Count = 1;
        mOpenCoreConfiguration.Kernel.Block.AllocCount = 1;
        mOpenCoreConfiguration.Kernel.Block.ValueSize = sizeof(__typeof_am__(**mOpenCoreConfiguration.Kernel.Block.Values));
        valuesSize = mOpenCoreConfiguration.Kernel.Block.AllocCount*sizeof(*mOpenCoreConfiguration.Kernel.Block.Values);
        mOpenCoreConfiguration.Kernel.Block.Values = (OC_KERNEL_BLOCK_ENTRY**)malloc(valuesSize);
        
        // to be sur where DBG MSG comes from 
    	DBG("\t\t--> At Src code line (else) of /.../CloverBootloader/rEFIt_UEFI/refit/main.cpp boolean BlockSkywalk value below is\n");
        DBG("\t\t---> KernelAndKextPatches.BlockSkywalk was set to %s\n", gSettings.KernelAndKextPatches.BlockSkywalk ? "TRUE" : "FALSE");   

 

Hi 

 

    if (gSettings.KernelAndKextPatches.BlockSkywalk) {
        DBG("\t\t--> At Src code line Num 1197 (if) of /.../CloverBootloader/rEFIt_UEFI/refit/main.cpp boolean BlockSkywalk value below is\n"); // to be sur where DBG MSG comes from 
        DBG("\t\t----> KernelAndKextPatches.BlockSkywalk was set to %s\n", gSettings.KernelAndKextPatches.BlockSkywalk ? "TRUE" : "FALSE");
        mOpenCoreConfiguration.Kernel.Block.Count = 1;
        mOpenCoreConfiguration.Kernel.Block.AllocCount = 1;
        mOpenCoreConfiguration.Kernel.Block.ValueSize = sizeof(__typeof_am__(**mOpenCoreConfiguration.Kernel.Block.Values));
        valuesSize = mOpenCoreConfiguration.Kernel.Block.AllocCount*sizeof(*mOpenCoreConfiguration.Kernel.Block.Values);
        mOpenCoreConfiguration.Kernel.Block.Values = (OC_KERNEL_BLOCK_ENTRY**)malloc(valuesSize);

       

        memset(mOpenCoreConfiguration.Kernel.Block.Values, 0, valuesSize);

 

        mOpenCoreConfiguration.Kernel.Block.Values[0] = (__typeof_am__(*mOpenCoreConfiguration.Kernel.Block.Values))malloc(mOpenCoreConfiguration.Kernel.Block.ValueSize);
          memset(mOpenCoreConfiguration.Kernel.Block.Values[0], 0, mOpenCoreConfiguration.Kernel.Block.ValueSize);
          mOpenCoreConfiguration.Kernel.Block.Values[0]->Enabled = 1;
          OC_STRING_ASSIGN(mOpenCoreConfiguration.Kernel.Block.Values[0]->Arch, OC_BLOB_GET(&mOpenCoreConfiguration.Kernel.Scheme.KernelArch));
          OC_STRING_ASSIGN(mOpenCoreConfiguration.Kernel.Block.Values[0]->Comment, "");
          OC_STRING_ASSIGN(mOpenCoreConfiguration.Kernel.Block.Values[0]->MaxKernel, "");
          OC_STRING_ASSIGN(mOpenCoreConfiguration.Kernel.Block.Values[0]->MinKernel, "23");
          OC_STRING_ASSIGN(mOpenCoreConfiguration.Kernel.Block.Values[0]->Identifier, "com.apple.iokit.IOSkywalkFamily");
          OC_STRING_ASSIGN(mOpenCoreConfiguration.Kernel.Block.Values[0]->Strategy, "Exclude");
    }else{
        DBG("\t\t--> At Src code line Num 1217 (else) of /.../CloverBootloader/rEFIt_UEFI/refit/main.cpp boolean BlockSkywalk value below is\n"); // to be sur where DBG MSG comes from 
        DBG("\t\t---> KernelAndKextPatches.BlockSkywalk was set to %s\n", gSettings.KernelAndKextPatches.BlockSkywalk ? "TRUE" : "FALSE");
    }
 

The 'else' step was added, the first message of twos (below if and else) to be certain that the content of the boolean BlockSkywalk in the second one is correct and what really your choice in config or modified in Clover SubMenu.

 

Change (or remove) the values of Src code line Num in first message (1197 and 1217) went from "main.ccp" of bdb7a95 commit Clover Repo content.

 

Regards 

Edited December 10, 2023 by matxpa

[matxpa]

2 hours ago, cankiulascmnfye said:

 

Thank you very much!

 

I tested Clover X64 r5156_bdb7a95 (it's detected a r5157, btw) and it boots! Wi-Fi and BT are workig (BCM4352). Awesome 😍

 

Hi

 

r5157 yes coz' Slice's r5156 had been released and published so new commits are (a beta) r5157 one.

Cosmetic modifications in buildme, ebuild.sh,  REFIT_MAINMENU_SCREEN.cpp, CloverVersion.cpp and CloverVersion.h and main.cpp (and tools_def.template to trap build errors on Xcode8,14 and 15)

 

Regards

 

Edited December 10, 2023 by matxpa

[cankiulascmnfye]

@matxpa Okay. So are you going to create a pull request so that your fix will be integrated into the main branch?

Edited December 10, 2023 by cankiulascmnfye

[Slice]

10 hours ago, matxpa said:

Hi 

 

    if (gSettings.KernelAndKextPatches.BlockSkywalk) {
        DBG("\t\t--> At Src code line Num 1197 (if) of /.../CloverBootloader/rEFIt_UEFI/refit/main.cpp boolean BlockSkywalk value below is\n"); // to be sur where DBG MSG comes from 
        DBG("\t\t----> KernelAndKextPatches.BlockSkywalk was set to %s\n", gSettings.KernelAndKextPatches.BlockSkywalk ? "TRUE" : "FALSE");
        mOpenCoreConfiguration.Kernel.Block.Count = 1;
        mOpenCoreConfiguration.Kernel.Block.AllocCount = 1;
        mOpenCoreConfiguration.Kernel.Block.ValueSize = sizeof(__typeof_am__(**mOpenCoreConfiguration.Kernel.Block.Values));
        valuesSize = mOpenCoreConfiguration.Kernel.Block.AllocCount*sizeof(*mOpenCoreConfiguration.Kernel.Block.Values);
        mOpenCoreConfiguration.Kernel.Block.Values = (OC_KERNEL_BLOCK_ENTRY**)malloc(valuesSize);

       

        memset(mOpenCoreConfiguration.Kernel.Block.Values, 0, valuesSize);

 

        mOpenCoreConfiguration.Kernel.Block.Values[0] = (__typeof_am__(*mOpenCoreConfiguration.Kernel.Block.Values))malloc(mOpenCoreConfiguration.Kernel.Block.ValueSize);
          memset(mOpenCoreConfiguration.Kernel.Block.Values[0], 0, mOpenCoreConfiguration.Kernel.Block.ValueSize);
          mOpenCoreConfiguration.Kernel.Block.Values[0]->Enabled = 1;
          OC_STRING_ASSIGN(mOpenCoreConfiguration.Kernel.Block.Values[0]->Arch, OC_BLOB_GET(&mOpenCoreConfiguration.Kernel.Scheme.KernelArch));
          OC_STRING_ASSIGN(mOpenCoreConfiguration.Kernel.Block.Values[0]->Comment, "");
          OC_STRING_ASSIGN(mOpenCoreConfiguration.Kernel.Block.Values[0]->MaxKernel, "");
          OC_STRING_ASSIGN(mOpenCoreConfiguration.Kernel.Block.Values[0]->MinKernel, "23");
          OC_STRING_ASSIGN(mOpenCoreConfiguration.Kernel.Block.Values[0]->Identifier, "com.apple.iokit.IOSkywalkFamily");
          OC_STRING_ASSIGN(mOpenCoreConfiguration.Kernel.Block.Values[0]->Strategy, "Exclude");
    }else{
        DBG("\t\t--> At Src code line Num 1217 (else) of /.../CloverBootloader/rEFIt_UEFI/refit/main.cpp boolean BlockSkywalk value below is\n"); // to be sur where DBG MSG comes from 
        DBG("\t\t---> KernelAndKextPatches.BlockSkywalk was set to %s\n", gSettings.KernelAndKextPatches.BlockSkywalk ? "TRUE" : "FALSE");
    }
 

The 'else' step was added, the first message of twos (below if and else) to be certain that the content of the boolean BlockSkywalk in the second one is correct and what really your choice in config or modified in Clover SubMenu.

 

Change (or remove) the values of Src code line Num in first message (1197 and 1217) went from "main.ccp" of bdb7a95 commit Clover Repo content.

 

Regards 

Did I understand correctly that it is not a fix? It is just a message in log.

[matxpa]

2 hours ago, Slice said:

Did I understand correctly that it is not a fix? It is just a message in log.

Hi Slice

 

Yes just a simple message to verify if this (inner if or outer aka. else) code lines are well executed.

Now we are certain that the test code lines are executed, but why correctly executed on a certain kind of Hard (or Soft) and not on others
 

And if you want to add that kind of message, only one could be added just before the 'if' just to get the value of boolean BlockSkywalk.

 

Regards

 

12 hours ago, cankiulascmnfye said:

@matxpa Okay. So are you going to create a pull request so that your fix will be integrated into the main branch?

Hi

 

Which fix, if you talk about the DBG message it's not a fix it's just to get a trace in the boot log.

 

Regards

[Slice]

Hardware dependency came from Memory Map as I see from debug-log

31:698  0:001  OCABC: AllocPages 2 0xFB00000 (71015) - Not Found

There is no problem who has large enough contiguous space in memory. Not me. 

[matxpa]

41 minutes ago, Slice said:

Hardware dependency came from Memory Map as I see from debug-log

31:698  0:001  OCABC: AllocPages 2 0xFB00000 (71015) - Not Found

There is no problem who has large enough contiguous space in memory. Not me. 

 

Preboot Log (last lines)

31:698  0:001  OCABC: AllocPages 2 0xFB00000 (71015) - Not Found
31:730  0:031  RestoreConfig called Param1=2
41:757  10:026  OCB: InternalEfiExit C78E2E18 - Aborted / Unsupported
41:757  0:000  StartImage failed : Aborted                                                                                                                                                                                                                           

 

pwd

/.../CloverBootloader

 

egrep "OCB: InternalEfiExit|OCABC: AllocPages|StartImage failed : " */*/* 2>/dev/null | grep -v "^Binary" 

rEFIt_UEFI/refit/main.cpp:      DBG("StartImage failed : %s\n", efiStrError(Status));

rEFIt_UEFI/refit/main.cpp:      printf("StartImage failed : %s\n", efiStrError(Status));

 

egrep "OCB: InternalEfiExit|OCABC: AllocPages|StartImage failed : " */*/*/* 2>/dev/null | grep -v "^Binary"

OpenCorePkg/Library/OcAfterBootCompatLib/ServiceOverrides.c:  DEBUG ((DEBUG_VERBOSE, "OCABC: AllocPages %u 0x%Lx (%u) - %r\n", Type, *Memory, NumberOfPages, Status));

OpenCorePkg/Library/OcBootManagementLib/ImageLoader.c:  DEBUG ((DEBUG_VERBOSE, "OCB: InternalEfiExit %p - %r / %r\n", ImageHandle, ExitStatus, Status));

 

 

[MakAsus]

I compiled build r5156 commit bd45a8c on macOS Sonoma Version 14.2 (23C64) and Version 15.0.1 (15A507), bat still unable to boot sonoma with BlockSkywalk Quirk enable:
Stuck at [EB.LD.LKC|R.2] <"System\Library\KernelCollections\BootKernelExtensions.kc">

13:900  0:007  ->Extra kext: 14\IOSkywalkFamily.kext (v.1.0)
14:038  0:007  Bridge kext to OC : Path=IOSkywalkFamily.kext
14:047  0:009  info plist path: Kexts\14\IOSkywalkFamily.kext\Contents\Info.plist
14:056  0:009  InfoPlistPath=Kexts\14\IOSkywalkFamily.kext\Contents\Info.plist
14:070  0:013  assign executable as 'Contents\MacOS\IOSkywalkFamily'
25:438  0:039  OCAK: Patching invalid size 2EFF8 with 145E000 for com.apple.iokit.IOSkywalkFamily
25:445  0:007  OCAK: com.apple.iokit.IOSkywalkFamily got KXLD 0 0
25:452  0:007  OCAK: Excluding com.apple.iokit.IOSkywalkFamily - VirtualBase FFFFFF800280E000, MaxSize 40000
25:459  0:007  OCAK: Found kext com.apple.iokit.IOSkywalkFamily (51DC5318) from link 51DC5320 to drop
25:466  0:007  OCAK: Erasing com.apple.iokit.IOSkywalkFamily from prelinked kext under dict index 3, plist 525DA018, plist index 167
25:477  0:010  OC: Prelinked blocker (Exclude) result 0 for com.apple.iokit.IOSkywalkFamily () - Success
25:633  0:007  OCAK: com.apple.iokit.IOSkywalkFamily got KXLD 0 0
25:643  0:010  OCAK: Requesting __LINKEDIT for com.apple.iokit.IOSkywalkFamily - 5643B4D0 at 3BB9000
25:650  0:007  OCAK: Requesting SymbolTable for com.apple.iokit.IOSkywalkFamily - 11261
25:778  0:012  OC: Prelinked injection Kexts\14\IOSkywalkFamily.kext () - Success
26:196  0:010  OCAK: Requesting SymbolTable for com.apple.iokit.IOSkywalkFamily - 10350
 

2023-12-11_13-28_CLOVERX64.EFI.log

[matxpa]

2 hours ago, MakAsus said:

I compiled build r5156 commit bd45a8c on macOS Sonoma Version 14.2 (23C64) and Version 15.0.1 (15A507), bat still unable to boot sonoma with BlockSkywalk Quirk enable:
Stuck at [EB.LD.LKC|R.2] <"System\Library\KernelCollections\BootKernelExtensions.kc">

13:900  0:007  ->Extra kext: 14\IOSkywalkFamily.kext (v.1.0)
14:038  0:007  Bridge kext to OC : Path=IOSkywalkFamily.kext
14:047  0:009  info plist path: Kexts\14\IOSkywalkFamily.kext\Contents\Info.plist
14:056  0:009  InfoPlistPath=Kexts\14\IOSkywalkFamily.kext\Contents\Info.plist
14:070  0:013  assign executable as 'Contents\MacOS\IOSkywalkFamily'
25:438  0:039  OCAK: Patching invalid size 2EFF8 with 145E000 for com.apple.iokit.IOSkywalkFamily
25:445  0:007  OCAK: com.apple.iokit.IOSkywalkFamily got KXLD 0 0
25:452  0:007  OCAK: Excluding com.apple.iokit.IOSkywalkFamily - VirtualBase FFFFFF800280E000, MaxSize 40000
25:459  0:007  OCAK: Found kext com.apple.iokit.IOSkywalkFamily (51DC5318) from link 51DC5320 to drop
25:466  0:007  OCAK: Erasing com.apple.iokit.IOSkywalkFamily from prelinked kext under dict index 3, plist 525DA018, plist index 167
25:477  0:010  OC: Prelinked blocker (Exclude) result 0 for com.apple.iokit.IOSkywalkFamily () - Success
25:633  0:007  OCAK: com.apple.iokit.IOSkywalkFamily got KXLD 0 0
25:643  0:010  OCAK: Requesting __LINKEDIT for com.apple.iokit.IOSkywalkFamily - 5643B4D0 at 3BB9000
25:650  0:007  OCAK: Requesting SymbolTable for com.apple.iokit.IOSkywalkFamily - 11261
25:778  0:012  OC: Prelinked injection Kexts\14\IOSkywalkFamily.kext () - Success
26:196  0:010  OCAK: Requesting SymbolTable for com.apple.iokit.IOSkywalkFamily - 10350
 

2023-12-11_13-28_CLOVERX64.EFI.log 119.17 kB · 1 download

Hi

 

did you try to boot without RtWlanU...  (and Wlan.app)

your Log PCI Devices list shows a BCM4360 (0x43a014e4)

0:104  0:000  PCI (00|07:00.00) : 14E4 43A0 class=028000
0:104  0:000   - WIFI: Vendor= Broadcom
 

RtWlanU... for Realtek chipsets on Wifi Cards or USB Sticks

 

27:038  0:011  OC: Prelinked injection Kexts\14\RtWlanU1827.kext () - Success
...

27:126  0:033  OC: Prelinked injection Kexts\14\RtWlanU.kext () - Success
 

Regards

[MakAsus]

2 hours ago, matxpa said:

Hi

 

did you try to boot without RtWlanU...  (and Wlan.app)

your Log PCI Devices list shows a BCM4360 (0x43a014e4)

0:104  0:000  PCI (00|07:00.00) : 14E4 43A0 class=028000
0:104  0:000   - WIFI: Vendor= Broadcom
 

RtWlanU... for Realtek chipsets on Wifi Cards or USB Sticks

 

27:038  0:011  OC: Prelinked injection Kexts\14\RtWlanU1827.kext () - Success
...

27:126  0:033  OC: Prelinked injection Kexts\14\RtWlanU.kext () - Success
 

Regards

Both cards work properly with OC 0.9.6 and do not interfere with each other, but I tried moving them to the Kexts\off\ folder from which they are not injected and the result is the same.
14:255  0:007  ->Extra kext: 14\IOSkywalkFamily.kext (v.1.0)
14:393  0:007  Bridge kext to OC : Path=IOSkywalkFamily.kext
14:402  0:009  info plist path: Kexts\14\IOSkywalkFamily.kext\Contents\Info.plist
14:412  0:010  InfoPlistPath=Kexts\14\IOSkywalkFamily.kext\Contents\Info.plist
14:427  0:014  assign executable as 'Contents\MacOS\IOSkywalkFamily'
26:303  0:043  OCAK: Patching invalid size 2EFF8 with 145E000 for com.apple.iokit.IOSkywalkFamily
26:312  0:009  OCAK: com.apple.iokit.IOSkywalkFamily got KXLD 0 0
26:320  0:007  OCAK: Excluding com.apple.iokit.IOSkywalkFamily - VirtualBase FFFFFF800280E000, MaxSize 40000
26:328  0:008  OCAK: Found kext com.apple.iokit.IOSkywalkFamily (58E54898) from link 58E548A0 to drop
26:336  0:007  OCAK: Erasing com.apple.iokit.IOSkywalkFamily from prelinked kext under dict index 3, plist 5966A498, plist index 167
26:347  0:010  OC: Prelinked blocker (Exclude) result 0 for com.apple.iokit.IOSkywalkFamily () - Success
26:514  0:007  OCAK: com.apple.iokit.IOSkywalkFamily got KXLD 0 0
26:522  0:007  OCAK: Requesting __LINKEDIT for com.apple.iokit.IOSkywalkFamily - 5740A4D0 at 3BB7000
26:533  0:010  OCAK: Requesting SymbolTable for com.apple.iokit.IOSkywalkFamily - 11261
26:667  0:012  OC: Prelinked injection Kexts\14\IOSkywalkFamily.kext () - Success
27:117  0:011  OCAK: Requesting SymbolTable for com.apple.iokit.IOSkywalkFamily - 10350

2023-12-11_17-34_CLOVERX64.EFI.log

Edited December 11, 2023 by MakAsus

[cankiulascmnfye]

Feedback on commit https://github.com/CloverHackyColor/CloverBootloader/commit/5817644aa00228c74dbf873a43e6cff7e49ca288

 

Does not work (BlockSkywalk)

[Matgen84]

Hi @Slice

 

I can't build commit 5817544aa. 🥲 Since few years, I delete Build directory before building Clover (no problem). Since few month, I'm using XCODE14 Toolchain (no problem)

Strangely, Build/XCODE8 is create before crash. See error message below. Please..

 

Note: Merge commit 8c86c0e for OpencorePKG is empty on GitHub repo !

 

Spoiler

TOOLCHAIN_DIR: /Users/mathieu/src/opt/local
MTOC_PREFIX: /Users/mathieu/src/opt/local/bin/
NASM_PREFIX: /Users/mathieu/src/opt/local/bin/
NASM_VER: 2.16.01
Initializing workspace
recreate Conf folder
WORKSPACE: /Users/mathieu/src/Cloverbootloader
EDK_TOOLS_PATH: /Users/mathieu/src/Cloverbootloader/BaseTools
CONF_PATH: /Users/mathieu/src/Cloverbootloader/Conf
Copying $EDK_TOOLS_PATH/Conf/build_rule.template
     to /Users/mathieu/src/Cloverbootloader/Conf/build_rule.txt
Copying $EDK_TOOLS_PATH/Conf/tools_def.template
     to /Users/mathieu/src/Cloverbootloader/Conf/tools_def.txt
Copying $EDK_TOOLS_PATH/Conf/target.template
     to /Users/mathieu/src/Cloverbootloader/Conf/target.txt
Build environment: macOS-12.7.1-x86_64-i386-64bit
Build start time: 09:30:02, Dec.13 2023

WORKSPACE        = /Users/mathieu/src/Cloverbootloader
EDK_TOOLS_PATH   = /Users/mathieu/src/Cloverbootloader/BaseTools
CONF_PATH        = /Users/mathieu/src/Cloverbootloader/Conf
PYTHON_COMMAND   = python3

Processing meta-data ... done!

build.py...
 : error C0DE: Unknown fatal error when processing [/Users/mathieu/src/Cloverbootloader/OpenCorePkg/Library/OcDebugLogLibOc2Clover/OcDebugLogLibOc2Clover.inf [X64, XCODE8, RELEASE]]
    
(Please send email to devel@edk2.groups.io for help, attaching following call stack trace!)

(Python 3.12.0 on darwin) Traceback (most recent call last):
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 1388, in _BuildPa
    RemoveDirectory(AutoGenObject.BuildDir, True)
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/Source/Python/Common/Misc.py", line 443, in RemoveDirectory
    os.rmdir(Directory)
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/Source/Python/Common/LongFilePathOs.py", line 33, in rmdir
    return os.rmdir(LongFilePath(path))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 66] Directory not empty: '/Users/mathieu/src/Cloverbootloader/Build/Clover/RELEASE_XCODE8'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 2695, in Main
    MyBuild.Launch()
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 2488, in Launch
    self._BuildPlatform()
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 1823, in _BuildPlatform
    self._BuildPa(self.Target, Pa, FfsCommand=CmdListDict,PcdMaList=PcdMaList)
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 1389, in _BuildPa
    except WindowsError as X:
           ^^^^^^^^^^^^
NameError: name 'WindowsError' is not defined

- Failed -

 

 

Screenshot

 

Spoiler

 

Edited December 13, 2023 by Matgen84