Jump to content

Clover General discussion

ErmaC

By ErmaC,
in Clover

 Share
30,171 posts in this topic

Recommended Posts

Slice
Slice
Posted
Posted
3 hours ago, chris1111 said:

is this something to change at the level of the AppleALC injection? Doesn't work here anymore

HP Prodesk 600 G1 and it worked fine before alcid=11

No changes.

  • Like 1
Link to comment
Share on other sites
LAbyOne
LAbyOne
Posted
Posted (edited)
20 hours ago, Slice said:

Built in Ventura using gcc-13.1.0

Few changes and clean Build folder.

 

working fine indeed

if this become default, you should also modify into buildme 

./build_gcc12.sh
->
./build_gcc13.sh

 

Also rolled back to Xcode 14.2 and all build fine again.

Thanks for the hint.

 

In the mean while 14.3.1 came to surface.... this time i will wait a little longer before update

Edited by LAbyOne
  • Like 1
Link to comment
Share on other sites
Slice
Slice
Posted
Posted
4 hours ago, LAbyOne said:

working fine indeed

if this become default, you should also modify into buildme 

./build_gcc12.sh
->
./build_gcc13.sh

 

Done.

  • Like 1
Link to comment
Share on other sites
fabiosun
fabiosun
Posted
Posted (edited)
16 hours ago, Slice said:

What is AM5 platform and why the Clover is 5149?

AMD consumer platform

Cpu 7XXX series...

Clover 5149 and latest 5152 have the same behavior 

you have to read open core PR posted above to understand

FYI solution for Opencore (and AMD AM5 users) was an idea born from Clover boot loader code..ask @Shaneeefor additional informations

image.thumb.png.712f9c1956b584f0b2f74e7869c248d2.png

Edited by mariosun
added macOS Sonoma and Clover R5152
  • Like 1
Link to comment
Share on other sites
Anto65
Anto65
Posted
Posted (edited)

Hi @Slice what is the trick to make the Sonoma icon appear ? Clover revision: 5152 (master, commit 5a6e6e363)

 

screenshot0.thumb.png.43d4fb671a53838b30f41de02f465d4c.png

 

1248749842_Screenshot2023-06-09alle21_06_13.png.77238c0c103206f81c4c6b3c58f11a2d.png

 

Edit : Fixed for now by naming the os_sonoma icon to os_unkown 🙃

 

916046004_Screenshot2023-06-09alle21_26_29.png.197edc7023ec6e844facb05cfd8fe4ea.png

 

 


 

Edited by antuneddu
  • Like 2
Link to comment
Share on other sites
fabiosun
fabiosun
Posted
Posted
10 hours ago, Slice said:

Did you try Clover setting

BusSpeedkHz = 100000

?

Or some nearest values?

For example 4500000/44 = 102273

 

Yes, it doesn't work

 

to solve in Opencore they changed this code:

image.thumb.png.12664d8adfb8f449eadf8338e01dcf11.png

 

with this one:

image.thumb.png.e1d64343d579643768f7325498764345.png

 

And now audio is perfect with no glitch and always in synch

Thank you for your attention

Link to comment
Share on other sites
Slice
Slice
Posted
Posted
32 minutes ago, mariosun said:

Yes, it doesn't work

 

to solve in Opencore they changed this code:

image.thumb.png.12664d8adfb8f449eadf8338e01dcf11.png

 

with this one:

image.thumb.png.e1d64343d579643768f7325498764345.png

 

And now audio is perfect with no glitch and always in synch

Thank you for your attention

This is not a trick. busFreqValue remains the same. busFCvtn2tValue will not used anywhere.

10 hours ago, antuneddu said:

Hi @Slice what is the trick to make the Sonoma icon appear ? Clover revision: 5152 (master, commit 5a6e6e363)

 

screenshot0.thumb.png.43d4fb671a53838b30f41de02f465d4c.png

 

1248749842_Screenshot2023-06-09alle21_06_13.png.77238c0c103206f81c4c6b3c58f11a2d.png

 

Edit : Fixed for now by naming the os_sonoma icon to os_unkown 🙃

 

916046004_Screenshot2023-06-09alle21_26_29.png.197edc7023ec6e844facb05cfd8fe4ea.png

 

 


 

Sorry I forgot to implement new icon name.

Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted

Hi @Slice Thanks for your great job. I test last commit but Sonoma icon (png) doen't be detected !

 

Loader.cpp

 

Spoiler

XStringW OSIconName;

if (OSVersion.isEmpty()) {

OSIconName = L"mac"_XSW;

} else if (OSVersion.elementAt(0) == 14 ){

// Ventura.                                                       <----- Sonoma instead of Ventura ?

OSIconName = L"sonoma,mac"_XSW;

} else if (OSVersion.elementAt(0) == 13 ){

// Ventura

OSIconName = L"ventura,mac"_XSW;


 

XIcon.cpp file : no Sonoma entry

Spoiler

//other oses will be added below

"os_bigsur", //53 == ICON_BIGSUR

"os_monterey", //54 == ICON_MONTEREY

"os_ventura", //55 == ICON_VENTURA

""

};

const INTN IconsNamesSize = sizeof(IconsNames) / sizeof(IconsNames[0]);

 

Link to comment
Share on other sites
fabiosun
fabiosun
Posted
Posted (edited)
5 hours ago, Slice said:
5 hours ago, mariosun said:

Expand  

This is not a trick. busFreqValue remains the same. busFCvtn2tValue will not used anywhere.

So this method/patch is not possible to apply in clover bootloader?

because it could be useful also for other AMD cpu with an integrated igpu 

Edited by mariosun
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
17 minutes ago, chris1111 said:

@Slice complete Sonoma Icon Done Thanks B)

 


@chris1111 can't build last commit df8fd2 !
 

Spoiler

Copying $EDK_TOOLS_PATH/Conf/target.template
     to /Users/mathieu/src/Cloverbootloader/Conf/target.txt
Build environment: macOS-12.6.6-x86_64-i386-64bit
Build start time: 16:14:58, Jun.10 2023

WORKSPACE        = /Users/mathieu/src/Cloverbootloader
EDK_TOOLS_PATH   = /Users/mathieu/src/Cloverbootloader/BaseTools
CONF_PATH        = /Users/mathieu/src/Cloverbootloader/Conf
PYTHON_COMMAND   = python3

Processing meta-data ... done!


build.py...
 : error C0DE: Unknown fatal error when processing [/Users/mathieu/src/Cloverbootloader/OpenCorePkg/Library/OcDebugLogLibOc2Clover/OcDebugLogLibOc2Clover.inf [X64, XCODE8, RELEASE]]
    
(Please send email to devel@edk2.groups.io for help, attaching following call stack trace!)

(Python 3.11.2 on darwin) Traceback (most recent call last):
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 1388, in _BuildPa
    RemoveDirectory(AutoGenObject.BuildDir, True)
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/Source/Python/Common/Misc.py", line 439, in RemoveDirectory
    RemoveDirectory(File, Recursively)
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/Source/Python/Common/Misc.py", line 443, in RemoveDirectory
    os.rmdir(Directory)
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/Source/Python/Common/LongFilePathOs.py", line 33, in rmdir
    return os.rmdir(LongFilePath(path))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 66] Directory not empty: 'X64'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 2695, in Main
    MyBuild.Launch()
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 2488, in Launch
    self._BuildPlatform()
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 1823, in _BuildPlatform
    self._BuildPa(self.Target, Pa, FfsCommand=CmdListDict,PcdMaList=PcdMaList)
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 1389, in _BuildPa
    except WindowsError as X:
           ^^^^^^^^^^^^
NameError: name 'WindowsError' is not defined


- Failed -
 

 

Link to comment
Share on other sites
chris1111
chris1111
Posted
Posted
12 minutes ago, Matgen84 said:


@chris1111 can't build last commit df8fd2 !
 

  Reveal hidden contents

 

The build is not complete Wait for completed

 See

 

Screenshot 2023-06-10 at 10.32.33.png

 

 

  • Thanks 1
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
10 minutes ago, chris1111 said:

The build is not complete Wait for completed

 See

 

Screenshot 2023-06-10 at 10.32.33.png

 

 

 

Thanks. "Some checks haven’t completed yet" if I click Orange dot. But if I git clone a new repo before the task end, I can build with no issue. Strange, I don't understand why.

Now checking is finished. I can build from my previous repo. 

  • Like 1
Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...