Jump to content

Clover General discussion

ErmaC

By ErmaC,
in Clover

 Share
30,171 posts in this topic

Recommended Posts

Matgen84
Matgen84
Posted
Posted
1 minute ago, Jief_Machak said:

Sorry, my bad. The problem is with the plist of the theme. Could you send me a zip of the theme, preferably with the problem.

cd OpencorePkg

git checkout master

git fetch

git pull

cd ..

 

 

Thanks ^_^

What do you think about:
 

In the GitHub repo, CloverHackycolor/Cloverbootloader/Opencorepkg ---->   commit   444a41b15eee65123be0b47b2f4813c6b11a0520

In the GitHub repo, CloverHackycolor/Opencorepkg ---->  commit    2378f2b5ee97ed31333d49881620af447e2b3095

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
4 minutes ago, Matgen84 said:

 

Thanks ^_^

What do you think about:
 

 

In the GitHub repo, CloverHackycolor/Cloverbootloader/Opencorepkg ---->   commit   444a41b15eee65123be0b47b2f4813c6b11a0520

In the GitHub repo, CloverHackycolor/Opencorepkg ---->  commit    2378f2b5ee97ed31333d49881620af447e2b3095

Yes, it was forgotten to commit in Clover the fact that there is a new commit in OpenCorePkg.

done.

Thanks for reporting.

Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted (edited)
51 minutes ago, Jief_Machak said:

Yes, it was forgotten to commit in Clover the fact that there is a new commit in OpenCorePkg.

done.

Thanks for reporting.


Thanks.
Few days ago, I've a discussion about this.
Is it possible to automate to commit in Clover the fact that there is a new commit in OpenCorePkg !

EDIT 1: now this (sorry, maybe, I am a little bit stupid)

  

Entering 'OpenCorePkg'
HEAD is now at 2378f2b5 CpuScan delegated to Clover
HEAD is now at afa09ccb4 OpenCorePkg new commit.
iMac-de-Mathieu:opencorepkg mathieu$ git checkout master
Previous HEAD position was 2378f2b5 CpuScan delegated to Clover
Switched to branch 'master'
Your branch is behind 'origin/master' by 2 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)
iMac-de-Mathieu:opencorepkg mathieu$ git fetch
iMac-de-Mathieu:opencorepkg mathieu$ git pull
Updating 77af4483..2378f2b5
Fast-forward
 Include/Intel/IndustryStandard/ProcessorInfo.h | 4 ++--
 Library/OcCpuLib/AppleCpuSupport.c             | 8 ++++----
 Platform/OpenCore/OpenCore.c                   | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

EDIT 2: Normally, I use BuildMe script, menu option 13

  

updateResetClover() {
echo "[UPDATE RESET CLOVER]"
cd "${CLOVERROOT}"
if [[ -d .git ]]; then
  git fetch --all --recurse-submodules
  git submodule foreach --recursive git clean -d -f -f
  git clean -d -f -f
  git submodule foreach --recursive git reset --hard origin/master
  git reset --hard origin/master
  git pull --recurse-submodules origin master
else
  echo "Error: this is not a git repository, can't update!"
fi
}

 

Edited by Matgen84
Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
1 hour ago, Slice said:

Some more lines

 

2021-4-23_15-35_CLOVERX64.EFI.log.zip 9.59 kB · 1 download

Are we facing a compiler problem ?

Because from your log, StrToGuidLE is called with a null value, from that line  

EFI_STATUS Status = StrToGuidLE(Smbios.SmUUID, uuid);

in settings.cpp from method  

const XString8& SETTINGS_DATA::getUUID(EFI_GUID *uuid)

but Smbios.SmUUID cannot be null : it's not a pointer.

 

Could you try this : CloverX64-2021-04-23-20-04-58-afa09cc-dirty-jief-gcc.zip it's a gcc compilation, and, if it panic, this : CloverX64-2021-04-23-20-04-58-afa09cc-dirty-jief-xcode.zip   ?

 

Thanks.

 

Link to comment
Share on other sites
Slice
Slice
Posted
Posted
2 hours ago, Jief_Machak said:

Are we facing a compiler problem ?

Because from your log, StrToGuidLE is called with a null value, from that line  


EFI_STATUS Status = StrToGuidLE(Smbios.SmUUID, uuid);

in settings.cpp from method  


const XString8& SETTINGS_DATA::getUUID(EFI_GUID *uuid)

but Smbios.SmUUID cannot be null : it's not a pointer.

 

Could you try this : CloverX64-2021-04-23-20-04-58-afa09cc-dirty-jief-gcc.zip it's a gcc compilation, and, if it panic, this : CloverX64-2021-04-23-20-04-58-afa09cc-dirty-jief-xcode.zip   ?

 

Thanks.

 

Both are not working. CPU stops or infinite loop.

But there is something new before start

IMG_0532.jpeg

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
58 minutes ago, MifJpn said:

Follwing is what I understand.
Reference:　https://www.w3.org/TR/xml/
<true></true> = <true/>
The end of "Tags for empty element" is "/>".
Therefore, the space before ”/>” is probably acceptable.

 

It seems to be arbitrary in XML whether to put a space before />, but in W3C, as follows
https://www.w3.org/TR/xhtml1/#guidelines
It seems that it is supposed to put a space.


Thank you.

Could you send me the theme you were using when that panic happened ?

1 hour ago, Slice said:

Both are not working. CPU stops or infinite loop.

But there is something new before start

IMG_0532.jpeg

Both not working : should not be a compiler issue.

Could you send a debug log, if you have one ?

What I don't understand is why I can't reproduce that here with your config.plist...

 

Yes, for now I display all errors and warnings from config.plist. That'll push people to correct them ! ;)

 

Could you reproduce that in Qemu ?

Link to comment
Share on other sites
Slice
Slice
Posted
Posted
8 hours ago, Jief_Machak said:

Could you send me the theme you were using when that panic happened ?

Both not working : should not be a compiler issue.

Could you send a debug log, if you have one ?

What I don't understand is why I can't reproduce that here with your config.plist...

 

Yes, for now I display all errors and warnings from config.plist. That'll push people to correct them ! ;)

 

Could you reproduce that in Qemu ?

Yes, reproduced in Qemu. First one (gcc compilation) 

custom properties for device 00:01.00 injected
custom properties for device 00:03.00 injected
custom properties for device 00:1D.00 injected
 RCBA disabled; cannot use it
stringlength = 1620
CurrentMode: Width=1024 Height=768
SetVariablesForOSX -> Enter
SetVariablesForOSX -> getUUID
getUUID -> 0
getUUID -> 3
StrToGuidLE -> 0
StrToGuidLE -> 1  0
getUUID -> 4
SmUUID() is not valid
A fatal error happened. System halted.

This is my old qemu with old img.

config.plist.zip

I also can't reproduce how can you create such binaries :rofl:

Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
15 hours ago, Matgen84 said:


Thanks.
Few days ago, I've a discussion about this.
Is it possible to automate to commit in Clover the fact that there is a new commit in OpenCorePkg !

EDIT 1: now this (sorry, maybe, I am a little bit stupid)

  


Entering 'OpenCorePkg'
HEAD is now at 2378f2b5 CpuScan delegated to Clover
HEAD is now at afa09ccb4 OpenCorePkg new commit.

iMac-de-Mathieu:opencorepkg mathieu$ git checkout master
Previous HEAD position was 2378f2b5 CpuScan delegated to Clover
Switched to branch 'master'
Your branch is behind 'origin/master' by 2 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)
iMac-de-Mathieu:opencorepkg mathieu$ git fetch
iMac-de-Mathieu:opencorepkg mathieu$ git pull
Updating 77af4483..2378f2b5
Fast-forward
 Include/Intel/IndustryStandard/ProcessorInfo.h | 4 ++--
 Library/OcCpuLib/AppleCpuSupport.c             | 8 ++++----
 Platform/OpenCore/OpenCore.c                   | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

EDIT 2: Normally, I use BuildMe script, menu option 13

  


updateResetClover() {
echo "[UPDATE RESET CLOVER]"
cd "${CLOVERROOT}"
if [[ -d .git ]]; then
  git fetch --all --recurse-submodules
  git submodule foreach --recursive git clean -d -f -f
  git clean -d -f -f
  git submodule foreach --recursive git reset --hard origin/master
  git reset --hard origin/master
  git pull --recurse-submodules origin master
else
  echo "Error: this is not a git repository, can't update!"
fi
}

 


Hi @Jief_Machak I know that you're busy at this moment, but if you've few minutes to take look to my comment posted 15 hours ago. Please. It would be great
 

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
3 minutes ago, Matgen84 said:

Is it possible to automate to commit in Clover

Not sure we want to automate commits. But sure, we could put a warning in ebuild.sh, for example...

 

4 minutes ago, Matgen84 said:

git fetch --all --recurse-submodules git submodule foreach --recursive git clean -d -f -f git clean -d -f -f git submodule foreach --recursive git reset --hard origin/master git reset --hard origin/master git pull --recurse-submodules origin master

We probably should add a git checkout master somewhere here to always pull the right OpencorePkg version that goes with the current Clover commit.

It's not the same thing as automating commits...

And to test that, I've either to setup test repositories, or wait for the next OpencorePkg commit. I will do something, but not top of the list at the moment.

Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
1 hour ago, Jief_Machak said:

Not sure we want to automate commits. But sure, we could put a warning in ebuild.sh, for example...

 

We probably should add a git checkout master somewhere here to always pull the right OpencorePkg version that goes with the current Clover commit.

It's not the same thing as automating commits...

And to test that, I've either to setup test repositories, or wait for the next OpencorePkg commit. I will do something, but not top of the list at the moment.

 

Thanks @Jief_Machak. That would be good indeed: "add a git checkout master somewhere here to always pull the right OpencorePkg version that goes with the current Clover commit." You're right, also: "not top of the list at the moment".

Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
13 hours ago, MifJpn said:

Follwing is what I understand.
Reference:　https://www.w3.org/TR/xml/
<true></true> = <true/>
The end of "Tags for empty element" is "/>".
Therefore, the space before ”/>” is probably acceptable.

 

It seems to be arbitrary in XML whether to put a space before />, but in W3C, as follows
https://www.w3.org/TR/xhtml1/#guidelines
It seems that it is supposed to put a space.


Thank you.


Hi Bro @MifJpn Just my opinion, there is a bug with PlistEdPlus since 1.0.50: the version introduce a space before "/>". I've got no issues with BBedit, PlisEdit Pro or SublimeText (no space).
The W3C guideLines for HTML, if I understand well: 'For empty element, also, use the minimized tag syntax for empty elements, e.g. <br />, as the alternative syntax <br></br> allowed by XML gives uncertain results in many existing user agents.' It's only for web HTML pages.

Clover sample.plist or Opencore config.plist don't use the space before ”/>” ^_^

  • Thanks 1
Link to comment
Share on other sites
arcade33
arcade33
Posted
Posted 
For me hd 4400 (Intel (R) Core (TM) i7-4510U CPU @ 2.00GHz) laptop does not work properly with clover 5133
the ram is at 5 MB and not full QE / CI

work perfectly with HD 4000 

Thank for your hard work

  • Like 1
Link to comment
Share on other sites
arcade33
arcade33
Posted
Posted
15 minutes ago, arcade33 said: 

For me hd 4400 (Intel (R) Core (TM) i7-4510U CPU @ 2.00GHz) laptop does not work properly with clover 5133
the ram is at 5 MB and not full QE / CI

HD 4400 work perfectly with clover 5132 

5133 work perfectly with HD 4000 

Thank for your hard work

 

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
2 hours ago, naiclub said:

What happened?

ภาพถ่ายหน้าจอ 2564-04-24 เวลา 03.06.40.png

Maybe you cloned a repo without getting the submodule.

May I suggest, as Clover is a collective effort, that you dig a little more before posting. At least check if the file is there or not when something tells you that a file is missing.

So, /Users/baby/CloverBootloader/OpenCorePkg/Application/ControlMsrE2/ControlMsrE2.inf exists, or not ?

Here it compiles fine.

@Slice @MifJpn I fixed the bug you found.

Everyone, please try this versionCloverX64-2021-04-24-16-05-00-afa09cc-dirty-jief.zip. 

If it works, I'll be able to finally commit this version.

  • Like 3
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted (edited)
1 hour ago, Jief_Machak said:

 

@Slice @MifJpn I fixed the bug you found.

Everyone, please try this versionCloverX64-2021-04-24-16-05-00-afa09cc-dirty-jief.zip. 

If it works, I'll be able to finally commit this version.

 

 @Jief_Machak I took the test just in case. (Z390 config Big Sur 11.4 Beta 1).

 

First test: press F11 3 times

I can't boot Big Sur: stuck at ACMRM-S: _saveAll: pushing 

No debug.log generated :cry:

Second test: press F11 3 times

I can't boot: panic, but debug.log generated 

 

Spoiler

image.thumb.png.0c6130bba659dd2fa89d3e5de2b1fd93.png

 

Third test: with keepsyms, debug=0x100
Boot with black screen :cry:

I don't understand this in debug.log.  Now is 24/04/2021

=== [ Starting Clover ] =========================
Now is 22.04.2021,  11:13:24 (GMT)

 

 

2021-4-22_11-13_CloverX64-2021-04-24-16-05-00-afa09cc-dirty-jief.efi.log

2021-4-22_11-13_CloverX64-2021-04-24-16-05-00-afa09cc-dirty-jief.efi-Third-Test.log

Edited by Matgen84
Link to comment
Share on other sites
Slice
Slice
Posted
Posted
4 hours ago, naiclub said:

What happened?

ภาพถ่ายหน้าจอ 2564-04-24 เวลา 03.06.40.png

cd OpenCorePkg

git checkout master

git pull

cd ..

1 hour ago, Jief_Machak said:

Maybe you cloned a repo without getting the submodule.

May I suggest, as Clover is a collective effort, that you dig a little more before posting. At least check if the file is there or not when something tells you that a file is missing.

So, /Users/baby/CloverBootloader/OpenCorePkg/Application/ControlMsrE2/ControlMsrE2.inf exists, or not ?

Here it compiles fine.

@Slice @MifJpn I fixed the bug you found.

Everyone, please try this versionCloverX64-2021-04-24-16-05-00-afa09cc-dirty-jief.zip. 

If it works, I'll be able to finally commit this version.

yes, fixed 

custom properties for device 00:1D.00 injected
 RCBA disabled; cannot use it
stringlength = 1620
CurrentMode: Width=1024 Height=768
SetNvramVariable (system-id, guid, 0x2, 16): -> writing new (Success)
SetNvramVariable (ROM, guid, 0x6, 6): -> writing new (Success)
SetNvramVariable (FirmwareFeatures, guid, 0x6, 4): -> writing new (Success)
AddNvramVariable (FirmwareFeaturesMask, guid, 0x6, 4): -> writing new (Success)
AddNvramVariable (HW_BID, guid, 0x6, 0): -> writing new (Not Found)
AddNvramVariable (security-mode, guid, 0x7, 5): -> already exists, abort
SetNvramVariable (platform-uuid, guid, 0x7, 16): -> writing new (Success)
set DefaultBackgroundColor=0x0
SetNvramVariable (DefaultBackgroundColor, guid, 0x7, 4): -> writing new (Success)
SetNvramVariable (ActualDensity, guid, 0x7, 2): -> writing new (Success)

and so on. The system started.

  • Thanks 1
Link to comment
Share on other sites
Slice
Slice
Posted
Posted
15 minutes ago, MifJpn said:

First do not halt.

And The following display has appeared.

IMG20210424225404.thumb.jpg.eba77e457d8925cbba710074cf4b2fd8.jpg

Since it is a syntactic error display, I think it is as spec.

The settings are not specified properly. Then I selected the Big Sur entry. And it stopped at the following display.

IMG20210424225449.thumb.jpg.f316e347d664da8012439a297b45186a.jpg

I tried it twice, but no log was output.

I will send the EFI as is for confirmation.
Not-Halt-EFI242317.zip
I will try working with config.plist, which should work next. Please wait for a while.

It looks like wrong SMBIOS.

Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted (edited)
1 hour ago, Matgen84 said:

 

 @Jief_Machak I took the test just in case. (Z390 config Big Sur 11.4 Beta 1).

 

First test: press F11 3 times

I can't boot Big Sur: stuck at ACMRM-S: _saveAll: pushing 

No debug.log generated :cry:

Second test: press F11 3 times

I can't boot: panic, but debug.log generated 

 

  Reveal hidden contents

image.thumb.png.0c6130bba659dd2fa89d3e5de2b1fd93.png

 

Third test: with keepsyms, debug=0x100
Boot with black screen :cry:

I don't understand this in debug.log.  Now is 24/04/2021

=== [ Starting Clover ] =========================
Now is 22.04.2021,  11:13:24 (GMT)

 

 

2021-4-22_11-13_CloverX64-2021-04-24-16-05-00-afa09cc-dirty-jief.efi.log 73.52 kB · 1 download

2021-4-22_11-13_CloverX64-2021-04-24-16-05-00-afa09cc-dirty-jief.efi-Third-Test.log 42.18 kB · 0 downloads


Forth test: F11 3 times, boot-args keepsyms, debug=0x100

Boot fine Big Sur + can't wake up

 

Fifth test: only F11 3 times

Boot fine Big Sur + can't wake up

 

Why this strange behavior ! :whistle:

 

Forth 2021-4-22_11-13_CloverX64-2021-04-24-16-05-00-afa09cc-dirty-jief.efi.log

Edited by Matgen84
Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...