Jump to content

Clover General discussion

ErmaC

By ErmaC,
in Clover

 Share
30,171 posts in this topic

Recommended Posts

maclinuxG4
maclinuxG4
Posted
Posted

/Users/Desktop/CloverBootloader/rEFIt_UEFI/cpp_unit_test/MacOsVersion_test.cpp: In function 'BOOLEAN IsOSValid_OLD(const XString8&, const XString8&)':
/Users/Desktop/CloverBootloader/rEFIt_UEFI/cpp_unit_test/MacOsVersion_test.cpp:78:21: error: 'XStringArray_<XString8, XString8Array>::XStringClass' {aka 'class XString8'} has no member named 'equalIC'; did you mean 'isEqualIC'?
   78 |       if ( osToc[1].equalIC("x") ) return true;
      |                     ^~~~~~~
      |                     isEqualIC
/Users/Desktop/CloverBootloader/rEFIt_UEFI/cpp_unit_test/MacOsVersion_test.cpp:96:30: error: 'XStringArray_<XString8, XString8Array>::XStringClass' {aka 'class XString8'} has no member named 'equalIC'; did you mean 'isEqualIC'?
   96 |                  && osToc[2].equalIC("x") ) {
      |                              ^~~~~~~
      |                              isEqualIC
/Users/Desktop/CloverBootloader/rEFIt_UEFI/cpp_unit_test/MacOsVersion_test.cpp:105:30: error: 'XStringArray_<XString8, XString8Array>::XStringClass' {aka 'class XString8'} has no member named 'equalIC'; did you mean 'isEqualIC'?
  105 |                  && osToc[2].equalIC("x") == 0 ) {
      |                              ^~~~~~~
      |                              isEqualIC
At global scope:
cc1plus: note: unrecognized command-line option '-Wno-incompatible-ms-struct' may have been intended to silence earlier diagnostics
make: *** [/Users/Desktop/CloverBootloader/Build/Clover/RELEASE_GCC53/X64/rEFIt_UEFI/refit/OUTPUT/cpp_unit_test/MacOsVersion_test.obj] Error 1


build.py...
 : error 7000: Failed to execute command
    make tbuild [/Users/Desktop/CloverBootloader/Build/Clover/RELEASE_GCC53/X64/rEFIt_UEFI/refit]


build.py...
 : error F002: Failed to build module
    /Users/Desktop/CloverBootloader/rEFIt_UEFI/refit.inf [X64, GCC53, RELEASE]

- Failed -
Build end time: 08:31:03, Apr.11 2021
Build total time: 00:01:11

 

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted

@everyone : I'm soon to switch to a new XML parser in Clover. To avoid regression, I made a "mass testing" program that'll find and read all the config.plist from your hard drive, read it with the old (current parser), read it with the new parser and compare. If there is a difference, the program stops and propose that you send me that config.plist, so I can run here and find why me new parser doesn't read the exact same as the current one.

NOTE : the program doesn't write anything, doesn't communicate on the internet, doesn't send anything over the internet...

 

The goal is to read the maximum possible different config.plist. Especially your old, forgotten ones buried in an archived folder... So before running, plug all your external hard drives and usb stick if they contains old config.plist !

 

To download this test program, download 3 files in the same location :

- https://github.com/jief666/CloverCommits/blob/master/CloverX64TestNewParser

- https://github.com/jief666/CloverCommits/blob/master/libgcc_s.1.dylib

- https://github.com/jief666/CloverCommits/blob/master/libstdc%2B%2B.6.dylib

 

do "chmod a+x [your path]/CloverX64TestNewParser" if needed.

and run this file.

 

At the end, if you have : 

"No parsing bug detected."

, just tell me.

 

If you have something like :  

"Please send the file '[path of clover config file]/[filename].plist' as is to me. DO NOT modify the file please, or I won't catch that bug in my new parser. Thanks."

 send me the file "[path of clover config file]/[filename].plist", please.

 

Even if you're not comfortable with command line, I'm willing to assist so we can really avoid regression/change of behavior when switching to this new parser.

 

Thanks for your contribution.

Link to comment
Share on other sites
polyzargone
polyzargone
Posted
Posted

@Jief_Machak

 

Not an urgent request but would it be possible to get back the following information when we run bdmesg:

  

Clover revision: 3202  running on H97-HD3
       ... with board H97-HD3

With new revisions (don't know when it happened), we only have this:

  

Starting Clover revision: 5133 (master, commit fe26ba998) on INSYDE Corp. EFI

 

AFAIK, we need the exact model (H97-HD3 for instance) to name folders in OEM and have Clover automatically detects what to use on different boards.

 

Thanks!

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
2 minutes ago, polyzargone said:

to name folders in OEM and have Clover automatically detects what to use on different boards

I don't remember having modified that but... who knows.

FYI, a bit further down, you'll find message like 

_checkOEMPath Look for oem dir at path '\EFI\CLOVER\OEM\440BX Desktop Reference Platform\UEFI'. Dir doesn't exist.

There is more than one and that gives you all the folder name you can use.

 

 

  • Thanks 1
Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted

For information.

This :

 

On 4/8/2021 at 6:45 PM, Slice said:

New commit 


/Users/sergey/src/CloverBootloader/rEFIt_UEFI/cpp_unit_test/XString_test.cpp:1570:28: error: no matching function for call to 'XStringW::takeValueFrom(XString32&, int)'
 1570 |   xsw2.takeValueFrom(xsw, 1);
      |                            ^

 

 

Could NOT be resolved to this :

 

On 4/8/2021 at 6:54 PM, Slice said:

Resolved by excluding second argument.

I.e. 


xsw2.takeValueFrom(xsw);


The '1' had a meaning...

 

I probably had fixed it, because the  tests run fine.

 

6 minutes ago, polyzargone said:

@Jief_Machak

 

Correct. This should be largely enough for achieving this :D !

 

Thanks again!

You're welcome.

 

Please consider running my test program.

Thanks.

Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted (edited)

@Jief_Machak

 

I didn't pay attention before. Z390 config.plist no error messages. Just this: 

 

=== [ Parse ] ====================

Warning: Invalid NULL char at offset 19954. Replace by a space


What does it mean ? We can ignore it or not

 

Result Z390 2021-04-11 17-18.rtf

 

For IvyBridge: no errors but this : EDIT: unknown key manually corrected in config.plist

 

Spoiler

=== [ Parse ] ====================

Warning: Invalid NULL char at offset 13054. Replace by a space

Warning: Unknown key '/ACPI/DSDT/DropOEM_DSM:12'. Skipped.

Warning: Unknown key '/Boot/EmptyDebugLogAtStart:149'. Skipped.

Warning: Expect a boolean, an int8 or a string starting with 'n' or '-' for '/Boot/XMPDetection:161'.

Warning: Unknown key '/GUI/Mouse/DoubleClick:214'. Skipped.

Warning: Unknown key '/KernelAndKextPatches/KernelCpu:268'. Skipped.

 

Result IvyBridge 2021-04-11 18-04.rtf

Edited by Matgen84
Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...