Clover General discussion

[Slice]

CLOVERX64-panic.efi

It is somehow smaller then regular Clover. Becuase of LTO knows OC will not used?

[jsl2000]

5 hours ago, Jief_Machak said:

In this refactoring, I had to slightly reorganize custom entries and subentries "settings" field.

So if you use custom entries, please test if you can.

 

If something is not right : DO NOT try to workaround and fix. There is suppose to have NO functional change. Just tell me. 

CLOVERX64.efi 1.25 MB · 4 downloads

Thanks and it worked without any issue at Big Sur 11.3 beta4 in my B85M-G hackintoshs.

Edited March 20, 2021 by jsl2000

[Jief_Machak]

1 hour ago, Slice said:

I also have this messages and I don't know what is wrong.

Good, send my your img and I'll debug it.

[JorgeMax]

@Sliceit's no use, doesn't load "invalid parameter" and I'm using the latest version of kext at 1.4.8

 

I'll try an older one

 

Spoiler

Version 1.4.6 loaded

Edited March 20, 2021 by JorgeMax

[Slice]

1 hour ago, Jief_Machak said:

Good, send my your img and I'll debug it.

It is Clover/Qemu image

It is not first observation of missing debug.log. I already encountered before reporting and other users told me there are no debug.log.

See

static UINTN GetDebugLogFile()
{
  EFI_STATUS          Status;
  EFI_FILE_PROTOCOL   *LogFile;

  if ( gLogFile ) return 0;

As the log file already defined then it will be not closed.

[Jief_Machak]

51 minutes ago, Slice said:

It is Clover/Qemu image

It is not first observation of missing debug.log. I already encountered before reporting and other users told me there are no debug.log.

See

static UINTN GetDebugLogFile()
{
  EFI_STATUS          Status;
  EFI_FILE_PROTOCOL   *LogFile;

  if ( gLogFile ) return 0;

As the log file already defined then it will be not closed.

Really ???

This means that if the log is already opened, it's not reopened. "GetDebugLogFile()" never closed the log file. Its purpose is and always was to open it !!!

 

The systematic close of the log file happens at then end "SaveMessageToDebugLogFile()" like it always was.

 

If you don't have any log in the current Qemu image, it's because there is no "Debug" key in boot section. I've already written 2 times about this.

You always seem to be very reluctant to send me Qemu images.

It would be much simpler than guessing configuration...

Edited March 20, 2021 by Jief_Machak

[Slice]

https://drive.google.com/file/d/1AaxV4BACMhVxpojrs21oJlFt5FAScHpW/view?usp=sharing

[Jief_Machak]

12 hours ago, Slice said:

https://drive.google.com/file/d/1AaxV4BACMhVxpojrs21oJlFt5FAScHpW/view?usp=sharing

No access. I've requested access few hours ago. In case you didn't see it.

[Slice]

38 minutes ago, Jief_Machak said:

No access. I've requested access few hours ago. In case you didn't see it.

To whom? I see no your request.

There is some strange issue #176 telling there is no debug.log.

[Slice]

OK, I opened access to all.

[Slice]

VOID SaveMessageToDebugLogFile(IN CHAR8 *LastMessage)
{
  EFI_STATUS Status;

  UINTN lastWrittenOffset = GetDebugLogFile();

then

static UINTN GetDebugLogFile()
{
  EFI_STATUS          Status;
  EFI_FILE_PROTOCOL   *LogFile;

  if ( gLogFile ) return 0;

so lastWrittenOffset = 0;

[Slice]

One more method to reproduce the bug: press RESET while in Clover GUI.

[Jief_Machak]

3 hours ago, Slice said:

VOID SaveMessageToDebugLogFile(IN CHAR8 *LastMessage)
{
  EFI_STATUS Status;

  UINTN lastWrittenOffset = GetDebugLogFile();

then

static UINTN GetDebugLogFile()
{
  EFI_STATUS          Status;
  EFI_FILE_PROTOCOL   *LogFile;

  if ( gLogFile ) return 0;

so lastWrittenOffset = 0;

At the end of "SaveMessageToDebugLogFile()" there is "closeDebugLog()". "closeDebugLog()" will set gLogFile to NULL. So this test is never true.

 

Well it is still a bug, that's true, because if you call "GetDebugLogFile()" twice in a row, the log will restart at the beginning.

I'll update that.

 

The log wasn't generate because there was no definition of PcdDebugPrintErrorLevel (defualt seems to be 0x80000000) in Clover.dsc when DEBUG_ON_SERIAL_PORT was not defined. Which is illogical as debug to file has nothing to do with serial port. Looks like RELEASE versions don't generate logs in quite some time.

That has nothing to do with panic or not, crash or not. The log was just never generate because of 

  if ((DebugMode & GetDebugPrintErrorLevel ()) == 0) {
    return;
  }

Committed.

Edited March 21, 2021 by Jief_Machak

[Slice]

The debug log is successfully generated when no panic, when no random reboot.

I will check you new commit.

[Jief_Machak]

 

3 minutes ago, Slice said:

The debug log is successfully generated when no panic, when no random reboot.

With another compilation maybe... Because with PcdDebugPrintErrorLevel = 0x80000000, no log is generated at all. It's a feature.

You can check the value in AutoGen.c, line 353. Path = Build/Clover/RELEASE_GCC53/X64/rEFIt_UEFI/refit/DEBUG/AutoGen.c

[Slice]

OK, now I see slow boot and debug log was created even with RESET. Thanks!

 

[maclinuxG4]

plz check  no more plateform ID correct (get from hackingtools  from clover r5131 (Mar 19, 2021).

(  device -> properties  is set in my config.plist, iget 0x00000000 instead 0x19120001). for me i use special value 0x19120010

 

from https://github.com/CloverHackyColor/CloverBootloader/commit/2a029bd298548730a5c61d0480117ad108cf9e56

[Slice]

47 minutes ago, maclinuxG4 said:

plz check  no more plateform ID correct (get from hackingtools  from clover r5131 (Mar 19, 2021).

(  device -> properties  is set in my config.plist, iget 0x00000000 instead 0x19120001). for me i use special value 0x19120010

 

from https://github.com/CloverHackyColor/CloverBootloader/commit/2a029bd298548730a5c61d0480117ad108cf9e56

Show your config.plist

 

 

@Jief_Machak Tell me when are you ready for 5132 release.

[Slice]

1 hour ago, LIMITANT said:

Slice please tell me why CPU shows 4,01 GHz instead of 4.00 GHz ? Why this .01 fraction 

Thank you and for @Jief_Machak for your amazing work 

A CPU frequency is not round value. Can you show me preboot.log for this situation?

6 hours ago, maclinuxG4 said:

plz check  no more plateform ID correct (get from hackingtools  from clover r5131 (Mar 19, 2021).

(  device -> properties  is set in my config.plist, iget 0x00000000 instead 0x19120001). for me i use special value 0x19120010

 

from https://github.com/CloverHackyColor/CloverBootloader/commit/2a029bd298548730a5c61d0480117ad108cf9e56

For your config.plist you should see 0x19120010

Where did you see other value?

[Slice]

@Jief_Machak

I may propose better config.plist for Clover/Qemu. Now it started up to [PCI Configuration begin]

 

 

config.plist-QEMU.zip

[maclinuxG4]

44 minutes ago, Slice said:

A CPU frequency is not round value. Can you show me preboot.log for this situation?

For your config.plist you should see 0x19120010

Where did you see other value?

it is  from imac17,1 of my father...i t  is work

[Slice]

8 hours ago, Hervé said:

@LIMITANT you can set CPU bus speed in your config if you want a reported round CPU frequency. Totally cosmetic but it'll do the job. If your CPU is meant to operate a multiplier of 100MHz (like most CPUs since Sandy Bridge), set the value to 100000 and you'll see.

 

No, it will be better to keep Bus Speed as automatic calculated (don't use Clover Configurator, it can't set "Automatic").

You may set Frequency MHz any value you like and see exactly same value in the "About this Mac".

[Jief_Machak]

21 hours ago, Slice said:

@Jief_Machak Tell me when are you ready for 5132 release.

I will commit tmo something and then ask the testers team for tests.

[Jief_Machak]

I've committed now.

This commit is a refactoring, as usual. Which means, report the least behaviour change, please, but DON'T modify your config to workaround.

The specific point I'd like to be tested, is custom entries and sub entries. If you have some of them configured, please test that it goes as usual.

Thanks.

[Slice]

What do you think about issue #376?