Jump to content

Clover General discussion


ErmaC
30,171 posts in this topic

Recommended Posts

Hi @Slice, good to see you around here 😎

 

I posted an issue at GitHub > Clover disobeys Efi Version set in config.plist/SMBIOS

 

I guess I don't need to post the same content here again, do I. Just wanted to post the link here because not everybody checks Clover's issue section over at GitHub.

 

When the gap between the EFI version macOS finds and the one it would like to see gets too big, functionality might get curtailed, so I felt it makes sense to address this issue.

 

Thanks for looking into this 💪

Edited by BuXb
Link to comment
Share on other sites

7 hours ago, BuXb said:

Hi @Slice, good to see you around here 😎

 

I posted an issue at GitHub > Clover disobeys Efi Version set in config.plist/SMBIOS

 

I guess I don't need to post the same content here again, do I. Just wanted to post the link here because not everybody checks Clover's issue section over at GitHub.

 

When the gap between the EFI version macOS finds and the one it would like to see gets too big, functionality might get curtailed, so I felt it makes sense to address this issue.

 

Thanks for looking into this 💪

See you.

Show please Clover preboot.log.

Link to comment
Share on other sites

On 5/12/2023 at 7:21 AM, STLVNUB said:

Any Chance Of Updating GCC Build Script To 13.1.0?

Builds Smaller EFI Files

Latest IS Greatest

If you tried and all builds works as expected feel free to submit.

 

I tested 13.1.0 and by my side Clover builds fails on all systems i tried.

there are different new implementations which need patches

if you want to update you current GCC there is the 12.3.0 which came out the same day, and its the only actually the safest one to use

 

I may eventually if @Slice is ok pull the actual 12.3.0 already tested

Edited by LAbyOne
  • Like 2
Link to comment
Share on other sites

@Slice (and also @LAbyOne since you happen to be active in here right now): can you let me know what happens when you edit the Efi Version string in Clover config.plist/SMBIOS as I described in  Clover disobeys Efi Version set in config.plist/SMBIOS -> reboot: what do you see in "About this Mac > System Report > System Firmware Version" - the updated string you wrote into config.plist, or some old one?

Edited by BuXb
Link to comment
Share on other sites

@BuXb

for what i see in your log Clover is just doing its job.

0:124  0:001  There is a problem in plist '\EFI\CLOVER\config.plist'
0:124  0:000  Warning: EfiVersion '1968.100.17.0.0' is older than default ('1715.0.57.0.0') -> ignored. Dict '/SMBIOS:913'.

.....

3:131  0:000  BiosVersion: MBP154.88Z.F000.B00.2107050236
3:131  0:000  BiosReleaseDate: 07/05/2021
3:131  0:000  EfiVersion: 1715.0.57.0.0

your EfiVersion seems to be obsolete for the corresponding model and Clover apply the most correct one for the chosen smbios.

since any version is timestamp based meaning it get updated (if exists) anytime your machine receive an update

Now i do not know the specific but if clover suggest and apply that one, its most probably the the latest checked against your smbios model.

Link to comment
Share on other sites

26 minutes ago, LAbyOne said:

@BuXb

for what i see in your log Clover is just doing its job.

0:124  0:001  There is a problem in plist '\EFI\CLOVER\config.plist'
0:124  0:000  Warning: EfiVersion '1968.100.17.0.0' is older than default ('1715.0.57.0.0') -> ignored. Dict '/SMBIOS:913'.

.....

3:131  0:000  BiosVersion: MBP154.88Z.F000.B00.2107050236
3:131  0:000  BiosReleaseDate: 07/05/2021
3:131  0:000  EfiVersion: 1715.0.57.0.0

your EfiVersion seems to be obsolete for the corresponding model and Clover apply the most correct one for the chosen smbios.

since any version is timestamp based meaning it get updated (if exists) anytime your machine receive an update

Now i do not know the specific but if clover suggest and apply that one, its most probably the the latest checked against your smbios model.

 

Hi @LAbyOne @BuXb Sorry if I made a mistake, but.. :

Below Opencore Model data update 2 months ago. @BuXb in your config.plist: are you also change BiosReleasedate and BiosVersion data to the newest !

BIOSVendor: "Apple Inc."
BIOSVersion: "1968.100.17.0.0"
BIOSLegacyVersion: "MBP154.88Z.F000.B00.2303040348"
BIOSReleaseDate: "03/04/2023"
SystemManufacturer: "Apple Inc."
SystemProductName: "MacBookPro15,4"
SystemVersion: "1.0"
# Note, this one is used by macserial
SystemSerialNumber: "FVFYV019L40Y"
SystemSKUNumber: ""
SystemFamily: "MacBook Pro"
BoardManufacturer: "Apple Inc."
# This and similar ones can be an array itself, like this:
# BoardProduct:
#  "Mac-53FDB3D8DB8CA971"
#  "Mac-smthelse"
BoardProduct: "Mac-53FDB3D8DB8CA971"
BoardVersion: "MacBookPro15,4"
# FIXME: check
BoardRevision: 0x1
BoardAssetTag: ""
BoardType: 0xA
BoardLocationInChassis: ""
ChassisManufacturer: "Apple Inc."
ChassisType: 0x9
ChassisVersion: "Mac-53FDB3D8DB8CA971"

Below Clover platformdata:
 

    { MacBookPro151, "MBP151.88Z.F000.B00.2107050205"_XS8, "715.0.57.0.0"_XS8, "Mac-937A206F2EE63C01"_XS8, // Intel Cor…
    { MacBookPro152, "MBP152.88Z.F000.B00.2107050204"_XS8, "1715.0.57.0.0"_XS8, "Mac-827FB448E656EC26"_XS8, // Intel Co…
    { MacBookPro153, "MBP153.88Z.F000.B00.2107050204"_XS8, "1715.0.57.0.0"_XS8, "Mac-1E7E29AD0135F9BC"_XS8, // Intel Co…
    { MacBookPro154, "MBP154.88Z.F000.B00.2107050236"_XS8, "1715.0.57.0.0"_XS8, "Mac-53FDB3D8DB8CA971"_XS8, // Intel Co…

 

Link to comment
Share on other sites

@LAbyOne Latest Efi Firmware Version for the MacBookPro15,4 is 1968.120.12.0.0 = more recent than the 1715.0.57.0.0 imposed by Clover. Therefore the calculation behind

0:124  0:000  Warning: EfiVersion '1968.100.17.0.0' is older than default ('1715.0.57.0.0')

and consequently both, the error message and Clover disregarding the newer string is not correct.

 

@Matgen84  great, thank you! Even OC v. 0.9.2's platformdata is thus a bit outdated - 1968.100.17.0.0 (old) vs. 1968.120.12.0.0 (current). But even with BiosReleasedate and BiosVersion data updated to the most recent, Clover does not accept the values.

 

@Slice (or whoever else can): can you:

a) pull over the current platformdata from OC so it's updated in the next Clover release (or even nightly)?

b) correct the function which calculates if a string value is higher = newer or lower = older than the one coded into Clover?

 

That would be awesome 😎

 

Thanks for all your input, folks - very much appreciated!

Edited by BuXb
  • Like 2
Link to comment
Share on other sites

@Slice Cool, so it's narrowed down already. Can you point me to the function in the code on GitHub which calculates if the manually entered EfiVersion string is older or newer than the default one? Maybe I can figure out how to correct it. My code skills are kind of rusty, but oh well, it's worth a try. Above all it should be logic to be applied, shouldn't it.

Link to comment
Share on other sites

I catched the bug.

AsciiStrVersionToUint64(EfiVersion.value(), 4, 5)

means 5 groups of 4 digits so 10000^5. It is larger than int64_max.

We will check first 3 groups, it is enough.

 

  • Like 2
  • Thanks 1
Link to comment
Share on other sites

Yes

6:166  0:001  Using latest EfiVersion from config instead of default '1715.0.57.0.0'
6:167  0:001  BiosVersion: IM131.88Z.F000.B00.1912181754
6:168  0:000  BiosReleaseDate: 12/18/2019
6:169  0:001  EfiVersion: 1968.100.17.0.0

 

  • Thanks 1
Link to comment
Share on other sites

Hi @Slice

I can't build Clover latest 0bc9659 (XCODE 14,2) 🥲

 

Spoiler

build.py...
 : error C0DE: Unknown fatal error when processing [/Users/mathieu/src/Cloverbootloader/OpenCorePkg/Library/OcDebugLogLibOc2Clover/OcDebugLogLibOc2Clover.inf [X64, XCODE8, RELEASE]]
    
(Please send email to devel@edk2.groups.io for help, attaching following call stack trace!)

(Python 3.11.2 on darwin) Traceback (most recent call last):
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 1388, in _BuildPa
    RemoveDirectory(AutoGenObject.BuildDir, True)
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/Source/Python/Common/Misc.py", line 443, in RemoveDirectory
    os.rmdir(Directory)
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/Source/Python/Common/LongFilePathOs.py", line 33, in rmdir
    return os.rmdir(LongFilePath(path))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 66] Directory not empty: '/Users/mathieu/src/Cloverbootloader/Build/Clover/RELEASE_XCODE8'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 2695, in Main
    MyBuild.Launch()
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 2488, in Launch
    self._BuildPlatform()
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 1823, in _BuildPlatform
    self._BuildPa(self.Target, Pa, FfsCommand=CmdListDict,PcdMaList=PcdMaList)
  File "/Users/mathieu/src/Cloverbootloader/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 1389, in _BuildPa
    except WindowsError as X:
           ^^^^^^^^^^^^
NameError: name 'WindowsError' is not defined
 

 

Link to comment
Share on other sites

@Matgen84

As I see you have a problem with Python 3.11.2

My version is 3.9.6 came with Xcode. I don't remember what is the difference but I forced to return to this version.

 

10 hours ago, cankiulascmnfye said:

@Slice FYI: On your Github repo, r5152 isn't set as "Latest Release" yet. So on the front page it still show lists r5151 as latest.

OK, I found the magic button making the new release to be "latest".

  • Like 2
Link to comment
Share on other sites

14 hours ago, Slice said:

@Matgen84

As I see you have a problem with Python 3.11.2

My version is 3.9.6 came with Xcode. I don't remember what is the difference but I forced to return to this version.

 

@Slice I don't have any problem with Clover r5151 commit e0bde75 and Python 3.11.2 To solve the issue, I git clone a new repo. All works well now 😊

  • Like 2
Link to comment
Share on other sites

On 5/27/2023 at 5:15 PM, LAbyOne said:

If you tried and all builds works as expected feel free to submit.

 

I tested 13.1.0 and by my side Clover builds fails on all systems i tried.

there are different new implementations which need patches

if you want to update you current GCC there is the 12.3.0 which came out the same day, and its the only actually the safest one to use

 

I may eventually if @Slice is ok pull the actual 12.3.0 already tested

Built in Ventura using gcc-13.1.0

image.png

Few changes and clean Build folder.

 

  • Like 3
Link to comment
Share on other sites

I am really tempted to familiarise my self with Clover again on a test disk.

I was an avid Clover user on my legacy Gigabyte GA-EX58-UDR Board with an i7 CPU then upgraded with a 170 Board.

I used to build all my Clover EFI Folders specifically for my machines but started using OC when I purchased a Z390 Board.

Unfortunately what little Clover knowledge I gained over the years, I have now forgotten and now reluctant to start messing again but I would like to add the Clover string to my bow, so to speak.

Maybe one day I will take the plunge and a dabble so then I will be a nuisance to the Clover Thread shouting for help. :)

Link to comment
Share on other sites

is this something to change at the level of the AppleALC injection? Doesn't work here anymore

HP Prodesk 600 G1 and it worked fine before alcid=11

  • Sad 1
Link to comment
Share on other sites

×
×
  • Create New...