Clover General discussion

[Matgen84]

11 minutes ago, Slice said:

Strange, but I see successful compilation

- Done -
Build end time: 10:11:30, May.01 2022
Build total time: 00:02:50

...
  -> CloverX64-RELEASE_XCODE8-20220430215154-b8c935a-dirty.efi

...
Copy CloverEFI:
  -> boot6
Changing byte at 0xa9 of boot6 to show 6 as init message:

What else to compile in your script?

 

I only build Clover using XCODE 12.4 (Catalina). Can't also build using Buildme GCC

 

 

OutPut GCC

[Slice]

33 minutes ago, Matgen84 said:

 

I only build Clover using XCODE 12.4 (Catalina). Can't also build using Buildme GCC

 

 

OutPut GCC 19.4 kB · 1 download

I see in the log

  634 |   Walker = (CHAR8 *) &Table->SignatureCommon.Signature;

But this line already have been corrected in yesterday. You was not updated embedded OpenCorePkg.

[Matgen84]

2 minutes ago, Slice said:

I see in the log

  634 |   Walker = (CHAR8 *) &Table->SignatureCommon.Signature;

But this line already have been corrected in yesterday. You was not updated embedded OpenCorePkg.

 

I solved the problem with the local repository compiled with GCC. But I still have a problem with the other local repository where I use XCODE.

[MifJpnAlphaPlus]

5 hours ago, Slice said:

You just didn't update embedded OpenCore

See

https://github.com/CloverHackyColor/OpenCorePkg/commit/614bd7b4ec82d10f6719faad61cc3adfda767a3b

 

@MifJpnAlphaPlus The same

Hello

I am not very familiar with Git-Hub, so I apologize if I am wrong.
The OpenCore part currently shown in Clover is
commit is 718db6190f93bacd4a4e19c96baed3cfd8070286.
In this commit, the
SignatureCommon.Signature is still there.

 

https://github.com/CloverHackyColor/OpenCorePkg/blob/718db6190f93bacd4a4e19c96baed3cfd8070286/Library/OcAcpiLib/OcAcpiLib.c

 

If "614bd7b4ec82d10f6719faad61cc3adfda767a3b" is new, I think it has been merged.

And I think that the OpenCore part that is currently out in Clover is commit would be new.

 

I think, the GirHub display is a red X sign, it is strange.

I feel that the mark will become a blue circle once the internal processing is finished.

It's odd, isn't it?

Thanks.

status_5146-20220501-19.14.13.txt

Edited May 1, 2022 by MifJpnAlphaPlus

[matxpa]

Hi,

r5146 (master, commit b8c935a64) Xcode8 build OK on Asus IvyBridge Big Sur 11.6.5 (20G527) and Xcode Version 13.2.1 (13C100).

 

Hackintool log

...
0:145  0:045  === [ Starting Clover ] =========================
0:145  0:000  Now is 01.05.2022,  10:05:59 (GMT)
0:145  0:000  Starting Clover revision: 5146 (master, commit b8c935a64) on American Megatrends EFI
0:145  0:000  Build id: 20220430215154-b8c935a-dirty
0:145  0:000  Build with: [Args: -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG -t XCODE8 | --cmd-len=50000 -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG --conf=/Users/meunier/CloverBootloader/Conf -D USE_LOW_EBDA -a X64 -b RELEASE -t XCODE8 -n 5 | OS: 11.6.5]
0:145  0:000  === [ Get Smbios ] ==============================
...
0:145  0:000  Boot status=0
0:145  0:000  Running on: 'X75VB' with board 'X75VB'
0:145  0:000  === [ GetCPUProperties ] ========================
0:145  0:000  CPU Vendor = 756E6547 Model=306A9
0:145  0:000   The CPU supported SSE4.1
0:145  0:000   The CPU supported RDRAND
0:145  0:000  BrandString = Intel(R) Core(TM) i5-3340M CPU @ 2.70GHz
...

 

Greetings

[LAbyOne]

@Slice On latest commit only product still having issues (making release) is ccpv

In file included from /Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/platformdata.cpp:9:
In file included from /Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/Nvram.h:14:
In file included from /Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/../gui/REFIT_MENU_SCREEN.h:39:
In file included from /Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/../gui/../Platform/Settings.h:5:
In file included from /Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/../gui/menu_items/menu_items.h:39:
In file included from /Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/../gui/menu_items/../../Platform/KERNEL_AND_KEXT_PATCHES.h:14:
In file included from /Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/../Settings/ConfigPlist/ConfigPlistClass.h:63:
/Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/../Settings/ConfigPlist/Config_SystemParameters.h:30:23: error: 
      no member named 'IsValidGuidString' in 'GUID'
      if ( !EFI_GUID::IsValidGuidString(xstring8) ) b = xmlLiteParser->addWarn...
            ~~~~~~~~~~^
/Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/../Settings/ConfigPlist/Config_SystemParameters.h:79:7: error: 
      no member named 'takeValueFrom' in 'GUID'
    g.takeValueFrom(CustomUUID.value());
    ~ ^
In file included from /Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/platformdata.cpp:9:
In file included from /Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/Nvram.h:14:
In file included from /Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/../gui/REFIT_MENU_SCREEN.h:39:
In file included from /Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/../gui/../Platform/Settings.h:5:
In file included from /Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/../gui/menu_items/menu_items.h:39:
In file included from /Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/../gui/menu_items/../../Platform/KERNEL_AND_KEXT_PATCHES.h:14:
In file included from /Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/../Settings/ConfigPlist/ConfigPlistClass.h:64:
/Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/../Settings/ConfigPlist/Config_RtVariables.h:25:29: error: 
      no member named 'IsValidGuidString' in 'GUID'
            if ( !EFI_GUID::IsValidGuidString(xstring8) ) b = xmlLiteParser->a...
                  ~~~~~~~~~~^
/Users/labyone/src/CloverBootloader/rEFIt_UEFI/Platform/../Settings/ConfigPlist/Config_RtVariables.h:54:21: error: 
      no member named 'takeValueFromBE' in 'GUID'
            efiGuid.takeValueFromBE(GuidString.value());
            ~~~~~~~ ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
2 warnings and 20 errors generated.
note: Using new build systemnote: Planning buildnote: Constructing build description
** BUILD FAILED **

Clover itself builds fine either in xcode or gcc.

Edited May 1, 2022 by LAbyOne

[Guest 5T33Z0]

In the Clover changes, I've read that you can enter a specific Framebuffer Name for newer AMD Cards as well. I have a RX580 Nitro+ How can I find out which Framebuffer it uses?

[chris1111]

@Slice  I am in Monterey 12.3.1  with Xcode 13.2.1 and OpenCore is embed

its  fletching from the command 

 

it work but I need to modified the file OcAcpiLib.c like your commits because some how Github not fletching your last commit ??

[Slice]

Check

git branch

It should reply "master"

 

[chris1111]

45 minutes ago, Slice said:

Check

git branch

It should reply "master"

 

I will test other thing later but now

I find the good solution for always have your commit at  https://github.com/CloverHackyColor/OpenCorePkg

 

Before build
rm -rf ~/src/CloverBootloader/OpenCorePkg
cd ~/src/CloverBootloader
git clone https://github.com/CloverHackyColor/OpenCorePkg.git

and now I build with Xcode 👍 😄 This is a complete build form scratch

 

              

Edited May 1, 2022 by chris1111

[Guest 5T33Z0]

32 minutes ago, Hervé said:

Same way it's always been: you check the card's PCI id and then you look in the AMD frambuffer's Info.plist to collect the FB's personalities name it defines.

 

Okay, thanks. I clicked on the magnifying glass in Hackintool for the GPU which took me to AMD9500Controller.kext.

 

The info.plist contains more than a dozen Framebuffers:

 

How do I find out which is the right one?

[MifJpnAlphaPlus]

Hello.

38 minutes ago, chris1111 said:

I will test other thing later but now

I find the good solution for always your commit at  https://github.com/CloverHackyColor/OpenCorePkg

 

Before build
rm -rf ~/src/CloverBootloader/OpenCorePkg
cd ~/src/CloverBootloader
git clone https://github.com/CloverHackyColor/OpenCorePkg.git

and now I build with Xcode 👍 😄 This is a complete build form scratch

 

              

Hello.
It certainly seems to be a Git-Hub issue.

 

--recurse-submodules

And I could only pull the commits as shown on webpage.

 

As @chris1111says, when I git clone the OpenCore part, I got beafbb ...
Thank you.

Edited May 1, 2022 by MifJpnAlphaPlus

[chris1111]

For now my concept is not bad  

[Slice]

19 minutes ago, 5T33Z0 said:

 

Okay, thanks. I clicked on the magnifying glass in Hackintool for the GPU which took me to AMD9500Controller.kext.

 

The info.plist contains more than a dozen Framebuffers:

 

How do I find out which is the right one?

Once in the past we had an utility to dump all connectors in all framebuffer to see if chosen framebuffer has connectors like your card.

But now I have no such dumps.

For my RX570 with DVI, HDMI, DP,DP I chosen Orinoco and it is fine for me: DVI monitor+HDMI TV.

[Guest 5T33Z0]

@Slice Ah, okay. So the FB Name is only relevant for the connectors and not performance? I guess I don't need it then because all the connectors i need are working.

[Matgen84]

Hi @Slice

Maybe I find the issue:  when I build Clover, at the same time I build CloverConfigPlistValidator before make the PKG.

Strangely, I can't build CloverConfigPlistValidator :

 

[XCODE]
- Building ccpv and archive
** BUILD FAILED **


The following build commands failed:
	CompileC /Users/mathieu/src/Cloverbootloader/Xcode/CloverConfigPlistValidator/build/CloverConfigPlistValidator.build/Release/CloverConfigPlistValidator.build/Objects-normal/x86_64/Config_GUI.o /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/Settings/ConfigPlist/Config_GUI.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

I mistaken somewhere ? Before all work fine.

 

EDIT
Same issue with Buildme script: can't build CloverConfigPlistValidator.
 

CCPV OutPut

Edited May 1, 2022 by Matgen84

[chris1111]

20 minutes ago, Matgen84 said:

Hi @Slice

Maybe I find the issue:  when I build Clover, at the same time I build CloverConfigPlistValidator before make the PKG.

Strangely, I can't build CloverConfigPlistValidator :

 

[XCODE]
- Building ccpv and archive
** BUILD FAILED **


The following build commands failed:
	CompileC /Users/mathieu/src/Cloverbootloader/Xcode/CloverConfigPlistValidator/build/CloverConfigPlistValidator.build/Release/CloverConfigPlistValidator.build/Objects-normal/x86_64/Config_GUI.o /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/Settings/ConfigPlist/Config_GUI.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

I mistaken somewhere ? Before all work fine.

 

EDIT
Same issue with Buildme script: can't build CloverConfigPlistValidator.
 

CCPV OutPut 7.5 kB · 0 downloads

Same here Build failled

[MifJpnAlphaPlus]

Hello.

After booting, I was told that there was a problem with my computer, I entered the setting Apple ID again and noticed the following.

Part of the interpretation of System-ID is as if it were little-endian.

Please help me.

Thank you.

[Matgen84]

34 minutes ago, MifJpnAlphaPlus said:

Hello.

After booting, I was told that there was a problem with my computer, I entered the setting Apple ID again and noticed the following.

Part of the interpretation of System-ID is as if it were little-endian.

 

Please help me.

Thank you.

 

Which r5146 commit to use ! 

Just a opinion. Maybe it's related to commit 1ea4700b or I mistake, so I'm sorry. 😪

Edited May 1, 2022 by Matgen84

[Slice]

2 hours ago, MifJpnAlphaPlus said:

Hello.

After booting, I was told that there was a problem with my computer, I entered the setting Apple ID again and noticed the following.

Part of the interpretation of System-ID is as if it were little-endian.

Please help me.

Thank you.

Please remember if it was otherwise with Clover-5146 release.

[MifJpnAlphaPlus]

1 hour ago, Slice said:

Please remember if it was otherwise with Clover-5146 release.

Thank you very much for your prompt reply.

I am very sorry for the inconvenience.

To tell you the truth
I don't know what you mean, and I am a little emotionally unstable mentally.

Apparently, others are not... If so, it is a very strange phenomenon.

I don't know about the cause, but I do know that it can be set up to be the same as before.

Anyway, I will get over my anxiety and move on.

Thank you so much for your help.

[chris1111]

@Slice the workflows here  https://github.com/CloverHackyColor/OpenCorePkg/tree/master/.github/workflows is not use by Clover

It is completetly useless I think, thats why we have a X on every commits; the workflow always faiiled !  

I don't know if this has any effect on opencore not being embed correctly?

Edited May 1, 2022 by chris1111
I don't know

[tluck]

13 hours ago, MifJpnAlphaPlus said:

Hello.

After booting, I was told that there was a problem with my computer, I entered the setting Apple ID again and noticed the following.

Part of the interpretation of System-ID is as if it were little-endian.

 

Please help me.

Thank you.

i had the same thing happen - using the most recent 5146 (after fixing the OC integration)

[Slice]

1 hour ago, tluck said:

i had the same thing happen - using the most recent 5146 (after fixing the OC integration)

Tell me something more. Is there system-id changed after changing the Clover version?

[MifJpnAlphaPlus]

On 5/1/2022 at 10:25 PM, Matgen84 said:

Hi @Slice

Maybe I find the issue:  when I build Clover, at the same time I build CloverConfigPlistValidator before make the PKG.

Strangely, I can't build CloverConfigPlistValidator :

 

[XCODE]
- Building ccpv and archive
** BUILD FAILED **


The following build commands failed:
	CompileC /Users/mathieu/src/Cloverbootloader/Xcode/CloverConfigPlistValidator/build/CloverConfigPlistValidator.build/Release/CloverConfigPlistValidator.build/Objects-normal/x86_64/Config_GUI.o /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/Settings/ConfigPlist/Config_GUI.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

I mistaken somewhere ? Before all work fine.

 

EDIT
Same issue with Buildme script: can't build CloverConfigPlistValidator.
 

CCPV OutPut 7.5 kB · 1 download

Me too

Spoiler

alpha@iMac CloverBootloader % ./buildme

 ------------------------------------------------------------------------------
                          🍀 Clover r5146 (SHA: b8c935a64)
              TOOLCHAIN: GCC53 (override example: './buildme XCODE8')
 ------------------------------------------------------------------------------









1) build Clover				 9) test Clover
2) update Clover			10) check status
3) build Clover with HFSPlus		11) show diff
4) make pkg				12) open CloverV2/EFI/CLOVER directory
5) make iso				13) update Clover (reset changes)
6) make app				14) clean BaseTools
7) build all				15) Utilities
8) make Release				16) quit

Please enter your choice: 15

 ------------------------------------------------------------------------------
                          🍀 Clover r5146 (SHA: b8c935a64)
                                  External Utilities 
 ------------------------------------------------------------------------------









1) Get CloverConfigPlistValidator	   	 9) Get SSDTTime
2) Get PlistEDPlus				10) Get USBMap
3) Get Hackintool				11) Get QtiASL
4) Get BitmaskDecode				12) Get CsrDecode
5) Get MaciASL					13) Get gibMacOS
6) Get dmidecode				14) Get mountR/W
7) Get IOReg-Devices				15) back to buildme
8) Get NativeDisplayBrightness			16) quit

Files will be put on Desktop/ClovUtils: 1
[CHECK XCODE]
In file included from /Users/alpha/CloverBootloader/rEFIt_UEFI/Platform/Utils.cpp:24:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/include/Efi.h:13:
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:16:7: error: 
      definition of type 'GUID' conflicts with typedef of the same name
class GUID;
      ^
In file included from <built-in>:1:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/PlatformPOSIX/include/Platform.h:42:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi.h:26:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi/UefiBaseType.h:20:
/Users/alpha/CloverBootloader/PosixCompilation/UefiMock/Base.h:228:3: note: 
      'GUID' declared here
} GUID;
  ^
In file included from /Users/alpha/CloverBootloader/rEFIt_UEFI/Platform/Utils.cpp:24:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/include/Efi.h:13:
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:18:9: warning: 
      'CONST_EFI_GUID_PTR_T' macro redefined [-Wmacro-redefined]
#define CONST_EFI_GUID_PTR_T  const EFI_GUID&
        ^
In file included from <built-in>:1:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/PlatformPOSIX/include/Platform.h:42:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi.h:26:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi/UefiBaseType.h:20:
/Users/alpha/CloverBootloader/PosixCompilation/UefiMock/Base.h:230:9: note: 
      previous definition is here
#define CONST_EFI_GUID_PTR_T  IN CONST EFI_GUID*
        ^
In file included from /Users/alpha/CloverBootloader/rEFIt_UEFI/Platform/Utils.cpp:24:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/include/Efi.h:13:
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:19:9: warning: 
      'JCONST_EFI_GUID_PTR_T' macro redefined [-Wmacro-redefined]
#define JCONST_EFI_GUID_PTR_T  const EFI_GUID&
        ^
In file included from <built-in>:1:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/PlatformPOSIX/include/Platform.h:42:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi.h:26:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi/UefiBaseType.h:20:
/Users/alpha/CloverBootloader/PosixCompilation/UefiMock/Base.h:231:9: note: 
      previous definition is here
#define JCONST_EFI_GUID_PTR_T  IN JCONST EFI_GUID*
        ^
In file included from /Users/alpha/CloverBootloader/rEFIt_UEFI/Platform/Utils.cpp:24:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/include/Efi.h:13:
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:51:7: error: 
      definition of type 'GUID' conflicts with typedef of the same name
class GUID
      ^
In file included from <built-in>:1:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/PlatformPOSIX/include/Platform.h:42:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi.h:26:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi/UefiBaseType.h:20:
/Users/alpha/CloverBootloader/PosixCompilation/UefiMock/Base.h:228:3: note: 
      'GUID' declared here
} GUID;
  ^
In file included from /Users/alpha/CloverBootloader/rEFIt_UEFI/Platform/Utils.cpp:24:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/include/Efi.h:13:
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:393:72: error: 
      no member named 'long_guid_form_length' in 'GUID'
  ...== GUID::long_guid_form_length && (str[0] != '{' || str[GUID::long_guid_...
                                                             ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:393:19: error: 
      no member named 'long_guid_form_length' in 'GUID'
    : (N == GUID::long_guid_form_length && (str[0] != '{' || str[GUID::l...
            ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:394:13: error: 
      no member named 'parse_guid_error2' in 'GUID'
    ? GUID::parse_guid_error2()
      ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:395:13: error: 
      no member named 'parse_guid' in 'GUID'
    : GUID::parse_guid(str + (N == GUID::long_guid_form_length ? 1 : 0));
      ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:395:42: error: 
      no member named 'long_guid_form_length' in 'GUID'
    : GUID::parse_guid(str + (N == GUID::long_guid_form_length ? 1 : 0));
                                   ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:391:24: error: 
      no member named 'long_guid_form_length' in 'GUID'
  return (!(N == GUID::long_guid_form_length || N == GUID::short_guid_fo...
                 ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:391:60: error: 
      no member named 'short_guid_form_length' in 'GUID'
  return (!(N == GUID::long_guid_form_length || N == GUID::short_guid_fo...
                                                     ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:392:13: error: 
      no member named 'parse_guid_error2' in 'GUID'
    ? GUID::parse_guid_error2()
      ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:389:16: error: 
      no return statement in constexpr function
constexpr GUID operator "" _guid(const char *str, size_t N)
               ^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:398:22: error: 
      default initialization of an object of const type 'const GUID' without a
      user-provided default constructor
constexpr const GUID nullGuid;
                     ^
                             {}
2 warnings and 12 errors generated.
note: Using new build system
note: Planning
note: Build preparation complete
warning: Building targets in manual order is deprecated - check "Parallelize build for command-line builds" in the project editor, or set DISABLE_MANUAL_TARGET_ORDER_BUILD_WARNING in any of the targets in the current build to suppress this warning
** BUILD FAILED **