Jump to content

Clover General discussion

ErmaC

By ErmaC,
in Clover

 Share
30,171 posts in this topic

Recommended Posts

matxpa
matxpa
Posted
Posted
On 4/12/2021 at 8:27 PM, Jief_Machak said:

We can define as 9 bytes long, or just do a memcpy instead of a snprintf.

 

@matxpa All your plist are in the folder "/Users/meunier/Desktop/"EFI X75 MBP1x,x"/Clover" ? If you have old, almost forgotten archive, I'm interested toparse them too.

You can do /CloverX64TestNewParser / ! (take a small break, it'll take some time).

 

Version 12 pushed...

Jief

 

as you asked is joined a "zip"

Clover EFI Backups.zip

Link to comment
Share on other sites
Slice
Slice
Posted
Posted
23 hours ago, eng_redaesm said:


@jief_makhac Unfortunately not booting with with me may be the. Version of xcode matters i have 12.4 ver
O


Sent from my iPhone using Tapatalk

Clover compiled by Xcode12 is not working.

@Jief_Machak attention.

  • Like 1
Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted

Version 13 of my test tool posted. There is counter, now :lol:;)

 

35 minutes ago, Slice said:

Clover compiled by Xcode12 is not working.

@Jief_Machak attention.

I really down know. I still have 11.2. And I had the same problem. Adding a log line seems to fix. By experience, that is not "fixing" and the problem is elsewhere. Exactly the same as when putting the path in a temporary variable seems to avoid a crash.

Knowing xcode was working fine until now, and nothing has changed, and that we had a problem with GCC, I'd say we reached a limit where the linker doesn't do the same as before. With Gcc, it was clear : always crash when trying to call the global constructors. So it was an easy fix. But with Xcode, it goes until the reading of settings arbitrary. And, on my VM, if I add a log line : no crash.

Really strange...

Link to comment
Share on other sites
yapan4
yapan4
Posted
Posted

@Jief_Machak

Version 13

...

...

file:/Volumes/BackupHD/To Sort and Backup 2/WS Pro EFI joedm/453604_wspro/config.plist

file:/Volumes/BackupHD/To Sort and Backup 2/WS Pro EFI joedm/EFI/OC/config.plist

374 file(s) read. No parsing bug detected. Great. Let me know

Saving session...

...copying shared history...

...saving history...truncating history files...

...completed.

Deleting expired sessions...none found.

 

[Process completed]

 

Link to comment
Share on other sites
matxpa
matxpa
Posted
Posted (edited)

@Jief_Machak

 

XCODE8 compilations with Xcode Version 12.4 (12D4e)

 

with commit fd3b09cf1 (initial commit of r5133) XCODE8 build works fine

with commit fe26ba9 XCODE8 build can't boot, nor with 4269083 and c07c154

 

On 4/12/2021 at 7:43 PM, matxpa said:

...

I've made a r5133 Release (master commit fd3b09cf1) XCODE8 build.

That r5133 XCODE8 Release work fine I can boot on a Laptop Asus X75VB (MBP11,3 IvyBridge I5-3340M) Big Sur 11.2.3 (20D91)

...

Past 4 days i've built three XCODE8 r5133 Releases based on the three master commits (fe26ba9, 4269083 and the last c07c154)

The three r5133 XCODE8 built Releases are OK but none of them can BOOT (black screen, no REFIT_MAINMENU_SCREEN displayed)

I didn't try with others commits

Those three r5133 GCC53 built Releases work fine

...

 

so the commit that introduce failure is between fd3b09cf1 and fe26ba9, the only one is 7babc6f and the behavior is no displayed BootMenu

 

Regards

Edited by matxpa
  • Sad 1
Link to comment
Share on other sites
Slice
Slice
Posted
Posted
44 minutes ago, matxpa said:

@Jief_Machak

 

XCODE8 compilations with Xcode Version 12.4 (12D4e)

 

with commit fd3b09cf1 (initial commit of r5133) XCODE8 build works fine

with commit fe26ba9 XCODE8 build can't boot, nor with 4269083 and c07c154

 

 

so the commit that introduce failure is between fd3b09cf1 and fe26ba9, the only one is 7babc6f and the behavior is no displayed BootMenu

 

Regards

Hey, @Jief_Machak

this commit introduced 

      LogDataHub(&gEfiMiscSubClassGuid, L"EPCI", &ApplePlatformData[GlobalConfig.CurrentModel].smcConfig,   4);
      LogDataHub(&gEfiMiscSubClassGuid, L"REV",  ApplePlatformData[GlobalConfig.CurrentModel].smcRevision,    6);

"&" is absent in the second line.

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted

In C, for a native array, called  "ar", ar is equal to &ar is equal to &ar[0].

 

I double checked with a log : 

ApplePlatformData[GlobalConfig.CurrentModel].smcRevision = 233175768
&ApplePlatformData[GlobalConfig.CurrentModel].smcRevision = 233175768
&ApplePlatformData[GlobalConfig.CurrentModel].smcRevision[0] = 233175768

That couldn't not be that. A compiler bug on that is nearly impossible as it is the same as 35 years ago !
 

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
4 hours ago, matxpa said:

@Jief_Machak

 

XCODE8 compilations with Xcode Version 12.4 (12D4e)

 

with commit fd3b09cf1 (initial commit of r5133) XCODE8 build works fine

with commit fe26ba9 XCODE8 build can't boot, nor with 4269083 and c07c154

 

 

so the commit that introduce failure is between fd3b09cf1 and fe26ba9, the only one is 7babc6f and the behavior is no displayed BootMenu

 

Regards

Thanks, that's helpful.

I'm currently compiling these 2 commits and will see if I can reproduce here (I think I will as I did before). I'll let you know.

  • Thanks 1
Link to comment
Share on other sites
matxpa
matxpa
Posted
Posted
1 hour ago, Jief_Machak said:

Thanks, that's helpful.

I'm currently compiling these 2 commits and will see if I can reproduce here (I think I will as I did before). I'll let you know.

 @Jief_Machak & @Slice

 

It seems that the problem is "clang"

 

with Xcode Version 12.4 (12D4e) and clang version 12.0.0 (clang-1200.0.32.29) --> r5133 9bff704 XCODE8 Release can't  boot           --> KO

with Xcode Version 11.3 (11C29) and clang version 11.0.0 (clang-1100.0.33.16) --> r5133 9bff704 XCODE8 Release boot and work fine --> OK

 

On an HDD I booted with Mojave (10.14.6) and  Xcode Version 11.3 (11C29) and clang version 11.0.0 (clang-1100.0.33.16)

I compiled r5133 9bff704 XCODE8 Release and install it on an USB KEY

Reboot with the USB KEY and it works fine

 

Boot Log on Laptop Asus MBP11,3
0:154  0:000  Starting Clover revision: 5133 (master, commit 9bff704ea) on American Megatrends EFI
0:154  0:000  Build id: 20210413222734-9bff704-dirty
0:154  0:000  Build with: [Args: -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG -t XCODE8 | -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG --conf=/Users/Meunier/CloverBootloader/Conf -D USE_LOW_EBDA -a X64 -b RELEASE -t XCODE8 -n 5 | OS: 10.14.6]
...
0:154  0:000  Boot status=0
0:154  0:000  Running on: 'X75VB' with board 'X75VB'
0:154  0:000  === [ GetCPUProperties ] ========================
0:154  0:000  CPU Vendor = 756E6547 Model=306A9
0:154  0:000   The CPU supported SSE4.1
0:154  0:000  BrandString = Intel(R) Core(TM) i5-3340M CPU @ 2.70GHz

 

  • Like 1
Link to comment
Share on other sites
matxpa
matxpa
Posted
Posted (edited)
31 minutes ago, Jief_Machak said:

I have compiled fd3b09cf13011fa585f92e19e514d35bc4a5dfc4 in release mode with xcode8 and it crash here !

@matxpa How did you build it ? buildme ?

@Jief_Machak

 

MACBOOKPRO:CloverBootloader Meunier$ ./buildme XCODE8

------------------------------------------------------------------------
buildme, Clover r5133 (SHA: 9bff704ea)
TOOLCHAIN: XCODE8 (override example: './buildme XCODE8')

 1) build Clover
or

3) make pkg

and usually 7) build all

 

yesterday I I got rid of ~/CloverBootloader  Repo and got a brand new clone, so Build was reBuilt and ToolChain but result was the same r5133 XCODE8 can't boot

 

Regards

Edited by matxpa
  • Sad 1
Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
20 minutes ago, matxpa said:

 @Jief_Machak & @Slice

 

It seems that the problem is "clang"

 

with Xcode Version 12.4 (12D4e) and clang version 12.0.0 (clang-1200.0.32.29) --> r5133 9bff704 XCODE8 Release can't  boot           --> KO

with Xcode Version 11.3 (11C29) and clang version 11.0.0 (clang-1100.0.33.16) --> r5133 9bff704 XCODE8 Release boot and work fine --> OK

 

On an HDD I booted with Mojave (10.14.6) and  Xcode Version 11.3 (11C29) and clang version 11.0.0 (clang-1100.0.33.16)

I compiled r5133 9bff704 XCODE8 Release and install it on an USB KEY

Reboot with the USB KEY and it works fine

 

Boot Log on Laptop Asus MBP11,3
0:154  0:000  Starting Clover revision: 5133 (master, commit 9bff704ea) on American Megatrends EFI
0:154  0:000  Build id: 20210413222734-9bff704-dirty
0:154  0:000  Build with: [Args: -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG -t XCODE8 | -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG --conf=/Users/Meunier/CloverBootloader/Conf -D USE_LOW_EBDA -a X64 -b RELEASE -t XCODE8 -n 5 | OS: 10.14.6]
...
0:154  0:000  Boot status=0
0:154  0:000  Running on: 'X75VB' with board 'X75VB'
0:154  0:000  === [ GetCPUProperties ] ========================
0:154  0:000  CPU Vendor = 756E6547 Model=306A9
0:154  0:000   The CPU supported SSE4.1
0:154  0:000  BrandString = Intel(R) Core(TM) i5-3340M CPU @ 2.70GHz

 

Problem is Xcode... or we do something that we're not supposed to do and some version of xcode accepts it.

As we never had that problem before with XCode, I guess there is something to find.

 

How to you build it ? with buildme script ?

 

 

Link to comment
Share on other sites
matxpa
matxpa
Posted
Posted
7 minutes ago, Jief_Machak said:

Problem is Xcode... or we do something that we're not supposed to do and some version of xcode accepts it.

As we never had that problem before with XCode, I guess there is something to find.

 

How to you build it ? with buildme script ?

 

 

@Jief_Machakr5133 0 local commit fd3b09c XCODE8 OK CLOVERX64.efi

r5133 0 local commit fd3b09c XCODE8 OK.txt

Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted

Hi @matxpa

Can you upload this: with Xcode Version 12.4 (12D4e) and clang version 12.0.0 (clang-1200.0.32.29) --> r5133 9bff704 XCODE8 Release. Please.

 

So, I can test with my Z390 config (Big Sur 11.3 Beta 8). 

Link to comment
Share on other sites
Slice
Slice
Posted
Posted
3 hours ago, Jief_Machak said:

In C, for a native array, called  "ar", ar is equal to &ar is equal to &ar[0].

 

I double checked with a log : 


ApplePlatformData[GlobalConfig.CurrentModel].smcRevision = 233175768
&ApplePlatformData[GlobalConfig.CurrentModel].smcRevision = 233175768
&ApplePlatformData[GlobalConfig.CurrentModel].smcRevision[0] = 233175768

That couldn't not be that. A compiler bug on that is nearly impossible as it is the same as 35 years ago !
 

Yes, it is true for an array. I will fix this just for similarity.

  • Like 1
Link to comment
Share on other sites
matxpa
matxpa
Posted
Posted (edited)
27 minutes ago, Matgen84 said:

Hi @matxpa

Can you upload this: with Xcode Version 12.4 (12D4e) and clang version 12.0.0 (clang-1200.0.32.29) --> r5133 9bff704 XCODE8 Release. Please.

 

So, I can test with my Z390 config (Big Sur 11.3 Beta 8). 

@Matgen84 sorry I answered a bit hastily i won't do it again I swear that (désolé j'ai répondu un peu précipitamment, je le ferai plus je le jure)

You use Big Sur and App Store didn't propose you an Xcode update or upgrade to 12.4.

Xcode 12.4 was published two months ago.

On my Catalina SSD Unit i've Xcode 12.3

 

An upLoad of Xcode 12.4 is about 11,6 Go, the way to obtain it is App Store

Edited by matxpa
  • Like 1
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted (edited)
23 minutes ago, matxpa said:

@Matgen84 sorry I answered a bit hastily i won't do it again I swear that (désolé j'ai répondu un peu précipitamment, je le ferai plus je le jure)

You use Big Sur and App Store didn't propose you an Xcode update or upgrade to 12.4.

Xcode 12.4 was published two months ago.

On my Catalina SSD Unit i've Xcode 12.3

 

An upLoad of Xcode 12.4 is about 11,6 Go, the way to obtain it is App Store

 

@matxpa I'm French too. :D No Xcode 12.4 :D
 

I talk about CloverX64.efi  r5133 9bff704 build with Xcode 12.4: can you upload it. Please. Because I haven't installed Xcode  on my Z390 config (Big Sur 11.3 Beta 8)

Edited by Matgen84
Link to comment
Share on other sites
matxpa
matxpa
Posted
Posted (edited)
40 minutes ago, Matgen84 said:

 

@matxpa I'm French too. :D No Xcode 12.4 :D
 

I talk about CloverX64.efi  r5133 9bff704 build with Xcode 12.4: can you upload it. Please. Because I haven't installed Xcode  on my Z390 config (Big Sur 11.3 Beta 8)

 

@Matgen84

 

Clover_r5133_4_20210413_XCODE8_66bbace-master KO on X75VB

 

Clover_r5133_4_20210413_XCODE8_66bbace-master KO on X75VB CLOVERX64.efi

Edited by matxpa
  • Thanks 1
Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted

When it doesn't boot, do you see the small message that starts with "new=" ?

For me, the first commit to show the problem is 69a47c5fac203f95efd87d01c81b4a268048c178

 

But swapping 2 adjacent lines resolve the problem !!!

 

Could you compile and try ?

Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...