Jump to content

Clover General discussion

ErmaC

By ErmaC,
in Clover

 Share
30,139 posts in this topic

Recommended Posts

Jief_Machak
Jief_Machak
Posted
Posted

Good !

Thanks you very much for all the tests.

Stay tuned : I'm now refactoring the properties settings structure and it's a hard one because they are mixed in struct where not all field are used...

When done, I wouldn't be surprised on some other glitches...

  • Thanks 4
Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted

Hi all,

I've finally refactor the Device properties management in Clover. That was a huge nightmare, mainly because they were all using the same data structure with some field used in some case and some other never used in some other cases. Finding if something is NOT used is always harder than something where and when something is used !

As usual, any tests are welcomed as I can't test a lot of configuration...

 

I also improved the menu. There is now 3 sub menu in Options->Pci devices :

- Properties

- Arbitrary Properties

- Add Properties

 

They, of course, correspond to the Config.plist section.

In these menu, you can enable/disable each property.

 

So please, confirm that your device properties seems to be well injected.

 

Here is the efi : CloverX64-2021-03-31-18-47-00-a5494a8-dirty-jief.zip

It's not committed yet, so please use this file. Do not compile the last commit (it's not working).

You can now check you used the right file once booted in macOs by looking at the system information :

207039945_Screenshot2021-03-31at18_49_41.png.b069a4fe9866e6171d0755e09b671801.png

The name must be the same as the efi file name when I posted it.

 

 

  • Thanks 2
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
23 minutes ago, Jief_Machak said:

Hi all,

I've finally refactor the Device properties management in Clover. That was a huge nightmare, mainly because they were all using the same data structure with some field used in some case and some other never used in some other cases. Finding if something is NOT used is always harder than something where and when something is used !

As usual, any tests are welcomed as I can't test a lot of configuration...

 

I also improved the menu. There is now 3 sub menu in Options->Pci devices :

- Properties

- Arbitrary Properties

- Add Properties

 

They, of course, correspond to the Config.plist section.

In these menu, you can enable/disable each property.

 

So please, confirm that your device properties seems to be well injected.

 

Here is the efi : CloverX64-2021-03-31-18-47-00-a5494a8-dirty-jief.zip

It's not committed yet, so please use this file. Do not compile the last commit (it's not working).

You can now check you used the right file once booted in macOs by looking at the system information :

207039945_Screenshot2021-03-31at18_49_41.png.b069a4fe9866e6171d0755e09b671801.png

The name must be the same as the efi file name when I posted it.

 

 


@Jief_Machak I confirm: Boot fine (Z390 Big Sur 11.3 Beta 5). Thanks for your great work.

I take a look to the submenu of Option/PCIdevices. I don't understand what 'Arbitrary Properties' and  'Add Properties' are ! Because I don't find these sections in Config-sample.plist
 

Properties submenu, I like the checkbox. Is It possible to have also a checkbox for <key>PciRoot(0x0)/Pci(0x1c,0x1)/Pci(0x0,0x0)</key>, for example. So we can enable or disable all sub-keys in one time

Sorry for my bad English.

 

 

 

  • Thanks 1
Link to comment
Share on other sites
eng_redaesm
eng_redaesm
Posted
Posted
1 hour ago, Jief_Machak said:

Hi all,

I've finally refactor the Device properties management in Clover. That was a huge nightmare, mainly because they were all using the same data structure with some field used in some case and some other never used in some other cases. Finding if something is NOT used is always harder than something where and when something is used !

As usual, any tests are welcomed as I can't test a lot of configuration...

 

I also improved the menu. There is now 3 sub menu in Options->Pci devices :

- Properties

- Arbitrary Properties

- Add Properties

 

They, of course, correspond to the Config.plist section.

In these menu, you can enable/disable each property.

 

So please, confirm that your device properties seems to be well injected.

 

Here is the efi : CloverX64-2021-03-31-18-47-00-a5494a8-dirty-jief.zip

It's not committed yet, so please use this file. Do not compile the last commit (it's not working).

You can now check you used the right file once booted in macOs by looking at the system information :

207039945_Screenshot2021-03-31at18_49_41.png.b069a4fe9866e6171d0755e09b671801.png

The name must be the same as the efi file name when I posted it.

 

 

confirm boots well

  • Thanks 1
Link to comment
Share on other sites
eng_redaesm
eng_redaesm
Posted
Posted
1 hour ago, Jief_Machak said:

Hi all,

I've finally refactor the Device properties management in Clover. That was a huge nightmare, mainly because they were all using the same data structure with some field used in some case and some other never used in some other cases. Finding if something is NOT used is always harder than something where and when something is used !

As usual, any tests are welcomed as I can't test a lot of configuration...

 

I also improved the menu. There is now 3 sub menu in Options->Pci devices :

- Properties

- Arbitrary Properties

- Add Properties

 

They, of course, correspond to the Config.plist section.

In these menu, you can enable/disable each property.

 

So please, confirm that your device properties seems to be well injected.

 

Here is the efi : CloverX64-2021-03-31-18-47-00-a5494a8-dirty-jief.zip

It's not committed yet, so please use this file. Do not compile the last commit (it's not working).

You can now check you used the right file once booted in macOs by looking at the system information :

207039945_Screenshot2021-03-31at18_49_41.png.b069a4fe9866e6171d0755e09b671801.png

The name must be the same as the efi file name when I posted it.

 

 

there is something strange i've noticed with this build  HEVEC CODEC is not enabled

 

but with this build  working good 

 

On 3/30/2021 at 6:42 AM, Jief_Machak said:

@Matgen84 Could you test this version : CloverX64-2021-03-30-06-39-58-a5494a8-dirty-jief.zip ?

and @eng_redaesm @tluck @MifJpn ?

Screen Shot 2021-03-31 at 8.33.24 PM.png

  • Like 1
Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
2 hours ago, Matgen84 said:

Because I don't find these sections in Config-sample.plist

They exist under Device/Arbitrary and Devices/AppProperties. Maybe you just don't need it.

 

57 minutes ago, eng_redaesm said:

but with this build  working good 

Probably an injection problem... That's the only thing I've touched.

@eng_redaesm Could you boot CloverX64-2021-03-31-21-48-49-a5494a8-dirty-jief.zip, check that HEVEC is enable and do "ioreg -lw0" > ioreg_ok.txt

Then boot : CloverX64-2021-03-31-21-50-04-a5494a8-dirty-jief.zip. Check that HEVEC in not enabled and do "ioreg -lw0 > ioreg_nok.txt

and send me the 2 files.

2 hours ago, Matgen84 said:

Is It possible to have also a checkbox for <key>PciRoot(0x0)/Pci(0x1c,0x1)/Pci(0x0,0x0)</key>, for example

I'm afraid that'll be too much work for now, due to the way the Clover menu system works. But I guess one day I'll refactor that too :lol::lol::lol:

  • Thanks 1
Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
10 minutes ago, iCanaro said:

I see that Clover is still stuck at this commit,

https://github.com/CloverHackyColor/CloverBootloader/commit/a5494a89f69a6ba08f12e8d287b97ab100ca0539

if it has already been said, sorry, but I have not read all the posts, but with this the device properties section is not loaded

Yes, I forgot to commit the fix yesterday and I started this properties refactoring.

That's why you have to use the efi I've posted here.

If there is reasonable success, I'll commit everything.

  • Thanks 2
Link to comment
Share on other sites
iCanaro
iCanaro
Posted
Posted
46 minutes ago, Jief_Machak said:

They exist under Device/Arbitrary and Devices/AppProperties. Maybe you just don't need it.

 

Probably an injection problem... That's the only thing I've touched.

@eng_redaesm Could you boot CloverX64-2021-03-31-21-48-49-a5494a8-dirty-jief.zip, check that HEVEC is enable and do "ioreg -lw0" > ioreg_ok.txt

Then boot : CloverX64-2021-03-31-21-50-04-a5494a8-dirty-jief.zip. Check that HEVEC in not enabled and do "ioreg -lw0 > ioreg_nok.txt

and send me the 2 files.

I'm afraid that'll be too much work for now, due to the way the Clover menu system works. But I guess one day I'll refactor that too :lol::lol::lol:

with this version at first glance everything seems OK, even H264 and HEVC are OK

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
43 minutes ago, Slice said:

and all my Properties are injected as it should.

@Slice Glad it works. Do you have any Device Properties ? or Arbitrary ? or AddProperties ?

3 minutes ago, iCanaro said:

with this version at first glance everything seems OK, even H264 and HEVC are OK

@iCanaro Which one ? There is 2 efi files in the poste you quoted. One is WITHOUT the refactor and one is WITH it. So it's important to know which one do you test.

This one is the refactored one : CloverX64-2021-03-31-21-50-04-a5494a8-dirty-jief

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
7 minutes ago, iCanaro said:

@Jief_Machak 

i used this CloverX64-2021-03-31-18-47-00-a5494a8-dirty-jief.zip

you have device properties very populated in all the hacks, here for example the Z370

589437098_Schermata2021-03-31alle21_48_32.thumb.png.b0ba9de856f9edceb13f941cfe02d7cd.png

CloverX64-2021-03-31-18-47-00-a5494a8-dirty-jief.zip this one is good too.

Are they in Properties section ? Or Arbitrary section ? Or AddProperties section ?

Link to comment
Share on other sites
iCanaro
iCanaro
Posted
Posted
2 minutes ago, Jief_Machak said:

CloverX64-2021-03-31-18-47-00-a5494a8-dirty-jief.zip this one is good too.

Are they in Properties section ? Or Arbitrary section ? Or AddProperties section ?

here

Devices --> Properties

659562438_Schermata2021-03-31alle22_01_41.thumb.png.e8b06069c4bd111ba581f9a2dcc0157d.png

Link to comment
Share on other sites
eng_redaesm
eng_redaesm
Posted
Posted
1 hour ago, Jief_Machak said:

They exist under Device/Arbitrary and Devices/AppProperties. Maybe you just don't need it.

 

Probably an injection problem... That's the only thing I've touched.

@eng_redaesm Could you boot CloverX64-2021-03-31-21-48-49-a5494a8-dirty-jief.zip, check that HEVEC is enable and do "ioreg -lw0" > ioreg_ok.txt

Then boot : CloverX64-2021-03-31-21-50-04-a5494a8-dirty-jief.zip. Check that HEVEC in not enabled and do "ioreg -lw0 > ioreg_nok.txt

and send me the 2 files.

I'm afraid that'll be too much work for now, due to the way the Clover menu system works. But I guess one day I'll refactor that too :lol::lol::lol:

CloverX64-2021-03-31-21-48-49-a5494a8-dirty-jief.zip, works good there is HEVEC

but with  CloverX64-2021-03-31-21-50-04-a5494a8-dirty-jief.zip no HEVEC

here is the ioreg 

ioreg_nok_48.txt ioreg_nok_50.txt

  • Like 1
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
12 hours ago, Jief_Machak said:

I'm afraid that'll be too much work for now, due to the way the Clover menu system works. But I guess one day I'll refactor that too :lol::lol::lol:


@Jief_Machak I guess that'll be refactoring one day. TODO list is growing from day to day :D

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
11 hours ago, eng_redaesm said:

CloverX64-2021-03-31-21-48-49-a5494a8-dirty-jief.zip, works good there is HEVEC

but with  CloverX64-2021-03-31-21-50-04-a5494a8-dirty-jief.zip no HEVEC

here is the ioreg 

ioreg_nok_48.txt 1.8 MB · 0 downloads ioreg_nok_50.txt 1.8 MB · 0 downloads

 

10 hours ago, eng_redaesm said:

@Jief_Machak

very strange but test again now both commits has HEVEC  i don't know why or what happened  ioreg_nok50.txtioreg_nok49.txt

I have to say that I'm not sure which log correspond to what !

You both named them ioreg_nok_xx.txt. 'nok' stands for "Not OK'. But then, you said both boot were sucessful. You said "test again" soI guess it's a reboot.

 

So, did you generate ioreg_nok_48.txt with CloverX64-2021-03-31-21-48-49-a5494a8-dirty-jief.zip and you had HEVEC.

did you generate ioreg_nok_50.txt   with CloverX64-2021-03-31-21-50-04-a5494a8-dirty-jief.zip and had not HEVEC.

Then, you reboot CloverX64-2021-03-31-21-50-04-a5494a8-dirty-jief.zip one more time and you had HEVEC.

Am I correct on all 3 statements ?

@MifJpn Please stop apologizing ;). I don't even know what you apologize for. You're fine. You didn't waste time or annoyed anyone. Your contribution is much appreciated. Everything's ok.

  • Like 3
  • Thanks 1
Link to comment
Share on other sites
matxpa
matxpa
Posted
Posted

@Jief_Machak

 

With your "CloverX64-2021-03-31-21-50-04-a5494a8-dirty-jief.efi" on  : 
    Laptop Asus X75VB (MBP11,3) IvyBridge (I5-3340M HD4000) and Desktop MSI Z270 SLI Plus (iMac18,3)  Kaby Lake (i5-7600K RX 570)
        - Big Sur 11.2.3 (20D91)                     PreBoot and Recovery--> boot OK
        - Big Sur beta6 11.3 (20E5224a)       PreBoot and Recovery--> boot OK

On Desktop only

        - Catalina 10.15.7 (19H524)                PreBoot and Recovery--> boot OK

 

Big Sur beta5 11.3 (20E5217a) to Big Sur beta6 11.3 (20E5224a) update was done on both Laptop and Desktop with that commit.

 

  • Like 3
Link to comment
Share on other sites
eng_redaesm
eng_redaesm
Posted
Posted
5 hours ago, Jief_Machak said:

 

I have to say that I'm not sure which log correspond to what !

You both named them ioreg_nok_xx.txt. 'nok' stands for "Not OK'. But then, you said both boot were sucessful. You said "test again" soI guess it's a reboot.

 

So, did you generate ioreg_nok_48.txt with CloverX64-2021-03-31-21-48-49-a5494a8-dirty-jief.zip and you had HEVEC.

did you generate ioreg_nok_50.txt   with CloverX64-2021-03-31-21-50-04-a5494a8-dirty-jief.zip and had not HEVEC.

Then, you reboot CloverX64-2021-03-31-21-50-04-a5494a8-dirty-jief.zip one more time and you had HEVEC.

Am I correct on all 3 statements ?

@MifJpn Please stop apologizing ;). I don't even know what you apologize for. You're fine. You didn't waste time or annoyed anyone. Your contribution is much appreciated. Everything's ok.

yes you are correct 

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted

Ok. So  that's probably not connected to my current refactoring because it seems to work with the others. That's why I've committed to github.

That said, if there is a Clover bug that causes intermittent failure of the codec loading, we'll track it !

Of course, the first thing to do is to know how to reproduce, because it's matter of luck, you never know for sure if this is fixed or not.

 

So I propose you stick to the last commit for a little time. You check if your codec is ok after each reboot. Have some cold boot too. Then after 10 or 20 boots, we'll see if the bug seems there, and if yes, how often.

You tell me then and will see...

last version is there : https://github.com/jief666/CloverCommits/blob/master/C-20210401110653-69a47c5.efi

  • Like 2
Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...