Clover General discussion

Matgen84 · March 10, 2021

38 minutes ago, kushwavez said:
But for example another rename is working. _INI is a method too.

_SB.PCI0.RP09._INI -> XINI

_SB.PCI0 (Scope)

RP09 (Device)

_INI (Method)
[...]
4:250  0:000  Name: _INI, Bridge: RP09, Replace: XINI
4:253  0:003    1 replacements
[...]
So I suppose _GPE.NTFY -> XTFY should work too, but it doesn't.

I suppose that Bridge must be a device: Scope/Device/Method works for INI --> XINI. Maybe this is the reason why RenameDevice don't work for _GPE

[...]
0:712  0:000  NTFY:_GPE:->will be renamed to XTFY
[...]
4:851  0:003  Name: NTFY, Bridge: _GPE, Replace: XTFY
4:852  0:001    0 replacements
[...]

kushwavez · March 10, 2021

Hmm.. yes that must be it. I tried with _SB.PCI0.RP09._PS3 too, but that doesn't work either.

_SB.PCI0.RP09 (Scope)
_PS3 (Method)

0:742  0:000  _PS3:RP09:PCI0:_SB_:->will be renamed to XPS3
[...]
7:700  0:001  Name: _PS3, Bridge: RP09, Replace: XPS3
7:705  0:003    0 replacements

But then any idea how can I rename them?

I need to patch ONLY one match, so I can't use hex rename patch because that will rename all matches.

Any idea @Slice?

_GPE.NTFY is the reason why my TB3 SSDT can't load up.

Slice · March 10, 2021

4 hours ago, kushwavez said:
Hmm.. yes that must be it. I tried with _SB.PCI0.RP09._PS3 too, but that doesn't work either.

_SB.PCI0.RP09 (Scope)

_PS3 (Method)
0:742  0:000  _PS3:RP09:PCI0:_SB_:->will be renamed to XPS3
[...]
7:700  0:001  Name: _PS3, Bridge: RP09, Replace: XPS3
7:705  0:003    0 replacements
But then any idea how can I rename them?

I need to patch ONLY one match, so I can't use hex rename patch because that will rename all matches.

Any idea @Slice?

_GPE.NTFY is the reason why my TB3 SSDT can't load up.

What is your Clover version? It was repaired recently https://github.com/CloverHackyColor/CloverBootloader/commit/e1a49a85b9f644e718f8d042444ea52a2e37f570

But may be you have a new bug.

I will check a little later.

kushwavez · March 10, 2021

@Slice Latest, Clover v5131

Slice · March 11, 2021

Sorry, no. The procedure is RenameDevices. It can't rename methods.

So rename _SB.PCI0.RP09._INI -> XINI shouldn't work.

Ok, I will look if it is possible to extend functionality.

The problem will be with the method call. You probably want the method will never called? You probably can to Find/Replace this call.

kushwavez · March 11, 2021

4 hours ago, Slice said:

Sorry, no. The procedure is RenameDevices. It can't rename methods.

So rename _SB.PCI0.RP09._INI -> XINI shouldn't work.

unfortunate. But it's working for now, even if because a bug.

4 hours ago, Slice said:

Ok, I will look if it is possible to extend functionality.

That would be neat, thanks.

4 hours ago, Slice said:

The problem will be with the method call. You probably want the method will never called? You probably can to Find/Replace this call.

Yes, I want to replace NTFY to XTFY inside _GPE scope. The problem is, if I simply use find/replace, that is replacing all matches, not just inside the _GPE Scope.

Hmm.. well, I'll locate that exact NTFY with HexFiend in the .aml, see what before or after and add that to find/replace. That could work.

kushwavez · March 11, 2021

So yes, HexFiend worked, but I found some (cosmetic I guess) issue.

If I rename something that is not in DSDT, but in SSDT, log says "bin not found / already patched" even if it's being patched.

For example _UPC to XUPC (_UPC is ONLY in SSDT's, not in DSDT): I looked up my SSDT-4.aml with HexFiend to find the pattern, found:

_UPC? (5F555043 08A4)
6_UPC (365F5550 43)
%_UPC (255F5550 43)

If I look at the log, it says:

10:786  0:000   - [_UPC? to XUPC]: pattern 5F555043, bin not found / already patched!
10:786  0:000   - [6_UPC to XUPC]: pattern 365F5550, bin not found / already patched!
10:786  0:000   - [%_UPC to XUPC]: pattern 255F5550, bin not found / already patched!

In this case this msg is at the first attempt for patch, so it isn't "already patched"

But they're patched, looking at my SSDT-4, so that's why I say it's cosmetic issue:

If it's in my DSDT, for example _GPE.NTFY (CGNTFY: 43474E54 4659) to XTFY it says:

10:787  0:000   - [GPE_NTFY to XTFY]: pattern 43474E54, patched at: [ (16B81) ]

So, in DSDT it's reporting correctly.

I think I'm gonna report these on GitHub, just for better tracking.

But at least finally my Thunderbolt Hot-Plug is working fine!

EDIT: reported them on Github for better tracking:

#379 Binpatch: "bin not found / already patched" if the pattern is in SSDT, but it's being patched even so

#378 [Enhancement] Use RenameDevices for Methods too

Edited March 11, 2021 by kushwavez

MacKonsti · March 13, 2021

Hi @Jief_Machak hope you are well. Can I kindly ask you to update your CloverValidator excellent tool to change the expected tags for <key>RenameDevices</key> ?

I get now Error: Expecting tag 'dict' at line 244.

According to @Slice post in the Clover updates:

New Clover proposes to rewrite this as:
            <key>RenameDevices</key>
            <array>
            	<dict>
                	<key>_SB.PCI0.RP05.PXSX</key>
                	<string>UPSB</string>
            	</dict>
             	<dict>
                	<key>_SB.PCI0.RP05.UPSB.DSB1.NHI0</key>
                	<string>UPS0</string>
                </dict>
           		<dict>
                	<key>_SB.PCI0.RP03.PXSX</key>
                	<string>BRG3</string>
            	</dict>
            </array>
In this case the order will be guaranteed.

Thank you!
(it's also a good opportunity to put a version in your too, too! Your safe bet is the date like iasl tool )

Slice · March 13, 2021

@kushwavez

Thanks for your reports. When I will have a time I will study what I can to do.

@MacKonsti

It is because of format of RenameDevices changed while CloverValidator no.

MacKonsti · March 13, 2021

Hi @Slice yes I am aware that now you allow <arrays> and afterwards inside <dict> entries, so I was hoping @Jief_Machak would be able to update his CloverValidator tool for Clover r5131+ for us
Many thanks to both.

P.S. Perhaps it would be a good idea to package CloverValidator with the newer Clover releases? It's extremely useful...

Edited March 13, 2021 by MacKonsti

Jief_Machak · March 14, 2021

On 3/8/2021 at 10:43 PM, Slice said:

2. Boot by timeout.

@Slice : do you mean that boot with pressing a key always works, and boot with timeout crash (before commit 45801ef2da07a163d27e513559fc5125b0546d67 "correct use of virtual pointer" ) ?

Jief_Machak · March 14, 2021

@Slice I tried to boot with timeout but cannot reproduce yet.

How did you compile gcc 10.3 ? Could you send me the zip of that gcc folder, so I can test with the exact same compiler you used ?

Could you send me the qemu img ? And the launch command ? Maybe there is something in my config that make it work...

Slice · March 15, 2021

11 hours ago, Jief_Machak said:

@Slice : do you mean that boot with pressing a key always works, and boot with timeout crash (before commit 45801ef2da07a163d27e513559fc5125b0546d67 "correct use of virtual pointer" ) ?

Yes, there are user's reports about this. I just reproduce this with qemu.

Jief_Machak · March 15, 2021

1 minute ago, Slice said:

Yes, there are user's reports about this. I just reproduce this with qemu.

I did too, but no problem.

If it's just a GCC 10.3 bug, I think we should just ban that version that brings nothing more to Clover, instead of doing strange fix that just clutters the code. That's why I'd like to test and reproduce.

Could you send me your compiler ?

iCanaro · March 15, 2021

error compilation

Spoiler

Please enter your choice: 1) build Clover

2) build Clover with HFSPlus

3) make pkg

4) make app

5) make app (with Clover)

6) make iso

7) build all

8) test build (no autogen, no boot files)

9) status

10) update Clover

11) show diff

12) open CloverV2/EFI/CLOVER directory

13) update Clover (reset changes)

14) clean BaseTools

15) quit

Please enter your choice: 10

[UPDATE CLOVER]

Fetching origin

Fetching submodule OpenCorePkg

From https://github.com/CloverHackyColor/CloverBootloader

* branch master -> FETCH_HEAD

Fetching submodule OpenCorePkg

Already up-to-date.

------------------------------------------------------------------------

buildme, Clover r5131 (SHA: 3fb08d97f)

TOOLCHAIN: GCC53 (override example: './buildme XCODE8')

1) build Clover

2) build Clover with HFSPlus

3) make pkg

4) make app

5) make app (with Clover)

6) make iso

7) build all

8) test build (no autogen, no boot files)

9) status

10) update Clover

11) show diff

12) open CloverV2/EFI/CLOVER directory

13) update Clover (reset changes)

14) clean BaseTools

15) quit

Please enter your choice: 7

[CHECK XCODE]

WORKSPACE: /Users/utente/CloverBootloader

EDK_TOOLS_PATH: /Users/utente/CloverBootloader/BaseTools

CONF_PATH: /Users/utente/CloverBootloader/Conf

Copying $EDK_TOOLS_PATH/Conf/build_rule.template

to /Users/utente/CloverBootloader/Conf/build_rule.txt

Copying $EDK_TOOLS_PATH/Conf/tools_def.template

to /Users/utente/CloverBootloader/Conf/tools_def.txt

Copying $EDK_TOOLS_PATH/Conf/target.template

to /Users/utente/CloverBootloader/Conf/target.txt

[BUILD CLOVER]

TOOLCHAIN_DIR: /Users/utente/CloverBootloader/toolchain

NASM_PREFIX: /Users/utente/CloverBootloader/toolchain/bin/

NASM_VER: 2.15.05

Initializing workspace

recreate Conf folder

WORKSPACE: /Users/utente/CloverBootloader

EDK_TOOLS_PATH: /Users/utente/CloverBootloader/BaseTools

CONF_PATH: /Users/utente/CloverBootloader/Conf

Copying $EDK_TOOLS_PATH/Conf/build_rule.template

to /Users/utente/CloverBootloader/Conf/build_rule.txt

Copying $EDK_TOOLS_PATH/Conf/tools_def.template

to /Users/utente/CloverBootloader/Conf/tools_def.txt

Copying $EDK_TOOLS_PATH/Conf/target.template

to /Users/utente/CloverBootloader/Conf/target.txt

Running edk2 build for CloverX64 using the command:

build -D DISABLE_USB_SUPPORT -D NO_GRUB_DRIVERS_EMBEDDED --conf=/Users/utente/CloverBootloader/Conf -D USE_BIOS_BLOCKIO -D USE_LOW_EBDA -p Clover.dsc -a X64 -b RELEASE -t GCC53 -n 13

Build environment: Darwin-19.6.0-x86_64-i386-64bit

Build start time: 12:32:25, Mar.15 2021

WORKSPACE = /Users/utente/CloverBootloader

EDK_TOOLS_PATH = /Users/utente/CloverBootloader/BaseTools

CONF_PATH = /Users/utente/CloverBootloader/Conf

Processing meta-data .Architecture(s) = X64

Build target = RELEASE

Toolchain = GCC53

Active Platform = /Users/utente/CloverBootloader/Clover.dsc

...build: : warning: Module MetaFile [Sources] is missing local header!

Local Header: /users/utente/cloverbootloader/refit_uefi/cpp_unit_test/strcasecmp_test.h not found in /Users/utente/CloverBootloader/rEFIt_UEFI/refit.inf

build: : warning: Module MetaFile [Sources] is missing local header!

Local Header: /users/utente/cloverbootloader/refit_uefi/cpp_unit_test/strcasecmp_test.h not found in /Users/utente/CloverBootloader/rEFIt_UEFI/refit.inf

done!

Building ... /Users/utente/CloverBootloader/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf [X64]