Slice Posted March 7, 2020 Share Posted March 7, 2020 18 minutes ago, Matgen84 said: Hi @Slice I just build and install latest r5104 (a00e14851). I've the same issues described yesterday: quick test message left top corner "all tests" + no icons. My knowledge is limited: It seems that the files with icns extension aren't display correctly. I excluded icns decoder because years ago we stated that all icons must be PNG files renamed to .icns. 1 1 Link to comment Share on other sites More sharing options...
Matgen84 Posted March 7, 2020 Share Posted March 7, 2020 (edited) 9 minutes ago, Slice said: I excluded icns decoder because years ago we state that all icon must be PNG files renamed to .icns. Sorry for my bad english: all icons are png files rename to .icns as I describe yesterday. I use one of BadruZeus's theme for Clover that worked fine before. It works if I rollback to r5104 (8dbd938bf). What about quick test message left top corner "all tests" Edited March 7, 2020 by Matgen84 Link to comment Share on other sites More sharing options...
Matgen84 Posted March 7, 2020 Share Posted March 7, 2020 Hi again @Slice I've found a new issue. When I use spacebar or arrow key: there is new message: a code line about operator or something like that, at left top corner. F10 don't work because keyboard don't work, so I can't post the screenshot. Link to comment Share on other sites More sharing options...
Slice Posted March 7, 2020 Share Posted March 7, 2020 2 hours ago, Matgen84 said: Sorry for my bad english: all icons are png files rename to .icns as I describe yesterday. I use one of BadruZeus's theme for Clover that worked fine before. It works if I rollback to r5104 (8dbd938bf). What about quick test message left top corner "all tests" The message "all tests..ok" can be excluded. It will be no in release. But about icns (PNG) I didn't test the theme. I think those png files are not standard. See Optimise PNG files Anyway it is strange that it worked before. 1 1 Link to comment Share on other sites More sharing options...
Matgen84 Posted March 7, 2020 Share Posted March 7, 2020 (edited) 1 hour ago, Slice said: The message "all tests..ok" can be excluded. It will be no in release. But about icns (PNG) I didn't test the theme. I think those png files are not standard. See Optimise PNG files Anyway it is strange that it worked before. @Slice The theme I'm using, is a BadruZeus's theme for Clover, included in CloverThemeManager. So, I think icns (PNG) are already optimize. This theme works fine with the version r5104 (8dbd938bf) @Jief_Machak knows the problem since Friday (see previous post). Now, there is another issue: When I use spacebar or arrow key to access to Menu: there is new message: a code line message about 'operator' or something like that, at left top corner. F10 don't work because keyboard don't work, so I can't post the screenshot. Edited March 7, 2020 by Matgen84 Link to comment Share on other sites More sharing options...
Slice Posted March 7, 2020 Share Posted March 7, 2020 On 3/6/2020 at 12:50 PM, Matgen84 said: This theme works fine with r5104 (8dbd938bf), don't works with r5104 (bc45ded34): perhaps, the problem comes from change between these two versions and in several commits. Unfortunately, I have no debug version because I only compile in release mode. So it is difficult to do tests to pinpoint the problem. There are changes in lodepng.cpp. But we have more recent version and it should work better as the author said. I may suppose bad png icons are decoded by old algo but failed with better algo. Link to comment Share on other sites More sharing options...
Matgen84 Posted March 7, 2020 Share Posted March 7, 2020 23 minutes ago, Slice said: There are changes in lodepng.cpp. But we have more recent version and it should work better as the author said. I may suppose bad png icons are decoded by old algo but failed with better algo. If it's right, There will be a lot of problems for all themes in CloverThemeManager and the great themes created by Badruzeus. 1 Link to comment Share on other sites More sharing options...
vector sigma Posted March 7, 2020 Share Posted March 7, 2020 53 minutes ago, Slice said: I may suppose bad png icons are decoded by old algo but failed with better algo Any conversion to do on the fly by Clover.app needed.... based on Clover revision?? 1 Link to comment Share on other sites More sharing options...
Slice Posted March 7, 2020 Share Posted March 7, 2020 22 minutes ago, vector sigma said: Any conversion to do on the fly by Clover.app needed.... based on Clover revision?? May be additional button? <Optimize theme icons> 1 Link to comment Share on other sites More sharing options...
vector sigma Posted March 7, 2020 Share Posted March 7, 2020 6 minutes ago, Slice said: May be additional button? <Optimize theme icons> Ok. And the result should be a png-8 with indexed color with 8-bit samples? 1 Link to comment Share on other sites More sharing options...
Matgen84 Posted March 7, 2020 Share Posted March 7, 2020 36 minutes ago, Slice said: May be additional button? <Optimize theme icons> I try Optimize png on my current theme: icons appears again but the new message: a code line message about 'operator' remains (no keyboard, no mouse). I can boot using timeout. Link to comment Share on other sites More sharing options...
Matgen84 Posted March 7, 2020 Share Posted March 7, 2020 8 minutes ago, Slice said: The message is 12:072 2:196 XArray::ElementAt(xsize) const -> Operator [] : index > m_len when I pressed SPACE on Mojave icon. Right. or when I pressed ARROW key left or right. Link to comment Share on other sites More sharing options...
vector sigma Posted March 7, 2020 Share Posted March 7, 2020 (edited) On 3/7/2020 at 4:06 PM, Slice said: May be additional button? <Optimize theme icons> Done: test app removed guys please report back.. thanks Edited March 8, 2020 by vector sigma 1 2 Link to comment Share on other sites More sharing options...
Matgen84 Posted March 8, 2020 Share Posted March 8, 2020 12 hours ago, vector sigma said: Done: Clover.app.zip guys please report back.. thanks Hi @vector sigma I've got a problem with indexing: not all themes are in preview window. Is it possible to optimize a theme installed which is not in the GitHub theme repo! I don't know if I made a mistake but when I check "Show Installed", Clover.app close itself. Thanks 1 Link to comment Share on other sites More sharing options...
vector sigma Posted March 8, 2020 Share Posted March 8, 2020 7 hours ago, Matgen84 said: repo! I don't know if I made a mistake but when I check "Show Installed", Clover.app close itself. Simply, you have a very very slow internet connection and no patient . Jokes aside try the last: Clover.app.zip P.S. you can now optimize only installed themes. @Slice, I introduced error handling optimizing themes and this is what I got at first try: Can't load /Volumes/EFI/EFI/CLOVER/themes/BGM/icons/pointer.icns: incorrect PNG signature, it's no PNG or corrupted manually checking it is true because it is really an icns instead of a png. Isn't this causing problems? 1 Link to comment Share on other sites More sharing options...
Matgen84 Posted March 8, 2020 Share Posted March 8, 2020 30 minutes ago, vector sigma said: Simply, you have a very very slow internet connection and no patient . Jokes aside try the last: Clover.app.zip P.S. you can now optimize only installed themes. Thanks. I've error message 'incorrect PNG signature, it's no PNG or corrupted' on several real png file on several theme. 2 Link to comment Share on other sites More sharing options...
Jief_Machak Posted March 8, 2020 Share Posted March 8, 2020 I'm about to commit the fix in a minute. 2 Link to comment Share on other sites More sharing options...
Matgen84 Posted March 8, 2020 Share Posted March 8, 2020 43 minutes ago, Jief_Machak said: I'm about to commit the fix in a minute. I've this issue when I build [SLINK] CLOVERX64 Undefined symbols for architecture x86_64: "egDecodeICNS(unsigned char*, unsigned long long, unsigned long long, unsigned char)", referenced from: egLoadIcon(_EFI_FILE_PROTOCOL*, wchar_t const*, unsigned long long) in CLOVERX64.lib(image.obj) ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) make: *** [/Users/mathieu/src/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit/DEBUG/CLOVERX64.dll] Error 1 build.py... : error 7000: Failed to execute command make tbuild [/Users/mathieu/src/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit] build.py... : error F002: Failed to build module /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/refit.inf [X64, XCODE8, RELEASE] - Failed - Build end time: 17:53:52, Mar.08 2020 Link to comment Share on other sites More sharing options...
Jief_Machak Posted March 8, 2020 Share Posted March 8, 2020 Forgot refit.inf. You can try, it compiles here with xcode. Link to comment Share on other sites More sharing options...
Matgen84 Posted March 8, 2020 Share Posted March 8, 2020 4 minutes ago, Jief_Machak said: Forgot refit.inf. You can try, it compiles here with xcode. Thanks I can build again. There is the same issue... Link to comment Share on other sites More sharing options...
Jief_Machak Posted March 8, 2020 Share Posted March 8, 2020 Sorry, I'm just working on Clover efi, not the app. 1 Link to comment Share on other sites More sharing options...
Slice Posted March 8, 2020 Share Posted March 8, 2020 Theme containing icns format must be rejected as not confirming Clover requirements. All icons MUST be PNG! 1 Link to comment Share on other sites More sharing options...
Mork vom Ork Posted March 8, 2020 Share Posted March 8, 2020 (edited) i have just updated the de-language files for CLOVER and CloverApp. Attached you will find the files wich where changed de_language_files.zip Edited March 8, 2020 by Mork vom Ork 1 Link to comment Share on other sites More sharing options...
vector sigma Posted March 8, 2020 Share Posted March 8, 2020 41 minutes ago, Matgen84 said: There is the same issue... Yes but I'm not the theme author... the app is also too precise since it tells you. 34 minutes ago, Slice said: Theme containing icns format must be rejected as not confirming Clover requirements. All icons MUST be PNG! I can covert icns to png on the fly. Should I? Link to comment Share on other sites More sharing options...
vector sigma Posted March 8, 2020 Share Posted March 8, 2020 @Matgen84 try this: Clover.app.zip P.S. conversion of all images to png when optimizing... only if they are not. 1 Link to comment Share on other sites More sharing options...
Recommended Posts