Clover General discussion

Sherlocks · June 24, 2019

7 minutes ago, gujiangjiang said:

When update to latest Clover it show an error or bug?

EFI or EF?

It shows "EF" in XPS 15 But in my anther laptop it shows well "EFI".

also me too.

vector sigma · June 24, 2019

14 hours ago, joevt said:

serial or firewire kprintf?

@joevt easy as I said, no redirecting to any socket, just my screen as It took just two reboots to understand that the xcpm patch wasn't working as the AIPM works. Anyway not really sure it "just don't work" or it's a consequence of another thing.

12 hours ago, PMheart said:

@joevt is correct, and I hope we have a workaround to this: (Apply the patch via Clover KernelToPatch)

https://github.com/acidanthera/OcSupportPkg/blob/3223115d876632f13408f64c182046dc1badd785/Library/OcAppleKernelLib/CommonPatches.c#L948-L958

Credit to @vit9696.

Thanks, looks pomising, I'll try it soon and let you know.

7 hours ago, Slice said:

I didn't check in 10.14+ but it is working in 10.13 with my i5-3320M.

I can confirm that it works well in mojave and sierra, but in 10.15 I have problems. Let see if I can provide more info with the patch @PMheart link to us... within an hour ...more or less when I'll be at Home.

vector sigma · June 24, 2019

Beta of 10.15 (19A487l)
Last login: Mon Jun 24 20:55:52 on console
vectorsigma@MacBook-Pro-di-vector ~ % sysctl -n machdep.xcpm.mode
0
vectorsigma@MacBook-Pro-di-vector ~ %

that's the outcome, xcpm enabled (confirmed in bdmesg) plus AICPM patch. This is the panic w/o AICPM patch and KernelXCPM turned on (thanks again to @PMheart for the patch linked):

still panics on AppleIntelCPUPowerManagement.

P.S. KernelPm turned on as well.

vector sigma · June 24, 2019

14 hours ago, Matgen84 said:

It's the same with release from Repo.

Not related, sf or the OS remove it during the download or the decompression. During the compilation the image is there, or at least for me.

PMheart · June 25, 2019

@vector sigma I think I have figured it out:

https://sourceforge.net/p/cloverefiboot/code/4973/tree/rEFIt_UEFI/Platform/kernel_patcher.c#l1122

which should be os_version >= AsciiOSVersionToUint64("10.16") now. (Meaning that 10.15 is still "unsupported" despite I added necessary patches)

Please also change the comment right above, thanks!

Matgen84 · June 25, 2019

9 hours ago, vector sigma said:

Not related, sf or the OS remove it during the download or the decompression. During the compilation the image is there, or at least for me.

I talk about Clover logo into Installer 'Background image' (Cloverpackage/Resources/Background.tiff), not Clover icon

mhaeuser · June 25, 2019

@PMheart probably an option similiar to Lilu's Beta bootflag makes sense?

PMheart · June 25, 2019

2 minutes ago, Download-Fritz said:

@PMheart probably an option similiar to Lilu's Beta bootflag makes sense?

Nope. It's not like the bytes are stable, so better to leave as is.

Yet I came up with a tiny function for compatibility check, see the diff please: (@vector sigma)

Index: rEFIt_UEFI/Platform/kernel_patcher.c
===================================================================
--- rEFIt_UEFI/Platform/kernel_patcher.c	(revision 4973)
+++ rEFIt_UEFI/Platform/kernel_patcher.c	(working copy)
@@ -822,6 +822,15 @@
 }
 
 //
+// Global XCPM patches compatibility
+// Currently 10.8.5 - 10.15
+//
+static inline BOOLEAN IsXCPMOSVersionCompat(UINT64 os_version)
+{
+  return (os_version >= AsciiOSVersionToUint64("10.8.5")) && (os_version < AsciiOSVersionToUint64("10.16")); 
+}
+
+//
 // Enable Unsupported CPU PowerManagement
 //
 // syscl - SandyBridgeEPM(): enable PowerManagement on SandyBridge-E
@@ -846,8 +855,8 @@
   UINT64      os_version = AsciiOSVersionToUint64(Entry->OSVersion);
 
   // check OS version suit for patches
-  if (os_version < AsciiOSVersionToUint64("10.8.5") || os_version >= AsciiOSVersionToUint64("10.14")) {
-    DBG("Unsupported macOS.\nHaswell-E requires macOS 10.8.5 - 10.13.x, aborted\n");
+  if (!IsXCPMOSVersionCompat(os_version)) {
+    DBG("HaswellEXCPM(): Unsupported macOS.\n");
     DBG("HaswellEXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -988,8 +997,8 @@
   UINT64      os_version = AsciiOSVersionToUint64(Entry->OSVersion);
 
   // check OS version suit for patches
-  if (os_version < AsciiOSVersionToUint64("10.8.5")) {
-    DBG("Unsupported macOS.\nBroadwell-E/EP requires macOS at least 10.8.5, aborted\n");
+  if (!IsXCPMOSVersionCompat(os_version)) {
+    DBG("BroadwellEPM(): Unsupported macOS.\n");
     DBG("BroadwellEPM() <===FALSE\n");
     return FALSE;
   }
@@ -1038,8 +1047,8 @@
   CHAR8       *comment;
 
   // check OS version suit for patches
-  if (os_version < AsciiOSVersionToUint64("10.8.5") || os_version >= AsciiOSVersionToUint64("10.14")) {
-    DBG("Unsupported macOS.\nHaswell Celeron/Pentium requires macOS 10.8.5 - 10.13.x, aborted\n");
+  if (!IsXCPMOSVersionCompat(os_version)) {
+    DBG("Unsupported macOS.\n");
     DBG("HaswellLowEndXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1118,9 +1127,8 @@
   }
 
   // check OS version suit for patches
-  // PMheart: attempt to add 10.14 compatibility
-  if (os_version < AsciiOSVersionToUint64("10.8.5") || os_version >= AsciiOSVersionToUint64("10.15")) {
-    DBG("Unsupported macOS.\nIvy Bridge XCPM requires macOS 10.8.5 - 10.13.x, aborted\n");
+  if (!IsXCPMOSVersionCompat(os_version)) {
+    DBG("Unsupported macOS.\n");
     DBG("KernelIvyBridgeXCPM() <===FALSE\n");
     return FALSE;
   } else if (os_version >= AsciiOSVersionToUint64("10.8.5") && os_version < AsciiOSVersionToUint64("10.12")) {
@@ -1203,8 +1211,8 @@
   
   // check OS version suit for patches
   // PMheart: attempt to add 10.14 compatibility
-  if (os_version < AsciiOSVersionToUint64("10.8.5") || os_version >= AsciiOSVersionToUint64("10.15")) {
-    DBG("Unsupported macOS.\nIvy Bridge-E XCPM requires macOS 10.8.5 - 10.13.x, aborted\n");
+  if (!IsXCPMOSVersionCompat(os_version)) {
+    DBG("Unsupported macOS.\n");
     DBG("KernelIvyE5XCPM() <===FALSE\n");
     return FALSE;
   }

Thanks!

Slice · June 25, 2019

Thanks, committed!

Slice · June 25, 2019

18 hours ago, gujiangjiang said:

When update to latest Clover it show an error or bug?

EFI or EF?

It shows "EF" in XPS 15 But in my anther laptop it shows well "EFI".

It is a bug requiring investigation.

cecekpawon · June 25, 2019

The string length is currently limited to 64 (SMBIOS_STRING_MAX_LENGTH) ?

https://github.com/tianocore/edk2/blob/3806e1fd139775610d8f2e7541a916c3a91ad989/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c#L196

Howerver, if I force change maxline in "UpdateSmbiosString" to SMBIOS_TABLE_MAX_LENGTH (with SmbiosEpsNew->MinorVersion = 7), "Apple ROM Info" doesnt show up.

https://sourceforge.net/p/cloverefiboot/code/HEAD/tree/rEFIt_UEFI/Platform/smbios.c#l303

Hope you will get a clue soon @Slice

Slice · June 25, 2019

Yes, thanks, it should be MAX_OEM_STRING. I will test at evening.

cecekpawon · June 25, 2019

Thanks. Also that unix lineending will produced "0x0D0A" by dmidecode instead of "0x0A" like on real mac dump.

vector sigma · June 25, 2019

10 hours ago, Download-Fritz said:

@PMheart probably an option similiar to Lilu's Beta bootflag makes sense?

Yes!

10 hours ago, PMheart said:

Nope. It's not like the bytes are stable, so better to leave as is.

Yet I came up with a tiny function for compatibility check, see the diff please: (@vector sigma)


Index: rEFIt_UEFI/Platform/kernel_patcher.c
===================================================================
--- rEFIt_UEFI/Platform/kernel_patcher.c	(revision 4973)
+++ rEFIt_UEFI/Platform/kernel_patcher.c	(working copy)
@@ -822,6 +822,15 @@
 }
 
 //
+// Global XCPM patches compatibility
+// Currently 10.8.5 - 10.15
+//
+static inline BOOLEAN IsXCPMOSVersionCompat(UINT64 os_version)
+{
+  return (os_version >= AsciiOSVersionToUint64("10.8.5")) && (os_version < AsciiOSVersionToUint64("10.16")); 
+}
+
+//
 // Enable Unsupported CPU PowerManagement
 //
 // syscl - SandyBridgeEPM(): enable PowerManagement on SandyBridge-E
@@ -846,8 +855,8 @@
   UINT64      os_version = AsciiOSVersionToUint64(Entry->OSVersion);
 
   // check OS version suit for patches
-  if (os_version < AsciiOSVersionToUint64("10.8.5") || os_version >= AsciiOSVersionToUint64("10.14")) {
-    DBG("Unsupported macOS.\nHaswell-E requires macOS 10.8.5 - 10.13.x, aborted\n");
+  if (!IsXCPMOSVersionCompat(os_version)) {
+    DBG("HaswellEXCPM(): Unsupported macOS.\n");
     DBG("HaswellEXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -988,8 +997,8 @@
   UINT64      os_version = AsciiOSVersionToUint64(Entry->OSVersion);
 
   // check OS version suit for patches
-  if (os_version < AsciiOSVersionToUint64("10.8.5")) {
-    DBG("Unsupported macOS.\nBroadwell-E/EP requires macOS at least 10.8.5, aborted\n");
+  if (!IsXCPMOSVersionCompat(os_version)) {
+    DBG("BroadwellEPM(): Unsupported macOS.\n");
     DBG("BroadwellEPM() <===FALSE\n");
     return FALSE;
   }
@@ -1038,8 +1047,8 @@
   CHAR8       *comment;
 
   // check OS version suit for patches
-  if (os_version < AsciiOSVersionToUint64("10.8.5") || os_version >= AsciiOSVersionToUint64("10.14")) {
-    DBG("Unsupported macOS.\nHaswell Celeron/Pentium requires macOS 10.8.5 - 10.13.x, aborted\n");
+  if (!IsXCPMOSVersionCompat(os_version)) {
+    DBG("Unsupported macOS.\n");
     DBG("HaswellLowEndXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1118,9 +1127,8 @@
   }
 
   // check OS version suit for patches
-  // PMheart: attempt to add 10.14 compatibility
-  if (os_version < AsciiOSVersionToUint64("10.8.5") || os_version >= AsciiOSVersionToUint64("10.15")) {
-    DBG("Unsupported macOS.\nIvy Bridge XCPM requires macOS 10.8.5 - 10.13.x, aborted\n");
+  if (!IsXCPMOSVersionCompat(os_version)) {
+    DBG("Unsupported macOS.\n");
     DBG("KernelIvyBridgeXCPM() <===FALSE\n");
     return FALSE;
   } else if (os_version >= AsciiOSVersionToUint64("10.8.5") && os_version < AsciiOSVersionToUint64("10.12")) {
@@ -1203,8 +1211,8 @@
   
   // check OS version suit for patches
   // PMheart: attempt to add 10.14 compatibility
-  if (os_version < AsciiOSVersionToUint64("10.8.5") || os_version >= AsciiOSVersionToUint64("10.15")) {
-    DBG("Unsupported macOS.\nIvy Bridge-E XCPM requires macOS 10.8.5 - 10.13.x, aborted\n");
+  if (!IsXCPMOSVersionCompat(os_version)) {
+    DBG("Unsupported macOS.\n");
     DBG("KernelIvyE5XCPM() <===FALSE\n");
     return FALSE;
   }

Thanks!

Thanks to you, I'll try it after the job!

13 hours ago, Matgen84 said:

I talk about Clover logo into Installer 'Background image' (Cloverpackage/Resources/Background.tiff), not Clover icon

O_ops, why that wasn't clear? . ~~I think this will be a bit difficult~~ since this is decided by Installer.app, but let see if I can do something (in the week end).

EDIT
just too easy

Edited June 25, 2019 by vector sigma
easy

vector sigma · June 25, 2019

@PMheart, just tried with success. Problem solved, thanks!

18 minutes ago, vector sigma said:

Yes!

Thanks to you, I'll try it after the job!

O_ops, why that wasn't clear? . I think this will a bit difficult since this is decided by Installer.app, but let see if I can do something (in the week end).

I think I found the solution in the apple developer portal....

Slice · June 25, 2019

27 minutes ago, cecekpawon said:

Thanks. Also that unix lineending will produced "0x0D0A" by dmidecode instead of "0x0A" like on real mac dump.

You means UEFI line ending?

cecekpawon · June 25, 2019

@Slice Please ignore if you already have similar results like imac dump below.

https://sourceforge.net/p/cloverefiboot/code/HEAD/tree/rEFIt_UEFI/Platform/smbios.c#l1083

@Any master: So, there's a chance for my i5-3570K ivy bridge to use xcpm with 10.13?

Edited June 25, 2019 by cecekpawon

vector sigma · June 25, 2019

2 hours ago, cecekpawon said:

@Any master: So, there's a chance for my i5-3570K ivy bridge to use xcpm with 10.13?

I'm not a master, but looks like you can certainly give it a try.

vector sigma · June 25, 2019

12 hours ago, Matgen84 said:

I talk about Clover logo into Installer 'Background image' (Cloverpackage/Resources/Background.tiff), not Clover icon

Tadan: Clover_v2.4k_r4974.pkg

after one year, as soon I understood that you wanted a dark background image and not the logo Lol, here is it:

aqua.png.6b2c36684c89538f56496fc1b1aae65c.png dark.png.54c0e0c718818dd66b22436f3e0a1dbd.png

To all,

before committing changes I want to know if the package can work in old OSes, e.g. 10.10 or maybe 10.7? Please report!

Matgen84 · June 26, 2019

10 hours ago, vector sigma said:

Tadan: Clover_v2.4k_r4974.pkg

after one year, as soon I understood that you wanted a dark background image and not the logo Lol, here is it:

To all,

before committing changes I want to know if the package can work in old OSes, e.g. 10.10 or maybe 10.7? Please report!

Thanks a lot I look forward to the new commit. It's possible that Clover Logo keeps Green color (in Dark Mode) instead of Gray. I've a dream...

I hope this new background would be compatible with old OSes e.g. 10.10 or 10.10.7

Edited June 26, 2019 by Matgen84

PMheart · June 26, 2019

Hi,

Sorry, I was too hurried yesterday, better to polish logging as follows:

Index: rEFIt_UEFI/Platform/kernel_patcher.c
===================================================================
--- rEFIt_UEFI/Platform/kernel_patcher.c	(revision 4974)
+++ rEFIt_UEFI/Platform/kernel_patcher.c	(working copy)
@@ -1048,7 +1048,7 @@
 
   // check OS version suit for patches
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("HaswellLowEndXCPM(): Unsupported macOS.\n");
     DBG("HaswellLowEndXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1121,7 +1121,7 @@
 
   // check whether Ivy Bridge
   if (gCPUStructure.Model != CPU_MODEL_IVY_BRIDGE) {
-    DBG("Unsupported platform.\nRequires Ivy Bridge, aborted\n");
+    DBG("KernelIvyBridgeXCPM(): Unsupported platform.\nRequires Ivy Bridge, aborted\n");
     DBG("KernelIvyBridgeXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1129,7 +1129,7 @@
   // check OS version suit for patches
   // PMheart: attempt to add 10.14 compatibility
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("KernelIvyBridgeXCPM(): Unsupported macOS.\n");
     DBG("KernelIvyBridgeXCPM() <===FALSE\n");
     return FALSE;
   } else if (os_version >= AsciiOSVersionToUint64("10.8.5") && os_version < AsciiOSVersionToUint64("10.12")) {
@@ -1205,7 +1205,7 @@
   
   // check whether Ivy Bridge-E5
   if (gCPUStructure.Model != CPU_MODEL_IVY_BRIDGE_E5) {
-    DBG("Unsupported platform.\nRequires Ivy Bridge-E, aborted\n");
+    DBG("KernelIvyE5XCPM(): Unsupported platform.\nRequires Ivy Bridge-E, aborted\n");
     DBG("KernelIvyE5XCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1213,7 +1213,7 @@
   // check OS version suit for patches
   // PMheart: attempt to add 10.15 compatibility
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("KernelIvyE5XCPM(): Unsupported macOS.\n");
     DBG("KernelIvyE5XCPM() <===FALSE\n");
     return FALSE;
   }

Thanks a lot!

Slice · June 26, 2019

3 hours ago, PMheart said:

Hi,

Sorry, I was too hurried yesterday, better to polish logging as follows:


Index: rEFIt_UEFI/Platform/kernel_patcher.c
===================================================================
--- rEFIt_UEFI/Platform/kernel_patcher.c	(revision 4974)
+++ rEFIt_UEFI/Platform/kernel_patcher.c	(working copy)
@@ -1048,7 +1048,7 @@
 
   // check OS version suit for patches
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("HaswellLowEndXCPM(): Unsupported macOS.\n");
     DBG("HaswellLowEndXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1121,7 +1121,7 @@
 
   // check whether Ivy Bridge
   if (gCPUStructure.Model != CPU_MODEL_IVY_BRIDGE) {
-    DBG("Unsupported platform.\nRequires Ivy Bridge, aborted\n");
+    DBG("KernelIvyBridgeXCPM(): Unsupported platform.\nRequires Ivy Bridge, aborted\n");
     DBG("KernelIvyBridgeXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1129,7 +1129,7 @@
   // check OS version suit for patches
   // PMheart: attempt to add 10.14 compatibility
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("KernelIvyBridgeXCPM(): Unsupported macOS.\n");
     DBG("KernelIvyBridgeXCPM() <===FALSE\n");
     return FALSE;
   } else if (os_version >= AsciiOSVersionToUint64("10.8.5") && os_version < AsciiOSVersionToUint64("10.12")) {
@@ -1205,7 +1205,7 @@
   
   // check whether Ivy Bridge-E5
   if (gCPUStructure.Model != CPU_MODEL_IVY_BRIDGE_E5) {
-    DBG("Unsupported platform.\nRequires Ivy Bridge-E, aborted\n");
+    DBG("KernelIvyE5XCPM(): Unsupported platform.\nRequires Ivy Bridge-E, aborted\n");
     DBG("KernelIvyE5XCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1213,7 +1213,7 @@
   // check OS version suit for patches
   // PMheart: attempt to add 10.15 compatibility
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("KernelIvyE5XCPM(): Unsupported macOS.\n");
     DBG("KernelIvyE5XCPM() <===FALSE\n");
     return FALSE;
   }

Thanks a lot!

Not a big deal! Committed.

fusion71au · June 26, 2019

16 hours ago, vector sigma said:

Tadan: Clover_v2.4k_r4974.pkg

after one year, as soon I understood that you wanted a dark background image and not the logo Lol, here is it:

To all,

before committing changes I want to know if the package can work in old OSes, e.g. 10.10 or maybe 10.7? Please report!

Install also succeeds in Lion and boots it as well ...

Spoiler

vector sigma · June 26, 2019

13 hours ago, Matgen84 said:

Thanks a lot I look forward to the new commit. It's possible that Clover Logo keeps Green color (in Dark Mode) instead of Gray. I've a dream.

I made it dark with Photoshop Lol, but ok will be green

6 hours ago, fusion71au said:

Install also succeeds in Lion and boots it as well ...

Thanks you so much! I'll commit this as soon as possible.

Edited June 26, 2019 by vector sigma
typo

Badruzeus · June 26, 2019

16 minutes ago, vector sigma said:

I made it dark with Photoshop Lol, but ok will be green

Thanks you so mutch! I'll commit this as soon as possible.

I think gray is also cool, so Clover logo is also transformed into another color when UI goes Dark lol

Clover General discussion

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites