Jump to content

Clover General discussion


ErmaC
30,172 posts in this topic

Recommended Posts

8 hours ago, Mork vom Ork said:

no matter which tool i will use to build the latest CLOVER rev. - i will always get the same error:

  Reveal hidden contents


Building CloverUpdater application...
[XCODE]
Building CloverPrefpane preference...
[XCODE]
================= Making all in fdisk440 =================
	[MKDIR] /Users/md/src/UDK2018/Clover/CloverPackage/sym/build/fdisk440
	[CC32] auto.c
	[CC32] cmd.c
	[CC32] disk.c
	[CC32] fdisk.c
	[CC32] getrawpartition.c
	[CC32] mbr.c
	[CC32] misc.c
	[CC32] opendev.c
	[CC32] part.c
	[CC32] user.c
	[CC64] auto.c
	[CC64] cmd.c
	[CC64] disk.c
	[CC64] fdisk.c
	[CC64] getrawpartition.c
	[CC64] mbr.c
	[CC64] misc.c
	[CC64] opendev.c
	[CC64] part.c
	[CC64] user.c
	[LD32] fdisk440_32
	[LD64] fdisk440_64
	[LIPO] /Users/md/src/UDK2018/Clover/CloverPackage/sym/utils/fdisk440
================= Making all in boot1-install =================
	[XCODE] boot1-install
================= Making all in partutil =================
	[XCODE] partutil
================= Making all in bdmesg =================
	[XCODE] bdmesg
================= Making all in clover-genconfig =================
	[XCODE] clover-genconfig
** INSTALL FAILED **


The following build commands failed:
	CompileC /Users/md/src/UDK2018/Clover/CloverPackage/sym/build/clover-genconfig/clover-genconfig.build/Release/clover-genconfig.build/Objects-normal/i386/clover-genconfig.o clover-genconfig.c normal i386 c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
make[2]: *** [/Users/md/src/UDK2018/Clover/CloverPackage/sym/utils/clover-genconfig] Error 65
make[1]: *** [all-recursive] Error 1
make: *** [pkg] Error 2

=========================== Make Clover ISO =================================

================= Making all in fdisk440 =================
make[2]: Nothing to be done for `all'.
================= Making all in boot1-install =================
make[2]: Nothing to be done for `all'.
================= Making all in partutil =================
make[2]: Nothing to be done for `all'.
================= Making all in bdmesg =================
make[2]: Nothing to be done for `all'.
================= Making all in clover-genconfig =================
	[XCODE] clover-genconfig
** INSTALL FAILED **


The following build commands failed:
	CompileC /Users/md/src/UDK2018/Clover/CloverPackage/sym/build/clover-genconfig/clover-genconfig.build/Release/clover-genconfig.build/Objects-normal/i386/clover-genconfig.o clover-genconfig.c normal i386 c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
make[2]: *** [/Users/md/src/UDK2018/Clover/CloverPackage/sym/utils/clover-genconfig] Error 65
make[1]: *** [all-recursive] Error 1
make: *** [utils] Error 2

Complete Build time 1m28s

================ Finish working: 2018-05-23 22:45:04 +0200 ===================

Syncing disk cache ... Done.

All done.
Have a nice ... day(night)
Enjoy ...

 

at the same part of the script. Tried with latest CloverBuilder 1.1.6 and Build Clover 4.8.4.sh script.

Seems to be broken since rev. 4496, cause building rev. 4495 allready worked for me at least. Anyone have any clue?

btw: i always build from the beginning by deleting the "src" folder in my homefolder location.

 

ps: the whole log file is attached as a download

clover_build_rev4497_log.rtf

Another issue here with commits r4997? I don't understand why.

 

I insert new sync EDK2 -27233 in Build_Clover.command script. I launch the script from scratch to new src folder: all work fine.... until makepkg function error message:

 

invalid option!!
Segmentation fault: 11

 

Edited by Matgen84
Link to comment
Share on other sites

3 hours ago, Matgen84 said:

Another issue here with commits r4997? I don't understand why.

 

I insert new sync EDK2 -27233 in Build_Clover.command script. I launch the script from scratch to new src folder: all work fine.... until makepkg function error message:

 

invalid option!!
Segmentation fault: 11

 

The exit code of several external commands was not handled correctly, causing this script loop and Segmentation fault after that, so I've just pushed a new script version to the work branch. Try it and you'll see the real cause for this fault.

Edited by Philip Petev
  • Like 2
Link to comment
Share on other sites

@Mork vom Ork, @Matgen84:

There was problem in clover-genconfig build settings after reversion of MdePkg/Include/Base.h that was causing its build to fail.  Try r4498.  Should be ok now.

 

PS: The problem was that it was building combined 32/64-bit binary, and the 32-bit build, for some reason defines MDE_CPU_X64.  I didn't bother to figure out why it's defining this symbol, but now it's only building the 64-bit build - which should be ok, since 64-bit user mode is supported since OS X Leopard.

Edited by Zenith432
Link to comment
Share on other sites



================================================================================

Build_Clover script v4.8.4                                  No update available.

                             <--------------------------------------------------

================================================================================

By Micky1979 based on Slice, apianti, vit9696, Download Fritz, Zenith432,

STLVNUB, JrCs,cecekpawon, Needy, cvad, Rehabman, philip_petev, ErmaC

 

Supported OSes: macOS X, Ubuntu (16.04/16.10), Debian Jessie and Stretch

                             <--------------------------------------------------

CLOVER Remote revision: 4498 Local revision: 4498

EDK2 Remote revision: 27236 Local revision: 27213

 

The current local EDK2 revision is the suggested one (27213). 

Used settings: /Users/shane/BuildCloverConfig.txt 

                             <--------------------------------------------------

Please enter your choice: 

 1) update Clover only (no building)

 2) update Clover + force edk2 update (no building)

 3) run my script on the source

 4) build existing revision (no update, for testing only)

 5) build existing revision for release (no update, standard build)

 6) build existing revision with custom macros enabled

 7) enter Developers mode (only for devs)

 8) Try Clover Configurator Pro.app

 9) edit the configuration file

 10) Exit

? 5

 

 

 

 

 

 

 

================================================================================

Select the desired architecture

                             <--------------------------------------------------

1) Standard x64 only

2) ia32 and x64 (ia32 is deprecated)

3) ia32 only (deprecated)

4) Back to Main Menu

5) Exit

? 1

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

================================================================================

Select the desired pkg type

                             <--------------------------------------------------

1) Standard

2) slim pkg that skip themes and CloverThemeManager.app

3) slim pkg that skip themes and CloverThemeManager.app, updater and PrefPanel

4) slim pkg UEFI only, without RC Scripts, themes & CTM, updater and PrefPanel

5) Back to Select architecture menu

6) Exit

? 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

================================================================================

Select the desired pkg type

                             <--------------------------------------------------

invalid choice!

 

1) Standard

2) slim pkg that skip themes and CloverThemeManager.app

3) slim pkg that skip themes and CloverThemeManager.app, updater and PrefPanel

4) slim pkg UEFI only, without RC Scripts, themes & CTM, updater and PrefPanel

5) Back to Select architecture menu

6) Exit

? 1

================================================================================

Running from: macOS 10.13.5

Xcode 9.3.1

Build version 9E501

                             <--------------------------------------------------

================================================================================

Compiler settings

                             <--------------------------------------------------

Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1

Apple LLVM version 9.1.0 (clang-902.0.39.1)

Target: x86_64-apple-darwin17.6.0

Thread model: posix

InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

                             <--------------------------------------------------

================================================================================

BUILDTOOL is XCODE8

                             <--------------------------------------------------

 

================================================================================

nasm check:

                             <--------------------------------------------------

NASM version 2.13.03 compiled on Feb  7 2018

================================================================================

gettext check:

                             <--------------------------------------------------

found gettext at /Users/shane/src/opt/local/bin

================================================================================

mtoc check:

                             <--------------------------------------------------

mtoc found in /Users/shane/src/opt/local/bin.

================================================================================

 

Loading previous configuration from /Users/shane/src/edk2/Conf/BuildEnv.sh

WORKSPACE: /Users/shane/src/edk2

EDK_TOOLS_PATH: /Users/shane/src/edk2/BaseTools

CONF_PATH: /Users/shane/src/edk2/Conf

Build environment: Darwin-17.6.0-x86_64-i386-64bit

Build start time: 19:06:43, May.24 2018

 

WORKSPACE        = /Users/shane/src/edk2

ECP_SOURCE       = /Users/shane/src/edk2/EdkCompatibilityPkg

EDK_SOURCE       = /Users/shane/src/edk2/EdkCompatibilityPkg

EFI_SOURCE       = /Users/shane/src/edk2/EdkCompatibilityPkg

EDK_TOOLS_PATH   = /Users/shane/src/edk2/BaseTools

CONF_PATH        = /Users/shane/src/edk2/Conf

 

 

Architecture(s)  = X64

Build target     = RELEASE

Toolchain        = XCODE8

 

Active Platform          = /Users/shane/src/edk2/AptioFixPkg/AptioFixPkg.dsc

 

Processing meta-data . done!

Building ... /Users/shane/src/edk2/MdePkg/Library/UefiUsbLib/UefiUsbLib.inf [X64]

make: Nothing to be done for `tbuild'.

Building ... /Users/shane/src/edk2/MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf [X64]

make: Nothing to be done for `tbuild'.

Building ... /Users/shane/src/edk2/MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf [X64]

Building ... /Users/shane/src/edk2/MdePkg/Library/UefiLib/UefiLib.inf [X64]

Building ... /Users/shane/src/edk2/MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf [X64]

make: Nothing to be done for `tbuild'.

Building ... /Users/shane/src/edk2/MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf [X64]

/Users/shane/src/edk2/MdeModulePkg/Library/UefiHiiLib/HiiLib.c:165:20: error: 'va_start' used in Win64 ABI function

  for (Length = 0, VA_START (Args, DeviceHandle); (Package = VA_ARG (Args, UINT32 *)) != NULL; ) {

                   ^

/Users/shane/src/edk2/MdePkg/Include/Base.h:740:38: note: expanded from macro 'VA_START'

#define VA_START(Marker, Parameter)  __builtin_va_start (Marker, Parameter)

                                     ^

/Users/shane/src/edk2/MdeModulePkg/Library/UefiHiiLib/HiiLib.c:209:8: error: 'va_start' used in Win64 ABI function

  for (VA_START (Args, DeviceHandle); (Package = VA_ARG (Args, UINT32 *)) != NULL; ) {

       ^

/Users/shane/src/edk2/MdePkg/Include/Base.h:740:38: note: expanded from macro 'VA_START'

#define VA_START(Marker, Parameter)  __builtin_va_start (Marker, Parameter)

                                     ^

make: Nothing to be done for `tbuild'.

Building ... /Users/shane/src/edk2/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf [X64]

2 errors generated.

make: *** [/Users/shane/src/edk2/Build/AptioFixPkg/RELEASE_XCODE8/X64/MdeModulePkg/Library/UefiHiiLib/UefiHiiLib/OUTPUT/HiiLib.obj] Error 1

 

 

build.py...

 : error 7000: Failed to execute command

make tbuild [/Users/shane/src/edk2/Build/AptioFixPkg/RELEASE_XCODE8/X64/MdeModulePkg/Library/UefiHiiLib/UefiHiiLib]

 

 

build.py...

 : error 7000: Failed to execute command

make tbuild [/Users/shane/src/edk2/Build/AptioFixPkg/RELEASE_XCODE8/X64/MdePkg/Library/UefiLib/UefiLib]

 

 

build.py...

 : error 7000: Failed to execute command

make tbuild [/Users/shane/src/edk2/Build/AptioFixPkg/RELEASE_XCODE8/X64/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib]

 

 

build.py...

 : error F002: Failed to build module

/Users/shane/src/edk2/MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf [X64, XCODE8, RELEASE]

 

- Failed -

Build end time: 19:06:45, May.24 2018

Build total time: 00:00:02

 

================================================================================

boot6

                             <--------------------------------------------------

TOOLCHAIN_DIR: /Users/shane/src/opt/local

MTOC_PREFIX: /Users/shane/src/opt/local/bin/

NASM_PREFIX: /Users/shane/src/opt/local/bin/

NASM_VER: 2.13.03

Building from: /Users/shane/src/edk2

 

Running edk2 build for CloverX64 using the command:

build  -D NO_GRUB_DRIVERS_EMBEDDED --conf=/Users/shane/src/edk2/Conf -D USE_LOW_EBDA -p Clover/Clover.dsc  -a X64 -b RELEASE -t XCODE8 -n 9 

 

Build environment: Darwin-17.6.0-x86_64-i386-64bit

Build start time: 19:06:45, May.24 2018

 

WORKSPACE        = /Users/shane/src/edk2

ECP_SOURCE       = /Users/shane/src/edk2/EdkCompatibilityPkg

EDK_SOURCE       = /Users/shane/src/edk2/EdkCompatibilityPkg

EFI_SOURCE       = /Users/shane/src/edk2/EdkCompatibilityPkg

EDK_TOOLS_PATH   = /Users/shane/src/edk2/BaseTools

CONF_PATH        = /Users/shane/src/edk2/Conf

 

 

Architecture(s)  = X64

Build target     = RELEASE

Toolchain        = XCODE8

 

Active Platform          = /Users/shane/src/edk2/Clover/Clover.dsc

Flash Image Definition   = /Users/shane/src/edk2/Clover/Clover.fdf

 

Processing meta-data .... done!

Building ... /Users/shane/src/edk2/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf [X64]

Building ... /Users/shane/src/edk2/MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf [X64]

make: Nothing to be done for `tbuild'.

make: Nothing to be done for `tbuild'.

Building ... /Users/shane/src/edk2/MdePkg/Library/BasePrintLib/BasePrintLib.inf [X64]

Building ... /Users/shane/src/edk2/MdePkg/Library/BaseLib/BaseLib.inf [X64]

Building ... /Users/shane/src/edk2/MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf [X64]

/Users/shane/src/edk2/MdePkg/Library/BasePrintLib/PrintLibInternal.c:1265:3: error: 'va_start' used in Win64 ABI function

make: Nothing to be done for `tbuild'.

  VA_START (Marker, FormatString);

  ^

/Users/shane/src/edk2/MdePkg/Include/Base.h:740:38: note: expanded from macro 'VA_START'

#define VA_START(Marker, Parameter)  __builtin_va_start (Marker, Parameter)

                                     ^

1 error generated.

make: *** [/Users/shane/src/edk2/Build/Clover/RELEASE_XCODE8/X64/MdePkg/Library/BasePrintLib/BasePrintLib/OUTPUT/PrintLibInternal.obj] Error 1

 

 

build.py...

 : error 7000: Failed to execute command

make tbuild [/Users/shane/src/edk2/Build/Clover/RELEASE_XCODE8/X64/MdePkg/Library/BasePrintLib/BasePrintLib]

 

 

build.py...

 : error 7000: Failed to execute command

make tbuild [/Users/shane/src/edk2/Build/Clover/RELEASE_XCODE8/X64/MdePkg/Library/BaseLib/BaseLib]

 

 

build.py...

 : error F002: Failed to build module

/Users/shane/src/edk2/MdePkg/Library/BasePrintLib/BasePrintLib.inf [X64, XCODE8, RELEASE]

 

- Failed -

Build end time: 19:06:51, May.24 2018

Build total time: 00:00:05

 

 

o_Ops, ./ebuild.sh exited with error(s), aborting..

Link to comment
Share on other sites

24 minutes ago, SavageAUS said:

I deleted src folder and re-ran, still same issue.

I don't know what "src folder" is.  Your log says EDK2 rev 27213.  For Clover 4498 you should use at least 27233 of EDK2.  In EDK2 tree, MdePkg/Include/Base.h should be reverted to original.  Then Clover/Patches_for_EDK2 recopied over EDK2.

  • Like 1
Link to comment
Share on other sites

6 minutes ago, Zenith432 said:

I don't know what "src folder" is.  Your log says EDK2 rev 27213.  For Clover 4498 you should use at least 27233 of EDK2.  In EDK2 tree, MdePkg/Include/Base.h should be reverted to original.  Then Clover/Patches_for_EDK2 recopied over EDK2.

Problem solved, thanks.

Link to comment
Share on other sites

Hi,the AppleALC injector doesn't work since I update the version of clover to r4497,and this problem is also been found in r4498  or r4499,but it works in r4496. Could you please fix it and test that? My Audio Codec is Realtek ALC1220, works with layout ID=11.

 

best regards

Edited by wyhtc
Link to comment
Share on other sites

16 hours ago, Cyberdevs said:

Clover r4498 broke my audio. ALC1150. Any idea why? I reverted back to clover r4492 and it works as it supposed to.

 

Using AppleALC v.1.2.6 and Lilu v.1.2.3

 

15 hours ago, iCanaro said:

Clover 4497 and 4498  not load the ID layout (layout 0) tested my hack 1 and 2

 

14 hours ago, wyhtc said:

Hi,the AppleALC injector doesn't work since I update the version of clover to r4497,and this problem is also been found in r4498  or r4499,but it works in r4496. Could you please fix it and test that? My Audio Codec is Realtek ALC1220, works with layout ID=11.

 

best regards

Yes, file Settings.c lines 5048 and 5051 should be added

gSettings.HDAInjection = TRUE;
Previously this was by default, but since 4497 I don't want any default injection because Properties will be full enough.
  • Like 2
  • Confused 1
Link to comment
Share on other sites

While I do agree that this is a problem on Clover side (and now I know why), this doesn't seem to occur on my Skylake system (ALC 1150)... Which is weird...

 

The config is slightly different than my home setup (the one in the signature), of course, but the Audio injection is set up pretty much the same way. So...not sure why it works for the Skylake build, but not for the Haswell build, with the exact same kexts (Lilu & AppleALC).

 

@Slice personally I'm a bit confused regarding your explanation. Are you saying, staring with 4497 we won't have audio again, unless we (I mean the users in general) change that line in Settings.c...? Cause, I'm pretty sure most of the users either don't know how to do that, or simply won't do that.

Also, I'm still not sure how does it work on my Skylake build though. With the same Clover 4497.

 

Is there something we can do from config in order to have sound? Cause I thought adding the Layout ID (in my case "1") is what we have to do. If that's not necessary anymore, and we can still have sound another way, could you, please, tell me what to do to get that done?

 

For now, I simply reverted to previous version. But...I would like to be able to upgrade to the newer versions in the future, without losing sound.

 

So, I guess my question is simple: is there another way to get sound back, other than editing that line in Settings.c which...I suppose would also mean re-compiling Clover by ourselves?

Edited by arsradu
  • Like 1
Link to comment
Share on other sites

8 minutes ago, SavageAUS said:

I havnt tested audio on my skylake build but on my haswell laptop i have audio.

I guess its working because audio layout is set in DSDT?

 

Bingo!

 

FixHDA in DSDT Fixes...is what makes it work on my Skylake build. I'm pretty sure that's not enabled on my Haswell build.

 

So, I would suggest anyone with this issue to just enable FixHDA in DSDT Fixes and...that should be it. Everything else stays the same.

 

Thank you very much! :)

 

@Slice all good, man. Thank you! :)

Edited by arsradu
  • Like 3
Link to comment
Share on other sites

1 hour ago, Slice said:

 

 

Yes, file Settings.c lines 5048 and 5051 should be added

gSettings.HDAInjection = TRUE;
Previously this was by default, but since 4497 I don't want any default injection because Properties will be full enough.

Thank you,Slice. I will try.

Link to comment
Share on other sites

 

 

what about this? Did you arrange Clover only UEFI now?

Several problems Booting Legacy (ESP)  last revision clover 4498 and 4499 BUILD UDK2018
I can not say what revision it was to break?

1510971873_screenshot4.thumb.png.28284abb420341a5851dcbac42f9faf0copie.png.4f99d4eebf6e9d94d44b98cf9e9c4345.png

Edited by chris1111
Link to comment
Share on other sites

1 hour ago, SavageAUS said:

I havnt tested audio on my skylake build but on my haswell laptop i have audio.

I guess its working because audio layout is set in DSDT?

I don't use DSDT on my SkyLake rig anymore.

 

1 hour ago, arsradu said:

 

Bingo!

 

FixHDA in DSDT Fixes...is what makes it work on my Skylake build. I'm pretty sure that's not enabled on my Haswell build.

 

So, I would suggest anyone with this issue to just enable FixHDA in DSDT Fixes and...that should be it. Everything else stays the same.

 

Thank you very much! :)

FixHDA also don't fix my problem.

 

2 hours ago, Slice said:

 

 

Yes, file Settings.c lines 5048 and 5051 should be added

gSettings.HDAInjection = TRUE;
Previously this was by default, but since 4497 I don't want any default injection because Properties will be full enough.

Is there a way to add those properties in the config.plist? can you please clarify your statement a little more on how to add those properties without having to edit the settings.c?

Link to comment
Share on other sites

1 hour ago, arsradu said:

While I do agree that this is a problem on Clover side (and now I know why), this doesn't seem to occur on my Skylake system (ALC 1150)... Which is weird...

 

The config is slightly different than my home setup (the one in the signature), of course, but the Audio injection is set up pretty much the same way. So...not sure why it works for the Skylake build, but not for the Haswell build, with the exact same kexts (Lilu & AppleALC).

 

@Slice personally I'm a bit confused regarding your explanation. Are you saying, staring with 4497 we won't have audio again, unless we (I mean the users in general) change that line in Settings.c...? Cause, I'm pretty sure most of the users either don't know how to do that, or simply won't do that.

Also, I'm still not sure how does it work on my Skylake build though. With the same Clover 4497.

 

Is there something we can do from config in order to have sound? Cause I thought adding the Layout ID (in my case "1") is what we have to do. If that's not necessary anymore, and we can still have sound another way, could you, please, tell me what to do to get that done?

 

For now, I simply reverted to previous version. But...I would like to be able to upgrade to the newer versions in the future, without losing sound.

 

So, I guess my question is simple: is there another way to get sound back, other than editing that line in Settings.c which...I suppose would also mean re-compiling Clover by ourselves?

I will make the change in Clover sources today evening.

And I think the problem is

<key>Inject</key>

<string>19</string>

 

but no problem with

<key>Inject</key>

<integer>19</integer>

  • Like 2
Link to comment
Share on other sites

So 4400 works good for old Mac (ESP Legacy) install :hysterical: it is not made for UEFI Only :wink_anim:

Any one have a issue with latest Clover on Old macOS . I recommend to used Clover 4400 for (Legacy ESP)

 

1823536804_Sanstitre.thumb.png.810e16c214b74c7446662d91cc262e98.png

 

i can not say where the code was broken for OLD Mac in Legacy ESP because i had been using my Snow and Lion for a month but i know that 4400 is working well :angel:

Edited by chris1111
  • Like 1
Link to comment
Share on other sites

34 minutes ago, SavageAUS said:

I still do and with Clover 4499 i have audio without FixHDA, AppleALC 1.2.6, Lilu 1.2.3

Is it the same DSDT that we used on Sierra? or it's been improved and optimized for High Sierra?

Link to comment
Share on other sites

×
×
  • Create New...