Clover General discussion

tluck · September 6, 2017

I wasn't sure that the max brightness issue affected newer models.

Anyway, for Haswell and Broadwell, LEVX should be 0x0AD90000 and Skylake and Kabylake should be 0x056C0000.

Perhaps this patch should be dynamic according to device id / CPU model. Or maybe customizable in config.plist

FYI ... 3 data points on Brightness from 3 systems

So for some reason (IIRC to get same brightness after sleep/wake) on my HD 3000 system

- I modify the SNB Framebuffer values to change brightness from 0x0710 (1808) to 0x1312 (4882).

- my brightness then ranges from 0x8c to 0x1312 (140 to 4882) as defined by AppleBacklightInjector

i set each to 50% (1/2 way on slider) brightness - note useable-linear-brightness - which is key to the range.

$ ioreg -l|grep Panel|grep -v Kit

ioreg -l|grep -i max|grep -i bright|grep -v Profile

| | | | | "FeatureControl" = {"Watermarks"=1,"RenderStandby"=1,"GPUInterruptHandling"=1,"DPM"=1,"MaximumSelfRefreshLevel"=3,"Gamma"=1,"PowerStates"=1,"IgnorePanelTimings"=0,"UseInterruptFilter"=1,"SpreadON"=1,"CachedEDIDDisable"=0,"FastDisplayDetectDisable"=0,"FBC"=0,"SetRC6Voltage"=0}

| | | "ApplePanelRawBrightness" = 999

| | +-o AppleIntelPanelA <class AppleIntelPanelA, id 0x10000032d, !registered, !matched, active, busy 0, retain 5>

| | "IOClass" = "AppleIntelPanelA"

| | "ApplePanel" = {"F10T02e2"=<00110000008c00d80136018f01fe02a3034503e704c70535075a091c0b130d9b10591312>}

$ ioreg -l|grep -i max|grep -i bright|grep -v Profile

| | | | | "IODisplayParameters" = {"commit"={"reg"=0},"fade-time2"={"min"=0,"max"=10000,"value"=4000},"linear-brightness-probe"={"min"=0,"max"=4882,"value"=999},"ggsc"={"min"=0,"max"=65536,"value"=65536},"gsc "={"min"=0,"max"=65536,"value"=0},"vblm"={"min"=0,"max"=196608,"value"=65536},"dsyp"={"min"=0,"max"=2,"value"=2},"rgsc"={"min"=0,"max"=65536,"value"=65536},"fade-style"={"min"=0,"max"=10,"value"=0},"fade-time1"={"min"=0,"max"=10000,"value"=500},"bgsc"={"min"=0,"max"=65536,"value"=65536},"brightness-probe"={"min"=0,"max"=1024,"value"=512},"fade-time3"={"min"=0,"max"=10000,"value"=500},"bklt"={"min"=0,"max"=4882,"value"=140},"linear-brightness"={"min"=0,"max"=4882,"value"=999},"brightness"={"max"=1024,"min"=0,"value"=512},"brightness-fade"={"min"=0,"max"=1023,"value"=0},"usable-linear-brightness"={"min"=140,"max"=4882,"value"=999}}

| | | "AppleMaxBrightness" = 4882

| | "IODisplayParameters" = {"brightness"={"max"=255,"min"=40},"commit"={"reg"=0}}

On my HD 4600 (Haswell) system, the maxBrightness seems to be 0xAD8 (2776) versus AD9?

$ ioreg -l|grep Panel|grep -v Kit

| | | "ApplePanelRawBrightness" = 568

| | +-o AppleIntelPanelA <class AppleIntelPanelA, id 0x10000036f, !registered, !matched, active, busy 0, retain 5>

| | "IOClass" = "AppleIntelPanelA"

| | "ApplePanel" = {"F10T11ed"=<00110000004f007a00b000e30122017f01db023802b7035a042e052e064c07bc094b0ad8>}

$ ioreg -l|grep -i max|grep -i bright|grep -v Profile

| | | | | "IODisplayParameters" = {"commit"={"reg"=0},"fade-time2"={"min"=0,"max"=10000,"value"=4000},"linear-brightness-probe"={"min"=0,"max"=2776,"value"=568},"ggsc"={"min"=0,"max"=65536,"value"=65536},"gsc "={"min"=0,"max"=65536,"value"=65536},"vblm"={"min"=0,"max"=196608,"value"=65536},"dsyp"={"min"=0,"max"=2,"value"=2},"rgsc"={"min"=0,"max"=65536,"value"=65536},"fade-style"={"min"=0,"max"=10,"value"=0},"fade-time1"={"min"=0,"max"=10000,"value"=500},"bgsc"={"min"=0,"max"=65536,"value"=65536},"brightness-probe"={"min"=0,"max"=1024,"value"=512},"fade-time3"={"min"=0,"max"=10000,"value"=500},"bklt"={"min"=0,"max"=2777,"value"=79},"linear-brightness"={"min"=0,"max"=2776,"value"=568},"brightness"={"max"=1024,"min"=0,"value"=512},"brightness-fade"={"min"=0,"max"=1023,"value"=0},"usable-linear-brightness"={"min"=79,"max"=2776,"value"=568}}

| | | "AppleMaxBrightness" = 2776

| | "IODisplayParameters" = {"brightness"={"max"=255,"min"=40},"commit"={"reg"=0}}

On my MacBookPro (KabyLake) i7-7567U (with Iris 650 gfx) system, the maxBrightness seems to be 0x50F (1295)

$ ioreg -l|grep Panel|grep -v Kit

...

| | | "ApplePanelRawBrightness" = 1295

| | +-o AppleIntelPanelA <class AppleIntelPanelA, id 0x10000046c, !registered, !matched, active, busy 0, retain 5>

| | "IOClass" = "AppleIntelPanelA"

| | "ApplePanel" = {"F17Ta033"=<00110000000d00120016001e0028003600490063008700b800fd015d01e3029c039f050f>}

$ ioreg -l|grep -i max|grep -i bright|grep -v Profile

| | | | "IODisplayParameters" = {"commit"={"reg"=0},"fade-time2"={"min"=0,"max"=10000,"value"=4000},"linear-brightness-probe"={"min"=0,"max"=1295,"value"=99},"ggsc"={"min"=0,"max"=65536,"value"=65536},"gsc "={"min"=0,"max"=65536,"value"=65536},"vblm"={"min"=0,"max"=196608,"value"=65536},"dsyp"={"min"=0,"max"=2,"value"=2},"rgsc"={"min"=0,"max"=65536,"value"=65536},"fade-style"={"min"=0,"max"=10,"value"=0},"fade-time1"={"min"=0,"max"=10000,"value"=500},"bgsc"={"min"=0,"max"=65536,"value"=65536},"brightness-probe"={"min"=0,"max"=1024,"value"=512},"fade-time3"={"min"=0,"max"=10000,"value"=500},"bklt"={"min"=0,"max"=1388,"value"=13},"linear-brightness"={"min"=0,"max"=1295,"value"=99},"brightness"={"max"=1024,"min"=0,"value"=513},"brightness-fade"={"min"=0,"max"=1023,"value"=0},"usable-linear-brightness"={"min"=13,"max"=1295,"value"=99}}

| | | "AppleMaxBrightness" = 1295

| | "IODisplayParameters" = {"brightness"={"max"=255,"min"=40},"commit"={"reg"=0}}

RehabMan · September 6, 2017

Yeah that's what I thought, so I did it on my Haswell laptop before and it made no difference with my backlight.

Sent from my SM-G930F using Tapatalk

This code added to Clover (SetIntelMaxBacklight) is completely wrong for Haswell and later.

The code, as written, is specific to HD3000/HD4000.

And keep in mind if your BIOS PWMMax setting is larger than 0x710, this "fix" will likely turn the screen black (assuming current PWM level at boot is higher than 0x710).

My SSDT-PNLF.dsl has correct/more general code.

azlvda · September 6, 2017

This code added to Clover (SetIntelMaxBacklight) is completely wrong for Haswell and later.

The code, as written, is specific to HD3000/HD4000.

And keep in mind if your BIOS PWMMax setting is larger than 0x710, this "fix" will likely turn the screen black (assuming current PWM level at boot is higher than 0x710).

My SSDT-PNLF.dsl has correct/more general code.

yes, my skylake laptop.. i get blackscreen after clover menu with SetIntelMaxBacklight=True

syscl · September 7, 2017

@Slice

SetIntelMaxBacklight=True indeed turn my screen into darkvoid on XPS 13 9350(Skylake Iris Model). Thus better to set LevelMaxW depends on the platform, here's the code I change such that XPS 13 9350 won't have a black screen with SetIntelMaxBacklight

--- rEFIt_UEFI/Platform/Settings.c	(revision 4195)
+++ rEFIt_UEFI/Platform/Settings.c	(working copy)
@@ -6603,7 +6603,35 @@
              (Pci.Hdr.ClassCode[1] == PCI_CLASS_DISPLAY_OTHER))) {
 
               UINT32 LevelW = 0xC0000000;
-              UINT32 LevelMaxW = 0x07100000;
+              // syscl: set PWMMax base on platform
+              // 10: Sandy/Ivy 0x710
+              // 11: Haswell/Broadwell 0xad9
+              // 12: Skylake/KabyLake 0x56c (and some Haswell, example 0xa2e0008)
+              // 99: Other
+              UINT32 LevelMaxW = 0;
+              switch (gCPUStructure.Model) {
+                  case CPU_MODEL_SANDY_BRIDGE:
+                      LevelMaxW = 0x07100000;
+                      break;
+                      
+                  case CPU_MODEL_IVY_BRIDGE:
+                      LevelMaxW = 0xad900000;
+                      break;
+                      
+                  case CPU_MODEL_HASWELL:
+                  case CPU_MODEL_HASWELL_ULT:
+                  case CPU_MODEL_HASWELL_U5:
+                  case CPU_MODEL_CRYSTALWELL:
+                  case CPU_MODEL_BROADWELL_HQ:
+                  case CPU_MODEL_SKYLAKE_U:
+                  case CPU_MODEL_KABYLAKE1:
+                  case CPU_MODEL_KABYLAKE2:
+                      LevelMaxW = 0x56c00000;
+                      break;
+                      
+                  default:
+                      break;
+              }
               UINT32 IntelDisable = 0x03;
 
               //        gGraphics.DeviceID = Pci.Hdr.DeviceId;

Could you test if it works on your laptop as well? Thank you in advance.

syscl

Dr. Hurt · September 7, 2017

@Slice

SetIntelMaxBacklight=True indeed turn my screen into darkvoid on XPS 13 9350(Skylake Iris Model). Thus better to set LevelMaxW depends on the platform, here's the code I change such that XPS 13 9350 won't have a black screen with SetIntelMaxBacklight

--- rEFIt_UEFI/Platform/Settings.c	(revision 4195)+++ rEFIt_UEFI/Platform/Settings.c	(working copy)@@ -6603,7 +6603,35 @@              (Pci.Hdr.ClassCode[1] == PCI_CLASS_DISPLAY_OTHER))) {                UINT32 LevelW = 0xC0000000;-              UINT32 LevelMaxW = 0x07100000;+              // syscl: set PWMMax base on platform+              // 10: Sandy/Ivy 0x710+              // 11: Haswell/Broadwell 0xad9+              // 12: Skylake/KabyLake 0x56c (and some Haswell, example 0xa2e0008)+              // 99: Other+              UINT32 LevelMaxW = 0;+              switch (gCPUStructure.Model) {+                  case CPU_MODEL_SANDY_BRIDGE:+                      LevelMaxW = 0x07100000;+                      break;+                      +                  case CPU_MODEL_IVY_BRIDGE:+                      LevelMaxW = 0xad900000;+                      break;+                      +                  case CPU_MODEL_HASWELL:+                  case CPU_MODEL_HASWELL_ULT:+                  case CPU_MODEL_HASWELL_U5:+                  case CPU_MODEL_CRYSTALWELL:+                  case CPU_MODEL_BROADWELL_HQ:+                  case CPU_MODEL_SKYLAKE_U:+                  case CPU_MODEL_KABYLAKE1:+                  case CPU_MODEL_KABYLAKE2:+                      LevelMaxW = 0x56c00000;+                      break;+                      +                  default:+                      break;+              }               UINT32 IntelDisable = 0x03;                //        gGraphics.DeviceID = Pci.Hdr.DeviceId;

Could you test if it works on your laptop as well? Thank you in advance.

syscl

Sandy/Ivy should be the same. Haswell and skylake should be separate.

See post 14353

Edit: Slice made the value customizable via confit.plist. That would make it easier to experiment.

syscl · September 7, 2017

Sandy/Ivy should be the same. Haswell and skylake should be separate.

See post 14353

Edit: Slice made the value customizable via confit.plist. That would make it easier to experiment.

Thank you for this information. The problem is when a user set this boolean key without paying attention just like me setting this boolean value on XPS 13..

IMHO, it's better to initialized LevelMaxW correctly, otherwise let users to set LevelMaxW.

syscl

Dr. Hurt · September 7, 2017

Thank you for this information. The problem is when a user set this boolean key without paying attention just like me setting this boolean value on XPS 13..

IMHO, it's better to initialized LevelMaxW correctly, otherwise let users to set LevelMaxW.

syscl

My proposed code only was only for Sandy/Ivy (as stated in Clover Changes thread).

Update your code using values from 14353 and try it out.

EDIT: Here's a quick fix.

--- rEFIt_UEFI/Platform/Settings.c (revision 4195)

+++ rEFIt_UEFI/Platform/Settings.c (working copy)

@@ -6603,7 +6603,35 @@

(Pci.Hdr.ClassCode[1] == PCI_CLASS_DISPLAY_OTHER))) {

UINT32 LevelW = 0xC0000000;

- UINT32 LevelMaxW = 0x07100000;

+ // syscl: set PWMMax base on platform

+ // 10: Sandy/Ivy 0x710

+ // 11: Haswell/Broadwell 0xad9

+ // 12: Skylake/KabyLake 0x56c (and some Haswell, example 0xa2e0008)

+ // 99: Other

+ UINT32 LevelMaxW = 0;

+ switch (gCPUStructure.Model) {

+ case CPU_MODEL_SANDY_BRIDGE:

+ case CPU_MODEL_IVY_BRIDGE:

+ LevelMaxW = 0x07100000;

+ break;

+

+ case CPU_MODEL_HASWELL:

+ case CPU_MODEL_HASWELL_ULT:

+ case CPU_MODEL_HASWELL_U5:

+ case CPU_MODEL_CRYSTALWELL:

+ case CPU_MODEL_BROADWELL_HQ:

+ LevelMaxW = 0xad900000;

+ break;

+

+ case CPU_MODEL_SKYLAKE_U:

+ case CPU_MODEL_KABYLAKE1:

+ case CPU_MODEL_KABYLAKE2:

+ LevelMaxW = 0x56c00000;

+ break;

+

+ default:

+ break;

+ }

UINT32 IntelDisable = 0x03;

// gGraphics.DeviceID = Pci.Hdr.DeviceId;

syscl · September 7, 2017

My proposed code only was only for Sandy/Ivy (as stated in Clover Changes thread).

Update your code using values from 14353 and try it out.

EDIT: Here's a quick fix.

--- rEFIt_UEFI/Platform/Settings.c    (revision 4195)
+++ rEFIt_UEFI/Platform/Settings.c    (working copy)
@@ -6603,7 +6603,35 @@
(Pci.Hdr.ClassCode[1] == PCI_CLASS_DISPLAY_OTHER))) {+ case CPU_MODEL_HASWELL:+ case CPU_MODEL_HASWELL_ULT:
+ case CPU_MODEL_HASWELL_U5:
+ case CPU_MODEL_CRYSTALWELL:
+ case CPU_MODEL_BROADWELL_HQ:UINT32 LevelW = 0xC0000000;
- UINT32 LevelMaxW = 0x07100000;
+ // syscl: set PWMMax base on platform
+ // 10: Sandy/Ivy 0x710
+ // 11: Haswell/Broadwell 0xad9
+ // 12: Skylake/KabyLake 0x56c (and some Haswell, example 0xa2e0008)
+ // 99: Other
+ UINT32 LevelMaxW = 0;
+ switch (gCPUStructure.Model) {
+ case CPU_MODEL_SANDY_BRIDGE:
+ case CPU_MODEL_IVY_BRIDGE:
+ LevelMaxW = 0x07100000;
+ break;
+ 
+ case CPU_MODEL_HASWELL:
+ case CPU_MODEL_HASWELL_ULT:
+ case CPU_MODEL_HASWELL_U5:
+ case CPU_MODEL_CRYSTALWELL:
+ case CPU_MODEL_BROADWELL_HQ:
+ LevelMaxW = 0xad900000;
+ break;
+ 
+ case CPU_MODEL_SKYLAKE_U:
+ case CPU_MODEL_KABYLAKE1:
+ case CPU_MODEL_KABYLAKE2:
+ LevelMaxW = 0x56c00000;
+ break;
+ 
+ default:
+ break;
+ }
UINT32 IntelDisable = 0x03;

// gGraphics.DeviceID = Pci.Hdr.DeviceId;

CPU Model is still not enough because some Haswell(ig-platform-id) still need 0x56c00000(same as Skylake/Kabylake). I will post another fix.

syscl

Dr. Hurt · September 7, 2017

Here's how to use the new custom value: #73

BTW, I think SetIntelBacklight should be deprecated/removed now that we have this.

syscl · September 7, 2017

Here's how to use the new custom value: #73

BTW, I think SetIntelBacklight should be deprecated/removed now that we have this.

Index: rEFIt_UEFI/Platform/Settings.c
===================================================================
--- rEFIt_UEFI/Platform/Settings.c	(revision 4197)
+++ rEFIt_UEFI/Platform/Settings.c	(working copy)
@@ -6606,7 +6606,36 @@
              (Pci.Hdr.ClassCode[1] == PCI_CLASS_DISPLAY_OTHER))) {
 
               UINT32 LevelW = 0xC0000000;
-              UINT32 LevelMaxW = 0x07100000;
+              // syscl: set PWMMax base on platform
+              // 10: Sandy/Ivy 0x710
+              // 11: Haswell/Broadwell 0xad9
+              // 12: Skylake/KabyLake 0x56c (and some Haswell, example 0xa2e0008)
+              // 99: Other
+              UINT32 LevelMaxW = 0;
+                
+              switch (gCPUStructure.Model) {
+                  case CPU_MODEL_SANDY_BRIDGE:
+                      LevelMaxW = 0x07100000;
+                      case CPU_MODEL_IVY_BRIDGE:
+                      break;
+                      
+                  case CPU_MODEL_HASWELL:
+                  case CPU_MODEL_HASWELL_ULT:
+                  case CPU_MODEL_HASWELL_U5:
+                  case CPU_MODEL_CRYSTALWELL:
+                  case CPU_MODEL_BROADWELL_HQ:
+                      LevelMaxW = gSettings.IgPlatform != (UINT32)0x0a2e0008 ? 0xad900000 : 0x56c00000;
+                      break;
+                      
+                  case CPU_MODEL_SKYLAKE_U:
+                  case CPU_MODEL_KABYLAKE1:
+                  case CPU_MODEL_KABYLAKE2:
+                      LevelMaxW = 0x56c00000;
+                      break;
+                      
+                  default:
+                      break;
+              }
               UINT32 IntelDisable = 0x03;
 
               //        gGraphics.DeviceID = Pci.Hdr.DeviceId;

Now the fix will add one more check on ig-platform-id == 0x0a2e0008.

syscl

Slice · September 7, 2017

Index: rEFIt_UEFI/Platform/Settings.c
===================================================================
--- rEFIt_UEFI/Platform/Settings.c	(revision 4197)
+++ rEFIt_UEFI/Platform/Settings.c	(working copy)
@@ -6606,7 +6606,36 @@
              (Pci.Hdr.ClassCode[1] == PCI_CLASS_DISPLAY_OTHER))) {
 
               UINT32 LevelW = 0xC0000000;
-              UINT32 LevelMaxW = 0x07100000;
+              // syscl: set PWMMax base on platform
+              // 10: Sandy/Ivy 0x710
+              // 11: Haswell/Broadwell 0xad9
+              // 12: Skylake/KabyLake 0x56c (and some Haswell, example 0xa2e0008)
+              // 99: Other
+              UINT32 LevelMaxW = 0;
+                
+              switch (gCPUStructure.Model) {
+                  case CPU_MODEL_SANDY_BRIDGE:
+                      LevelMaxW = 0x07100000;
+                      case CPU_MODEL_IVY_BRIDGE:
+                      break;
+                      
+                  case CPU_MODEL_HASWELL:
+                  case CPU_MODEL_HASWELL_ULT:
+                  case CPU_MODEL_HASWELL_U5:
+                  case CPU_MODEL_CRYSTALWELL:
+                  case CPU_MODEL_BROADWELL_HQ:
+                      LevelMaxW = gSettings.IgPlatform != (UINT32)0x0a2e0008 ? 0xad900000 : 0x56c00000;
+                      break;
+                      
+                  case CPU_MODEL_SKYLAKE_U:
+                  case CPU_MODEL_KABYLAKE1:
+                  case CPU_MODEL_KABYLAKE2:
+                      LevelMaxW = 0x56c00000;
+                      break;
+                      
+                  default:
+                      break;
+              }
               UINT32 IntelDisable = 0x03;
 
               //        gGraphics.DeviceID = Pci.Hdr.DeviceId;

Now the fix will add one more check on ig-platform-id == 0x0a2e0008.

syscl

I think you can commit this.

SavageAUS · September 7, 2017

Is it a clover issue with the memory tab missing in about this mac on my laptop in both Sierra and High Sierra or did apple remove it and i not notice til now?

Sherlocks · September 7, 2017

Is it a clover issue with the memory tab missing in about this mac on my laptop in both Sierra and High Sierra or did apple remove it and i not notice til now?

Try to use 0xFFFF in PlatformFeature at config.plist

Clover followed vanilla PlatformFeature values on each smbios models.

Need to move clover general thread.

나의 LG-F800S 의 Tapatalk에서 보냄

SavageAUS · September 7, 2017

Try to use 0xFFFF in PlatformFeature at config.plist

Clover followed vanilla PlatformFeature values on each smbios models.

Need to move clover general thread.

나의 LG-F800S 의 Tapatalk에서 보냄

Thanks, that worked.

Apologies for wrong thread.

ndx2014 · September 7, 2017

Hi. Whats the value to fully enable sip? 0x0 shows me :

System Integrity Protection status: enabled (Custom Configuration).

Configuration:
   Apple Internal: disabled
   Kext Signing: disabled
   Filesystem Protections: disabled
   Debugging Restrictions: disabled
   DTrace Restrictions: disabled
   NVRAM Protections: disabled
   BaseSystem Verification: disabled

@ 10.13 Beta 17A360a

Matgen84 · September 7, 2017

Hi. Whats the value to fully enable sip? 0x0 shows me :

System Integrity Protection status: enabled (Custom Configuration).

Configuration:

   Apple Internal: disabled

   Kext Signing: disabled

   Filesystem Protections: disabled

   Debugging Restrictions: disabled

   DTrace Restrictions: disabled

   NVRAM Protections: disabled

   BaseSystem Verification: disabled

@ 10.13 Beta 17A360a

Try 0x67 instead of 0x0. Why full enable sip? But if you want: try csrutil enable in Terminal on Recovery HD.

ndx2014 · September 7, 2017

Try 0x67 instead of 0x0. Why full enable sip? But if you want: try csrutil enable in Terminal on Recovery HD.

Thanks. Because i want to have Filesystem Protection etc. It alway worked after post-installations when the system was running fine and since i got it 0x0 i could fix an issue with a usb-device (which sounds strange i know) I will try to enable it in Recovery HD.

Sherlocks · September 7, 2017

Thanks. Because i want to have Filesystem Protection etc. It alway worked after post-installations when the system was running fine and since i got it 0x0 i could fix an issue with a usb-device (which sounds strange i know) I will try to enable it in Recovery HD.

0x0 can't use other kext ex. Manual dummy applehda. At least, i recommend to use 0x67 for hack. Or if you dont need to add any kext in S/L/E. You can use more less values. Maybe need to find best value for your enviroment

나의 LG-F800S 의 Tapatalk에서 보냄

TheRacerMaster · September 7, 2017

Is it a clover issue with the memory tab missing in about this mac on my laptop in both Sierra and High Sierra or did apple remove it and i not notice til now?

It has to do with the platform-feature value (see here).

Andrey1970 · September 7, 2017

Index: rEFIt_UEFI/Platform/Settings.c
===================================================================
--- rEFIt_UEFI/Platform/Settings.c	(revision 4197)
+++ rEFIt_UEFI/Platform/Settings.c	(working copy)
@@ -6606,7 +6606,36 @@
              (Pci.Hdr.ClassCode[1] == PCI_CLASS_DISPLAY_OTHER))) {
 
               UINT32 LevelW = 0xC0000000;
-              UINT32 LevelMaxW = 0x07100000;
+              // syscl: set PWMMax base on platform
+              // 10: Sandy/Ivy 0x710
+              // 11: Haswell/Broadwell 0xad9
+              // 12: Skylake/KabyLake 0x56c (and some Haswell, example 0xa2e0008)
+              // 99: Other
+              UINT32 LevelMaxW = 0;
+                
+              switch (gCPUStructure.Model) {
+                  case CPU_MODEL_SANDY_BRIDGE:
+                      LevelMaxW = 0x07100000;
+                      case CPU_MODEL_IVY_BRIDGE:
+                      break;
+                      
+                  case CPU_MODEL_HASWELL:
+                  case CPU_MODEL_HASWELL_ULT:
+                  case CPU_MODEL_HASWELL_U5:
+                  case CPU_MODEL_CRYSTALWELL:
+                  case CPU_MODEL_BROADWELL_HQ:
+                      LevelMaxW = gSettings.IgPlatform != (UINT32)0x0a2e0008 ? 0xad900000 : 0x56c00000;
+                      break;
+                      
+                  case CPU_MODEL_SKYLAKE_U:
+                  case CPU_MODEL_KABYLAKE1:
+                  case CPU_MODEL_KABYLAKE2:
+                      LevelMaxW = 0x56c00000;
+                      break;
+                      
+                  default:
+                      break;
+              }
               UINT32 IntelDisable = 0x03;
 
               //        gGraphics.DeviceID = Pci.Hdr.DeviceId;

Now the fix will add one more check on ig-platform-id == 0x0a2e0008.

syscl

r4198 Bug! The screen flickers! HD4000 laptop.

r4197 all OK.

TheRacerMaster · September 7, 2017

Index: rEFIt_UEFI/Platform/Settings.c
===================================================================
--- rEFIt_UEFI/Platform/Settings.c	(revision 4197)
+++ rEFIt_UEFI/Platform/Settings.c	(working copy)
@@ -6606,7 +6606,36 @@
              (Pci.Hdr.ClassCode[1] == PCI_CLASS_DISPLAY_OTHER))) {
 
               UINT32 LevelW = 0xC0000000;
-              UINT32 LevelMaxW = 0x07100000;
+              // syscl: set PWMMax base on platform
+              // 10: Sandy/Ivy 0x710
+              // 11: Haswell/Broadwell 0xad9
+              // 12: Skylake/KabyLake 0x56c (and some Haswell, example 0xa2e0008)
+              // 99: Other
+              UINT32 LevelMaxW = 0;
+                
+              switch (gCPUStructure.Model) {
+                  case CPU_MODEL_SANDY_BRIDGE:
+                      LevelMaxW = 0x07100000;
+                      case CPU_MODEL_IVY_BRIDGE:
+                      break;
+                      
+                  case CPU_MODEL_HASWELL:
+                  case CPU_MODEL_HASWELL_ULT:
+                  case CPU_MODEL_HASWELL_U5:
+                  case CPU_MODEL_CRYSTALWELL:
+                  case CPU_MODEL_BROADWELL_HQ:
+                      LevelMaxW = gSettings.IgPlatform != (UINT32)0x0a2e0008 ? 0xad900000 : 0x56c00000;
+                      break;
+                      
+                  case CPU_MODEL_SKYLAKE_U:
+                  case CPU_MODEL_KABYLAKE1:
+                  case CPU_MODEL_KABYLAKE2:
+                      LevelMaxW = 0x56c00000;
+                      break;
+                      
+                  default:
+                      break;
+              }
               UINT32 IntelDisable = 0x03;
 
               //        gGraphics.DeviceID = Pci.Hdr.DeviceId;

Now the fix will add one more check on ig-platform-id == 0x0a2e0008.

syscl

                  case CPU_MODEL_SANDY_BRIDGE:
                      LevelMaxW = 0x07100000;
                      case CPU_MODEL_IVY_BRIDGE:
                      break;

This case is broken, no?

Slice · September 7, 2017

r4198 Bug! The screen flickers! HD4000 laptop.

r4197 all OK.

Corrected in 4199

MattsCreative · September 7, 2017

Hmm might be pointless to ask but any chance of building intel mausi and both Realtek next work kexts into clover since they are the most used or isn’t it possible

Sent from my iPhone using Tapatalk

chris1111 · September 7, 2017

0x0 can't use other kext ex. Manual dummy applehda. At least, i recommend to use 0x67 for hack. Or if you dont need to add any kext in S/L/E. You can use more less values. Maybe need to find best value for your enviroment

나의 LG-F800S 의 Tapatalk에서 보냄

The Default value in config.plist Clover Package is

<key>CsrActiveConfig</key>

Good or not?

Sherlocks · September 7, 2017

The Default value in config.plist Clover Package is

<key>CsrActiveConfig</key>

<string>0x3E7</string>

Good or not?

Users preference. If you want to disable all csr flags, use 0x3FF. 0x3E7 has some enabled csr flags. At least need 0x67 or over for hack.

My case, use 0x67, i dont need to disable all csr flags. It means miniminzed 0x67 for hack. I tested Sierra/High Sierra.

EDIT1.

Ofc, According to users system, can use more less csrconfigactive values than 0x67.

EDIT2.

Clover used 0x67 in yos/elc/sie. There was problem before.

Actually to disabled all csr flags on each osx

Yos/ElC 0xFF <--- not remember correctly whether both or not. i dont have time to check this. Im in mobile.

Sie 0x1FF

HS 0x3FF

나의 LG-F800S 의 Tapatalk에서 보냄

Clover General discussion

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites