Jump to content

Clover General discussion

ErmaC

By ErmaC,
in Clover

 Share
30,171 posts in this topic

Recommended Posts

Sherlocks
Sherlocks
Posted
Posted

@Slice

 

i have this issue

post-980913-0-58146400-1477664763_thumb.jpg

 

macbookpro 13,1 already runs 10.12.1

https://browser.primatelabs.com/v4/cpu/874771

 

can you add New Macbook Pro 13,1 13,2 13,3?

 

 

#elif (TARGET_MODEL == MACBOOK_PRO_131)

    // 13-inch without Touch Bar
    // Intel Core i5-6360U 2.0 GHz (Max Turbo Boost 3.1 GHz).
    // Intel Core i7-6660U 2.4 GHz (Max Turbo Boost 3.4 GHz).
    #define SMB_BIOS_VERSION    "MBP131.88Z.0205.B02.1610121536"
    #define SMB_PRODUCT_NAME    "MacBookPro13,1"
    #define SMB_BOARD_PRODUCT   "Mac-473D31EABEB93F9B"
    #define EFI_MODEL_NAME      { 'M', 'a', 'c', 'B', 'o', 'o', 'k', 'P', 'r', 'o', '1', '3', ',', '1' }
#elif (TARGET_MODEL == MACBOOK_PRO_132)
    // 13-inch with Touch Bar
    // Intel Core i5-6267U 2.9 GHz (3.3 GHz Max Turbo Boost)
    // Intel Core i5-6287U 3.1 GHz (3.5 GHz Max Turbo Boost)
    // Intel Core i7-6567U 3.3 GHz (3.6 GHz Max Turbo Boost)
    #define SMB_BIOS_VERSION    "MBP132.88Z.0223.B00.1610201042"
    #define SMB_PRODUCT_NAME    "MacBookPro13,2"
    #define SMB_BOARD_PRODUCT   "Mac-66E35819EE2D0D05"
    #define EFI_MODEL_NAME      { 'M', 'a', 'c', 'B', 'o', 'o', 'k', 'P', 'r', 'o', '1', '3', ',', '2' }
#else // Defaults to MacBookPro13,3
    // 15-inch with Touch Bar
    // Intel Core i7-6700HQ 2.6 GHz (Max Turbo Boost 3.5 GHz).
    // Intel Core i7-6820HQ 2.7 GHz (Max Turbo Boost 3.6 GHz).
    // Intel Core i7-6920HQ 2.9 GHz (Max Turbo Boost 3.8 GHz).
    #define SMB_BIOS_VERSION    "MBP133.88Z.0223.B00.1610201042"
    #define SMB_PRODUCT_NAME    "MacBookPro13,3"
    #define SMB_BOARD_PRODUCT   "Mac-A5C67F76ED83108C"
    #define EFI_MODEL_NAME      { 'M', 'a', 'c', 'B', 'o', 'o', 'k', 'P', 'r', 'o', '1', '3', ',', '3' }
#endif

 

thanks to pike.alpha

  • Like 2
Link to comment
Share on other sites
wastez
wastez
Posted
Posted

No, I have successfull FileVault2 with VBoxHFS.efi. Forget myths!

Only module that I have no is AppleKeyMapAggregator. Others work fine.

So just AppleKeyMapAggregator is enough?

Because savvamitrofanov before wrote that a lot more drivers are needed.

Link to comment
Share on other sites
Slice
Slice
Posted
Posted

Here is preboot log with Custom EDID I got from Dump EDID inserted in to Clover.

No, this EDID is not custom, it is native.

1:484  0:000  EdidOverrideFound!
1:484  0:000   found Detail Timing 2560x1440
1:548  0:064     0 640x480 attr=3BF - ok, edid+, 640x480, working, highest, pref=0
1:550  0:002     1 800x600 attr=3BF - ok, edid+, 800x600, working, highest, pref=1
1:553  0:002     2 1024x768 attr=3BF - ok, edid+, 1024x768, working, highest, pref=2
1:555  0:002     3 1280x1024 attr=3BF - ok, edid+, working, highest, pref=3
1:565  0:009  BV new mode: 3 1280x1024

You have to modify it with some EDID_Editor to have 1920x1080 in this list.

I believe he means that he has all the modules except AppleKeyMapAggregator. :)

Clover has AppleKeyAggregator performing the same function. It is our opensource replacement.

@Slice

 

i have this issue

attachicon.gifKakaoTalk_Photo_2016-10-28-23-27-23_47.jpg

 

macbookpro 13,1 already runs 10.12.1

https://browser.primatelabs.com/v4/cpu/874771

 

can you add New Macbook Pro 13,1 13,2 13,3?

 

 

thanks to pike.alpha

I see no reason to thank PA.

Your screenshot shows that this BoardID is not in supported PlatformPlist.

It is not Clover mistake. Clover is not that who set this wrong BoardID. Wrong BoardID was set by your config.plist with a help of PA.

  • Like 1
Link to comment
Share on other sites
smolderas
smolderas
Posted
Posted

Could someone please help me build clover? I like to test filevault2, but ebuild.sh fails with following error:

[CC] AutoGen
/Users/<redacted>/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c:4020:29: error: implicit declaration of function 'ARRAY_SIZE' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    for (Index = 0; Index < ARRAY_SIZE (mVariableEntryProperty); Index++) {
                            ^
1 error generated
Link to comment
Share on other sites
Slice
Slice
Posted
Posted

Read

PlatformSupport.plist.zip

macOS 10.12.1


 

Could someone please help me build clover? I like to test filevault2, but ebuild.sh fails with following error:

[CC] AutoGen
/Users/<redacted>/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c:4020:29: error: implicit declaration of function 'ARRAY_SIZE' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    for (Index = 0; Index < ARRAY_SIZE (mVariableEntryProperty); Index++) {
                            ^
1 error generated

 

#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))

 

Looks like you updated EDK2? My version 22865 contains correct line 4020

  • Like 1
Link to comment
Share on other sites
Slice
Slice
Posted
Posted

Thanks Slice, so I should define that function in every file, which uses ARRAY_SIZE?

 

Edit:

I'm sorry to bother you, I reverted to previous edk2 and it is good to go. I forget the comment out the svn up edk2 line :)

It is EDK2 developers problem. I thing they resolve it in nearest commit.

Yes, in every file. As I see in the whole EDK2 tree it is defined multiple times.

  • Like 1
Link to comment
Share on other sites
phi777
phi777
Posted
Posted

@smolderas

I did the trick 3 times in MdeModulePkg/Universal/EbcDxe/EbcExecute.c, MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c and MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c

and now it works with newest ed2k!

It's fast, if you use "vim +LineNumber file" like "vim +4020 MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c"!

  • Like 1
Link to comment
Share on other sites
smolderas
smolderas
Posted
Posted

@smolderas

I did the trick 3 times in MdeModulePkg/Universal/EbcDxe/EbcExecute.c, MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c and MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c

and now it works with newest ed2k!

It's fast, if you use "vim +LineNumber file" like "vim +4020 MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c"!

Thanks for the tip. I'm trying to hold my diff from the repository to a minimum, so I've just reversed the EDK2 version and it's working again.

Link to comment
Share on other sites
tluck
tluck
Posted
Posted

@slice - what are these new "mandatory" UEFI drivers all about that came in r3882/3883? 

 

$ ls -1
AppleImageCodec-64.efi
AppleKeyAggregator-64.efi
AppleUITheme-64.efi
DataHubDxe-64.efi
EmuVariableUefi-64.efi
FSInject-64.efi
FirmwareVolume-64.efi
OsxAptioFix2Drv-64.efi
OsxFatBinaryDrv-64.efi
SMCHelper-64.efi
UsbKbDxe-64.efi
VBoxHfs-64.efi

Link to comment
Share on other sites
Sherlocks
Sherlocks
Posted
Posted

Read

attachicon.gifPlatformSupport.plist.zip

macOS 10.12.1

 

#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))

 

Looks like you updated EDK2? My version 22865 contains correct line 4020

 

thank you

serial invaild(generated random)

 

replace plist and test for other users

 

skylake users have bug

glitch on menubar

touchpad blank

capslock

post-980913-0-85347400-1477712928_thumb.png

PlatformSupport.plist.zip

Link to comment
Share on other sites
Sherlocks
Sherlocks
Posted
Posted

when you use the plist file on 10.12.1,glitch on menubar still exists?

Yes. I think we have to use FakeID "Iris HD540 or HD550" or find hex code to fix glitch on menubar.

 

I see Macbook pro 13,1 geekbench.

They use other MacOS build number.

 

It use more number than10.12.1 official xxx555.

 

We need time to clear this issue.

 

나의 LG-F410S 의 Tapatalk에서 보냄

what does this platform differs in vanilla?

I just added platform id for macbookpro13,1

 

나의 LG-F410S 의 Tapatalk에서 보냄

Link to comment
Share on other sites
pkdesign
pkdesign
Posted
Posted

No, this EDID is not custom, it is native.

1:484  0:000  EdidOverrideFound!
1:484  0:000   found Detail Timing 2560x1440
1:548  0:064     0 640x480 attr=3BF - ok, edid+, 640x480, working, highest, pref=0
1:550  0:002     1 800x600 attr=3BF - ok, edid+, 800x600, working, highest, pref=1
1:553  0:002     2 1024x768 attr=3BF - ok, edid+, 1024x768, working, highest, pref=2
1:555  0:002     3 1280x1024 attr=3BF - ok, edid+, working, highest, pref=3
1:565  0:009  BV new mode: 3 1280x1024

You have to modify it with some EDID_Editor to have 1920x1080 in this list.

 

Well i guess I'm out since I have no clue how to do this.

 

I've also tried to find a way to edit the VBIOS of my card but can't seem to find a way to do that. I have followed several guides but can't find the hex code they tell you to.

 

It's only a few seconds at boot time so I guess I will just live with it.

Link to comment
Share on other sites
wastez
wastez
Posted
Posted

@ Clover Developers

Since 10.12 it´s not possible to use a custom hibernate file path. (Clover will not load it)

I saw in the Clover log that it took the hibernate preferences from /Library/Preferences/com.apple.PowerManagement.plist, what could be the reason why it can´t find the setting for "hibernatefile".

hibernatefile is stored in /Library/Preferences/com.apple.PowerManagement.XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX.plist since 10.12.

 

Would be great if somebody can have a look on it.

  • Like 1
Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...